On Sat, Jul 4, 2020 at 12:32 PM Amit Kapila <amit.kapil...@gmail.com> wrote:
>
> On Fri, Jul 3, 2020 at 5:18 PM Masahiko Sawada
> <masahiko.saw...@2ndquadrant.com> wrote:
> >
> > On Fri, 3 Jul 2020 at 17:07, vignesh C <vignes...@gmail.com> wrote:
> > >
> > > Hi,
> > >
> > > While checking through the code I found that some of the function
> > > parameters in reorderbuffer & vacuumlazy are not used. I felt this
> > > could be removed. I'm not sure if it is kept for future use or not.
> > > Attached patch contains the changes for the same.
> > > Thoughts?
> > >
> >
> > For the part of parallel vacuum change, it looks good to me.
> >
>
> Unlike ReorderBuffer, this change looks fine to me as well. This is a
> quite recent (PG13) change and it would be good to remove it now. So,
> I will push this part of change unless I hear any objection in a day
> or so.
Thanks all for your comments, attached patch has the changes that
excludes the changes made in reorderbuffer.
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com
From 70a626eb7a384c2357134142611d511635e5c369 Mon Sep 17 00:00:00 2001
From: Vignesh C <vignes...@gmail.com>
Date: Sun, 5 Jul 2020 06:11:02 +0530
Subject: [PATCH] Removed unused function parameter in end_parallel_vacuum.
Removed unused function parameter in end_parallel_vacuum. This
function parameter is not used, it can be removed safely.
---
src/backend/access/heap/vacuumlazy.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/access/heap/vacuumlazy.c b/src/backend/access/heap/vacuumlazy.c
index 68effca..1bbc459 100644
--- a/src/backend/access/heap/vacuumlazy.c
+++ b/src/backend/access/heap/vacuumlazy.c
@@ -390,7 +390,7 @@ static void update_index_statistics(Relation *Irel, IndexBulkDeleteResult **stat
static LVParallelState *begin_parallel_vacuum(Oid relid, Relation *Irel,
LVRelStats *vacrelstats, BlockNumber nblocks,
int nindexes, int nrequested);
-static void end_parallel_vacuum(Relation *Irel, IndexBulkDeleteResult **stats,
+static void end_parallel_vacuum(IndexBulkDeleteResult **stats,
LVParallelState *lps, int nindexes);
static LVSharedIndStats *get_indstats(LVShared *lvshared, int n);
static bool skip_parallel_vacuum_index(Relation indrel, LVShared *lvshared);
@@ -1712,7 +1712,7 @@ lazy_scan_heap(Relation onerel, VacuumParams *params, LVRelStats *vacrelstats,
* during parallel mode.
*/
if (ParallelVacuumIsActive(lps))
- end_parallel_vacuum(Irel, indstats, lps, nindexes);
+ end_parallel_vacuum(indstats, lps, nindexes);
/* Update index statistics */
update_index_statistics(Irel, indstats, nindexes);
@@ -3361,8 +3361,8 @@ begin_parallel_vacuum(Oid relid, Relation *Irel, LVRelStats *vacrelstats,
* context, but that won't be safe (see ExitParallelMode).
*/
static void
-end_parallel_vacuum(Relation *Irel, IndexBulkDeleteResult **stats,
- LVParallelState *lps, int nindexes)
+end_parallel_vacuum(IndexBulkDeleteResult **stats, LVParallelState *lps,
+ int nindexes)
{
int i;
--
1.8.3.1
