Re: BUG #15548: Unaccent does not remove combining diacritical characters

2019-02-17 Thread Michael Paquier
On Sun, Feb 17, 2019 at 12:45:39PM +0530, Ramanarayana wrote: > The patch I submitted was tested both in python 2 and 3 and it worked for > me.The single line of code > added in the patch runs only in python 3. I dont think it can break > python2. Would like to see the error you got in python 2 G

Re: BUG #15548: Unaccent does not remove combining diacritical characters

2019-02-16 Thread Ramanarayana
Hi Hugh, The patch I submitted was tested both in python 2 and 3 and it worked for me.The single line of code added in the patch runs only in python 3. I dont think it can break python2. Would like to see the error you got in python 2 Good to know the reported issue is a valid one in windows.I

Re: BUG #15548: Unaccent does not remove combining diacritical characters

2019-02-16 Thread Hugh Ranalli
On Mon, 11 Feb 2019 at 15:57, Ramanarayana wrote: > Hi Hugh, > > I tested the script in python 2.7 and it works perfect. The problem is in > python 3.7(and may be only in windows as you were not getting the issue) > and I was getting the following error > > UnicodeEncodeError: 'charmap' codec can

Re: BUG #15548: Unaccent does not remove combining diacritical characters

2019-02-12 Thread Hugh Ranalli
On Tue, 12 Feb 2019 at 08:54, Ramanarayana wrote: > Hi Michael, > The issue was that the python script was working in python 2 but not in > python 3 in Windows. This is because the python script writes the final > output to stdout and stdout encoding is set to utf-8 only for python 2 but > not py

Re: BUG #15548: Unaccent does not remove combining diacritical characters

2019-02-12 Thread Ramanarayana
Hi Michael, The issue was that the python script was working in python 2 but not in python 3 in Windows. This is because the python script writes the final output to stdout and stdout encoding is set to utf-8 only for python 2 but not python 3.If no encoding is set for stdout it takes the encoding

Re: BUG #15548: Unaccent does not remove combining diacritical characters

2019-02-11 Thread Michael Paquier
On Tue, Feb 12, 2019 at 02:27:31AM +0530, Ramanarayana wrote: > I tested the script in python 2.7 and it works perfect. The problem is in > python 3.7(and may be only in windows as you were not getting the issue) > and I was getting the following error > > UnicodeEncodeError: 'charmap' codec can't

Re: BUG #15548: Unaccent does not remove combining diacritical characters

2019-02-11 Thread Ramanarayana
Hi Hugh, I tested the script in python 2.7 and it works perfect. The problem is in python 3.7(and may be only in windows as you were not getting the issue) and I was getting the following error UnicodeEncodeError: 'charmap' codec can't encode character '\u0100' in position 0: character maps to

Re: BUG #15548: Unaccent does not remove combining diacritical characters

2019-02-11 Thread Hugh Ranalli
On Sun, 10 Feb 2019 at 15:07, raam narayana wrote: > Hi, > > After the latest commit in master branch, I was trying to test the python > script. Ironically I still see that the output from the script is > completely different from the unaccent.rules file content. Am I missing > anything.My testin

Re: BUG #15548: Unaccent does not remove combining diacritical characters

2019-02-10 Thread Thomas Munro
On Mon, Feb 11, 2019 at 7:07 AM raam narayana wrote: > After the latest commit in master branch, I was trying to test the python > script. Ironically I still see that the output from the script is completely > different from the unaccent.rules file content. Am I missing anything.My > testing in

Re: BUG #15548: Unaccent does not remove combining diacritical characters

2019-02-10 Thread raam narayana
Hi, After the latest commit in master branch, I was trying to test the python script. Ironically I still see that the output from the script is completely different from the unaccent.rules file content. Am I missing anything.My testing includes the following Downloaded the following files htt