On Sun, Feb 17, 2019 at 12:45:39PM +0530, Ramanarayana wrote: > The patch I submitted was tested both in python 2 and 3 and it worked for > me.The single line of code > added in the patch runs only in python 3. I dont think it can break > python2. Would like to see the error you got in python 2 Good to know the > reported issue is a valid one in windows.I tested your patch as well and > it is also working fine.
I can see that the commit fest entry associated to this thread has been switched back from "committed" to "Needs Review" with Thomas Munro still associated as committer. The thing is that we have already committed all the bits discussed here, so I am switching back the status as "committed", which reflects the state of the thread. If you have a set of fixes for what has been pushed regarding Windows and Python 2/3 capabilities, I would suggest to create a new entry with yourself as the author. Spawning a new thread would be also nice so as you attract the correct audience, this thread about initially diacritical character support for unaccent has been used more than enough now. Python 2/3 support for this script is easy enough to check on Linux, and now you are adding Windows in the mix... Thanks, -- Michael
signature.asc
Description: PGP signature
