Re: Assignment before assert

2025-02-14 Thread Daniel Gustafsson
> On 14 Feb 2025, at 06:44, Michael Paquier wrote: > the proposed patch makes sense to me. Committed, with a backpatch down to 13. -- Daniel Gustafsson

Re: Assignment before assert

2025-02-13 Thread Michael Paquier
On Fri, Feb 14, 2025 at 12:15:40AM +0100, Daniel Gustafsson wrote: > > On 13 Feb 2025, at 18:08, Dmitry Koval wrote: > > > > Hi! > > Function EvalPlanQualFetchRowMark contains an assignment > > > > ExecRowMark *erm = earm->rowmark; > > > > before assert > > > > Assert(earm != NULL); > > > > M

Re: Assignment before assert

2025-02-13 Thread Daniel Gustafsson
> On 13 Feb 2025, at 18:08, Dmitry Koval wrote: > > Hi! > Function EvalPlanQualFetchRowMark contains an assignment > > ExecRowMark *erm = earm->rowmark; > > before assert > > Assert(earm != NULL); > > Maybe these lines need to be swapped? That does admittedly look a bit odd, that assertion c

Assignment before assert

2025-02-13 Thread Dmitry Koval
Hi! Function EvalPlanQualFetchRowMark contains an assignment ExecRowMark *erm = earm->rowmark; before assert Assert(earm != NULL); Maybe these lines need to be swapped? -- With best regards, Dmitry Koval Postgres Professional: http://postgrespro.com diff --git a/src/backend/e