On Fri, Feb 14, 2025 at 12:15:40AM +0100, Daniel Gustafsson wrote: > > On 13 Feb 2025, at 18:08, Dmitry Koval <d.ko...@postgrespro.ru> wrote: > > > > Hi! > > Function EvalPlanQualFetchRowMark contains an assignment > > > > ExecRowMark *erm = earm->rowmark; > > > > before assert > > > > Assert(earm != NULL); > > > > Maybe these lines need to be swapped? > > That does admittedly look a bit odd, that assertion can't be reached if earm > is > null since we've already dereferenced it by then. I'll have another look > after > coffee but something along the lines of your patch looks right (or just remove > the Assertion perhaps).
Accessing earm->rowmark is one thing, assuming that earm should never be NULL is a different one. Looking at 27cc7cd2bc8a that has introduced this assertion, the proposed patch makes sense to me. -- Michael
signature.asc
Description: PGP signature
