On Wed, 11 Dec 2024 at 11:36, David Rowley wrote:
> I've now pushed v7-0001.
... and, after a few comment tweaks, I've also pushed the v7-0002 patch.
Thanks for your reviews, Andrei.
David
On Sat, 2 Nov 2024 at 22:13, Andrei Lepikhov wrote:
> Okay, I passed through the code. It looks good. Hashing expressions are
> too simple to give notably impressive results, but it is a step in the
> right direction.
> I found only one minor issue: an outdated comment (see attachment).
Thanks fo
On 11/1/24 06:17, David Rowley wrote:
On Thu, 31 Oct 2024 at 15:30, Andrei Lepikhov wrote:
Comparing the master with and without your patch, the first, I see is
more extensive usage of memory (see complete explains in the attachment):
Current master:
Batches: 1 Memory Usage: 74513kB
Pa
On Thu, 31 Oct 2024 at 15:30, Andrei Lepikhov wrote:
> Comparing the master with and without your patch, the first, I see is
> more extensive usage of memory (see complete explains in the attachment):
>
> Current master:
>Batches: 1 Memory Usage: 74513kB
> Patched:
>Batches: 261 Memory
On 10/31/24 08:16, David Rowley wrote:
On Tue, 29 Oct 2024 at 22:47, David Rowley wrote:
I've attached an updated patch with a few other fixes. Whilr checking
this tonight, noticed that master does not use
SubPlanState.tab_eq_funcs for anything. I resisted removing that in
this patch. Perhaps a
On Tue, 29 Oct 2024 at 22:47, David Rowley wrote:
> I've attached an updated patch with a few other fixes. Whilr checking
> this tonight, noticed that master does not use
> SubPlanState.tab_eq_funcs for anything. I resisted removing that in
> this patch. Perhaps a follow-on patch can remove that.
On Mon, 28 Oct 2024 at 21:51, Andrei Lepikhov wrote:
> Having remembered that SQL Server uses lightweight threads to execute
> massive hash and aggregate operations in parallel, I think this patch is
> promising. Unfortunately, it causes SEGFAULT on 'make check'.
Thanks for having a look. The cra
On 9/1/24 18:49, David Rowley wrote:
adf97c156 added support to allow ExprStates to support hashing and
adjusted Hash Join to make use of that. That allowed a speedup in hash
value generation as it allowed JIT compilation of hash values. It also
allowed more efficient tuple deforming as all requi
adf97c156 added support to allow ExprStates to support hashing and
adjusted Hash Join to make use of that. That allowed a speedup in hash
value generation as it allowed JIT compilation of hash values. It also
allowed more efficient tuple deforming as all required attributes are
deformed in one go r
