Hi,
On 2023-04-14 11:58:42 -0400, Greg Stark wrote:
> On Wed, 11 May 2022 at 06:19, Peter Eisentraut
> wrote:
> >
> > After that, these configure options don't have an equivalent yet:
> >
> > --enable-profiling
>
> Afaics this still doesn't exist? Is there a common idiom to enable
> this? Like,
On Wed, 11 May 2022 at 06:19, Peter Eisentraut
wrote:
>
> After that, these configure options don't have an equivalent yet:
>
> --enable-profiling
Afaics this still doesn't exist? Is there a common idiom to enable
this? Like, if I add in something to cflags is that enough? I seem to
recall we had
On 2022-06-14 20:47:59 +0200, Peter Eisentraut wrote:
> On 14.06.22 20:27, Andres Freund wrote:
> > One thing I'm not quite sure about: Why does the makefile need awareness of
> > the stop files, but Install.pm doesn't? I suspect currently the patch leads
> > to
> > stopwords not being installed o
On 14.06.22 20:27, Andres Freund wrote:
One thing I'm not quite sure about: Why does the makefile need awareness of
the stop files, but Install.pm doesn't? I suspect currently the patch leads to
stopwords not being installed on windows anymore?
Install.pm contains this elsewhere:
Gener
Hi,
On 2022-06-08 14:33:16 +0200, Peter Eisentraut wrote:
> Attached is a patch the finishes up the work to move the snowball SQL script
> generation into a separate script.
That looks good, merged. I did split the commit, because there's not yet a
meson.build "at the time" of the prereq: commits
Hi,
On 2022-06-08 08:27:06 +0200, Peter Eisentraut wrote:
> I looked at some of the "prereq" patches again to see what state they are
> in:
>
> commit 351a12f48e395b31cce4aca239b934174b36ea9d
> Author: Andres Freund
> Date: Wed Apr 20 22:46:54 2022
>
> prereq: deal with \ paths in basebac
Attached is a patch the finishes up the work to move the snowball SQL
script generation into a separate script.From 02ca51dfb918666dfde8e48499a4c73afae4e89e Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 8 Jun 2022 11:05:31 +0200
Subject: [PATCH] fixup! meson: prereq: move snowball_
I looked at some of the "prereq" patches again to see what state they
are in:
commit 351a12f48e395b31cce4aca239b934174b36ea9d
Author: Andres Freund
Date: Wed Apr 20 22:46:54 2022
prereq: deal with \ paths in basebackup_to_shell tests.
This is a new component in PG15, so a fix might be i
On Tue, May 24, 2022 at 08:08:26PM +0200, Peter Eisentraut wrote:
> On 18.05.22 21:48, Andres Freund wrote:
>> - GETTIMEOFDAY_1ARG - test doesn't exist - I suspect it might not be
>> necessary
>
> Might be obsolete, consider removing.
I just came across this one independently of what you are doi
Hi,
On 2022-06-01 06:55:06 +0200, Peter Eisentraut wrote:
>
> On 06.05.22 23:27, Andres Freund wrote:
> > I added pkgconfig since then. They're not exactly the same, but pretty
> > close,
> > except for one thing: Looks like some of the ecpg libraries really should
> > link
> > to some other ec
On 06.05.22 23:27, Andres Freund wrote:
I added pkgconfig since then. They're not exactly the same, but pretty close,
except for one thing: Looks like some of the ecpg libraries really should link
to some other ecpg libs? I think we're missing something there... That then
leads to missing requir
On 18.05.22 21:48, Andres Freund wrote:
- CONFIGURE_ARGS - empty in meson, not clear what to fill it with
Ok to leave empty for now.
- GETTIMEOFDAY_1ARG - test doesn't exist - I suspect it might not be necessary
Might be obsolete, consider removing.
- PACKAGE_STRING, PACKAGE_TARNAME - unc
Hi,
On 2022-05-18 10:30:12 +0200, Peter Eisentraut wrote:
> Here are some more patches that clean up various minor issues.
I rebased the meson tree, squashed a lot of the existing commits, merged your
changes, and fixed a few more differences between autoconf and meson.
For me the difference in
Here are some more patches that clean up various minor issues.From bc06fda7198d182dce73f39cfff8e4724e00b12d Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 4 May 2022 14:38:02 +0200
Subject: [PATCH 1/7] meson: Put genbki header files back into original order
The order affects the out
Hi,
On 2022-05-16 17:47:24 +0200, Peter Eisentraut wrote:
> On 12.05.22 21:30, Andres Freund wrote:
> > On 2022-05-11 12:18:58 +0200, Peter Eisentraut wrote:
> > > I fixed the Perl detection issue in my macOS environment that I had
> > > reported
> > > a while ago.
> >
> > Hm. I wonder if it's r
On 2022-05-16 17:48:08 +0200, Peter Eisentraut wrote:
> On 14.05.22 01:17, Andres Freund wrote:
> > On 2022-05-11 12:18:58 +0200, Peter Eisentraut wrote:
> > > This currently only works on macOS. The dtrace -G calls needed on
> > > other platforms are not implemented yet.
> >
> > I looked into th
On 14.05.22 01:17, Andres Freund wrote:
On 2022-05-11 12:18:58 +0200, Peter Eisentraut wrote:
This currently only works on macOS. The dtrace -G calls needed on
other platforms are not implemented yet.
I looked into that part. The make rule passes all the backend object files as
an option, but
On 12.05.22 21:30, Andres Freund wrote:
On 2022-05-11 12:18:58 +0200, Peter Eisentraut wrote:
I fixed the Perl detection issue in my macOS environment that I had reported
a while ago.
Hm. I wonder if it's right to check with is_file() - perhaps there are
platforms that have split off the inclu
Hi,
On 2022-05-11 12:18:58 +0200, Peter Eisentraut wrote:
> This currently only works on macOS. The dtrace -G calls needed on
> other platforms are not implemented yet.
I looked into that part. The make rule passes all the backend object files as
an option, but it's not clear to me where / why t
Hi,
On 2022-05-11 12:18:58 +0200, Peter Eisentraut wrote:
> I fixed the Perl detection issue in my macOS environment that I had reported
> a while ago.
Hm. I wonder if it's right to check with is_file() - perhaps there are
platforms that have split off the include directory?
> Then I added in s
More patches:
I fixed the Perl detection issue in my macOS environment that I had
reported a while ago.
Then I added in support for all configure options that had not been
ported over yet. Some of these are rather trivial.
After that, these configure options don't have an equivalent yet:
On 06.05.22 23:27, Andres Freund wrote:
Re symlink: Do you have an opion about dropping the symlink vs implementing it
(likely via a small helper script?)?
I think the postmaster symlink could be dropped. The postmaster man
page has been saying that it's deprecated since 2006.
Hi,
On 2022-05-06 14:27:24 -0700, Andres Freund wrote:
> > 0003-meson-Install-all-server-headers.patch
> >
> > With this, all the server headers installed by a makefile-based build are
> > installed. I tried to strike a balance between using install_subdir() with
> > exclude list versus listing
Hi,
On 2022-04-21 17:34:47 -0400, Tom Lane wrote:
> FWIW, I don't think that either gaur or prairiedog need be factored into
> this conversation. They cannot build ninja at all for lack of ,
> so whether they could run meson is pretty much beside the point.
Yea.
> (I wonder if we should stick
Hi,
On 2022-05-04 13:53:54 +0200, Peter Eisentraut wrote:
> 0001-meson-Assorted-compiler-test-tweaks.patch
>
> I was going through a diff of pg_config.h between old and new build and
> found a few omissions and small differences.
Thanks, merged that.
> is of course annoying and can be removed
More patches:
0001-meson-Assorted-compiler-test-tweaks.patch
I was going through a diff of pg_config.h between old and new build and
found a few omissions and small differences.
Some of the
blah ? 1 : false
is of course annoying and can be removed eventually, but it's useful
when analy
Hi,
On 2022-05-02 16:47:43 +0200, Peter Eisentraut wrote:
> On 29.04.22 19:46, Andres Freund wrote:
> > explicitly using shared_library() rather than library()
>
> Why is that? We do build static libraries right now, so using library()
> would seem more suitable for that.
When I wrote this I ha
On 29.04.22 19:46, Andres Freund wrote:
explicitly using shared_library() rather than library()
Why is that? We do build static libraries right now, so using library()
would seem more suitable for that.
Hi,
On 2022-04-29 11:00:43 -0700, Andres Freund wrote:
> On 2022-04-27 21:56:27 +0200, Peter Eisentraut wrote:
> > Here is a patch that adds in NLS.
>
> Cool! I know very little about translations, so I was reticent tackling
> this...
> > The annoying thing is that the i18n module doesn't appear
Hi,
On 2022-04-27 21:56:27 +0200, Peter Eisentraut wrote:
> Here is a patch that adds in NLS.
Cool! I know very little about translations, so I was reticent tackling
this...
> For example, we could move the list of languages from the meson.build files
> into separate LINGUAS files, which could
Hi,
On 2022-04-20 15:09:31 +0200, Peter Eisentraut wrote:
> On 13.04.22 12:26, Peter Eisentraut wrote:
> > Some feedback and patches for your branch at
> > 3274198960c139328fef3c725cee1468bbfff469:
>
> Here is another patch. It adds support for building ecpg.
Cool!
I have merged this, with a f
Here is a patch that adds in NLS.
There are some opportunities to improve this. For example, we could
move the list of languages from the meson.build files into separate
LINGUAS files, which could be shared with the makefile-based build
system. I need to research this a bit more.
Also, thi
On 2022-04-21 Th 17:34, Tom Lane wrote:
> Andres Freund writes:
>> On 2022-04-21 22:36:01 +0200, Peter Eisentraut wrote:
>>> Why is Python 3.5 relevant?
>> It's the latest available on some older platforms. It's pretty easy to
>> install
>> a new meson, a heck of a lot more work to install a ne
Andres Freund writes:
> On 2022-04-21 22:36:01 +0200, Peter Eisentraut wrote:
>> Why is Python 3.5 relevant?
> It's the latest available on some older platforms. It's pretty easy to install
> a new meson, a heck of a lot more work to install a new python. IIRC solaris,
> AIX and some of Tom's din
Hi,
On 2022-04-21 22:36:01 +0200, Peter Eisentraut wrote:
> On 20.04.22 23:04, Andres Freund wrote:
> > > 0003-Fix-warnings-about-deprecated-features.patch
> > >
> > > This fixes some deprecation warnings and raises the requirement to 0.56.
> >
> > I don't see any deprecation warnings - I see so
On 20.04.22 23:04, Andres Freund wrote:
0003-Fix-warnings-about-deprecated-features.patch
This fixes some deprecation warnings and raises the requirement to 0.56.
I don't see any deprecation warnings - I see some notices about *future*
deprecated features being used:
NOTICE: Future-deprecated
Hi,
On 2022-04-13 12:26:05 +0200, Peter Eisentraut wrote:
> Some feedback and patches for your branch at
> 3274198960c139328fef3c725cee1468bbfff469:
Thanks! I just rebased the branch, will merge your changes once the fallout
from that is fixed...
> 0001-Install-a-few-more-files.patch
>
> These
On 13.04.22 12:26, Peter Eisentraut wrote:
Some feedback and patches for your branch at
3274198960c139328fef3c725cee1468bbfff469:
Here is another patch. It adds support for building ecpg.From 35a23442727cdf82558c7e5eab85bc29df86b5d5 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 2
Some feedback and patches for your branch at
3274198960c139328fef3c725cee1468bbfff469:
0001-Install-a-few-more-files.patch
These are just some files that were apparently forgotten to be installed
so far.
0002-Adjust-some-header-file-installation-paths.patch
The installation of server header
Hi,
On 2022-03-28 18:58:19 -0400, Tom Lane wrote:
> If we can commit meson build infrastructure without removing the
> existing infrastructure, then the buildfarm can continue to work,
> and we can roll out support for the new way slowly.
I think it's not a huge issue to have both for a while. Of
Andrew Dunstan writes:
> On 3/28/22 15:59, Andres Freund wrote:
>> In our context it could make sense to merge meson, after a few months of
>> shakeup remove the current windows buildsystems, and then in release + 1
>> remove the make based stuff.
That sounds like a decent plan.
> I'd like to ge
On 3/28/22 15:59, Andres Freund wrote:
>
> One thing I'd like to discuss fairly soon is what kind of approach to take for
> integrating meson support. Most other projects I looked kept parallel
> buildsystems for at least a release, so that there's one round of "broad" user
> feedback.
We did
Hi,
On 2022-03-25 10:01:09 +0100, Peter Eisentraut wrote:
> On 22.03.22 03:22, Andres Freund wrote:
> > Attached is v8. It's just a rebase to resolve conflicts with recent changes.
>
> I have committed the DLSUFFIX refactoring, and also a stripped-down version
> of the patch that makes update-uni
On 22.03.22 03:22, Andres Freund wrote:
Attached is v8. It's just a rebase to resolve conflicts with recent changes.
I have committed the DLSUFFIX refactoring, and also a stripped-down
version of the patch that makes update-unicode work with vpath. This
takes care of patches 0007 and 0009.
Hi,
Attached is v8. It's just a rebase to resolve conflicts with recent changes.
- Andres
v8-0001-meson-prereq-output-and-depencency-tracking-work.patch.gz
Description: application/patch-gzip
binfm5f_PMrcn.bin
Description: application/patch-gzip
binkuFB75lqSa.bin
Description: application/pa
45 matches
Mail list logo
