Re: [Proposal] Allow pg_dump to include all child tables with the root table

2023-03-14 Thread Tom Lane
Gilles Darold writes: > Thanks Stepane, I've changed commit fest status to "Ready for committers". Pushed with some minor editing. regards, tom lane

Re: [Proposal] Allow pg_dump to include all child tables with the root table

2023-03-14 Thread Gilles Darold
Le 14/03/2023 à 10:50, stephane tachoires a écrit : The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed V5 is o

Re: [Proposal] Allow pg_dump to include all child tables with the root table

2023-03-14 Thread stephane tachoires
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed V5 is ok (aside for LLVM 14 deprecated warnings, but that's a

Re: [Proposal] Allow pg_dump to include all child tables with the root table

2023-03-14 Thread Stéphane Tachoires
Hi Gilles, V5 is ok (aside for LLVM 14 deprecated warnings, but that's another problem) with meson compile and meson test on Ubuntu 20.04.2. Code fits well and looks standart, --help explain what it does clearly, and documentation is ok (but as a Français, I'm not an expert in English). Stéphane

Re: [Proposal] Allow pg_dump to include all child tables with the root table

2023-03-13 Thread Gilles Darold
Le 12/03/2023 à 19:05, Stéphane Tachoires a écrit : Hi Gilles, On Ubuntu 22.04.2 all deb's updated, I have an error on a test I'll try to find where and why, but I think you should know first. 1/1 postgresql:pg_dump / pg_dump/002_pg_dump        ERROR            24.40s   exit status 1

Re: [Proposal] Allow pg_dump to include all child tables with the root table

2023-03-12 Thread Stéphane Tachoires
Hi Gilles, On Ubuntu 22.04.2 all deb's updated, I have an error on a test I'll try to find where and why, but I think you should know first. 1/1 postgresql:pg_dump / pg_dump/002_pg_dumpERROR24.40s exit status 1

Re: [Proposal] Allow pg_dump to include all child tables with the root table

2023-03-12 Thread Gilles Darold
Le 11/03/2023 à 19:51, Gilles Darold a écrit : Le 04/03/2023 à 20:18, Tom Lane a écrit : As noted, "childs" is bad English and "partitions" is flat out wrong (unless you change it to recurse only to partitions, which doesn't seem like a better definition).  We could go with --[exclude-]table-and

Re: [Proposal] Allow pg_dump to include all child tables with the root table

2023-03-11 Thread Gilles Darold
Le 04/03/2023 à 20:18, Tom Lane a écrit : As noted, "childs" is bad English and "partitions" is flat out wrong (unless you change it to recurse only to partitions, which doesn't seem like a better definition). We could go with --[exclude-]table-and-children, or maybe --[exclude-]table-and-child-

Re: [Proposal] Allow pg_dump to include all child tables with the root table

2023-03-05 Thread Gilles Darold
Le 04/03/2023 à 19:18, Tom Lane a écrit : Gilles Darold writes: But I disagree the use of --table-with-childs and --exclude-table-with-childs because we already have the --table and --exclude-table, and it will add lot of code where we just need a switch to include children tables. I quite dis

Re: [Proposal] Allow pg_dump to include all child tables with the root table

2023-03-04 Thread Tom Lane
Gilles Darold writes: > But I disagree the use of --table-with-childs and > --exclude-table-with-childs because we already have the --table and > --exclude-table, and it will add lot of code where we just need a switch > to include children tables. I quite dislike the idea of a separate --with

Re: [Proposal] Allow pg_dump to include all child tables with the root table

2023-02-25 Thread Gilles Darold
Le 25/02/2023 à 16:40, Stéphane Tachoires a écrit : Hi, I'm not sure about the "child" -> "partition" change as it also selects childs that are not partitions. I'm more dubious about the --with-childs option, I'd rather have --table-with-childs= and --exclude-table-with-childs=. That will be

Re: [Proposal] Allow pg_dump to include all child tables with the root table

2023-02-25 Thread Stéphane Tachoires
Hi, I'm not sure about the "child" -> "partition" change as it also selects childs that are not partitions. I'm more dubious about the --with-childs option, I'd rather have --table-with-childs= and --exclude-table-with-childs=. That will be clearer about what is what. I'm working on that, but hav

Re: [Proposal] Allow pg_dump to include all child tables with the root table

2023-02-24 Thread Cary Huang
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:not tested Hi the patch applies fine on current master branch and it works as d

[Proposal] Allow pg_dump to include all child tables with the root table

2023-01-11 Thread Gilles Darold
Hi all, I would like to propose a new pg_dump option called --with-child to include or exclude from a dump all child and partition tables when a parent table is specified using option -t/--table or -T/--exclude-table. The whole tree is dumped with the root table. To include all partitions