Hi, I'm not sure about the "child" -> "partition" change as it also selects childs that are not partitions. I'm more dubious about the --with-childs option, I'd rather have --table-with-childs=<PATTERN> and --exclude-table-with-childs=<PATTERN>. That will be clearer about what is what.
I'm working on that, but have a hard time with test pg_dump/002_pg_dump (It's brand new to me) Stéphane Le ven. 24 févr. 2023 à 23:50, Cary Huang <cary.hu...@highgo.ca> a écrit : > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: not tested > Documentation: not tested > > Hi > > the patch applies fine on current master branch and it works as described. > However, I would suggest changing the new option name from "--with-childs" > to "--with-partitions" for several reasons. > > "childs" is grammatically incorrect and in the PG community, the term > "partitioned table" is normally used to denote a parent table, and the term > "partition" is used to denote the child table under the parent table. We > should use these terms to stay consistent with the community. > > Also, I would rephrase the documentation as: > > Used in conjunction with <option>-t</option>/<option>--table</option> or > <option>-T</option>/<option>--exclude-table</option> options to include or > exclude partitions of the specified tables if any. > > thank you > > Cary Huang > ================ > HighGo Software Canada > www.highgo.ca -- "Où se posaient les hirondelles avant l'invention du téléphone ?" -- Grégoire Lacroix
