Re: [PATCH v1] Add \echo_stderr to psql

2019-04-27 Thread Fabien COELHO
Hello David, About v3. Applies, compiles, global & local make check are ok. doc gen ok. I'd put the commands in alphabetical order (echo, qecho, warn) instead of e/w/q in the condition. Done. Cannot see it: + else if (strcmp(cmd, "echo") == 0 || strcmp(cmd, "warn") == 0 || strcmp(cmd,

Re: [PATCH v1] Add \echo_stderr to psql

2019-04-27 Thread David Fetter
On Sat, Apr 27, 2019 at 04:05:20PM +0200, Fabien COELHO wrote: > > Hello David, > > > Please find attached v2, name is now \warn. > > Patch applies cleanly, compiles, "make check ok", although there are no > tests. Doc gen ok. > > Code is pretty straightforward. > > I'd put the commands in alp

Re: [PATCH v1] Add \echo_stderr to psql

2019-04-27 Thread Fabien COELHO
Hello David, Please find attached v2, name is now \warn. Patch applies cleanly, compiles, "make check ok", although there are no tests. Doc gen ok. Code is pretty straightforward. I'd put the commands in alphabetical order (echo, qecho, warn) instead of e/w/q in the condition. The -n t

Re: [PATCH v1] Add \echo_stderr to psql

2019-04-22 Thread Fabien COELHO
\warn ... \warning ... These two seem about the best to me, drawing from the perl warn command. Yep, I was thinking of perl & gmake. Maybe the 4 letter option is better because its the same length as "echo". I suppose we could go the bash &2 route here, but I don't want to. I agre

Re: [PATCH v1] Add \echo_stderr to psql

2019-04-22 Thread David Fetter
On Mon, Apr 22, 2019 at 09:04:08AM +0200, Fabien COELHO wrote: > > Hello Corey, > > > >\warn ... > > >\warning ... > > > > These two seem about the best to me, drawing from the perl warn command. > > Yep, I was thinking of perl & gmake. Maybe the 4 letter option is better > because its

Re: [PATCH v1] Add \echo_stderr to psql

2019-04-22 Thread Fabien COELHO
Hello Corey, \warn ... \warning ... These two seem about the best to me, drawing from the perl warn command. Yep, I was thinking of perl & gmake. Maybe the 4 letter option is better because its the same length as "echo". I suppose we could go the bash &2 route here, but I don't w

Re: [PATCH v1] Add \echo_stderr to psql

2019-04-21 Thread Corey Huinker
> > >\warn ... >\warning ... > These two seem about the best to me, drawing from the perl warn command. I suppose we could go the bash &2 route here, but I don't want to.

Re: [PATCH v1] Add \echo_stderr to psql

2019-04-21 Thread David Fetter
On Sun, Apr 21, 2019 at 09:31:16PM +0200, Fabien COELHO wrote: > > Any interest in this? > > Yep, although I'm not sure of the suggested command name. More suggestions: > \stderr ... > \err ... > \error ... > \warn ... > \warning ... Naming Things is one of the two[1] hard problems in C

Re: [PATCH v1] Add \echo_stderr to psql

2019-04-21 Thread Fabien COELHO
Any interest in this? Yep, although I'm not sure of the suggested command name. More suggestions: \stderr ... \err ... \error ... \warn ... \warning ... -- Fabien.

Re: [PATCH v1] Add \echo_stderr to psql

2019-04-21 Thread Pavel Stehule
ne 21. 4. 2019 v 20:31 odesílatel David Fetter napsal: > Folks, > > Any interest in this? > has sense Pavel > Best, > David. > -- > David Fetter http://fetter.org/ > Phone: +1 415 235 3778 > > Remember to vote! > Consider donating to Postgres: http://www.postgresql.org/about/donate >

[PATCH v1] Add \echo_stderr to psql

2019-04-21 Thread David Fetter
21 Apr 2019 11:08:40 -0700 Subject: [PATCH v1] Add \echo_stderr to psql To: hackers MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="2.20.1" This is a multi-part message in MIME format. --2.20.1 Content-Type: text/plain; charset=UTF-8; format=fixed Con