Re: [PATCH] vacuumlo: print the number of large objects going to be removed

2019-09-06 Thread Daniel Verite
Michael Paquier wrote: > Sure. However do we need to introduce this much complication as a > goal for this patch though whose goal is just to provide hints about > the progress of the work done by vacuumlo? Yeah, I went off on a tangent when realizing that ~500 lines of C client-side co

Re: [PATCH] vacuumlo: print the number of large objects going to be removed

2019-09-06 Thread Michael Paquier
On Wed, Jul 17, 2019 at 01:31:05PM +0200, Daniel Verite wrote: > The tab width should be 4. Please have a look at > https://www.postgresql.org/docs/current/source-format.html > It also explains why opportunistic reformatting is futile, anyway: - char *schema, - *table,

Re: [PATCH] vacuumlo: print the number of large objects going to be removed

2019-07-17 Thread Daniel Verite
Timur Birsh wrote: > Please find attached patch v2. > I fixed some indentation in the variable declaration blocks. The tab width should be 4. Please have a look at https://www.postgresql.org/docs/current/source-format.html It also explains why opportunistic reformatting is futile, anyway:

Re: [PATCH] vacuumlo: print the number of large objects going to be removed

2019-06-13 Thread Timur Birsh
13.06.2019, 13:57, "Michael Paquier" : > On Thu, Jun 13, 2019 at 01:25:38PM +0600, Timur Birsh wrote: >>  Just to be sure, a new command line argument needs to be added for >>  reporting the numbers? Should it implies --verbose argument? > > Nope. I mean that running a SELECT count(*) can be costly

Re: [PATCH] vacuumlo: print the number of large objects going to be removed

2019-06-13 Thread Michael Paquier
On Thu, Jun 13, 2019 at 01:25:38PM +0600, Timur Birsh wrote: > Just to be sure, a new command line argument needs to be added for > reporting the numbers? Should it implies --verbose argument? Nope. I mean that running a SELECT count(*) can be costly for many items. -- Michael signature.asc Des

Re: [PATCH] vacuumlo: print the number of large objects going to be removed

2019-06-13 Thread Timur Birsh
Hello Michael, 13.06.2019, 12:11, "Michael Paquier" : > Welcome. Nice to see that you have subscribed to the lists. Thank you for your explanations! > Now, if you want to get review for your patch, you should register it > in what we call the commit fest app, which is here: > https://commitfest.

Re: [PATCH] vacuumlo: print the number of large objects going to be removed

2019-06-12 Thread Michael Paquier
Hi, On Thu, Jun 13, 2019 at 10:49:46AM +0600, Timur Birsh wrote: > 12.06.2019, 14:31, "Timur Birsh" : >> Please cc, I am not subscribed to the list. > > I have subscribed to the mailing list, there is no need to cc me. Welcome. Nice to see that you have subscribed to the lists. Please note tha

Re: [PATCH] vacuumlo: print the number of large objects going to be removed

2019-06-12 Thread Timur Birsh
12.06.2019, 14:31, "Timur Birsh" : > Please cc, I am not subscribed to the list. I have subscribed to the mailing list, there is no need to cc me. Thank you.

[PATCH] vacuumlo: print the number of large objects going to be removed

2019-06-12 Thread Timur Birsh
Hello, If tables has a lot of rows with large objects (>1_000_000) that removed throughout the day, it would be useful to know how many LOs going to be removed. First patch - print the number of large objects going to be removed, second patch - print how many LOs removed in percent. Can anyone p