Hello Michael, 13.06.2019, 12:11, "Michael Paquier" <mich...@paquier.xyz>: > Welcome. Nice to see that you have subscribed to the lists.
Thank you for your explanations! > Now, if you want to get review for your patch, you should register it > in what we call the commit fest app, which is here: > https://commitfest.postgresql.org/23/ Done. Please see https://commitfest.postgresql.org/23/2148/ > Commit fests happen every two months for a duration of one month, and > the next one which will begin the development cycle of v13 begins on > the 1st of July. As a basic rule, it is expected that for one patch > submitted, you should review another patch of equal difficulty to keep > some balance in the force. Ok. > Regarding the patch, there is an argument to be made for reporting a > rate as well as the actual numbers of deleted and to-delete items. > > + if (param->verbose) > + { > + snprintf(buf, BUFSIZE, "SELECT count(*) FROM vacuum_l"); > + res = PQexec(conn, buf); > That part is costly. Just to be sure, a new command line argument needs to be added for reporting the numbers? Should it implies --verbose argument? Thanks, Timur
