Re: [PATCH] remove deprecated v8.2 containment operators

2021-03-05 Thread Tom Lane
Justin Pryzby writes: > On Thu, Mar 04, 2021 at 08:58:39PM -0500, Tom Lane wrote: >> I'm confused by why this patch is only dropping the operators' >> opclass-membership links. Don't we want to actually DROP OPERATOR >> too? > Okay Pushed. Since hstore already had a new-in-v14 edition, I just

Re: [PATCH] remove deprecated v8.2 containment operators

2021-03-04 Thread Justin Pryzby
27 + Operator Strategy 8, 26, 27 > Also, the patch seems to be trying to resurrect hstore--1.0--1.1.sql, Not sure why or how I had that. -- Justin >From d9cfb33c1a87a8404fa949613500acd1021254cd Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Sat, 11 Apr 2020 22:57:06 -0500 Subject:

Re: [PATCH] remove deprecated v8.2 containment operators

2021-03-04 Thread Tom Lane
Justin Pryzby writes: > [ 0001-remove-deprecated-v8.2-containment-operators.patch ] I'm confused by why this patch is only dropping the operators' opclass-membership links. Don't we want to actually DROP OPERATOR too? Also, the patch seems to be trying to resurrect hstore--1.0--1.1.sql, which I

Re: [PATCH] remove deprecated v8.2 containment operators

2021-02-02 Thread Justin Pryzby
Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Sat, 11 Apr 2020 22:57:06 -0500 Subject: [PATCH] remove deprecated v8.2 containment operators See also: ba920e1c9182eac55d5f1327ab0d29b721154277 684ad6a92fcc33adebdab65c4e7d72a68ba05408 3165426e54df02a6199c0a2165

Re: [PATCH] remove deprecated v8.2 containment operators

2021-02-01 Thread Masahiko Sawada
On Thu, Jan 28, 2021 at 9:50 PM Masahiko Sawada wrote: > > On Tue, Dec 1, 2020 at 4:09 AM Tom Lane wrote: > > > > Justin Pryzby writes: > > > I think this is waiting on me to provide a patch for the contrib/ modules > > > with > > > update script removing the SQL operators, and documentating th

Re: [PATCH] remove deprecated v8.2 containment operators

2021-01-28 Thread Masahiko Sawada
On Tue, Dec 1, 2020 at 4:09 AM Tom Lane wrote: > > Justin Pryzby writes: > > I think this is waiting on me to provide a patch for the contrib/ modules > > with > > update script removing the SQL operators, and documentating their > > deprecation. > > Right. We can remove the SQL operators, but

Re: [PATCH] remove deprecated v8.2 containment operators

2020-11-30 Thread Tom Lane
Justin Pryzby writes: > I think this is waiting on me to provide a patch for the contrib/ modules with > update script removing the SQL operators, and documentating their deprecation. Right. We can remove the SQL operators, but not (yet) the C code support. I'm not sure that the docs change wou

Re: [PATCH] remove deprecated v8.2 containment operators

2020-11-30 Thread Justin Pryzby
On Mon, Nov 30, 2020 at 09:51:12PM +0300, Anastasia Lubennikova wrote: > On 16.11.2020 23:55, Justin Pryzby wrote: > > On Fri, Nov 13, 2020 at 10:03:43AM -0500, Stephen Frost wrote: > > > * Magnus Hagander (mag...@hagander.net) wrote: > > > > On Thu, Nov 12, 2020 at 11:28 PM Tom Lane wrote: > > >

Re: [PATCH] remove deprecated v8.2 containment operators

2020-11-30 Thread Tom Lane
Anastasia Lubennikova writes: > Status update for a commitfest entry. > The commitfest is nearing the end and this thread is "Waiting on > Author". As far as I see we don't have a patch here and discussion is a > bit stuck. > So, I am planning to return it with feedback. Any objections? AFAICS

Re: [PATCH] remove deprecated v8.2 containment operators

2020-11-30 Thread Anastasia Lubennikova
On 16.11.2020 23:55, Justin Pryzby wrote: On Fri, Nov 13, 2020 at 10:03:43AM -0500, Stephen Frost wrote: * Magnus Hagander (mag...@hagander.net) wrote: On Thu, Nov 12, 2020 at 11:28 PM Tom Lane wrote: The changes to the contrib modules appear to be incomplete in some ways. In cube, hstore,

Re: [PATCH] remove deprecated v8.2 containment operators

2020-11-16 Thread Justin Pryzby
On Fri, Nov 13, 2020 at 10:03:43AM -0500, Stephen Frost wrote: > * Magnus Hagander (mag...@hagander.net) wrote: > > On Thu, Nov 12, 2020 at 11:28 PM Tom Lane wrote: > > > > The changes to the contrib modules appear to be incomplete in some ways. > > > > In cube, hstore, and seg, there are no cha

Re: [PATCH] remove deprecated v8.2 containment operators

2020-11-16 Thread Peter Eisentraut
On 2020-11-13 16:57, Tom Lane wrote: Peter Eisentraut writes: On 2020-11-12 23:28, Tom Lane wrote: I'm on board with pulling these now --- 8.2 to v14 is plenty of deprecation notice. However, the patch seems incomplete in that the code support for these is still there -- look for RTOldContain

Re: [PATCH] remove deprecated v8.2 containment operators

2020-11-13 Thread Tom Lane
Peter Eisentraut writes: > On 2020-11-12 23:28, Tom Lane wrote: >> I'm on board with pulling these now --- 8.2 to v14 is plenty of >> deprecation notice. However, the patch seems incomplete in that >> the code support for these is still there -- look for >> RTOldContainedByStrategyNumber and RTOl

Re: [PATCH] remove deprecated v8.2 containment operators

2020-11-13 Thread Stephen Frost
Greetings, * Magnus Hagander (mag...@hagander.net) wrote: > On Thu, Nov 12, 2020 at 11:28 PM Tom Lane wrote: > > > The changes to the contrib modules appear to be incomplete in some ways. > > > In cube, hstore, and seg, there are no changes to the extension > > > scripts to remove the operators

Re: [PATCH] remove deprecated v8.2 containment operators

2020-11-13 Thread Magnus Hagander
On Thu, Nov 12, 2020 at 11:28 PM Tom Lane wrote: > > > The changes to the contrib modules appear to be incomplete in some ways. > > In cube, hstore, and seg, there are no changes to the extension > > scripts to remove the operators. All you're doing is changing the C > > code to no longer recog

Re: [PATCH] remove deprecated v8.2 containment operators

2020-11-12 Thread Peter Eisentraut
On 2020-11-12 23:28, Tom Lane wrote: I'm on board with pulling these now --- 8.2 to v14 is plenty of deprecation notice. However, the patch seems incomplete in that the code support for these is still there -- look for RTOldContainedByStrategyNumber and RTOldContainsStrategyNumber. Admittedly, t

Re: [PATCH] remove deprecated v8.2 containment operators

2020-11-12 Thread Tom Lane
Peter Eisentraut writes: > On 2020-10-27 04:25, Justin Pryzby wrote: >> They have been deprecated for a Long Time, so finally remove them for v14. >> Four fewer exclamation marks makes the documentation less exciting, which is >> a >> good thing. > I have committed the parts that remove the buil

Re: [PATCH] remove deprecated v8.2 containment operators

2020-11-03 Thread Peter Eisentraut
On 2020-10-27 04:25, Justin Pryzby wrote: Forking this thread: https://www.postgresql.org/message-id/fd93f1c5-7818-a02c-01e5-1075ac0d4...@iki.fi They have been deprecated for a Long Time, so finally remove them for v14. Four fewer exclamation marks makes the documentation less exciting, which is

Re: [PATCH] remove deprecated v8.2 containment operators

2020-10-27 Thread Magnus Hagander
On Tue, Oct 27, 2020 at 9:38 AM Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 2020-10-27 04:25, Justin Pryzby wrote: > > Forking this thread: > > > https://www.postgresql.org/message-id/fd93f1c5-7818-a02c-01e5-1075ac0d4...@iki.fi > > > > They have been deprecated for a Long Time

Re: [PATCH] remove deprecated v8.2 containment operators

2020-10-27 Thread Peter Eisentraut
On 2020-10-27 04:25, Justin Pryzby wrote: Forking this thread: https://www.postgresql.org/message-id/fd93f1c5-7818-a02c-01e5-1075ac0d4...@iki.fi They have been deprecated for a Long Time, so finally remove them for v14. Four fewer exclamation marks makes the documentation less exciting, which is

[PATCH] remove deprecated v8.2 containment operators

2020-10-26 Thread Justin Pryzby
rom 7868fee24f92fb5150735f1f9507cfe9a6ab212c Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Sat, 11 Apr 2020 22:57:06 -0500 Subject: [PATCH] remove deprecated v8.2 containment operators See also: ba920e1c9182eac55d5f1327ab0d29b721154277 684ad6a92fcc33adebdab65c4e7d72a68ba05408 --- contrib/cube/cub