Re: [PATCH] pg_regress.c: Fix "make check" on Mac OS X: Pass DYLD_LIBRARY_PATH

Hi, On 2023-06-05 22:33:16 -0400, Tom Lane wrote: > Julien Rouhaud writes: > > On Mon, Jun 05, 2023 at 09:47:30AM -0400, Evan Jones wrote: > >> This makes "make check" work on Mac OS X. Without this patch, on Mac OS X a > >> default "./configure; make; make check" fails with errors like: > >> ...

Re: [PATCH] pg_regress.c: Fix "make check" on Mac OS X: Pass DYLD_LIBRARY_PATH

On 22.06.23 21:08, David Zhang wrote: Currently, there is a description suggesting a workaround by running a 'make install' command first, but I find it to be somewhat inaccurate. It would be better to update the existing description to provide more precise instructions on how to overcome this

Re: [PATCH] pg_regress.c: Fix "make check" on Mac OS X: Pass DYLD_LIBRARY_PATH

After conducting a further investigation into this issue, I have made some discoveries. The previous patch successfully resolves the problem when running the commands `./configure && make && make check` (without any previous sudo make install or make install). However, it stops at the 'isolatio

Re: [PATCH] pg_regress.c: Fix "make check" on Mac OS X: Pass DYLD_LIBRARY_PATH

I have applied the patch to the latest master branch and successfully executed './configure && make && make check' on macOS Ventura. However, during the process, a warning was encountered: "mixing declarations and code is incompatible with standards before C99 [-Wdeclaration-after-statement]". M

Re: [PATCH] pg_regress.c: Fix "make check" on Mac OS X: Pass DYLD_LIBRARY_PATH

On Tue, Jun 06, 2023 at 09:48:24PM -0400, Tom Lane wrote: > configure with --enable-tap-tests, then do "make check-world". > > Also, adding certain additional feature arguments such as > --with-python enables more test cases. We aren't going to be > super excited about a patch that doesn't handle

Re: [PATCH] pg_regress.c: Fix "make check" on Mac OS X: Pass DYLD_LIBRARY_PATH

On Wed, Jun 7, 2023 at 5:44 AM Evan Jones wrote: > > On Tue, Jun 6, 2023 at 5:23 PM Peter Eisentraut wrote: >> >> This addresses only pg_regress. What about all the other test suites? >> Per the previous discussions, you'd need to patch up other places in a >> similar way, potentially everywhere

Re: [PATCH] pg_regress.c: Fix "make check" on Mac OS X: Pass DYLD_LIBRARY_PATH

Evan Jones writes: > On Tue, Jun 6, 2023 at 5:23 PM Peter Eisentraut > wrote: >> This addresses only pg_regress. What about all the other test suites? > Are there instructions for how I can run these other test suites? configure with --enable-tap-tests, then do "make check-world". Also, addin

Re: [PATCH] pg_regress.c: Fix "make check" on Mac OS X: Pass DYLD_LIBRARY_PATH

On Tue, Jun 6, 2023 at 5:23 PM Peter Eisentraut wrote: > This addresses only pg_regress. What about all the other test suites? > Per the previous discussions, you'd need to patch up other places in a > similar way, potentially everywhere system() is called. > Are there instructions for how I ca

Re: [PATCH] pg_regress.c: Fix "make check" on Mac OS X: Pass DYLD_LIBRARY_PATH

On 06.06.23 16:24, Evan Jones wrote: On Mon, Jun 5, 2023 at 10:33 PM Tom Lane > wrote: > Note that this is a known issue Yeah.  We have attempted to work around this before, but failed to find a solution without more downsides than upsides.  I will be inte

Re: [PATCH] pg_regress.c: Fix "make check" on Mac OS X: Pass DYLD_LIBRARY_PATH

On Mon, Jun 5, 2023 at 10:33 PM Tom Lane wrote: > > Note that this is a known issue > Yeah. We have attempted to work around this before, but failed to find > a solution without more downsides than upsides. I will be interested > to look at this patch, but lack time for it right now. Anybody e

Re: [PATCH] pg_regress.c: Fix "make check" on Mac OS X: Pass DYLD_LIBRARY_PATH

Julien Rouhaud writes: > On Mon, Jun 05, 2023 at 09:47:30AM -0400, Evan Jones wrote: >> This makes "make check" work on Mac OS X. Without this patch, on Mac OS X a >> default "./configure; make; make check" fails with errors like: >> ... >> The reason is that at some point, Mac OS X started removi

Re: [PATCH] pg_regress.c: Fix "make check" on Mac OS X: Pass DYLD_LIBRARY_PATH

Hi, On Mon, Jun 05, 2023 at 09:47:30AM -0400, Evan Jones wrote: > This makes "make check" work on Mac OS X. Without this patch, on Mac OS X a > default "./configure; make; make check" fails with errors like: > > dyld[65265]: Library not loaded: /usr/local/pgsql/lib/libpq.5.dylib > Referenced fr

[PATCH] pg_regress.c: Fix "make check" on Mac OS X: Pass DYLD_LIBRARY_PATH

This makes "make check" work on Mac OS X. Without this patch, on Mac OS X a default "./configure; make; make check" fails with errors like: dyld[65265]: Library not loaded: /usr/local/pgsql/lib/libpq.5.dylib Referenced from: <59A2EAF9-6298-3112-BEDB-EA9A62A9DB53> /Users/evan.jones/postgresql-cle