Phil Krylov writes:
> Attaching the new version, with the test case and free-before-exit
> removed.
Pushed with minor cosmetic adjustments. Thanks for the patch!
regards, tom lane
before-exit
removed.
-- Ph.From 4f8e39f3c5e39b5ec507ec4b07ad5d33c6610524 Mon Sep 17 00:00:00 2001
From: Phil Krylov
Date: Thu, 2 Sep 2021 21:39:58 +0200
Subject: [PATCH] pg_ctl should not truncate command lines at 1024 characters
---
src/bin/pg_ctl/pg_ctl.c | 43 +++
Phil Krylov writes:
> IMHO pg_ctl should not blindly truncate generated command lines at
> MAXPGPATH (1024 characters) and then run that, resulting in:
Fair enough.
> The attached patch tries to fix it in the least intrusive way.
Seems reasonable. We didn't have psprintf when this code was wr
On 2021-09-03 00:36, Ranier Vilela wrote:
The msvc docs says that limit for the command line is 32,767
characters,
while ok for me, I think if not it would be better to check this limit?
Well, it's ARG_MAX in POSIX, and ARG_MAX is defined as 256K in Darwin,
512K in FreeBSD, 128K in Linux; _P
Em qui., 2 de set. de 2021 às 18:36, Phil Krylov escreveu:
> Hello,
>
> Lacking a tool to edit postgresql.conf programmatically, people resort
> to passing cluster options on the command line. While passing all
> non-default options in this way may sound like an abuse of the feature,
> IMHO pg_ct
short-lived
process and is therefore allowed to leak memory? I've noticed some
places where I would like to add a free() call.
-- Ph.From 6f2e70025208fa4d0034ddbe5254e2cb9759dd24 Mon Sep 17 00:00:00 2001
From: Phil Krylov
Date: Thu, 2 Sep 2021 21:39:58 +0200
Subject: [PATCH] pg_ctl should no
