Em qui., 2 de set. de 2021 às 18:36, Phil Krylov <p...@krylov.eu> escreveu:
> Hello, > > Lacking a tool to edit postgresql.conf programmatically, people resort > to passing cluster options on the command line. While passing all > non-default options in this way may sound like an abuse of the feature, > IMHO pg_ctl should not blindly truncate generated command lines at > MAXPGPATH (1024 characters) and then run that, resulting in: > The msvc docs says that limit for the command line is 32,767 characters, while ok for me, I think if not it would be better to check this limit? > /bin/sh: Syntax error: end of file unexpected (expecting word) > pg_ctl: could not start server > Examine the log output. > > The attached patch tries to fix it in the least intrusive way. > > While we're at it, is it supposed that pg_ctl is a very short-lived > process and is therefore allowed to leak memory? I've noticed some > places where I would like to add a free() call. > +1 to add free. regards, Ranier Vilela
