Re: [PATCH] Use role name "system_user" instead of "user" for unsafe_tests

Hi, > On Wed, Apr 12, 2023 at 03:30:03PM +0300, Aleksander Alekseev wrote: > > Any objections if we remove the tests for "user"? > > Based on some rather-recent experience in this area with > COERCE_SQL_SYNTAX, the relationship between the SQL keywords and the > way they can handled internally cou

Re: [PATCH] Use role name "system_user" instead of "user" for unsafe_tests

On Wed, Apr 12, 2023 at 03:30:03PM +0300, Aleksander Alekseev wrote: > Any objections if we remove the tests for "user"? Based on some rather-recent experience in this area with COERCE_SQL_SYNTAX, the relationship between the SQL keywords and the way they can handled internally could be tricky if

Re: [PATCH] Use role name "system_user" instead of "user" for unsafe_tests

Hi, > Whether we need to have a test for this at all is perhaps a > more interesting argument. This was my initial thought but since somebody put it there I assumed this is a very important test. Any objections if we remove the tests for "user"? -- Best regards, Aleksander Alekseev

Re: [PATCH] Use role name "system_user" instead of "user" for unsafe_tests

Aleksander Alekseev writes: >> I don't think we can protect against all possible user names. Wouldn't it be >> better to run the tests under an OS user with a different name, like >> "marmaduke"? ("user" is a truly terrible default user name). > 100% agree. The point is not to protect against a

Re: [PATCH] Use role name "system_user" instead of "user" for unsafe_tests

Hi Andrew, > I don't think we can protect against all possible user names. Wouldn't it be > better to run the tests under an OS user with a different name, like > "marmaduke"? ("user" is a truly terrible default user name). 100% agree. The point is not to protect against all possible user names

Re: [PATCH] Use role name "system_user" instead of "user" for unsafe_tests

On 2023-04-11 Tu 14:25, Aleksander Alekseev wrote: Hi, While playing with a new single board computer (VisionFive 2) I discovered that postgresql:unsafe_tests suite fails like this: ``` --- /home/user/projects/postgresql/src/test/modules/unsafe_tests/expected/rolenames.out 2023-04-11 14:58:57

[PATCH] Use role name "system_user" instead of "user" for unsafe_tests

Hi, While playing with a new single board computer (VisionFive 2) I discovered that postgresql:unsafe_tests suite fails like this: ``` --- /home/user/projects/postgresql/src/test/modules/unsafe_tests/expected/rolenames.out 2023-04-11 14:58:57.844550612 + +++ /home/user/projects/postgresql/b