On Thu, Jul 30, 2020 at 02:16:04PM +0900, Masahiko Sawada wrote:
> Yeah, that's the reason why I mentioned about toast tables. "VACUUM
> " displays "pg_toast." but, "VACUUM pg_to" doesn't
> complement anything.
So am I OK with this situation. The same is true as well for CLUSTER
and TRUNCATE, and
On Thu, 30 Jul 2020 at 12:24, Fujii Masao wrote:
>
>
>
> On 2020/07/30 10:46, Michael Paquier wrote:
> > On Thu, Jul 30, 2020 at 08:44:26AM +0900, Fujii Masao wrote:
> >> Isn't it better to add the comment explaining why toast tables are
> >> excluded from the tab completion for vacuum while they
On 2020/07/30 10:46, Michael Paquier wrote:
On Thu, Jul 30, 2020 at 08:44:26AM +0900, Fujii Masao wrote:
Isn't it better to add the comment explaining why toast tables are
excluded from the tab completion for vacuum while they are vacuumable?
Sounds sensible, still it does not apply only to
On Thu, Jul 30, 2020 at 08:44:26AM +0900, Fujii Masao wrote:
> Isn't it better to add the comment explaining why toast tables are
> excluded from the tab completion for vacuum while they are vacuumable?
Sounds sensible, still it does not apply only to vacuum. I would go
as far as just adding a co
On 2020/07/30 3:33, Justin Pryzby wrote:
On Wed, Jul 29, 2020 at 03:21:19PM +0900, Michael Paquier wrote:
On Wed, Jul 29, 2020 at 01:27:07PM +0900, Masahiko Sawada wrote:
Good catch. The patch looks good to me.
While this patch is logically correct. I think that we should try to
not incre
On Wed, Jul 29, 2020 at 03:21:19PM +0900, Michael Paquier wrote:
> On Wed, Jul 29, 2020 at 01:27:07PM +0900, Masahiko Sawada wrote:
> > Good catch. The patch looks good to me.
>
> While this patch is logically correct. I think that we should try to
> not increase more the number of queries used t
On Wed, Jul 29, 2020 at 06:41:16PM +0900, Masahiko Sawada wrote:
> whereas Query_for_list_of_vacuumables should search for:
>
> RELKIND_RELATION
> RELKIND_PARTITIONED_TABLE
> RELKIND_MATVIEW
> RELKIND_TOASTVALUE
FWIW, I don't think that we should make toast relations suggested to
the user at all
On Wed, 29 Jul 2020 at 15:21, Michael Paquier wrote:
>
> On Wed, Jul 29, 2020 at 01:27:07PM +0900, Masahiko Sawada wrote:
> > Good catch. The patch looks good to me.
>
> While this patch is logically correct. I think that we should try to
> not increase more the number of queries used to scan pg_
On Wed, Jul 29, 2020 at 01:27:07PM +0900, Masahiko Sawada wrote:
> Good catch. The patch looks good to me.
While this patch is logically correct. I think that we should try to
not increase more the number of queries used to scan pg_class
depending on a list of relkinds. For example, did you noti
On Wed, 29 Jul 2020 at 02:04, Justin Pryzby wrote:
>
> Could maybe backpatch to v10.
>
> diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
> index 272f799c24..06ef658afb 100644
> --- a/src/bin/psql/tab-complete.c
> +++ b/src/bin/psql/tab-complete.c
> @@ -578,14 +578,23 @@ stat
catname = "pg_catalog.pg_constraint c",
>From fef1fcced9f25a73084b618dab9eafd37e3f6898 Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Tue, 28 Jul 2020 11:56:26 -0500
Subject: [PATCH] Tab completion for VACUUM of partitioned tables
---
src/bin/psql/tab-complete.c | 13 +++--
11 matches
Mail list logo
