On Thu, Jul 30, 2020 at 08:44:26AM +0900, Fujii Masao wrote: > Isn't it better to add the comment explaining why toast tables are > excluded from the tab completion for vacuum while they are vacuumable?
Sounds sensible, still it does not apply only to vacuum. I would go as far as just adding a comment at the beginning of the block for schema queries: "Never include toast tables in any of those queries to avoid unnecessary bloat in the completions." > The patch looks good to me except that. Indeed. FWIW, I would also adjust the comment on top of Query_for_list_of_indexables to not say "index creation", but just "supporting indexing" instead. Fujii-san, perhaps you would prefer taking care of this patch? I am fine to do it if you wish. -- Michael
signature.asc
Description: PGP signature
