Bharath Rupireddy writes:
> On Sat, Jul 11, 2020 at 11:53 PM Tom Lane wrote:
>> Pushed with some fiddling. Mainly, if we're going to the trouble of
>> checking for binary mode here, we might as well skip allocating the
>> line_buf too.
> Isn't it good if we backpatch this to versions 13, 12, 11
On Sat, Jul 11, 2020 at 11:53 PM Tom Lane wrote:
>
> vignesh C writes:
> > On Tue, Jun 30, 2020 at 2:41 PM Bharath Rupireddy
> > wrote:
> >> I've added this patch to commitfest -
> >> https://commitfest.postgresql.org/28/.
>
> > I felt this patch is ready for committer, changing the status to r
vignesh C writes:
> On Tue, Jun 30, 2020 at 2:41 PM Bharath Rupireddy
> wrote:
>> I've added this patch to commitfest - https://commitfest.postgresql.org/28/.
> I felt this patch is ready for committer, changing the status to ready
> for committer.
Pushed with some fiddling. Mainly, if we're g
On Tue, Jun 30, 2020 at 2:41 PM Bharath Rupireddy
wrote:
>
> Thanks Vignesh and Rushabh for reviewing this.
>
> I've added this patch to commitfest - https://commitfest.postgresql.org/28/.
I felt this patch is ready for committer, changing the status to ready
for committer.
Regards,
Vignesh
Ente
Thanks Vignesh and Rushabh for reviewing this.
I've added this patch to commitfest - https://commitfest.postgresql.org/28/.
Request community take this patch further if there are no further issues.
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
On Sat, Jun 27, 2020 a
On Sat, Jun 27, 2020 at 9:23 AM Bharath Rupireddy
wrote:
>
> Thanks Rushabh and Vignesh for the comments.
>
> >
> > One comment:
> > We could change below code:
> > + */
> > + if (!cstate->binary)
> > + cstate->raw_buf = (char *) palloc(RAW_BUF_SIZE + 1);
> > + else
> > + cstate->raw_buf = NULL;
>
Thanks Rushabh and Vignesh for the comments.
>
> One comment:
> We could change below code:
> + */
> + if (!cstate->binary)
> + cstate->raw_buf = (char *) palloc(RAW_BUF_SIZE + 1);
> + else
> + cstate->raw_buf = NULL;
> to:
> cstate->raw_buf = (cstate->binary) ? NULL : (char *) palloc(RAW_BUF_SIZE
On Fri, Jun 26, 2020 at 6:15 PM Rushabh Lathia wrote:
>
>
>
> On Fri, Jun 26, 2020 at 3:16 PM Bharath Rupireddy
> wrote:
>>
>> Hi Hackers,
>>
>> There seems to be an extra palloc of 64KB of raw_buf for binary format
>> files which is not required
>> as copy logic for binary files don't use raw_b
On Fri, Jun 26, 2020 at 3:16 PM Bharath Rupireddy <
bharath.rupireddyforpostg...@gmail.com> wrote:
> Hi Hackers,
>
> There seems to be an extra palloc of 64KB of raw_buf for binary format
> files which is not required
> as copy logic for binary files don't use raw_buf, instead, attribute_buf
> is
Hi Hackers,
There seems to be an extra palloc of 64KB of raw_buf for binary format
files which is not required
as copy logic for binary files don't use raw_buf, instead, attribute_buf
is used in CopyReadBinaryAttribute.
Attached is a patch, which places a check to avoid this unnecessary 64KB pall
10 matches
Mail list logo
