On Sat, Jun 27, 2020 at 9:23 AM Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> wrote: > > Thanks Rushabh and Vignesh for the comments. > > > > > One comment: > > We could change below code: > > + */ > > + if (!cstate->binary) > > + cstate->raw_buf = (char *) palloc(RAW_BUF_SIZE + 1); > > + else > > + cstate->raw_buf = NULL; > > to: > > cstate->raw_buf = (cstate->binary) ? NULL : (char *) palloc(RAW_BUF_SIZE + > > 1); > > > > Attached the patch with the above changes.
Changes look fine to me. Regards, Vignesh EnterpriseDB: http://www.enterprisedb.com
