Re: Checking pgwin32_is_junction() errors

2022-08-11 Thread r . zharkov
On 2022-08-11 07:55, Thomas Munro wrote: I checked a few variants: 21.07.2022 15:11 HOME [\??\Volume{GUID}\] 09.08.2022 15:06 Test1 [\\?\Volume{GUID}\] 09.08.2022 15:06 Test2 [\\.\Volume{GUID}\] 09.08.2022 15:17 Test3 [\??\Volume{GUID}\] 09.08.2022 15:27

Re: Checking pgwin32_is_junction() errors

2022-08-09 Thread r . zharkov
On 2022-08-09 05:44, Thomas Munro wrote: On Tue, Aug 9, 2022 at 8:30 AM Thomas Munro wrote: On Mon, Aug 8, 2022 at 8:23 PM wrote: > "C:/HOME" is the junction point to the second volume on my hard drive - > "\??\Volume{GUID}\" which name pgreadlink() erroneously strips here: > https://github.c

Re: Checking pgwin32_is_junction() errors

2022-08-09 Thread r . zharkov
On 2022-08-09 03:30, Thomas Munro wrote: Then our readlink() emulation removes it again, but in the case of your \??\Volume{GUID} path, created by you, not our symlink() emulation, removing "\??\" apparently makes it unopenable with CreateFile() (I guess that's what fails? What's the error?).

Re: Checking pgwin32_is_junction() errors

2022-08-08 Thread r . zharkov
On 2022-08-06 08:02, Thomas Munro wrote: Pushed. Hmm, this stuff could *really* use a little test framework that's run by check-world, that exercises these various replacement operations. But I also suspect that problems in this area are likely to be due to concurrency. It's hard to make a sim

Re: TAP tests aren't using the magic words for Windows file access

2020-12-16 Thread r . zharkov
Thank you very much! On 2020-12-15 20:47, Andrew Dunstan wrote: On 12/15/20 12:05 AM, r.zhar...@postgrespro.ru wrote: Are there any plans to backport the patch to earlier versions of the Postgres? https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=114541d58e5970e51b78b77b65de16210be

Re: TAP tests aren't using the magic words for Windows file access

2020-12-15 Thread r . zharkov
Hello hackers, Are there any plans to backport the patch to earlier versions of the Postgres? https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=114541d58e5970e51b78b77b65de16210beaab43 We rarely see the issue with the pg_ctl/004_logrotate test on the REL_12_STABLE branch. On my note

Re: Intermittent pg_ctl failures on Windows

2019-07-17 Thread r . zharkov
On 2019-07-17 20:51, Tom Lane wrote: r.zhar...@postgrespro.ru writes: pg_ctl now opens the postmaster.pid file using pgwin32_open() function to correctly handle share locks. HEAD already does that, no? See f02259fe9. You are right. I tested branch REL_11_STABLE and it is my mistake. On W

Re: Intermittent pg_ctl failures on Windows

2019-07-17 Thread r . zharkov
Hello! We reproduced these errors on out buildfarm and my windows workstation. We used small TAP test that restarts PostgresNode in loop. Additionally, constant WAITS_PER_SEC in the pg_ctl.c file has been increased 1000 times. There are two different problems with pg_ctl: 1 - share access to p