Re: New committer: Jacob Champion

2025-04-15 Thread Umar Hayat
everts! > > Thanks, > > Jonathan Congratulations Jacob! -- Umar Hayat SKAI Worldwide (https://skaiworldwide.com/ <https://www.skaiworldwide.com/>)

Add missing tab completion for VACUUM and ANALYZE with ONLY option

2025-02-06 Thread Umar Hayat
easier to separate command options (VERBOSE, FREEZE, ... ) from table list. [1] https://www.postgresql.org/message-id/flat/CADofcAWATx_haD%3DQkSxHbnTsAe6%2Be0Aw8Eh4H8cXyogGvn_kOg%40mail.gmail.com Regards -- Umar Hayat Bitnine (https://bitnine.net/) v0-psql-vacuum-analyze-only-option.patch Descripti

Re: jsonlog missing from logging_collector description

2025-01-31 Thread Umar Hayat
On Fri, 31 Jan 2025 at 20:41, Ashutosh Bapat wrote: > > On Fri, Jan 31, 2025 at 2:43 PM Michael Paquier wrote: > > > > On Fri, Jan 31, 2025 at 06:09:48PM +0900, Umar Hayat wrote: > > > Enabling logging_collector is required for json log. During jsonlog > > >

jsonlog missing from logging_collector description

2025-01-31 Thread Umar Hayat
). Attached is the patch for this minor fix. [1] https://www.postgresql.org/message-id/CAH7T-aqswBM6JWe4pDehi1uOiufqe06DJWaU5=x7ddlyque...@mail.gmail.com Regards -- Umar Hayat Bitnine (https://bitnine.net/) v0-logging-collector-jsonlog.patch Description: Binary data

Re: Feature Request: Add AES-128-CFB Mode Support to pgcrypto

2025-01-31 Thread Umar Hayat
Hi Vladyslav, No Problem, I also did not realize that you will be implementing it. So I spent a couple of hours and provided a patch. Also created commitfest entry as well, Please do review the patch and let me know if this is sufficient at least for your use case. Regards, Umar Hayat Bitnine

Re: Feature Request: Add AES-128-CFB Mode Support to pgcrypto

2025-01-29 Thread Umar Hayat
-cfb128. For simplicity I only added aes-cfb, which is the most common method used, lower number of bits will introduce performance degradation, but if it's desirable I can add them as well. -- Umar Hayat Bitnine (https://bitnine.net/) v0-0001-pgcrypto-aes-cfb-mode.patch Description: Binary data

Re: Add XMLNamespaces to XMLElement

2025-01-27 Thread Umar Hayat
Pavel and Jim, If that's the case, it looks good to me. Just wanted to highlight potential issues and implementation differences compared to other databases. Regards Umar Hayat

Re: New process of getting changes into the commitfest app

2025-01-26 Thread Umar Hayat
g critical to rather fresh member of community. +1 in github you can enforce a minimum number of reviewers. IMO there should be a minimum of two reviewers and one of the reviewers should be from the security group/role. Though primary risk would be introducing new vulnerable dependency but there is no

Re: Add XMLNamespaces to XMLElement

2025-01-21 Thread Umar Hayat
On Tue, 21 Jan 2025 at 04:04, Jim Jones wrote: > > Hi Umar > > On 20.01.25 17:19, Umar Hayat wrote: > > Hi Jim & Pavel, > > Sorry for getting back a bit late on this. Few more case you might > > need consider: > > > > As I mentioned in my first stati

Re: Add XMLNamespaces to XMLElement

2025-01-20 Thread Umar Hayat
;); select xmlelement(NAME "root", xmlnamespaces(default col1)) from tbl1; xmlelement ----- (2 rows) Changing status in commitfest, feel free to revert back. Regards Umar Hayat On Sun, 19 Jan 2025 at 18:33, Jim Jones wrote: > > > On 16.01.25 08:36, Pavel St

Re: Add XMLNamespaces to XMLElement

2024-12-25 Thread Umar Hayat
lement -- instead of SELECT xmlelement(NAME "root", xmlnamespaces(NO DEFAULT)); xmlelement -- Regards Umar Hayat On Sat, 21 Dec 2024 at 14:57, Pavel Stehule wrote: > > Hi > > so 21. 12. 2024 v 0:51 odesílatel Jim Jones > napsal: >> &

Re: ActiveState Perl is not valid anymore to build PG17 on the Windows 10/11 platforms, So Documentation still suggesting it should be updated

2024-10-28 Thread Umar Hayat
Hi Bruce, Patch looks good. In my opinion patch should be committed as more and more people who are trying to build PG 17 on Windows are facing similar issues. Latest issue was reported yesterday [0]. Regards Umar Hayat [0] https://www.postgresql.org/message-id/flat/CA%2BOCxozXN%3DGFPWU8vBjG6ch

Re: msvc directory missing in PostgreSQL 17.0

2024-10-27 Thread Umar Hayat
Hi, In my opinion the issue could be Active-state perl ( as I see in your log file, activestate perl path). In this thread [0] people faced same problem and solved it using strawberry perl. Regards Umar Hayat [0] https://www.postgresql.org/message-id/flat

Re: psql client does not handle WSAEWOULDBLOCK on Windows

2024-08-05 Thread Umar Hayat
pqsecure_raw_read/write, does not need to take care of portable ERRNO. Regards Umar Hayat The new status of this patch is: Waiting on Author

Re: strange context message in spi.c?

2024-08-02 Thread Umar Hayat
The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: tested, failed Spec compliant: tested, failed Documentation:tested, failed As tree is branched out for PG17, I guess now it's time to co