Hi Bruce, Patch looks good. In my opinion patch should be committed as more and more people who are trying to build PG 17 on Windows are facing similar issues. Latest issue was reported yesterday [0].
Regards Umar Hayat [0] https://www.postgresql.org/message-id/flat/CA%2BOCxozXN%3DGFPWU8vBjG6ch%3Di2q46FrQbTMjpsERGaSXQj-%2BtQ%40mail.gmail.com#8c5cefdb5881f4ed49e254d4ef9dbe09 Umar Hayat On Thu, 17 Oct 2024 at 07:35, Bruce Momjian <br...@momjian.us> wrote: > > On Tue, Jul 16, 2024 at 08:23:11AM -0400, Andrew Dunstan wrote: > > > > On 2024-07-16 Tu 7:46 AM, Yasir wrote: > > > > Hi Hackers, > > > > Recently, I compiled PG17 on the windows. Till PG16 "ActiveState Perl", > > as > > instructed in the documentation, was being used successfully on the > > Windows > > 10/11 to compile PG. > > However, it looks like that "ActiveState Perl" is not valid anymore to > > compile PG17 on Windows 10/11 but documentation still suggests it. > > Therefore, I think documentation needs to be updated. > > Moreover, I had to install "strawberry's perl" in order to compile PG17 > > on > > Windows 10/11. Please check out the thread "errors building on windows > > using meson" highlighting the issue. > > > > > > > > See https://postgr.es/m/4acddcd4-1c08-44e7-ba60-cab102259...@dunslane.net > > > > I agree we should fix the docco. > > I have written the attached patch to make these changes. > > -- > Bruce Momjian <br...@momjian.us> https://momjian.us > EDB https://enterprisedb.com > > When a patient asks the doctor, "Am I going to die?", he means > "Am I going to die soon?"
