Re: [PATCH] ltree hash functions

2023-12-05 Thread Tommy Pavlicek
Thanks. I've attached the latest version that updates the naming in line with the convention. On Mon, Dec 4, 2023 at 12:46 AM jian he wrote: > > On Fri, Dec 1, 2023 at 8:44 AM Tommy Pavlicek wrote: > > > > > > Patch updated for those comments (and a touch of cleanu

Re: [PATCH] ltree hash functions

2023-11-30 Thread Tommy Pavlicek
On Tue, Nov 28, 2023 at 7:38 PM jian he wrote: > you only change Makefile, you also need to change contrib/ltree/meson.build? > Do you need to use EXPLAIN to demo the index usage? Thanks! Yes, I missed the Meson build file. I added additional commands with EXPLAIN (COSTS OFF) as I found in other

Re: [PATCH] ltree hash functions

2023-11-28 Thread Tommy Pavlicek
On Thu, Jul 6, 2023 at 2:18 AM Daniel Gustafsson wrote: > > > On 19 Jun 2023, at 11:18, Tommy Pavlicek wrote: > > > Tommy, are you interested in extending ALTER OPERATOR to allow this, > > which would also allow fixing the ltree operator? > > > > Yes, I can

Re: Commitfest: older Waiting on Author entries

2023-11-08 Thread Tommy Pavlicek
On Tue, Nov 7, 2023 at 8:28 AM John Naylor wrote: > > The following entries are WoA but have not had an email update since > July. If there is no actionable update soon, I plan to mark these > Returned with Feedback before end of CF: > > ltree hash functions I should be able to update this with a

Re: [PATCH] Extend ALTER OPERATOR to support adding commutator, negator, hashes, and merges

2023-10-31 Thread Tommy Pavlicek
Tom. On Tue, Oct 24, 2023 at 2:51 PM Christoph Berg wrote: > > Re: Tommy Pavlicek > > I've added another patch (0002-require_unused_neg_com-v1.patch) that > > prevents using a commutator or negator that's already part of a pair. > > Hmm. I agree with the general ide

Re: [PATCH] Extend ALTER OPERATOR to support adding commutator, negator, hashes, and merges

2023-10-11 Thread Tommy Pavlicek
On Tue, Oct 10, 2023 at 9:32 PM Tom Lane wrote: > > Tommy Pavlicek writes: > > I did notice one further potential bug. When creating an operator and > > adding a commutator, PostgreSQL only links the commutator back to the > > operator if the commutator has no commut

Re: [PATCH] Extend ALTER OPERATOR to support adding commutator, negator, hashes, and merges

2023-10-10 Thread Tommy Pavlicek
On Thu, Sep 28, 2023 at 9:18 PM Tom Lane wrote: > > Tommy Pavlicek writes: > > I've attached a new version of the ALTER OPERATOR patch that allows > > no-ops. It should be ready to review now. > > I got around to looking through this finally (sorry about the delay

Re: [PATCH] Extend ALTER OPERATOR to support adding commutator, negator, hashes, and merges

2023-07-02 Thread Tommy Pavlicek
On Fri, Jun 23, 2023 at 12:21 PM Tom Lane wrote: > > Tommy Pavlicek writes: > > I've added a single patch here: https://commitfest.postgresql.org/43/4389/ > > > It wasn't obvious whether I should create a second commitfest entry > > because I've inclu

Re: [PATCH] Extend ALTER OPERATOR to support adding commutator, negator, hashes, and merges

2023-06-23 Thread Tommy Pavlicek
Tom Lane writes: > Please add this to the upcoming commitfest [1], to ensure we don't > lose track of it. I've added a single patch here: https://commitfest.postgresql.org/43/4389/ It wasn't obvious whether I should create a second commitfest entry because I've included 2 patches so I've just d

[PATCH] Extend ALTER OPERATOR to support adding commutator, negator, hashes, and merges

2023-06-22 Thread Tommy Pavlicek
Hi All, I've attached a couple of patches to allow ALTER OPERATOR to add commutators, negators, hashes and merges to operators that lack them. The need for this arose adding hash functions to the ltree type after the operator had been created without hash support[1]. There are potential issues wi

Re: [PATCH] ltree hash functions

2023-06-19 Thread Tommy Pavlicek
> > FWIW the CREATE OPERATOR documentation only talks about hash joins for HASHES, maybe it should be updated to also mention hash aggregates? I think I might have been a bit unclear here, the hash aggregate does work without altering the operator so it's just the join that's blocked. Sorry abou

[PATCH] ltree hash functions

2023-06-17 Thread Tommy Pavlicek
Hi All, I've written a patch to add hash functions for the ltree extension. It adds support for hash indexes and hash aggregation. I've reused the existing logic that's used to hash arrays and added tests that mirror elsewhere (i.e. hstore and hash_func regression tests). The patch doesn't curren