On 24.04.25 12:53, Christoph Berg wrote:
Now you can say `psql -h db.example.com -p 5433 dbfoo`, but for
specifying the sslmode, you have to rewrite at least the last argument
to use connection string syntax, `psql "dbname=dbfoo sslmode=verify-full`.
This needs be be less cumbersome. (And the nam
On 24.04.25 13:16, Jelte Fennema-Nio wrote:
On Thu, 24 Apr 2025 at 10:54, Peter Eisentraut wrote:
The cut-off in practice for these things is usually RHEL. PG18
currently still supports RHEL 7, which appears to come with Python 3.6.
Seeing that the small problem with the test script was
On 23.04.25 00:24, Tomas Vondra wrote:
The patch that flips the default has been committed.
I also started a PG18 open items page and made a note that we follow up
on the upgrade experience, as was discussed in this thread.
https://wiki.postgresql.org/wiki/PostgreSQL_18_Open_Items
Regarding t
On 22.04.25 18:04, Tom Lane wrote:
Jacob Champion writes:
As for picking a version... 3.6 will have been EOL for almost three
years by the time 18 releases. It seems like we would drop it happily,
were it not for RHEL8.
Agreed, but RHEL8 is out there and I don't think we can just drop
support
On 10.04.25 01:08, Jacob Champion wrote:
Christoph noted that this was also confusing from the packaging side,
earlier, and Daniel proposed -Doauth-client/--with-oauth-client as the
feature switch name instead. Any objections? Unfortunately it would
mean a buildfarm email is in order, so we shoul
On 08.04.25 19:44, Jacob Champion wrote:
Would anybody following along be opposed to a situation where
- dynamiclib builds go through the dlopen() shim
- staticlib builds always rely on statically linked symbols
If this can be implemented in a straightforward way, that would be the
best way, I
I would like for someone else to prepare the list of acknowledgments in
the release notes this year.
I have been preparing the list of acknowledgments in the release notes
(example: [0]) since PostgreSQL 10 (launched from discussions at PGCon
2017 [1]). I'm looking to hand this off now, so that
On 09.04.25 12:02, Peter Eisentraut wrote:
I ran src/tools/mark_pgdllimport.pl and it detected a few new global
variables with missing markings. See attached patch. Please point out
if any of these should not be marked or if they are special cases in
some other way. I'm Cc'i
On 10.04.25 05:51, David Rowley wrote:
Looks like v18 has grown a few appendStringInfo misusages, e.g. using
appendStringInfo() when no formatting is needed or just using format
"%s" instead of using appendStringInfoString().
Would it be useful to augment appendStringInfo() something like this:
On 09.04.25 16:23, Tom Lane wrote:
Heikki Linnakangas writes:
Inconsistency is not good either though. I'm not sure it's worth the
churn, but I could get on board a patch to actually replace all
HeapTupleIsValid(tuple) calls with plain "tuple != NULL" checks. Keep
HeapTupleIsValid() just for co
On 09.04.25 14:26, Heikki Linnakangas wrote:
It's a matter of taste, but personally I find 'if (tuple != NULL)' more
clear than 'if (HeapTupleIsValid(tuple))'. The presence of a macro
suggests that there might be other kinds of invalid tuples than a NULL
pointer, which just adds mental load.
Btw., this new variable in memutils.h
extern dsa_area *area;
could probably do with a less generic name?
From e9d868a38b50c1fa449258926c40cef88bd73045 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 9 Apr 2025 11:55:48 +0200
Subject: [PATCH] WIP: Add missing PGDLLIMPORT markings
an't
backpatch this because of the ABI change, so once PG18 ships the window
is over.
For the -bundle -> -dynamiclib change, I don't have any particular
urgency right now.
From 57de7451676506f79a99681338efcb0a1f956c3c Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: We
On 14.09.24 21:14, Tom Lane wrote:
+Section: Class 10 - XQuery Error
+
+# recent SQL versions define quite a few codes in this class, but for now
+# we are only using this generic one
+10608EERRCODE_INVALID_ARGUMENT_FOR_XQUERY
invalid_argument_for_xquery
Coul
On 08.04.25 14:22, Junwang Zhao wrote:
When I read the libpq source code, I found unnecessary static type qualifiers
in PQsetClientEncoding().
diff --git a/src/interfaces/libpq/fe-connect.c
b/src/interfaces/libpq/fe-connect.c
index 0258d9ace3c..300ddfffd55 100644
--- a/src/interfaces/libpq/fe-c
On 08.04.25 16:59, Bruce Momjian wrote:
On Tue, Apr 8, 2025 at 10:36:45AM -0400, Bruce Momjian wrote:
Since we recorded feature freeze as April 8, 2025 0:00 AoE (anywhere on
Earth):
https://wiki.postgresql.org/wiki/PostgreSQL_18_Open_Items#Important_Dates
https://www.timeandda
On 07.04.25 16:43, Andres Freund wrote:
While I was looking into this I found that Debian's going to use the
existence of an SONAME to check other things, which I assume will make
Christoph's life harder. I have switched over to
'libpq-oauth-.so', without any SONAME or symlinks.
Yes, this is cor
On 05.04.25 02:27, Jacob Champion wrote:
On Tue, Apr 1, 2025 at 3:40 PM Jacob Champion
wrote:
Maybe a better idea would be to ship an SONAME of
`libpq-oauth.so.0.`, without any symlinks, so that there's
never any ambiguity about which module belongs with which libpq.
While I was looking into
On 28.03.25 09:13, Peter Eisentraut wrote:
About patch 0003:
I had previously pointed out that the canonicalization might have
been intentional, and that we have canonicalization of ICU locale
names. But we don't have to keep the setlocale()-based locale
checking implementation just for
ation
for what you can implement yourself in your extension's makefile.
From d08218d36d4590f80c2d46f3d7c30bee3e35b7e2 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Thu, 20 Mar 2025 14:00:18 +0100
Subject: [PATCH v0] WIP: Support "make check" for PGXS extensions
---
s
I have committed these four patches (squashed into three). I made the
error handling change in 0003 that you requested, and also the error
handling change in 0002 discussed in an adjacent message.
On 12.03.25 16:52, Mark Dilger wrote:
On Wed, Mar 12, 2025 at 7:00 AM Peter Eisentraut
On 24.03.25 10:24, Jakub Wartak wrote:
On Fri, Mar 14, 2025 at 11:31 AM vignesh C wrote:
On Wed, 5 Mar 2025 at 11:46, Amit Kapila wrote:
On Tue, Mar 4, 2025 at 4:44 PM Jakub Wartak
I can go with the last patch as you observed that in a real-world
case, and we can look at others (if any) on
On 12.03.25 17:08, Mark Dilger wrote:
On Wed, Mar 12, 2025 at 7:25 AM Tom Lane <mailto:t...@sss.pgh.pa.us>> wrote:
Peter Eisentraut mailto:pe...@eisentraut.org>> writes:
> 0002: Add get_opfamily_member_for_cmptype(). This was called
> get_opmethod_membe
On 04.04.25 14:17, Andres Freund wrote:
skink/valgrind just started to die during the main regression tests:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2025-04-04%2011%3A01%3A56
Thanks, fix is on the way.
The set of commits seem to point to the changes made as part of th
On 31.03.25 15:52, Tom Lane wrote:
Peter Eisentraut writes:
I'm not sure what to do with this. If setlocale() and newlocale()
indeed behave differently in what set of locale names they accept, then
technically we ought to test both of them, since we do use both of them
later on. Or may
On 17.03.25 19:54, Jeff Davis wrote:
On Thu, 2025-03-13 at 14:49 +0100, Peter Eisentraut wrote:
I think these test result changes are incorrect. AFAICT, nothing has
changed in the upstream data that would explain such a change.
I didn't get such test differences in my original patch. Di
On 03.04.25 10:07, Alvaro Herrera wrote:
The new flag is there for quick access by get_relation_info. We could
easily not have it otherwise, because clients don't need it, but its
lack would probably make planning measurably slower because it'd have to
do syscache access for every single not-nul
nch right now is that we should probably take the patch that sets
the version option and consider it for backpatching. The patch with the
tests can be held for detailed review later.
From c1e85711e1b0c7efcd1fa55cc46db959e12d6cfb Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Thu, 3 Apr 202
It occurred to me that we will also want to have NOT NULL NOT ENFORCED
constraints eventually. As we have discussed elsewhere, the NOT
ENFORCED state is closely related to the NOT VALID state. So that
should probably be considered in the design here.
Reading up on this again now, I'm confuse
On 11.03.25 11:42, Peter Eisentraut wrote:
Here is an updated patch that works more along those lines. It adds a
pg_upgrade option --update-checksums, which activates the code to
rewrite the checksums. You must specify this option if the source and
target clusters have different checksum
On 28.03.25 14:27, Amul Sul wrote:
On Fri, Mar 28, 2025 at 3:34 PM Ashutosh Bapat
wrote:
On Thu, Mar 27, 2025 at 6:25 PM Amul Sul wrote:
I am not sure how to make such tests stable enough since the trigger
name involves OIDs. In count check, I tried adjusting the join
condition to ensure t
ritten away from that it's a
glibc-specific extension.
From e12c5d224a195b893f79c470bc4f21de1585c808 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Tue, 1 Apr 2025 19:00:39 +0200
Subject: [PATCH] WIP: Fix AC_CHECK_DECLS equivalent in meson
---
meson.build | 19
On 31.03.25 08:28, Kyotaro Horiguchi wrote:
If you're already aware of this and have taken it into account, please
feel free to ignore this.
As described in the recent commit a0ed19e0a9e, many %ll? format
specifiers are being replaced with %.
I hadn’t paid much attention to this before, but I h
On 20.03.25 12:59, Peter Eisentraut wrote:
v22-0006-Convert-from-StrategyNumber-to-CompareType.patch
This is all that remains now. I think with a bit more polishing around
the edges, some comment updates, etc., this is close to ready.
Here is an updated version of this patch. I have left
On 10.03.25 10:49, Peter Eisentraut wrote:
On 02.03.25 22:08, Thomas Munro wrote:
On Mon, Mar 3, 2025 at 6:21 AM Peter Eisentraut
wrote:
On 05.12.24 23:18, Thomas Munro wrote:
Old: errmsg("hello %llu", (unsigned long long) x)
New: errmsg("hello %" PRIu64, x
On 28.03.25 17:32, Peter Eisentraut wrote:
On 28.03.25 17:14, Masahiko Sawada wrote:
On Fri, Mar 28, 2025 at 8:30 AM Peter Eisentraut
wrote:
On 09.02.25 08:32, Peter Eisentraut wrote:
Checking the status of this thread ...
The patches that removed the configure checks for
On 28.03.25 17:14, Masahiko Sawada wrote:
On Fri, Mar 28, 2025 at 8:30 AM Peter Eisentraut wrote:
On 09.02.25 08:32, Peter Eisentraut wrote:
Checking the status of this thread ...
The patches that removed the configure checks for _configthreadlocale(),
and related cleanup, have been
On 09.02.25 08:32, Peter Eisentraut wrote:
Checking the status of this thread ...
The patches that removed the configure checks for _configthreadlocale(),
and related cleanup, have been committed.
The original patch to "Tidy up locale thread safety in ECPG library" is
still o
On 24.03.25 04:26, jian he wrote:
rebase, and some minor code comments change.
I have committed this.
I did a bit more editing on the naming of various things. In terms of
functionality, in ExecConstraints() notnull_virtual_attrs and
virtual_notnull_check were redundant, so I simplified tha
On 02.03.25 22:08, Thomas Munro wrote:
And one more thing like that: in a couple of places we see warnings on
macOS CI that I'd missed: when printing the result of i64abs() as
PRId64, because it happens to use labs() and it happens to define
int64_t as long long, [...]. I
suppose we should cast
On 27.03.25 11:16, Peter Eisentraut wrote:
Patch 0002 also looks okay, except that the error handling could be
unified with existing code, as I had previously pointed out. Patch
0005 fixes that.
I plan to commit this one next, after the above had a bit of time to stew.
also done
About
On 20.03.25 18:20, David E. Wheeler wrote:
On Mar 20, 2025, at 09:06, Peter Eisentraut wrote:
This is a quick follow-up to the extension_control_path patch. With this little
additional patch, you can now run "make check" in PGXS-using extensions
(instead of having to do make ins
On 14.02.25 15:13, Peter Eisentraut wrote:
On 09.02.25 15:52, Peter Eisentraut wrote:
This patch set is still desirable. Here is a rebased version of the
v5 patches. I haven't applied any corrections or review comments.
Here is the same patch set with some review comments.
Patch 0001
On 24.03.25 21:33, Matheus Alcantara wrote:
I'm a bit confused about the refactoring patch 0001. There are some
details there that don't seem right. For example, you write that the
pfree(rconn) calls are no longer necessary, but AFAICT, it would still
be needed in dblink_get_conn(). Also, ther
On 25.03.25 17:02, Álvaro Herrera wrote:
With commit f4e53e10b6ce we introduced a way to flip the NO INHERIT bit
on not-null constraints. However, because of the way the grammar
dealt with ALTER CONSTRAINT, we were too blind to see a way to implement
it using the existing production. It turns o
On 24.03.25 11:45, Vincent Moreau wrote:
I came across date information from an external data source where the
month number is zero-based (January = 0, December = 11) and found that
I couldn't process it directly using the TO_DATE function.
This patch introduces a new pattern (MZ) for handling ze
On 23.03.25 04:05, Andrew Jackson wrote:
> This is the first complaint I can recall hearing about that, so
exactly which ones are "many"?
I've tested a 2 before figuring out about the v3 issue. lldap[0] and the
docker image osixia/docker-openldap[1].
- lldap gives the following error message
On 21.03.25 06:58, Amul Sul wrote:
I think the next step here is that you work to fix Álvaro's concerns
about the recursion structure.
Yes, I worked on that in the attached version. I refactored
ATExecAlterConstraintInternal() and moved the code that updates the
pg_constraint entry into a separ
On 25.03.25 12:52, Alvaro Herrera wrote:
Hello
On 2025-Mar-25, Peter Eisentraut wrote:
A patch in the NOT ENFORCED constraints patch series proposes to refactor
some of the code added by this patch series ([0] patch v18-0001). I noticed
that the code paths from this patch series do not call
On 05.03.25 13:56, Alvaro Herrera wrote:
On 2025-Mar-03, Suraj Kharage wrote:
Thanks Alvaro for the review and fixup patch.
I agree with your changes and merged that into the main patch along with a
couple of other changes.
Please find attached v6 for further review.
Thanks, I have pushed t
On 21.03.25 19:24, Matheus Alcantara wrote:
On Fri, Mar 21, 2025 at 1:28 PM Jacob Champion
wrote:
Great, thank you! Looking over v10, I think I've run out of feedback
at this point. Marked Ready for Committer.
Thanks for all the effort reviewing this patch!
I have committed the 0003 patch
On 22.03.25 12:15, Jelte Fennema-Nio wrote:
On Fri, 21 Mar 2025 at 18:53, Tom Lane wrote:
Peter Eisentraut writes:
- If I'm the committer for a patch but not a reviewer, and the patch is
in "needs review" status, then the patch is formally speaking not
actionable by me an
On 17.03.25 23:11, Jelte Fennema-Nio wrote:
1. Major change: There's a new /me page which shows a dashboard of
open patches where you are author/reviewer/committer. These patches
are ordered & grouped in a hopefully useful way. Peter Geoghegan
suggested adding a "dashboard" of this kind. It's the
On 15.03.25 07:54, Jeremy Schneider wrote:
in favor of leaving it alone because ICU is there for when I need
up-to-date unicode versions.
From my perspective, the whole point of the builtin collation was to
one option that avoids these problems that come with updating both ICU
and glibc.
So I
On 18.03.25 21:18, Andres Freund wrote:
On 2025-03-13 09:37:37 +0100, Francesco Canovai wrote:
In this scenario, `tcp_user_timeout` could close a connection retrying
the SYNs (even though it doesn't seem to do it from the documentation,
it works) the parameter will affect the entire connection.
On 07.03.25 10:01, Peter Eisentraut wrote:
Since lapwing no longer runs with -Werror, and might be gone completely
soon, we no longer need the various workarounds gathered over time to
avoid compiler warnings there. The attached patch reverts various
patches and makes similar adjustments to
This patch set has expanded significantly in scope recently, which is
probably the right thing, but that means there won't be enough time to
review and finish it for PG18. So I'm moving this to the next
commitfest now.
On 13.03.25 15:02, Alexandra Wang wrote:
Hi Mark,
Thank you so much for
On 19.03.25 20:25, Matheus Alcantara wrote:
On Wed, Mar 19, 2025 at 3:56 PM Tom Lane wrote:
Peter Eisentraut writes:
Committed that, thanks.
Buildfarm member snakefly doesn't like this too much. Since no other
animals have failed, I guess it must be about local conditions on
that ma
On 21.02.25 20:39, Masahiko Sawada wrote:
I have one question about the 0001 patch; since we add
'default_char_signedness' field to ControlFileData do we need to bump
PG_CONTROL_VERSION? We have comments about bumping PG_CONTROL_VERSION
when changing CheckPoint struct or DBState enum so it seems
On 12.03.25 14:17, Matheus Alcantara wrote:
There should be a simpler way into this. Maybe
pg_available_extensions() should fill out the ExtensionControlFile
structure itself, set ->control_dir with where it found it, then call
directly to parse_extension_control_file(), and that should skip the
On 18.03.25 17:53, Jacob Champion wrote:
On Tue, Mar 18, 2025 at 9:35 AM Peter Eisentraut wrote:
So the way I understand this is that the options are:
(1) We add a libpq function like PQconnectionUsedScramKeys() in the
style of PQconnectionUsedPassword() and call that function during the
On 17.03.25 17:49, Jacob Champion wrote:
If we implement this, it needs to check that the keys were actually
sent during scram_exchange(). Having them set on the PGconn doesn't
mean that we used them for authentication.
We use the client key and server key on calculate_client_proof and
verify_s
On 15.03.25 03:42, Thomas Munro wrote:
- I don't think it's proper to assume that pgoff_t or off_t matches int64_t.
So we should make pgoff_t a typedef for int64_t everywhere. It's a
bit annoying that we have to teach everyone to remember to use PRId64
to print it, though.
The ramifications
On 10.03.25 14:58, Andres Freund wrote:
diff --git a/src/backend/utils/mmgr/slab.c b/src/backend/utils/mmgr/slab.c
index ec8eddad863..d32c0d318fb 100644
--- a/src/backend/utils/mmgr/slab.c
+++ b/src/backend/utils/mmgr/slab.c
@@ -601,8 +601,8 @@ SlabAllocFromNewBlock(MemoryContext context, Size si
On 13.03.25 19:31, Tom Lane wrote:
Jacob Champion writes:
Adding the PG prefix to the envvar name addresses my collision
concern, but I think Tom's comment upthread [1] was saying that we
should not provide any envvar at all:
I think it might be safer if we only accepted it as a connection
p
On 05.03.25 17:40, Peter Eisentraut wrote:
On 03.03.25 11:17, Peter Eisentraut wrote:
Update for the hackers list: This patch set was briefly committed but
had to be reverted because it crashed on some older Python versions;
see [0].
I have locally reproduced the problem with Python 3.6 and
On 13.03.25 13:43, Peter Eisentraut wrote:
I committed the first two patches (squashed together) (about
pg_noreturn). I had to make one change: I put back the GCC fallback
that I had removed between v1 and v2. This is needed for GCC versions
before C11 became the default (gcc 5) and also for
On 17.02.25 20:46, Jeff Davis wrote:
Note that the Unicode update has a few test diffs for NORMALIZE(),
please check to see if the tests themselves need an update.
I think these test result changes are incorrect. AFAICT, nothing has
changed in the upstream data that would explain such a chang
I committed the first two patches (squashed together) (about
pg_noreturn). I had to make one change: I put back the GCC fallback
that I had removed between v1 and v2. This is needed for GCC versions
before C11 became the default (gcc 5) and also for situations like
buildfarm member mylodon th
to compare types (which was in
v21-0006 or so) with the removal of the btree requirements.
From bca4cfd1b8837ced9b74a04267861cac8003fbc6 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 12 Mar 2025 13:45:39 +0100
Subject: [PATCH v21.2 1/4] Add get_opfamily_method()
---
src/backend/u
umbers
to pass information about the sort direction. We can do this simpler by
just passing a bool. See attached patch.From f1855169b20ecfa12016c89abac52913cedf6688 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 12 Mar 2025 11:02:33 +0100
Subject: [PATCH v21.1] Simplify
On 02.03.25 22:08, Thomas Munro wrote:
On Mon, Mar 3, 2025 at 6:21 AM Peter Eisentraut wrote:
On 05.12.24 23:18, Thomas Munro wrote:
Old: errmsg("hello %llu", (unsigned long long) x)
New: errmsg("hello %" PRIu64, x)
I have committed the subset of this patch f
I have committed the first three refactoring patches (v16-0001,
v16-0002, v16-0003). (I guess Álvaro didn't like the first one, so I
suppose I'll revert that one, but it's a simple one, so you can proceed
either way.)
I think the next step here is that you work to fix Álvaro's concerns
about
On 26.02.25 06:15, Paul Jungwirth wrote:
> ON DELETE RESTRICT must be specified when PERIOD BUSINESS_TIME is
also specified.
Here are some patches removing support for RESTRICT
I have committed this.
I think this is about as much as we can hope to get done from this patch
series for PG18.
On 10.03.25 21:25, Matheus Alcantara wrote:
On Thu, Mar 6, 2025 at 10:46 AM Peter Eisentraut wrote:
This looks very good to me. I have one issue to point out: The logic
in get_extension_control_directories() needs to be a little bit more
careful to align with the rules in find_in_path
On 31.01.25 10:32, Laurenz Albe wrote:
I'll set this patch to "ready for committer".
This is about the color of the bikeshed, and several people
have voiced their opinion. I don't think much more review
is needed. All that is needed is a committer who either
commits or rejects it.
I don't thi
On 21.02.25 00:41, Robert Treat wrote:
On Tue, Aug 27, 2024 at 5:57 PM Nathan Bossart wrote:
On Mon, Aug 26, 2024 at 08:23:44AM +0200, Peter Eisentraut wrote:
The purpose of this patch is to allow using pg_upgrade between clusters that
have different checksum settings. When upgrading
On 13.02.25 16:34, Peter Eisentraut wrote:
On 22.01.25 19:16, Peter Eisentraut wrote:
On 06.01.25 15:52, Peter Eisentraut wrote:
On 03.01.25 21:51, Dagfinn Ilmari Mannsåker wrote:
Peter Eisentraut writes:
I suggest we define pg_noreturn as
1. If C11 is supported, then _Noreturn, else
2
On 06.03.25 22:58, Jacob Champion wrote:
On Thu, Mar 6, 2025 at 12:33 PM Peter Eisentraut wrote:
AFAICT, in pgfdw_security_check(), if SCRAM has been used for the
outgoing server connection, then PQconnectionUsedPassword() is true, and
then this check should fail if no "password" par
On 07.03.25 04:51, Amit Kapila wrote:
I agree that the originally proposed name max_replication_origins is not
good, because you can "create" (using pg_replication_origin_create())
more than the configured maximum. What is the term for what the setting
actually controls? How many are "active"?
On 06.03.25 21:23, Robert Haas wrote:
On Wed, Mar 5, 2025 at 4:38 PM Tom Lane wrote:
v4 has addressed most of my nitpicks, but you still have typedefs
for ExplainState in both header files. My bet is that at least
one buildfarm animal will complain about that. I could be wrong
though, maybe a
35c8adb8ba0aefe3a8ad375196da510f5a2a72bd Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Fri, 7 Mar 2025 07:36:41 +0100
Subject: [PATCH] Revert workarounds for -Wmissing-braces false positives on
old GCC
We have collected several instances of a workaround for GCC bug 53119,
which caused false-positive compiler
On 06.03.25 22:54, Melanie Plageman wrote:
One thing I've been wishing for recently is access to the discussion
and lore around individual buildfarm animals in a consolidated place.
As a new committer, I haven't been part of all of these discussions
over the last N years and so if an animal goes
On 04.03.25 21:37, Jelte Fennema-Nio wrote:
1. This new homepage includes open patches from*all* commitfests. And
there's currently no page with that information.
Ok, that's interesting, but I'm even less sure why that should be the
default view. The whole point of chunking things into commit
On 11.02.25 00:19, Jacob Champion wrote:
These don't seem right to me. SCRAM passthrough should be considered
as_part_ of the connstr/security checks, but I think it should not
_bypass_ those checks. We have to enforce the use of the SCRAM
credentials on the remote for safety, similarly to GSS de
On 06.03.25 11:55, Shay Rojansky wrote:
For whatever it's worth, I'll note that SQL Server's OPENJSON does do
this (so when a JSON string property is extracted as a binary type,
base64 encoding is assumed). Other databases also have very specific
documented conversion rules for JSON_VALUE RETUR
that suggests to use the
newer foreach_ptr() macro in some places.From 35c2106558095e74359cec58b9631fa19ed937b3 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Thu, 6 Mar 2025 14:28:08 +0100
Subject: [PATCH] Use foreach_ptr
---
src/backend/commands/extension.c | 20 ++--
1
On 03.03.25 11:17, Peter Eisentraut wrote:
Update for the hackers list: This patch set was briefly committed but
had to be reverted because it crashed on some older Python versions; see
[0].
I have locally reproduced the problem with Python 3.6 and 3.7; Python
3.8 is ok. This matches the
On 11.02.25 21:25, Euler Taveira wrote:
Here is another patch that only changes the GUC name to
max_replication_origin_sessions.
I think the naming and description of this is still confusing.
What does this name mean? There is (I think) no such thing as a
"replication origin session". So wh
On 10.12.24 03:02, Thomas Munro wrote:
On Thu, Dec 5, 2024 at 12:16 PM Tom Lane wrote:
Now you already snuck the camel's nose under the
tent by including stdint.h there, and maybe these additional headers
wouldn't do any further damage.
Even though we fixed the immediate issue (thanks), this
On 04.03.25 11:33, Jelte Fennema-Nio wrote:
I'm curious if there was anything specific that you used the old
homepage for. Especially things you did often that are now harder to
do. The only things I used on the homepage were:
1. Going to the "In Progress" and "Open" commitfest (usually with one
On 04.03.25 02:21, Jelte Fennema-Nio wrote:
6. The "latest email" column now shows "time since" (e.g. 1 week ago)
instead of an exact timestamp. You can still see the exact timestamp
by hovering over the cell.
Another small complaint: I don't like this style of relative times. (I
have also co
On 04.03.25 02:21, Jelte Fennema-Nio wrote:
1. Major change: The homepage is revamped completely! It now shows a
dashboard of open patches where you are author/reviewer/committer if
you are logged in. These patches are ordered & grouped in a hopefully
useful way. If you're not logged in it will s
On 02.03.25 22:08, Thomas Munro wrote:
And one more thing like that: in a couple of places we see warnings on
macOS CI that I'd missed: when printing the result of i64abs() as
PRId64, because it happens to use labs() and it happens to define
int64_t as long long, and when printing a Datum as PRIx
On 03.03.25 06:05, Jacob Brazeal wrote:
Hi all,
It looks like commit 630f9a43cece93cb4a5c243b30e34abce6a89514 omitted an
equals sign in an ereport() in GetOperatorFromCompareType, giving the line:
cmptype = COMPARE_EQ ? errmsg("could not identify an equality operator
for type %s", format_typ
On 28.02.25 14:36, Srinath Reddy wrote:
Hi,
I have applied the patch and verified,and patch LGTM.
committed, thanks
On 15.01.25 23:20, Peter Eisentraut wrote:
On 15.01.25 12:28, Jakob Egger wrote:
On 14.01.2025, at 16:51, Jakob Egger wrote:
I've tried to create a patch with this change. I'm attaching it to
this message so that cfbot picks it up. (I was unable to reproduce
the issue locally)
On 26.02.25 06:15, Paul Jungwirth wrote:
I agree with that last principle: it shouldn't matter how the primary
keys are split up. But it seems to me that "matches" in the standard
should include the period. It does for NO ACTION, so why not RESTRICT?
That's why your example of expanding the ref
On 05.12.24 23:18, Thomas Munro wrote:
Having learned some things about gettext based on clues[1] from Peter
E, I decided to see what it would take to expunge all (long long) and
similar casts now that we're using the standard types with system
support.
The short version is tha given uint64 x:
On 18.02.25 09:34, Jelte Fennema-Nio wrote:
On Thu, 27 Jun 2024 at 12:43, Jelte Fennema-Nio wrote:
Attached is a rebased patchset of my previous proposal, including a
few changes that Michael preferred:
Rebased again. (got notified because of the new commitfest rebase emails)
The first patch
1 - 100 of 2166 matches
Mail list logo
