Inconsistent string comparison using modified ICU collations

2025-01-22 Thread Oleg Tselebrovskiy
U Jira[1] where I have reproduced this behaviour using minimal C code To compose the collation name I have read and used an article by Peter Eisentraut on ICU collation settings[2] Unfortunately, I don't have any proposed solution for this issue, but I thought it was important to

pg_dump memory leak of 400 bytes

2024-12-11 Thread Oleg Tselebrovskiy
atches for both variants are attached. I also propose changing palloc to pg_malloc since it is the only place in pg_dump where palloc is used instead of pg_malloc Oleg Tselebrovskiy, Postgres Prodiff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c index ec0cdf4ed74..9a24ebfca24 10064

Re: Why is citext/regress failing on hamerkop?

2024-08-01 Thread Oleg Tselebrovskiy
.org/message-id/6885a0b52d06f7e5910d2b6276bbb4e8%40postgrespro.ru Oleg Tselebrovskiy, Postgres ProThe files belonging to this database system will be owned by user "GitLabRunner". This user must also own the server process. The database cluster will be initialized with locale "English_United

Re: [PROPOSAL] Skip test citext_utf8 on Windows

2024-03-11 Thread Oleg Tselebrovskiy
Michael Paquier писал(а) 2024-03-12 06:24: On Mon, Mar 11, 2024 at 03:21:11PM +0700, Oleg Tselebrovskiy wrote: The proposed patch for skipping test is attached Your attached patch seems to be in binary format. -- Michael Right, I had it saved in not-UTF-8 encoding. Kind of ironic Here

[PROPOSAL] Skip test citext_utf8 on Windows

2024-03-11 Thread Oleg Tselebrovskiy
4-windows, compiled by gcc-13.1.0, 64-bit The proposed patch for skipping test is attached Oleg Tselebrovskiy, Postgres Proÿþdiff --git a/contrib/citext/expected/citext_utf8.out b/contrib/citext/expected/citext_

BRIN integer overflow

2024-02-20 Thread Oleg Tselebrovskiy
ttached [1] - https://svace.pages.ispras.ru/svace-website/en/ Oleg Tselebrovskiy, Postgres Prodiff --git a/src/backend/access/brin/brin.c b/src/backend/access/brin/brin.c index 1087a9011ea..f72667e484e 100644 --- a/src/backend/access/brin/brin.c +++ b/src/backend/access/brin/brin.c @@ -559,7 +559,7 @@ bringet

Re: Returning non-terminated string in ECPG Informix-compatible function

2024-02-15 Thread Oleg Tselebrovskiy
Thanks for review! I added a regression test that is based on code from previous email New patch is attached Oleg Tselebrovskiy, Postgres Prodiff --git a/src/interfaces/ecpg/compatlib/informix.c b/src/interfaces/ecpg/compatlib/informix.c index dccf39582da..80d40aa3e09 100644 --- a/src

xmlBufferCreate return value not checked in pgxmlNodeSetToText

2024-02-14 Thread Oleg Tselebrovskiy
the return value inside. I suggest to add the same checks here that are used in other four calls of xmlBufferCreate. The proposed patch is attached. [1] - https://svace.pages.ispras.ru/svace-website/en/ Oleg Tselebrovskiy, Postgres Prodiff --git a/contrib/xml2/xpath.c b/contrib/xml2/xpa

Re: Returning non-terminated string in ECPG Informix-compatible function

2024-02-14 Thread Oleg Tselebrovskiy
could lead to segfault. I suggest adding a check for a return value since all other calls of pgtypes_alloc are checked for NULL. A proposed patch (with previous and current changes) is attached Oleg Tselebrovskiy, Postgres Prodiff --git a/src/interfaces/ecpg/compatlib/informix.c b/src/inter

Re: Returning non-terminated string in ECPG Informix-compatible function

2024-01-30 Thread Oleg Tselebrovskiy
ect that uses intoasc() in it - https://github.com/credativ/informix_fdw/ Oleg Tselebrovskiy, Postgres Pro