Thomas Munro wrote 2024-05-12 06:31:
Hamerkop is already green on the 15 and 16 branches, apparently because it's using the pre-meson test stuff that I guess just didn't run the relevant test. In other words, nobody would notice the difference anyway, and a master-only fix would be enough to end this 44-day red streak.
Sorry for necroposting, but in our automated testing system we have found some fails of this test. The most recent one was a couple of days ago (see attached files) on PostgreSQL 15.7. Also I've reported this bug some time ago [1], but provided an example only for PostgreSQL 17. Back then the bug was actually found on 15 or 16 branches (no logs remain from couple of months back), but i wanted to show that it was reproducible on 17. I would appreciate if you would backpatch this change to 15 and 16 branches.[1] https://www.postgresql.org/message-id/6885a0b52d06f7e5910d2b6276bbb4e8%40postgrespro.ru
Oleg Tselebrovskiy, Postgres Pro
The files belonging to this database system will be owned by user "GitLabRunner". This user must also own the server process. The database cluster will be initialized with locale "English_United States.1252". The default text search configuration will be set to "english". Data page checksums are disabled. fixing permissions on existing directory C:/gr-builds/TaKFe3FF/2/pgpro-dev/postgrespro/ci_base ... ok creating subdirectories ... ok selecting dynamic shared memory implementation ... windows selecting default max_connections ... 100 selecting default shared_buffers ... 128MB selecting default time zone ... Europe/Moscow creating configuration files ... ok running bootstrap script ... ok performing post-bootstrap initialization ... ok syncing data to disk ... ok initdb: warning: enabling "trust" authentication for local connections initdb: hint: You can change this by editing pg_hba.conf or using the option -A, or --auth-local and --auth-host, the next time you run initdb. Success. You can now start the database server using: pg_ctl -D ^"C^:^\gr^-builds^\TaKFe3FF^\2^\pgpro^-dev^\postgrespro^\ci^_base^" -l logfile start
2024-07-29 14:41:21.649 MSK [14344] LOG: starting PostgreSQL 15.7, compiled by Visual C++ build 1929, 64-bit 2024-07-29 14:41:21.653 MSK [14344] LOG: listening on IPv6 address "::1", port 5432 2024-07-29 14:41:21.653 MSK [14344] LOG: listening on IPv4 address "127.0.0.1", port 5432 2024-07-29 14:41:21.697 MSK [8052] LOG: database system was shut down at 2024-07-29 14:41:17 MSK 2024-07-29 14:41:21.735 MSK [14344] LOG: database system is ready to accept connections 2024-07-29 14:41:22.859 MSK [9348] ERROR: tablespace location must be an absolute path 2024-07-29 14:41:22.859 MSK [9348] STATEMENT: CREATE TABLESPACE regress_tblspace LOCATION 'relative';
diff -w -U3 C:/gr-builds/TaKFe3FF/2/pgpro-dev/postgrespro/contrib/citext/expected/citext_utf8.out C:/gr-builds/TaKFe3FF/2/pgpro-dev/postgrespro/contrib/citext/results/citext_utf8.out --- C:/gr-builds/TaKFe3FF/2/pgpro-dev/postgrespro/contrib/citext/expected/citext_utf8.out 2024-07-29 13:53:45.259126600 +0300 +++ C:/gr-builds/TaKFe3FF/2/pgpro-dev/postgrespro/contrib/citext/results/citext_utf8.out 2024-07-29 14:43:38.772857200 +0300 @@ -54,7 +54,7 @@ SELECT 'i'::citext = 'Ä°'::citext AS t; t --- - t + f (1 row) -- Regression.