Re: pg_dump new feature: exporting functions only. Bad or good idea ?

2021-07-30 Thread Lætitia Avrot
> > > > On Fri, Jul 9, 2021 at 4:43 PM Tomas Vondra < > tomas.von...@enterprisedb.com> wrote: > > > > The main question I have is whether this should include procedures. I'd > > probably argue procedures should be considered different from functions > > (i.e. requiring a separate --procedures-only

Re: pg_dump new feature: exporting functions only. Bad or good idea ?

2021-03-27 Thread Lætitia Avrot
> > >> Using --functions-only along with --table= does not error out and > warn the user, instead it creates a dump containing only the SET commands. > An error similar to using --functions-only along with --data-only seems > like a good idea. > > Thank you for giving my patch a try. I added the ne

Re: pg_dump new feature: exporting functions only. Bad or good idea ?

2021-03-27 Thread Lætitia Avrot
s any impact on performance. I guess that adding 4 if statements will slow down `pg_dump` a little bit. Have a nice day, Lætitia Le mer. 17 mars 2021 à 18:16, Tom Lane a écrit : > Vik Fearing writes: > > On 3/17/21 6:00 PM, Lætitia Avrot wrote: > >> However, when I finally got th

pg_dump new feature: exporting functions only. Bad or good idea ?

2021-03-17 Thread Lætitia Avrot
Hey hackers, I had this idea, that I raised and cherished like my baby to add a switch in `pg_dump` to allow exporting stored functions (and procedures) only. However, when I finally got the time to look at it in detail, I found out there was no way to solve the dependencies in the functions and

Re: [Doc] pg_restore documentation didn't explain how to use connection string

2020-01-18 Thread Lætitia Avrot
Hi Laurenz, Thank you for taking the time to review that patch. Le lun. 25 nov. 2019 à 22:34, Laurenz Albe a écrit : > On Wed, 2019-11-13 at 16:48 +0100, Lætitia Avrot wrote: > > So after some thoughts I did the minimal patch (for now). > > I corrected documentation for the fol

Re: [Doc] pg_restore documentation didn't explain how to use connection string

2019-11-13 Thread Lætitia Avrot
ai 2019 à 09:16, Lætitia Avrot a écrit : > Hi all, > > It seems my approach was quite candid because, of all postgres client > applications, some document usage of connection string whereas other don't. > Then, several ways of using connection strings are involved. > > Here

Re: [Doc] pg_restore documentation didn't explain how to use connection string

2019-05-17 Thread Lætitia Avrot
> > >> Maybe I wasn't clear enough. My point was using a connection string is >> not documented. Here is PgBench documentation about dbname: >> >> > where *dbname* is the name of the already-created database to test in. >> (You may also need -h, -p, and/or -U options to specify how to connect >> to

Re: [Doc] pg_restore documentation didn't explain how to use connection string

2019-05-17 Thread Lætitia Avrot
Hi Juan, Le ven. 17 mai 2019 à 11:26, Juan José Santamaría Flecha < juanjo.santama...@gmail.com> a écrit : > > On Fri, May 17, 2019 at 9:16 AM Lætitia Avrot > wrote: > >> >> Given that, I think it would be a good thing to generalize the -d switch >> (and m

Re: [Doc] pg_restore documentation didn't explain how to use connection string

2019-05-17 Thread Lætitia Avrot
he -d switch. Those don't have a -d switch now. Given that, I think it would be a good thing to generalize the -d switch (and maybe the --maintenance-db switch too). What do you think ? Cheers, Lætitia Le mar. 30 avr. 2019 à 19:10, Lætitia Avrot a écrit : > Hi all, > > I&#

Re: [Patch] Log10 and hyperbolic functions for SQL:2016 compliance

2019-03-13 Thread Lætitia Avrot
Thanks, Tom ! Thank you everyone for your help and patience. Cheers, Lætitia Le mar. 12 mars 2019 à 20:57, Tom Lane a écrit : > =?UTF-8?Q?L=C3=A6titia_Avrot?= writes: > > So, as you're asking that too, maybe my reasons weren't good enough. > You'll > > find enclosed a new version of the pat

Re: [Patch] Log10 and hyperbolic functions for SQL:2016 compliance

2019-02-11 Thread Lætitia Avrot
Hi Andrew and Tom, I considered that option before writing my patch but I refrained for 2 reasons: - There is no consensus about how to name these functions. The standard 8000-2 goes with arsinh, arcosh and artanh, but you will find easily arcsinh, arccosh and arctanh or even argsinh, argcosh a

Re: [Patch] Log10 and hyperbolic functions for SQL:2016 compliance

2019-02-02 Thread Lætitia Avrot
Hi Alvaro, Thank you so much for taking the time to review the patch and for taking the time again to sort things out with me this evening. > I see that in dtanh() you set errno to 0 before calling tanh(), but 1) > you don't check for it afterwards (seems like you should be checking for > ERANG

Re: [Patch] Log10 and hyperbolic functions for SQL:2016 compliance

2019-01-31 Thread Lætitia Avrot
Hi, Thanks to Emil Iggland's kind review, I added precision on documentation for hyperbolic functions. I added the patch to the next commitfest. Cheers, Lætitia Le dim. 27 janv. 2019 à 20:39, Lætitia Avrot a écrit : > Hi, > > Thanks for your time a

Re: [Patch] Log10 and hyperbolic functions for SQL:2016 compliance

2019-01-27 Thread Lætitia Avrot
Hi, Thanks for your time and advice, Tom! > > [ adding_log10_and_hyperbolic_functions_v1.patch ] > > No objection to the feature, but > > - Why are you using the float4-width library functions (coshf etc) > rather than the float8-width ones (cosh etc)? > > Well, I guess the only reason is that I

[Patch] Log10 and hyperbolic functions for SQL:2016 compliance

2019-01-26 Thread Lætitia Avrot
Hello hackers, In his blog post (What's new in SQL 2016)[ https://modern-sql.com/blog/2017-06/whats-new-in-sql-2016], Markus Winand explained some of the changes added to SQL:2016. I spotted that Postgres was behind other RDBMS on hyperbolic functions and log10 function. The log10 function existed

Re: Grant documentation about "all tables"

2019-01-07 Thread Lætitia Avrot
Hi Stephen, Le sam. 5 janv. 2019 à 20:41, Stephen Frost a écrit : > Greetings Lætitia! > > * Lætitia Avrot (laetitia.av...@gmail.com) wrote: > > When you look at Postgres' SQL reference documentation for `GRANT`, the > > `ALL TABLES` clause is explained as : > &g

Grant documentation about "all tables"

2018-12-16 Thread Lætitia Avrot
Hi all, When you look at Postgres' SQL reference documentation for `GRANT`, the `ALL TABLES` clause is explained as : > ALL TABLES also affects views and foreign tables, just like the specific-object GRANT command. A colleague of mine was asking himself if it included materialized views or not (

Re: Alter table documentation page (again)

2018-12-07 Thread Lætitia Avrot
Hi all, Here's the patch. The patch should apply to MASTER. I built and tested it successfully on my laptop. I'll add it to January's commitfest. Cheers, Lætitia diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml index be1647937d..c49a20fb93 100644 --- a/doc/src/

Re: Alter table documentation page (again)

2018-12-06 Thread Lætitia Avrot
> > > I'd rename the action in ON DELETE/UPDATE to referential_action, both in > alter_table and in create_table (the latter just for consistency). > I love that "option 3" ! So clever!

Alter table documentation page (again)

2018-12-06 Thread Lætitia Avrot
Hi, I was trying to answer a former colleague question about postgres' default behaviour when deleting or updating when she pointed out that Postgres alter table documentation page used twice the 'action' keywords for two different things. And indeed she is right : - it's used to described any ac

Re: Markdown format output for psql, design notes

2018-12-02 Thread Lætitia Avrot
:11 odesílatel Daniel Verite > napsal: > >> Lætitia Avrot wrote: >> >> > But as Vik said earlier, maybe it's not worth it to provide a markdown >> > output as pandoc can generate the markdown from the HTML output. >> > And if you need the mar

Re: Commitfest 2018-11

2018-12-01 Thread Lætitia Avrot
> > > > Yeah, I've been annoyed by that too (not that I've not been guilty of > it myself). We should probably tell people not to add themselves as > reviewers unless they're actively planning to review soon, because it > discourages other people from reviewing the same item. Maybe also, > when a

Re: Markdown format output for psql, design notes

2018-11-30 Thread Lætitia Avrot
Hi, No I meant independently of the screen, if there's an LF character > in a cell. Or a '|' character, since that's the same problem: an > element of structure happening to be in the contents. > The specs mentioned upthread don't seem to give any indication > about that being supported. > > i've

Re: Markdown format output for psql, design notes

2018-11-28 Thread Lætitia Avrot
> > I'm a little bit reluctant for us to write and maintain more and more > format styles, especially one as subjective and varied as markdown. I > imagine we will constantly be bombarded with "this isn't quite right" or > "this isn't compatible with github". > > I understand your concern. It's a

Re: Markdown format output for psql, design notes

2018-11-28 Thread Lætitia Avrot
Le mer. 28 nov. 2018 à 16:25, Daniel Verite a écrit : > Lætitia Avrot wrote: > > > # The result I want > > From points 3 and 4, here is what I'd like to see : > > > > | Header 1 | Header 2 | Header 3 | > > |--|--|

Markdown format output for psql, design notes

2018-11-28 Thread Lætitia Avrot
Hi all, # What I'd like to do I've been working on the idea of a markdown format for psql as I had said in that thread : https://www.postgresql.org/message-id/flat/CAB_COdiiwTmBcrmjXWCKiqkcPgf_bLodrUyb4GYE6pfKeoK2eg%40mail.gmail.com An attempt was made a year ago (see here : https://www.postgresq

Re: Constraint documentation

2018-11-26 Thread Lætitia Avrot
Hi all, Thank you for helping us to make that patch better. It didn't > seem worth blocking this patch for your proposed change (particularly > since Lætitia seems to have given up on it already). > > I haven't given up. As I said in the begining, Patrick and I were working together on that patch

Re: Constraint documentation

2018-08-07 Thread Lætitia Avrot
...@2ndquadrant.com> a écrit : > On 6/26/18 09:49, Lætitia Avrot wrote: > > + > > + > > + Check constraints are not designed to enforce business rules > across tables. > > + Avoid using check constraints with a function accessing other > tables and

Re: Constraint documentation

2018-06-26 Thread Lætitia Avrot
Hi, Thanks a lot. I did the modification. It's in the patch enclosed. Have a nice day, Lætitia Le mar. 26 juin 2018 à 01:42, Brad DeJong a écrit : > On 25/06/18 17:45, Lætitia Avrot wrote: > > + > > + > > + Check constraint are not designed to enf

Re: Constraint documentation

2018-06-25 Thread Lætitia Avrot
Hello, Ok, I corrected the patch as suggested. I hope I did it right. Have a nice day, Lætitia Le lun. 25 juin 2018 à 16:02, Lætitia Avrot a écrit : > Thanks! > I'll correct the patch ASAP including your modifications. > > Le sam. 23 juin 2018 à 19:15, Fabien

Re: Constraint documentation

2018-06-25 Thread Lætitia Avrot
Thanks! I'll correct the patch ASAP including your modifications. Le sam. 23 juin 2018 à 19:15, Fabien COELHO a écrit : > > Hello lætitia, > > My 0.02 € to try to simplify the suggested documentation. > > > Check constraint were not > > are not > > > designed to enforce business rules across tab

Constraint documentation

2018-06-02 Thread Lætitia Avrot
Hi, Patrick Francelle and I encountered this situation where there was a check constraint on a table using a function to enforce a constraint across two different tables. When using pg_dump to dump structure and data we found out we couldn't restore it because tables weren't dumped in the right or

Re: Adding Markodwn formatting to psql output

2018-05-29 Thread Lætitia Avrot
Le mar. 29 mai 2018 à 17:28, Euler Taveira a écrit : > 2018-05-29 12:11 GMT-03:00 Lætitia Avrot : > > I write often documents for my customers in MarkDown to produce pdf > > documents. Quite often, I need to present data from queries in a tabular > > form. > > >

Adding Markodwn formatting to psql output

2018-05-29 Thread Lætitia Avrot
Hi, I write often documents for my customers in MarkDown to produce pdf documents. Quite often, I need to present data from queries in a tabular form. Psql output provides formatting in text (aligned and unaligned), HTML, latex, JSON (and so many more) but not in MarkDown. The aligned output is q

Re: VACUUM FULL name is very confusing to some people (or to most non expert people)

2018-02-26 Thread Lætitia Avrot
> > Although VACUUM and VACUUM FULL is different, then result is same (depends > on detail level) - the data files are optimized for other processing. You > should to see a VACUUM like family of commands that does some data files > optimizations. VACUUM, VACUUM FULL, VACUUM FREEZE, VACUUM ANALYZE,

VACUUM FULL name is very confusing to some people (or to most non expert people)

2018-02-25 Thread Lætitia Avrot
Hi all, For most beginners (and even a lot of advanced users) there is a strong confusion between simple VACUUM and VACUUM FULL. They think "full" is simply an option to the maintenance operation vacuum while it's not. It's a complete different operation. I have a hard time explaining it when I

Re: [HACKERS] Adding column_constraint description in ALTER TABLE synopsis

2018-02-04 Thread Lætitia Avrot
Hi, Thank you all for this so warm reception for my very first patch. Thanks Stephen to have thought to add that patch to the commit fest. As it was committed Friday, I was able to tell the whole story in my talk and that's great. And thanks again to everyone who helped me with that patch. Regard