Hi, client can use CURSOR feature to process data in batches. What is the
case where proposed feature solves problem that CURSOR does not?
https://www.postgresql.org/docs/current/plpgsql-cursors.html
On Fri, 17 Jan 2025, 16:08 Vladimir Sitnikov,
wrote:
> Hi,
>
> Applications often face an "out
std is not supported by this build
2025-01-12 18:10:47.657 UTC [4167965] PANIC: cannot abort transaction
1, it was already committed
Aborted (core dumped)
child process exited with exit code 134
initdb: removing data directory "db"
```
Also pg_waldump fails with
```
corrupted size vs. prev_size
Aborted (core dumped)
```
Best regards,
Kirill Reshke
Maybe we can add a `malformed_tuples` column to this view?
> 3. do we settled (on_error set_to_null) syntax.
I think so. I prefer this syntax to others discussed in this thread.
--
Best regards,
Kirill Reshke
oneous rows tests.
In short, we need this message somewhere in a regression test.
```
ERROR: skipped more than REJECT_LIMIT (xxx) rows due to data type
incompatibility
```
Also, please update commit msg with all authors and reviewers. This
will make committer job a little bit easier
--
Best regards,
Kirill Reshke
;+
>+ if ((p->skip_option == SKIP_PAGES_ALL_FROZEN && (mapbts &
>VISIBILITYMAP_ALL_FROZEN) != 0) ||
>+ (p->skip_option == SKIP_PAGES_ALL_VISIBLE && (mapbts &
>VISIBILITYMAP_ALL_VISIBLE) != 0))
> + continue;
I don't understand this change. The patch aims to be purely applying
streaming API, not refactoring. And if we refactor this code, this is
less readable than it was.
Other than that, LGTM.
--
Best regards,
Kirill Reshke
On Wed, 18 Dec 2024 at 00:15, Euler Taveira wrote:
>
> Hi,
>
> Sometimes you need to inspect some debug messages from autovacuum worker but
> you cannot apply the same setting for backends (that could rapidly fill the
> log
> file). This proposal aims to change log_min_messages to have different
stead harness the existing one. Would you do it that way?
Sure, my bad, I missed this part of your message. PFA v5 with
database.sql changes.
--
Best regards,
Kirill Reshke
v5-0001-When-making-dependency-changes-lock-the-tuple-for.patch
Description: Binary data
nd of checks.
+1 on that.
--
Best regards,
Kirill Reshke
the high key on
the rightmost page in the entry GIN tree explicitly, as this is not
actually stored.
PFA little v35 fix for this. I will update this thread with a full v35
patch set shortly.
[0] https://www.postgresql.org/message-id/87a5gyqnl5.fsf%40163.com
--
Best regards,
Kirill Reshke
v35
On Thu, 12 Dec 2024, 21:45 Tom Lane, wrote:
> Peter Eisentraut writes:
> > This patch allows subfield references in column references without
> > parentheses, subject to certain condition. This implements (hopes to,
> > anyway) the rules from the SQL standard (since SQL99).
> > This has been re
On Tue, 10 Dec 2024 at 14:14, Kirill Reshke wrote:
> CI fails due to bad naming in the regression test.
> The change is deptestdb1 -> regressdeptestdb1
I'm very sorry for spam.
PFAv4
regressdeptestdb1 -> regressiondeptestdb1
--
Best regards,
Kirill Reshke
v4-0001-When-
made within CREATE SCHEMA, a possible though non-standard answer
> would be to allow ALTER TABLE ADD CONSTRAINT as a .
That's a nice feature to have by itself?
--
Best regards,
Kirill Reshke
On Tue, 10 Dec 2024 at 10:47, Kirill Reshke wrote:
>
> On Tue, 10 Dec 2024 at 10:45, Kirill Reshke wrote:
>
> > PFA v2.
> Also CF entry https://commitfest.postgresql.org/51/5430/ to get CI feedback.
CI fails due to bad naming in the regression test.
The change is deptestdb1 -&
d in the first patch.
>
> This makes also the whole review easier.
Ok. Sure.
> Typo here: s/exists/exist/.
Fixed, Thank you
PFA v8.
--
Best regards,
Kirill Reshke
v8-0001-Add-more-regression-tests-to-various-DDL-patterns.patch
Description: Binary data
v8-0002-Print-out-error-
On Tue, 10 Dec 2024 at 10:45, Kirill Reshke wrote:
> PFA v2.
Also CF entry https://commitfest.postgresql.org/51/5430/ to get CI feedback.
--
Best regards,
Kirill Reshke
in database.sql.
Sure. I added one test case to dependency.sql (for DATABASE ownership
change), do we need more (other catalog classes)?
--
Best regards,
Kirill Reshke
v2-0001-When-making-dependency-changes-lock-the-tuple-for.patch
Description: Binary data
On Mon, 9 Dec 2024 at 15:27, Alexander Kukushkin wrote:
> postgres=# reassign owned by test to postgres;
> WARNING: missing lock on database "postgres" (OID 5) @ TID (0,4)
> REASSIGN OWNED
Hi!
Looks like PFA should fix that.
--
Best regards,
Kirill Reshke
v1-0001-Loc
auxiliary functions are
> actual arguments to errstart() -- which means that the parentheses
> you're adding here are unnecessary and discouraged. Just add the
> parser_errposition() call and it'll be fine.
Should be fixed in v7.
--
Best regards,
Kirill Reshke
v7-0001-Pri
I can take
> care of that ...
>
Thank you for taking a look.
PFA v6 with last Karina's review comments addressed.
--
Best regards,
Kirill Reshke
v6-0003-Add-missing-tab-completion-for-CREATE-TEMP-TABLE-.patch
Description: Binary data
v6-0001-Enhance-tab-completion-to-ALTER-TYPE-ADD-ATT
ql.org/51/5385/
--
Best regards,
Kirill Reshke
I did not yet look into this in detail, but please note that PostgreSQL
comments style is /**/ not //. Also, please, do not top post on this list
_items and version?
[0]
https://api.cirrus-ci.com/v1/artifact/task/5037800950595584/testrun/build-32/testrun/pgstattuple/regress/regression.diffs
--
Best regards,
Kirill Reshke
.postgresql.org/wiki/Submitting_a_Patch>. *Please find the
> attachments for the patch and performance results.*
> Please let us know if you have any queries or suggestions.
>
>
> Thanks & Regards,
> Susmitha Devanga.
>
Hi! Is this patch somehow related to [0] ?
[0]
https://www.postgresql.org/message-id/010101936e4aaa70-b474ab9e-b9ce-474d-a3ba-a3dc223d295c-00%40us-west-2.amazonses.com
--
Best regards,
Kirill Reshke
lso add more tests to the pgstattuple regression test, as Nazir
suggested. It turns out that pgstattuple works on GIST indexes, but
not GIN, while `pgstatginindex` exists and `pgstatgistindex` does not.
It took me a while to process the reasons. But those reasons worth
another thread & patch, s
On Fri, 20 Sept 2024 at 07:11, jian he wrote:
> attached patch removes attndims and typndims entirely.
LGTM?
I see no open items in this thread. Are there any issues about v1?
--
Best regards,
Kirill Reshke
Looks like v4 fails on windows, PFA v5.
Sorry for the noise, I hope Cirrus CI will like this version.
--
Best regards,
Kirill Reshke
v5-0001-print-out-error-position-for-some-DDL-command.patch
Description: Binary data
On Thu, 5 Dec 2024 at 11:45, Michael Paquier wrote:
>
> On Wed, Dec 04, 2024 at 03:31:47PM +0500, Kirill Reshke wrote:
> > On Sat, 30 Nov 2024 at 17:37, jian he wrote:
> >> So I guess bundling it into a single patch should be fine?
> >
> > Ok. I created CF entry
On Thu, 5 Dec 2024 at 14:36, Alvaro Herrera wrote:
> Maybe it would have been wise to forbid NOT VALID when used with CREATE
> TABLE. But we didn't. Should we do that now? Maybe we can just
> document that you can specify it but it doesn't do anything.
+1 on that
--
B
) that was
read from the altered table.
Thoughts?
--
Best regards,
Kirill Reshke
v1-0001-Add-pg_stat_progress_rewrite-view.patch
Description: Binary data
-id/CAPpHfdvRmTzGJw5rQdSMkTxUPZkjwtbQ%3DLJE2u9Jqh9gFXHpmg%40mail.gmail.com
> 4.
> https://www.postgresql.org/message-id/4953563546cb8c8851f84c7debf723ef%40postgrespro.ru
> 5.
> https://www.postgresql.org/message-id/ab0eddce-06d4-4db2-87ce-46fa2427806c%40iki.fi
>
> --
> Regards,
> Alexander Korotkov
> Supabase
Hi!
What's the current status of
https://commitfest.postgresql.org/50/5167/ ? Should we close it or
reattach to this thread?
--
Best regards,
Kirill Reshke
On Sat, 30 Nov 2024 at 17:37, jian he wrote:
> So I guess bundling it into a single patch should be fine?
Ok. I created CF entry for this patch.
[0] https://commitfest.postgresql.org/51/5420/
--
Best regards,
Kirill Reshke
317d0c26786953646a411.ca...@cybertec.at)
> + * in COPY FROM keep error saving table locks until the transaction end.
> + */
I can rarely see other comments referencing commits, and even few
referencing a mail archive thread.
Can we just write proper comment explaining the reasons?
= overall
Patch design is a little dubious for me. We give users some really
incomprehensible API. To use on_error *relation* feature user must
create tables with proper schema.
Maybe a better design will be to auto-create on_error table if this
table does not exist.
Thoughts?
--
Best regards,
Kirill Reshke
and it fixes the repro that
> Justin posted. FYI on my machine I had to use sleep 0.005 where he
> had 0.05, as an FYI if someone else is trying to reproduce the issue.
Hi!
This patch needs a rebase.CF entry status now is Waiting On author.
--
Best regards,
Kirill Reshke
ksz_32k.diff) that supports the
> block size == 32K case.
>
> Best,
> Yushi Ogiwara
>
Hi!
There is review comments that need to be addressed in [1]
Patch status now is waiting on author
[1]
https://www.postgresql.org/message-id/CAD21AoCthHcSQ5zeeivNpiz7HMi_FPG-dtwDDNYUx2oKG36bCQ%40mail.gmail.com
--
Best regards,
Kirill Reshke
On Wed, 2 Oct 2024 at 10:29, Michael Paquier wrote:
>
> Rebased as v29 due to an OID conflict.
Hi!
Looks like this needs another rebase
--
Best regards,
Kirill Reshke
On Fri, 29 Nov 2024 at 16:19, Nazir Bilal Yavuz wrote:
> v4 is attached.
Hi!
I feel like we are ready to mark this as RFC, WDYT?
--
Best regards,
Kirill Reshke
rtions, character sets, translations,
collations, privileges) and their associated descriptors are
effectively created.
```
Look like we are 100% to do it in order of definition
--
Best regards,
Kirill Reshke
v2-0001-Don-t-try-to-re-order-the-subcommands-of-CREATE-S.patch
Description: Binary data
"1foo"
> HINT: Valid units for this parameter are "B", "kB", "MB", "GB", and "TB".
> postgres=# set log_parameter_max_length = '1TB';
> ERROR: invalid value for parameter "log_parameter_max_length": "1TB"
> HINT: Value exceeds integer range.
>
> I think we can leave it as is.
Hi
> +for (my $attempts = 0; $attempts < $max_attempts; $attempts++)
> +{
> + eval {
> + $current_logfiles = slurp_file($node->data_dir . '/current_logfiles');
> + };
> + last unless $@;
> + usleep(100_000);
> +}
`usleep` in tap tests is usually a bad pattern. Do we have a chance to
test this using `wait_for_log` or similar?
--
Best regards,
Kirill Reshke
the next CF.
--
Best regards,
Kirill Reshke
llo!
After a brief glance, I think this patch set is good.
But there isn't any more time in the current CF to commit this :(.
So I moved to the next CF.
I also like the 0001 commit message. This commit message is quite
large and easy to understand. Actually, it might be too big. Perhaps
rather of being a commit message, the final paragraph (pages_frozen -
number of pages that..) need to be a part of the document. Perhaps
delete the explanation on pages_frozen that we have in 0004?
--
Best regards,
Kirill Reshke
On Fri, 29 Nov 2024 at 20:20, Bertrand Drouvot
wrote:
> On Fri, Nov 29, 2024 at 11:23:12AM +0500, Kirill Reshke wrote:
> > If we don’t have the relation OID when writing buffers out, can we
> > just store oid to buffertag mapping somewhere and use it?
>
> Do you mean add the
On Fri, 29 Nov 2024 at 18:47, jian he wrote:
>
> new patch, add tab complete for it.
Thank you. You may also be interested in reviewing [0].
[0]
https://www.postgresql.org/message-id/CALdSSPhqfvKbDwqJaY%3DyEePi_aq61GmMpW88i6ZH7CMG_2Z4Cg%40mail.gmail.com
--
Best regards,
Kirill Reshke
On Wed, 14 Aug 2024 at 23:08, Сергей Соловьев
wrote:
>
>
>
> 10.08.2024, 16:40, "Kirill Reshke" :
>
> On Thu, 4 Jul 2024 at 21:46, Sergey Solovev
> wrote:
>
>
> Hi.
>
> We encountered a problem with excessive logging when transaction is
> sampl
ws by passing
> QueryEnv to DefineView() (or in ealier stage) , but there are other
> objects that can contain ENR in their definition, for examle, functions,
> cursor, or RLS policies. Is it worth introducing this version of error
> message for all these objects?
>
> Regards,
> Yugo Nagata
>
> --
> Yugo NAGATA
Hi!
There are review comments that need to be addressed.
Commitfest status is now waiting on the author.
[0] https://www.postgresql.org/message-id/ZzrHUEaWB67EAZpW%40paquier.xyz
[1] https://www.postgresql.org/message-id/222722.1732124596%40sss.pgh.pa.us
--
Best regards,
Kirill Reshke
:08.804) -- with small variance
db1=# select drive_popcount64(1000, 1);
drive_popcount64
--
64608
(1 row)
Time: 200716.879 ms (02:21.717) -- with small variance
```
I'm not sure how to interpret these results. Looks like this does not help
much on a large $num?
--
Best regards,
Kirill Reshke
that we will break too many abstraction layers for such a minor
matter?
--
Best regards,
Kirill Reshke
On Fri, 29 Nov 2024, 09:14 Sergey Prokhorenko, <
sergeyprokhore...@yahoo.com.au> wrote:
> I mean to add not benchmark results to the patch, but functions so that
> everyone can compare themselves on their equipment. The comparison with
> UUIDv4 is not very interesting, as the choice is usually bet
se_main() function when it is set to false.
>
> block_range_read_stream_cb() callback is used when the callback only
> needs to loop over the block numbers. However, for the autoprewarm
> case; the callback function needs to do additional checks so another
> callback and the use of this variable are required.
>
> v3 is attached.
>
> --
> Regards,
> Nazir Bilal Yavuz
> Microsoft
Hi!
> + old_blk = &(p->block_info[p->pos - 1]);
> + cur_blk = &(p->block_info[p->pos]);
Should we Assert(p->pos > 0 && p->pos < *something*)
Patch tested with no regression.
--
Best regards,
Kirill Reshke
n one of
this format:
https://wiki.postgresql.org/wiki/Cfbot#Which_attachments_are_considered_to_be_patches.3F
This is useful for reviewers who use cfbot or cputube.
--
Best regards,
Kirill Reshke
old.patch
>
> Fine tuning for the previous patch, makes only arrays with the length over a
> certain threshold to be reduced.
>
> On top of that Yasuo Honda and Jakub Wartak have provided a couple of
> practical
> examples, where handling of constant arrays has to be improved. David Geier
> pointed out some examples that might be confusing as well. All those are
> definitely worth addressing, but out of scope of this patch for now.
Hi! Can you please send a rebased version of this?
--
Best regards,
Kirill Reshke
On Tue, 19 Nov 2024 at 13:52, jian he wrote:
>
> On Sat, Nov 16, 2024 at 5:55 PM Kirill Reshke wrote:
> >
> > I am attaching my v8 for reference.
> >
>
> in your v8.
>
>
> REJECT_LIMIT
>
>
> Specifies the maxim
On Mon, 18 Nov 2024 at 16:34, Andrey M. Borodin wrote:
>
>
>
> > On 2 Nov 2024, at 02:36, Kirill Reshke wrote:
> >
> > I noticed CI failure for this patch. This does not look like a flap.
>
> Seems like vacuum did not start index cleanup. I’ve added "i
ro stated in [0]
Patch status is now Rejected.
[0]
https://www.postgresql.org/message-id/202411051209.hzs5jktf6e3s@alvherre.pgsql
--
Best regards,
Kirill Reshke
on A. Melnikov
> Postgres Professional: http://www.postgrespro.com
> The Russian Postgres Company
Hi!
Given little activity here, there is a little chance of being
committed in the current commitfest, so I moved to the next.
I will try to take a look at v19 soon.
--
Best regards,
Kirill Reshke
est regards,
Kirill Reshke
Hi hackers!
PFA patch fixing a number of places where typenameType called with NULL pstate.
=== motivation.
Per discussion in a nearby thread for `CREATE SCHEMA ... CREATE DOMAIN
support`. Suggested by Jian He & Tom Lane.
On Thu, 28 Nov 2024 at 10:52, Tom Lane wrote:
>
> Kirill Resh
On Tue, 26 Nov 2024 at 15:39, Nazir Bilal Yavuz wrote:
>
> Hi,
>
> Thank you for working on this!
>
> On Mon, 25 Nov 2024 at 21:17, Kirill Reshke wrote:
> > While reviewing other threads implementing stream API for various core
> > subsystems, I spotted that pgsta
On Wed, 27 Nov 2024 at 23:39, Tom Lane wrote:
>
> Kirill Reshke writes:
> > On Wed, 27 Nov 2024 at 08:42, jian he wrote:
> >> CREATE SCHEMA regress_schema_2 AUTHORIZATION CURRENT_ROLE
> >> create domain ss1 as ss
> >> create domain ss as text;
> >>
tx block. this is however untrue
before the bind+exec message for p1 will be sent (\bind_name
metacommand). Am I correct?
--
Best regards,
Kirill Reshke
should instead
support \sync meta-command in psql? This will be a useful contribution
itself.
> Those meta-commands will allow testing pipelined query behaviour using
> psql regression tests.
>
> Regards,
> Anthonin
I haven't looked into the patch in detail yet.
--
Best regards,
Kirill Reshke
^
To implement this, we need to include `ParseLoc location` to the
`CreateDomainStmt` struct, which is doubtful, because I don't see any
other type of create *something* that does this.
`make check` on v3 runs successfully. Test & doc seems fine to me.
PFA v4. The only change I made
On Sat, 23 Nov 2024, 07:44 Nathan Bossart, wrote:
> On Fri, Nov 22, 2024 at 06:13:16PM -0500, Andres Freund wrote:
> >> -if (procStatus && procStatus->st_backendType ==
> B_AUTOVAC_WORKER)
> >> +if (pgstat_get_backend_type(pid) == B_AUTOVAC_WORKER)
> >
> > Because we alrea
w';
fdwowner
--
10
(1 row)
--
Best regards,
Kirill Reshke
, since the streaming API
already delivers the right buffer, I think it's okay.
This change behaves sanely on my by-hand testing.
--
Best regards,
Kirill Reshke
v1-0001-Use-stream-read-interface-for-pgstattuple-routine.patch
Description: Binary data
or.
>
Hello! Please deliver the most recent patch version and fix the issues
Jim identified [0] as the current commitfest draws to a close.
Do not forget to include both parts of this patch (This was actually
developed off-list, and we are now using this on our cloud PostgreSQL
distribution on versions 12–17).
[0]
https://www.postgresql.org/message-id/35096a36-04d4-480b-a7cd-a2d8151fb737%40uni-muenster.de
--
Best regards,
Kirill Reshke
vious if statements.
5) In _gin_partition_sorted_data:
>charfname[128];
>sprintf(fname, "worker-%d", i);
Other places use MAXPGPATH in similar cases.
Also, code `sprintf(fname, "worker-%d",...);` duplicates. This might
be error-prone. Should we have a macro/inline function for this?
I will take another look later, maybe reporting real problems, not nit-picks.
--
Best regards,
Kirill Reshke
ave a copy of the backend type in PGPROC.
>
> Greetings,
>
> Andres Freund
Hi, thanks for taking care of this. I agree with this analysis, and it
appears that the worries are legitimate.
For the fix, I believe that copy-pasting
`pgstat_get_backend_current_activity` to get the backend type should
solve the issue. Not sure if this is the correct way of doing this.
Enlarging PGPROC somehow feels worse.
--
Best regards,
Kirill Reshke
On Tue, 19 Nov 2024, 13:52 jian he, wrote:
>
> On Sat, Nov 16, 2024 at 5:55 PM Kirill Reshke wrote:
> >
> > I am attaching my v8 for reference.
> >
>
> in your v8.
>
>
> REJECT_LIMIT
>
>
> Specifies the maxim
Hi!
On Tue, 19 Nov 2024, 14:08 jian he, wrote:
> hi.
>
> in v17, we support COPY(MERGE RETURNING)
> we can add tab_complete for it.
>
Sounds sane
> /* Complete COPY ( with legal query commands */
> else if (Matches("COPY|\\copy", "("))
> - COMPLETE_WITH("SELECT", "TABLE",
On Mon, 18 Nov 2024 at 11:26, Kirill Reshke wrote:
>
> On Fri, 1 Nov 2024 at 02:47, Michael Banck wrote:
> >
> > Hi,
> >
> > Even though there has not been a lot of discussion on this, here is a
> > rebased patch. I have also added it
loaded on the host, I never want a normal user to run code with
superuser privileges.
For a thorough understanding of the current situation and the
rationale behind the design, you can read this[1] discussion.
[1] https://www.postgresql.org/message-id/5889.1566415762%40sss.pgh.pa.us
--
Best regards,
Kirill Reshke
> 5. Provide mapping between index AM strategy numbers and
> > RowCompareType (with some small extensions). This is what this
> > patch does.
>
> As the patch author, obviously this is the one I chose. The "small
> extensions" are just to handle "no such value" type cases.
>
>
> —
> Mark Dilger
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
Hi! Can we please have a rebased version of this patch series?
--
Best regards,
Kirill Reshke
On Sat, 16 Nov 2024 at 13:27, jian he wrote:
>
> On Sat, Nov 9, 2024 at 8:55 PM Kirill Reshke wrote:
> >
>
> > > > But while I was trying to implement that, I realized that I don't
> > > > understand v4 of this patch. My misunderstanding is about
>
is needed in PostgreSQL
== end
[0]
https://www.postgresql.org/message-id/CALdSSPgxcRkooZ2iQ5A7XhYoexVAdbiT6znZDqJTE8hxUVjz_A%40mail.gmail.com
[1]
https://www.postgresql.org/message-id/20241009.ckna4vp7ahyk%40alvherre.pgsql
--
Best regards,
Kirill Reshke
v1-0001-Extend-CREATE-SCHEMA-elemen
bigint.
If not specified, ON_ERROR=ignore
allows an unlimited number of errors, meaning COPY will
skip all erroneous data.
There is a difference. Should we add REJECT_LIMIT vs ON_ERROR
clarification for file_fdw too? or maybe we put a reference for COPY
doc.
--
Best regards,
Kirill Reshke
On Mon, 11 Nov 2024 at 16:11, torikoshia wrote:
>
> On 2024-11-09 21:55, Kirill Reshke wrote:
>
> Thanks for working on this!
Thanks for reviewing the v7 patch series!
> > On Thu, 7 Nov 2024 at 23:00, Fujii Masao
> > wrote:
> >>
> >>
> &g
On Thu, 7 Nov 2024 at 22:33, Karina Litskevich
wrote:
>
> I looked through the new set of patches.
>
> On Thu, Nov 7, 2024 at 2:42 PM Kirill Reshke wrote:
> > v3-0002 patch actually mixes two types of completion. First one, which
> > adds a data type completion for
On Thu, 7 Nov 2024 at 23:00, Fujii Masao wrote:
>
>
>
> On 2024/10/26 6:03, Kirill Reshke wrote:
> > when the REJECT LIMIT is set to some non-zero number and the number of
> > row NULL replacements exceeds the limit, is it OK to fail. Because
> > there WAS errors, a
a
Hi!
Sorry for disturbing you after so much time. Today, while I was doing
my stuff and researching several FSM-related questions, I noticed that
the comment in the `heap_xlog_visible` function used improper
punctuation.
After some investigation, I conclude that this is an oversight of
ab7dbd6, wh
so perhaps we should wait for some other views..
For this reason, I split v3-0002 into two separate patches.
I also want to propose an Access method completion for create M.V.
using. This is a patch I forgot to attach in my last email.
Please, see v4-0004
--
Best regards,
Kirill Reshke
v4
ase?
Something like:
```
reshke=# \set WATCH_INTERVAL -1e-309
underflow while parsing parameter
```
Also, maybe we should provide `double max` arg to the
ParseVariableDouble function, because this is a general-use function?
--
Best regards,
Kirill Reshke
cxt.blist = NIL;
>
> cxt.alist = NIL;
>
> cxt.pkey = NULL;
>
> - cxt.ispartitioned = (rel->rd_rel->relkind ==
> RELKIND_PARTITIONED_TABLE);
>
> cxt.partbound = NULL;
>
> cxt.ofType = false;
>
>
>
> --
>
> Best regards,
>
> hugozhang
Hi, I noticed a change of cf entry, thanks!
Can you please also send your patch as attachment?
You need to do something like git format-patch -v1 -1 and attach resulting file
--
Best regards,
Kirill Reshke
On Fri, 1 Nov 2024 at 15:43, Kirill Reshke wrote:
>
> Hi hackers!
>
> I have been working on cloudberry/greenplum tab completion features,
> and I spotted that the postgres version of psql does not tab-complete
> ALTER TABLE ADD COLUMN IF NOT EXISTS pattern.
> So, I pr
t regards, Andrey Borodin.
>
I noticed CI failure for this patch. This does not look like a flap.
[0] https://cirrus-ci.com/task/4527545259917312
[1]
https://api.cirrus-ci.com/v1/artifact/task/4527545259917312/log/src/test/modules/test_misc/tmp_check/log/regress_log_007_vacuum_btree
--
Best regards,
Kirill Reshke
On Fri, 1 Nov 2024 at 15:43, Kirill Reshke wrote:
>
> Hi hackers!
>
> I have been working on cloudberry/greenplum tab completion features,
> and I spotted that the postgres version of psql does not tab-complete
> ALTER TABLE ADD COLUMN IF NOT EXISTS pattern.
> So, I pr
Hi hackers!
I have been working on cloudberry/greenplum tab completion features,
and I spotted that the postgres version of psql does not tab-complete
ALTER TABLE ADD COLUMN IF NOT EXISTS pattern.
So, I propose to support this.
--
Best regards,
Kirill Reshke
v1-0001-Add-missing-psql-tab
Hi
On Thu, 24 Oct 2024, 18:08 hugo, <2689496...@qq.com> wrote:
> Hi!
>
>When looking at the partition-related code, I found that the
> ispartitioned
>
> field in CreateStmtContext is not used. It looks like we can safely remove
> it and
>
> avoid invalid assignment logic.
>
>
>
> Here's a
18:11写道：
>>
>> Kirill,
>>
>> Good catch!
>> I will split the patch into two to cover both cases.
>>
>> Thanks,
>> Steven
>>
>>
>> Junwang Zhao 于2024年8月9日周五 18:19写道：
>>>
>>> On Fri, Aug 9, 2024 at 5:20 PM Kirill Reshk
Hi!
On Mon, 21 Oct 2024 at 17:39, Fujii Masao wrote:
>
>
>
> On 2024/10/21 18:30, Kirill Reshke wrote:
> > v4 no longer applies. It now conflicts with
> > e7834a1a251d4a28245377f383ff20a657ba8262.
> > Also, there were review comments.
> >
> > So, I d
ue keys on partition tables in commit eb7ed3f
[2], this field became unneeded. CreateStmtContext is internal parser
struct, so no not used outside PG core (i mean, by any extension).
So, my suggestion is to remove it.
Hugo, can you please create a CF entry for this patch? Patch itself looks good.
[1]
https://github.com/postgres/postgres/blob/f0e44751d7175fa3394da2c8f85e3ceb3cdbfe63/src/backend/parser/parse_utilcmd.c#L617
[2]
https://github.com/postgres/postgres/commit/eb7ed3f3063401496e4aa4bd68fa33f0be31a72f#diff-5bd59ecc8991bacaefd56f7fe986287b8d664e62566eb3588c3845d7625cacf1L715
--
Best regards,
Kirill Reshke
> acceptable) behaviour.
I suspect this is the case. If that is, should be reflect it in the doc?
--
Best regards,
Kirill Reshke
change this correctly. We definitely don't want
two separate forms of saying the same in 2 consecutive lines.
I did small changes:
1) added
`-- tests for set_to_null`
option in the test script akin to 4ac2a9beceb10d44806d2cf157d5a931bdade39e
2) I rephrased
Allow "stop", or "ignore", "set_to_null" values
to
Allow "stop", "ignore", "set_to_null" values
PFA.
[1]
https://www.postgresql.org/message-id/b26e9c6c-75bf-45ea-8aea-346dda3bd445%40uni-muenster.de
--
Best regards,
Kirill Reshke
v5-0001-on_error-set_to_null.patch
Description: Binary data
ere is a memory leak.
>
>
> regards
>
> --
> Tomas Vondra
>
>
So, I did some testing, and it seems that the tuple returned by
`gistgetadjusted` inside `gist_check_page` is not being freed.
Trivial fix attached.
--
Best regards,
Kirill Reshke
v28-0014-Fix-memory-leak-in-gist_check_page.patch
Description: Binary data
#x27;s why we add 1), and this is strictly better than multiplying by
2, but why exactly is this formula like this, not (1.0 + cmpMultiplier
^ 2 / 10) for example? Maybe we need some more sophisticated approach?
Also, this patch needs to be rebased, again.
--
Best regards,
Kirill Reshke
ince this simplifies RMGR API for extension developers.
Compiler warns about `src/backend/access/transam/xlogrecovery.c:1860`,
where we switch to maybe-uninitialized memory context. Lets assign
this to something.
--
Best regards,
Kirill Reshke
ke that for extension
backward compatibility.
So, I propose to refactor this a little bit.
Am I missing something?
--
Best regards,
Kirill Reshke
hed, then redo is not needed.
=== Proposed fix
Is as simply as attached. WFM, but this is probably not a correct way
to fix this.
--
Best regards,
Kirill Reshke
v1-0001-Fix.patch
Description: Binary data
om/pg-sharding/pg_log_trunc/blob/master/pg_log_trunc.c#L43
--
Best regards,
Kirill Reshke
t; Only parallel HashJoin speed up to ~2x(all data cached in memory),
>
> not full query, include non-parallel HashJoin.
>
> non-parallel HashJoin only when batchs large then one will speed up,
>
> because this patch only optimize for read batchs tuples to memory.
>
> Hi
likely/unlikely usage can be justified via benchmark. Parallel HashJoin
speed up still also can be verified via benchmark. Either benchmark script
or benchmark result, and it is better to provide both.
--
Best regards,
Kirill Reshke
ditional and where only one rule can exist on each
* relation).
*
```
Maybe I'm really bad at searching things and nobody before had
problems understanding what RIR stands for. If not, should we enhance
documentation in some way? If yes, what is the proper place?
--
Best regards,
Kirill Reshke
1 - 100 of 161 matches
Mail list logo
