On Fri, 29 Nov 2024 at 22:05, Matheus Alcantara <matheusssil...@gmail.com> wrote: > Just for reference; On pg_prewarm() for example this loop is > implemented as: > > for (block = first_block; block <= last_block; ++block) > { > Buffer buf; > ... > buf = read_stream_next_buffer(stream, NULL); > ... > } > Assert(read_stream_next_buffer(stream, NULL) == InvalidBuffer); > > > Would this approach make sense on these cases? (this patch and on > collect_corrupt_items)
Hi! Thank you for your input. I applied this change for this patch. I did also add more tests to the pgstattuple regression test, as Nazir suggested. It turns out that pgstattuple works on GIST indexes, but not GIN, while `pgstatginindex` exists and `pgstatgistindex` does not. It took me a while to process the reasons. But those reasons worth another thread & patch, so no changes here. -- Best regards, Kirill Reshke
v3-0001-Use-stream-read-interface-for-pgstattuple-routine.patch
Description: Binary data