Re: Proposal: allow database-specific role memberships

2022-07-24 Thread Kenaniah Cerny
Hi Antonin, Thank you again for the detailed review and questions. It was encouraging to see the increasing level of nuance in this latest round. It's not clear from the explanation of the GRANT ... IN DATABASE ... / GRANT > ... IN CURRENT DATABASE ... that, even if "membership in ... will be >

Re: Proposal: allow database-specific role memberships

2022-07-17 Thread Kenaniah Cerny
Rebased yet again... On Mon, Jul 4, 2022 at 1:17 PM Kenaniah Cerny wrote: > Hi Antonin, > > First of all, thank you so much for taking the time to review my patch. > I'll answer your questions in reverse order: > > The "unsafe_tests" directory is where the pre-e

Re: Proposal: allow database-specific role memberships

2022-07-04 Thread Kenaniah Cerny
abase, the grantee's read-everything privilege is effectively constrained to just that specific database (as membership within "pg_read_all_data" would not otherwise be held). A rebased version is attached. Thanks again! - Kenaniah On Wed, Jun 29, 2022 at 6:45 AM Antonin Houska wrot

Re: Proposal: allow database-specific role memberships

2022-03-23 Thread Kenaniah Cerny
Hi all, cfbot is once again green as of the v7 patch: https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/37/3374 - Kenaniah

Re: Proposal: allow database-specific role memberships

2022-03-23 Thread Kenaniah Cerny
Thanks Andres, An updated patch is attached. - Kenaniah On Mon, Mar 21, 2022 at 5:40 PM Andres Freund wrote: > Hi, > > On 2022-01-22 22:56:44 +0800, Julien Rouhaud wrote: > > On Sat, Jan 22, 2022 at 05:28:05AM -0800, Kenaniah Cerny wrote: > > > Thank you s

Re: Parameter for planner estimate of recursive queries

2022-01-22 Thread Kenaniah Cerny
> The factor 10 should not be hardcoded in the planner, but should be settable, just as cursor_tuple_fraction is. I feel considerably out of my depth here, but I like the idea of a working table size multiplier GUC, given the challenges of predicting the number of iterations (and any adjustments t

Re: Proposal: allow database-specific role memberships

2022-01-22 Thread Kenaniah Cerny
Thank you so much for the backtrace! This latest patch should address by moving the dumpRoleMembership call to before the pointer is closed. On Sat, Jan 22, 2022 at 1:11 AM Julien Rouhaud wrote: > Hi, > > On Fri, Jan 21, 2022 at 07:01:21PM -0800, Kenaniah Cerny wrote: > >

Re: Proposal: allow database-specific role memberships

2022-01-21 Thread Kenaniah Cerny
3:04 PM David G. Johnston < david.g.johns...@gmail.com> wrote: > On Fri, Jan 21, 2022 at 3:12 PM Kenaniah Cerny wrote: > >> The latest rebased version of the patch is attached. >> > > As I was just reminded, we tend to avoid specifying specific PostgreSQL > versi

Re: Proposal: allow database-specific role memberships

2022-01-21 Thread Kenaniah Cerny
The latest rebased version of the patch is attached. On Tue, Jan 11, 2022 at 11:01 PM Julien Rouhaud wrote: > Hi, > > On Thu, Dec 2, 2021 at 2:26 AM Kenaniah Cerny wrote: > > > > Attached is a rebased version of the patch that omits catversion.h in > order to avoid conf

Re: Proposal: allow database-specific role memberships

2021-12-01 Thread Kenaniah Cerny
Thank you for the advice! Attached is a rebased version of the patch that omits catversion.h in order to avoid conflicts. On Wed, Nov 17, 2021 at 6:17 AM Daniel Gustafsson wrote: > > On 28 Oct 2021, at 21:39, Kenaniah Cerny wrote: > > > Thank you Asif. A rebased patch is att

Re: Proposal: allow database-specific role memberships

2021-10-28 Thread Kenaniah Cerny
Thank you Asif. A rebased patch is attached. On Thu, Oct 28, 2021 at 11:04 AM Asif Rehman wrote: > The following review has been posted through the commitfest application: > make installcheck-world: not tested > Implements feature: not tested > Spec compliant: not tested > Docum

Re: Proposal: allow database-specific role memberships

2021-10-24 Thread Kenaniah Cerny
Hi all, Thank you for the feedback so far! Attached is a completed implementation (including tests and documentation). Based on the feedback I have received so far, I will be submitting this implementation to the commitfest. Thanks again, Kenaniah On Mon, Oct 11, 2021 at 9:05 AM Stephen Frost

Proposal: allow database-specific role memberships

2021-10-10 Thread Kenaniah Cerny
Hi all, In building off of prior art regarding the 'pg_read_all_data' and 'pg_write_all_data' roles, I would like to propose an extension to roles that would allow for database-specific role memberships (for the purpose of granting database-specific privileges) as an additional layer of abstractio