v17 attached adds a (missing) reference to C14N 1.1 specification.
JimFrom e5d1b74af7ff17eaa4ef35cdeaa8305fcad6ce6f Mon Sep 17 00:00:00 2001
From: Jim Jones
Date: Mon, 7 Apr 2025 14:00:16 +0200
Subject: [PATCH v17] Add xmlcanonicalize function
This patch adds the xmlcanonicalize function, which
mFrom 28f7c62de548468c8fb15ba95d4a68e2fdf0528e Mon Sep 17 00:00:00 2001
From: Jim Jones
Date: Fri, 21 Mar 2025 09:46:49 +0100
Subject: [PATCH v16] Add xmlcanonicalize function
This patch adds the xmlcanonicalize function, which transforms an
XML document into its canonical form according to the W3C Canonical
XML Ve
On 15.03.25 07:12, Laurenz Albe wrote:
> ... and here is v7, improved in the spirit of
> https://postgr.es/m/E132D362-A669-4606-AFE1-B45C9DFCC141%40yesql.se
I just revisited this patch and v7 passes all tests from [1,2].
LGTM.
Best regards, Jim
[1] -
https://www.postgresql.org/message-id/2055
On 12.03.25 09:00, jian he wrote:
>> 1) WARNING might be a better fit than NOTICE here.
>>
> but NOTICE, on_errror set_to_null is aligned with on_errror ignore.
>
>> I would still leave the extra messages from "log_verbosity verbose" as
>> NOTICE though. What do you think?
>>
>>
> When LOG_V
Hi
On 12.03.25 08:21, newtglobal postgresql_contributors wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, failed
> Implements feature: tested, failed
> Spec compliant: tested, failed
> Documentation:te
Hi Jian
On 07.03.25 04:48, jian he wrote:
> hi.
> rebase only.
I revisited this patch today. It applies and builds cleanly, and it
works as expected.
Some tests and minor comments:
1) WARNING might be a better fit than NOTICE here.
postgres=# \pset null NULL
Null display is "NULL".
post
On 11.03.25 10:46, Laurenz Albe wrote:
> Thanks for the thorough test!
>
>> There are a few issues though ...
>>
>> 1) Invalid codes aren't rejected. Is there any way to validate them?
>>
>> postgres=# SET log_suppress_errcodes TO '0foo1'; SHOW log_suppress_errcodes;
>> SET
>> log_suppress_errco
Hi Laurenz
On 18.06.24 18:49, Laurenz Albe wrote:
> I have attached a new version that leaves the parameter empty by default.
I've tested this patch and for the most part it works as intended. For
convenience, I wrote a small function to simulate the exceptions using a
given errcode:
CREATE OR
Hi
On 27.02.25 15:37, vignesh C wrote:
> Here is a rebased version along with the test failure fixes, please
> accept the change if you are ok with it.
Patch LGTM. +1
It applies cleanly and works as described:
== pg_dump ==
$ /usr/local/postgres-dev/bin/pg_dump db > dump.out
$ grep "POLICY"
Hi Vignesh
On 05.03.25 10:22, vignesh C wrote:
> The following "Ready for committer" patches needs rebase
> ---
> Truncate logs by max_log_size - Kirill Gavrilov
>
> Patch owners, please provide a rebased version to prepare it for
> reviewers and committers.
Is
On 27.02.25 14:54, Greg Sabino Mullane wrote:
> Great question. I think "supposed to" is a bit of a stretch, but I
> presume it's the difference between a client connecting and using its
> connection information versus an already existing backend process,
> which is always going to be "local".
>
On 21.02.25 12:46, Michael Paquier wrote:
> One way would be to generate by yourself dumps from an older version
> by yourself, as documented by src/bin/pg_upgrade/TESTING, part DETAILS
> (the part about USE_MODULE_DB=1 is very important). Then you can
> reuse the SQL files by specifying an old
Hi Michael & Andrew
On 21.02.25 11:46, Andrew Dunstan wrote:
>> On Feb 21, 2025, at 4:55 AM, Michael Paquier wrote:
>>
>> On Fri, Feb 21, 2025 at 04:36:07AM -0500, Andrew Dunstan wrote:
>>> The fix has broken cross version upgrade test. Maybe we need to filter out
>>> NO INDENT in releases prior
On 30.09.24 10:08, Jim Jones wrote:
> On 25.09.24 18:02, Tom Lane wrote:
>> AFAICS, all we do with an embedded XML version string is pass it to
>> libxml2's xmlNewDoc(), which is the authority on whether it means
>> anything. I'd be inclined to do the same here.
&
CT XMLSERIALIZE(DOCUMENT '42'::xml AS text NO
INDENT) AS "xmlserialize"
Regression tests were updated accordingly.
Best regards, Jim
From ff1b261ef74ae381eb946ec675e0f116c728cee0 Mon Sep 17 00:00:00 2001
From: Jim Jones
Date: Thu, 20 Feb 2025 14:08:04 +0100
Subject: [PATCH v1] Fix m
https://www.postgresql.org/message-id/CAFj8pRC24FEBNfTUrDgAK8f2nqDVvzWCuq%3DR%3DT19nUjL9GuLBA%40mail.gmail.com
From 93ea0e1b07763bca7ffb1d4cf88cc380640604cb Mon Sep 17 00:00:00 2001
From: Jim Jones
Date: Thu, 20 Feb 2025 09:58:34 +0100
Subject: [PATCH v6] Add XMLNamespaces option to XMLElement
This patch add
On 12.09.24 12:56, Jim Jones wrote:
> v14 attached adds the function xmlcanonicalize, as suggested.
rebase.
Best regards, Jim
From 2121e54145eae40c8a6c172038ca3a4d07f9b78a Mon Sep 17 00:00:00 2001
From: Jim Jones
Date: Mon, 17 Feb 2025 12:05:34 +0100
Subject: [PATCH v15] Add xmlcanonical
Hi Kirill
On 31.01.25 11:46, Kirill Gavrilov wrote:
> Sorry for the long silence. I fixed the indentation and a trailing
> whitespace. Should look fine now.
The patch applies cleanly, the documentation is clear, and all tests pass.
It is possible to change this new parameter session-wise, whic
Hi Robert
On 28.01.25 05:54, Robert Treat wrote:
> Was playing around with the patch and was thinking about this wording:
> "The xmldocument function returns the input argument
> unchanged... and is provided for compatibility."
>
> When I run an example similar to the db2 example you gave earlier
On 21.01.25 11:48, Umar Hayat wrote:
> For XMLAttributes attribute it should have ColumnRef/Expr because
> that's the data/content we want to generate. But namespaces and xml
> tags, IMO they should be considered as part of the structure/schema of
> XML. Allowing namespaces (default or otherwise)
Hi Chapman & Pavel
On 25.01.25 16:05, Pavel Stehule wrote:
>
>
> so 25. 1. 2025 v 15:10 odesílatel Chapman Flack napsal:
>
> On 01/25/25 02:16, Pavel Stehule wrote:
> > because the function does nothing, then it is useless to convert
> input to
> > XML and force detosting
> >
On 25.01.25 11:50, Pavel Stehule wrote:
> you still forces detoasting (inside PG_GETARG_XML_P)
Ah, ok .. I overlooked it. You meant _DATUM instead of _XML_P
Fixed in v8.
Thanks!
Best, Jim
From 43cb30a6348a2e7b9911f8bb82e1ec8359b668f0 Mon Sep 17 00:00:00 2001
From: Jim Jones
Date: Fri,
On 25.01.25 08:16, Pavel Stehule wrote:
> because the function does nothing, then it is useless to convert input
> to XML and force detosting
Right. Fixed in v7 attached.
Thanks
Best, Jim
From f4dc90994fc42879c7ab522bd9a03032be9a936c Mon Sep 17 00:00:00 2001
From: Jim Jones
Date: Fri,
necessary.
v6 attached.
Thanks.
Best regards, JimFrom 44ca7b7664d7fe49b95ced79c51d1b5f55741b81 Mon Sep 17 00:00:00 2001
From: Jim Jones
Date: Fri, 24 Jan 2025 20:51:00 +0100
Subject: [PATCH v6] Add XMLDocument function (SQL/XML X030)
This patch adds the SQL/XML X030 function XMLDocument. It
non-null value of the XML
type already has that structure, making any additional processing by
this function unnecessary.
---
Is it ok like this?
Best regards, Jim
From 8b3b5b451f0a2fd9c70ce8c96b46f0eda4be8be3 Mon Sep 17 00:00:00 2001
From: Jim Jones
Date: Fri, 24 Jan 2025 20:51:00 +0
On 24.01.25 13:48, Pavel Stehule wrote:
> Lot of users use XML functions without XMLDOCUMENT now. The doc should to
> help with a reply to question where and when I need (I can) use this
> function. This should
> be in context of Postgres where every XML expr returns XML value, so
> sentence
> cr
On 24.01.25 12:31, Pavel Stehule wrote:
> I don't know what it means - `function returns a document node` in the
> context of Postgres implementation of XML.
> I miss the information so it returns an input argument without
> changing anything, because in a system, where XML expression
> holds a c
Hi
On 24.01.25 07:28, Pavel Stehule wrote:
> I think documentation should be strongly enhanced. This is probably
> the hardest part of this patch - explain well what this function does
> and what it doesn't.
You mean something like this? Or perhaps something more technical?
The xmldocument funct
429acf8c4a999f457ec85f Mon Sep 17 00:00:00 2001
From: Jim Jones
Date: Thu, 23 Jan 2025 15:38:07 +0100
Subject: [PATCH v4] Add XMLDocument function (SQL/XML X030)
This patch adds the SQL/XML X030 function XMLDocument. It returns
an XML document from a given XML expression. An XML document node
can
Hi Chapman & Robert
Many thanks for the input
On 22.01.25 22:35, Chapman Flack wrote:
> On 01/22/25 13:41, Robert Treat wrote:
>> So even if we are following the spec (which I think technically we may
>> not be),
> There are definite ways in which we're not following the SQL/XML spec,
> which we
On 21.01.25 23:45, Robert Treat wrote:
> Is there some concrete use case you have seen that this would help
> with? Not objecting to adding it, but you've mentioned this migration
> idea twice but it seems to me this doesn't conform with existing
> implementations, and I don't see much benefit in
hing :).
Thank you again for your help in interpreting the SQL/XML standard. Much
appreciated!
Best regards, Jim
From 200cb507fb694179fd3f452a5e81017d76fa7bb1 Mon Sep 17 00:00:00 2001
From: Jim Jones
Date: Tue, 21 Jan 2025 11:45:34 +0100
Subject: [PATCH v3] Add XMLDocument function (SQL/XML X030)
Hi Chap,
Thanks for the thorough explanation!
On 20.01.25 20:09, Chapman Flack wrote:
>> PostgreSQL does not support the RETURNING SEQUENCE or RETURNING CONTENT
>> clauses explicitly. Instead, it implicitly uses RETURNING CONTENT[2] in
>> functions that require it. Since RETURNING CONTENT implie
-
>
>
> (2 rows)
What are your concerns about supporting ColumnRef for the URI's?
It is currently supported by XMLAttributes:
CREATE TABLE t AS SELECT 'http://x.y' AS uri;
SELECT xmlelement(NAME el, xmlattributes("uri" AS att)) FROM t;
On 16.01.25 08:21, Jim Jones wrote:
> On 16.01.25 07:11, Pavel Stehule wrote:
>> It is better.
> v2 attached updates the documentation.
>> My note was related to a very different description of this
>> functionality in DB2. So if you propose this function for better
&g
base due to gram.y changes introduced in 80feb72
--
Jim
From d394083020dfca69f96f459d4852f77614934603 Mon Sep 17 00:00:00 2001
From: Jim Jones
Date: Sun, 19 Jan 2025 10:27:07 +0100
Subject: [PATCH v4] Add XMLNamespaces option to XMLElement
This patch adds the scoped option XMLNamespaces to XMLElemen
9f499d8fda276df08739babe8360c0bee85c Mon Sep 17 00:00:00 2001
From: Jim Jones
Date: Thu, 16 Jan 2025 07:55:21 +0100
Subject: [PATCH v2] Add XMLDocument function (SQL/XML X030)
This patch adds the SQL/XML X030 function XMLDocument. It returns
an XML document from a given XML expression. An XML docum
Hi Pavel
On 14.01.25 09:14, Pavel Stehule wrote:
> I did some research and the design of this document is different
>
> 1. Oracle doesn't support this
> 2. DB2 has different implementations for z/OS (variadic) and for unix
> (nonvariadic)
> 3. looks so db2 allows some concatenation of xml content
Hi Umar, Hi Pavel,
On 26.12.24 14:46, Jim Jones wrote:
> The idea of NO DEFAULT is pretty much to free an element (and its
> children) from a previous DEFAULT in the same scope.
>
> SELECT
> xmlserialize(DOCUMENT
> xmlelement(NAME "root",
> xmlna
f38c714220be8f2f4f939bedc46d8630ec5cd6dc Mon Sep 17 00:00:00 2001
From: Jim Jones
Date: Mon, 30 Dec 2024 09:57:05 +0100
Subject: [PATCH v5] Add XMLCast function (SQL/XML X025)
This implements the SQL/XML function xmlcast, which enables
conversions between SQL data types and the XML data type.
XMLCAST
like DEFAULT NULL only in the root element
would make things clearer? The SQL/XML spec doesn't say anything
specific about it, but DB2 had the same thought[1]. For reference, here
are the regress tests[2] of this patch tested with the DB2 implementation.
> On Sat, 21 Dec 2024 at 14:57, Pavel
rmXmlExpr() it seemed convenient to use the same parameters to
store the prefixes and URIs as in XMLAttributes (arg_names and
named_args), but I am still not so sure it is the right approach. Is
there perhaps a better way?
Any thoughts? Feedback welcome!
Best, Jim
From 8dee3772be0d89b3d49eff17344
Hi Andrew
On 10.12.24 14:59, Andrew Dunstan wrote:
> LGTM at a first glance.
>
>
> Please add this to the next CommitFest if you haven't done already.
Thanks!
This is the CF entry: https://commitfest.postgresql.org/51/5431/
Best, Jim
On 04.12.24 17:18, Jim Jones wrote:
> I'd like to propose the implementation of XMLDocument (SQL/XML X030).
> It basically returns an XML document from a given XML expression, e.g.
>
> SELECT
> xmldocument(
> xmlelement(NAME foo,
> xmlattributes(42 AS att),
&
Hi,
I'd like to propose the implementation of XMLDocument (SQL/XML X030).It
basically returns an XML document from a given XML expression, e.g.
SELECT
xmldocument(
xmlelement(NAME foo,
xmlattributes(42 AS att),
xmlelement(NAME bar,
xmlconcat('va', 'lue'))
)
);
On 29.11.24 21:57, Kirill Gavrilov wrote:
> Same thing applies to log_parameter_max_length, for example.
>
> postgres=# set log_parameter_max_length = '1foo';
> ERROR: invalid value for parameter "log_parameter_max_length": "1foo"
> HINT: Valid units for this parameter are "B", "kB", "MB", "GB
On 29.11.24 12:05, Kirill Gavrilov wrote:
> Setting max_log_size to 0 already disables truncation.
> I changed guc units to bytes, just to make it more human-friendly.
> Did some refactoring and fixed all warnings. Set default value in
> postgresql.conf.
Nice. The patch applies cleanly and
On 28.11.24 20:20, Kirill Gavrilov wrote:
> Here is version 3 of this patch. I found another place where this
> setting can be applied.
> Also added some documentation and specified that this setting
> truncates queries by size in bytes.
Thanks. It is now possible to change the parameter u
On 25.11.24 17:52, Kirill Reshke wrote:
> Hello! Please deliver the most recent patch version and fix the issues
> Jim identified [0] as the current commitfest draws to a close.
> Do not forget to include both parts of this patch (This was actually
> developed off-list, and we are now using this
Hi Andrey, Nikolay, and Kirk
On 08.11.24 04:46, Kirk Wolak wrote:
> Hackers,
> The concept was driven by an all too common support request. A user
> accidentally dropped the wrong table. (this could also be applied to
> dropping a database, etc).
>
> If we had the LSN before the drop, this w
Hi Greg
On 11.07.24 18:09, Greg Sabino Mullane wrote:
> Thanks for the review. Please find attached a new version with proper
> tabs and indenting.
>
> Cheers,
> Greg
>
I'm testing this new log prefix and I'm wondering whether the following
behaviour is expected. The value of '%L' is different in
On 12.11.24 15:59, Robert Haas wrote:
> Those are good things to check, but we also need to consider how it
> interacts with features PostgreSQL itself already has.
I totally agree. It just didn't occur to me to check how XMLTABLE()
deals with these conversions :)
> In particular,
> I'm conce
Hi Robert
Thanks for taking a look at it.
On 11.11.24 19:15, Robert Haas wrote:
> Hmm, this patch has gotten no responses for 4 months. That's kind of
> unfortunate. Sadly, there's not a whole lot that I can do to better
> the situation, because I know very little either about XML-related
> standa
rebase.
--
Jim
From a43036de62a69c00d0c5c4469af02c8ded438530 Mon Sep 17 00:00:00 2001
From: Jim Jones
Date: Sun, 10 Nov 2024 16:13:18 +0100
Subject: [PATCH v4] Add XMLCast function (SQL/XML X025)
This function implements the SQL/XML function xmlcast, which
enables conversions between SQL data
On 02.10.24 06:48, Hunaid Sohail wrote:
> Should I revert to the v34 docs for Session User, or is it fine as is?
What I tried to say is that the current description is a bit vague ---
specially "Authenticated User".
> Authenticated User: The name of the user returned by PQuser()
> Session User
On 01.10.24 17:46, Kirill Gavrilov wrote:
> My apologies, attached patch should work on master branch.
Nice.
I tested the feature and it does what it is intended to.
postgres=# SHOW max_log_size;
max_log_size
--
10
(1 row)
postgres=# INSERT INTO t VALUES (1,2,3,4,5,6,7,8,9,0);
On 27.09.24 12:36, Andrey M. Borodin wrote:
> Consider max_log_size = 10Mb. The perspective might look very different.
> It’s not about WHERE anymore. It's a guard against heavy abuse.
>
> The feature looks very important for me.
I have the same opinion. As a fail safe it sounds very useful to m
On 01.10.24 06:27, Hunaid Sohail wrote:
> There are two users in the conninfo+: 'session' and 'authenticated'.
> Both are documented.
Right. I meant "Session User"
> Authenticated User: The name of the user returned by PQuser()
> Session User: The session user's name.
Thanks
--
Jim
Hi
On 26.09.24 09:15, Hunaid Sohail wrote:
> This patch renames "Current User" to "Authenticated User" as suggested
> by me in my last email. I have also updated the documentation accordingly.
Could you perhaps in the documentation elaborate a bit more on the
difference between "Current User" and
ue had no XML declaration and
INCLUDING XMLDECLARATION was not used.
SELECT
xmlserialize(
CONTENT '42'::xml AS text
VERSION '');
xmlserialize
--
42
(1 row)
Best, Jim
From 8bcb91f8b163a9efda1de33ebb7538767c860ad9 Mon Sep 17 00:00:00 2001
From: Jim Jones
Hi,
I'm working on the flags VERSION (X076), INCLUDING XMLDECLARATION, and
EXCLUDING XMLDECLARATION (X078) for XMLSerialize, and I have a question
for SQL/XML experts on the list.
Is there any validation mechanism for VERSION ? The SQL/XML spec says
"The immediately contained in shall be '1.0'
On 16.09.24 08:51, Hunaid Sohail wrote:
> I have attached a new patch that now prints all info in tabular format
> for \conninfo+. I have also made the table output dynamic, so if the
> connection uses SSL, the columns in the table will expand accordingly.
>
It looks much cleaner now.
> I have a
On 12.09.24 12:13, jian he wrote:
> please check the attached file.
v4 applies cleanly, it works as expected, and all tests pass.
postgres=# \pset null '(NULL)'
Null display is "(NULL)".
postgres=# CREATE TEMPORARY TABLE t2 (a int, b int);
CREATE TABLE
postgres=# COPY t2 (a,b) FROM STDIN WIT
On 13.09.24 06:49, Hunaid Sohail wrote:
>
> $ bin/psql --port=5430 postgres
> psql (18devel)
> Type "help" for help.
>
> postgres=# \conninfo+
> You are connected to database "postgres" as user "hunaid" via socket
> in "/tmp" at port "5430".
> Co
On 11.09.24 13:35, Hunaid Sohail wrote:
> Hi Jim,
>
> On Wed, Sep 11, 2024 at 3:03 PM Jim Jones
> wrote:
>
> Thanks for working on this.
>
> Any particular reason for the design change? In v28 it returned a
> table
> with a single row and multi
hen the SQL committee moves in this direction.
v14 attached adds the function xmlcanonicalize, as suggested.
Thanks
--
Jim
From 08850417c9f0e1504a5e0cfbbd815c3a7aaaf7e8 Mon Sep 17 00:00:00 2001
From: Jim Jones
Date: Thu, 12 Sep 2024 12:23:34 +0200
Subject: [PATCH v14] Add xmlcanonicalize funct
On 11.09.24 10:16, Hunaid Sohail wrote:
I have made the requested changes. Now output is returned in tabular
form. Indentation/whitespace issues are fixed.
$bin/psql --port=5430 postgres
postgres=# \conninfo+
You are connected to database "postgres" as user "hunaid" via socket
in "/tmp" at p
On 10.09.24 06:32, Hunaid Sohail wrote:
>
> I have attached a rebased patch.
Thanks.
Is \conninfo+ no longer supposed to return the results in tabular form?
At least it wasn't the case till v28.
$ /usr/local/postgres-dev/bin/psql -d postgres -h 0 -c "\conninfo+"
You are connected to database
Hi there
On 26.08.24 02:00, jian he wrote:
> hi all.
> patch updated.
> simplified the code a lot.
>
> idea is same:
> COPY t_on_error_null FROM STDIN WITH (on_error set_to_null);
>
> If the STDIN number of columns is the same as the target table, then
> InputFunctionCallSafe
> call failure will
Hi Hunaid
On 02.08.24 14:11, Hunaid Sohail wrote:
>
> I have also edited the documentation and added it to the patch. Please
> let me know if any changes are required.
>
I just wanted to review this patch again but v30 does not apply
=== Applying patches on top of PostgreSQL commit ID
d8df7ac5c
Hi Oliver
On 08.09.24 15:56, Oliver Ford wrote:
> Whoops, yes all tests and docs pass!
Thanks for the review!
Best, Jim
ld be removed after indentation.
IIRC there's an xmlSaveToBuffer option called XML_SAVE_WSNONSIG that can
be used to preserve it.
Thanks
Best, JimFrom ba0aa7c2a822bd23a9b2ec5af07265bc3eba86ce Mon Sep 17 00:00:00 2001
From: Jim Jones
Date: Fri, 6 Sep 2024 23:48:24 +0200
Subject: [PATCH v2 2/2] Bug fix: rem
On 28.08.24 10:19, Jim Jones wrote:
> Hi,
>
> While testing a feature reported by Pavel in this thread[1] I realized
> that elements containing whitespaces between them won't be indented with
> XMLSERIALIZE( ... INDENT)
>
mmh... xmlDocContentDumpOutput seems to add a
v13 attached removes two variables that were left unused after
refactoring parsenodes.h and primnodes.h, both booleans related to the
INDENT feature of xmlserialize.
On 30.08.24 08:05, Jim Jones wrote:
>
> On 30.08.24 06:46, Pavel Stehule wrote:
>>
>> čt 29. 8. 2024 v 23:54 od
On 30.08.24 06:46, Pavel Stehule wrote:
>
>
> čt 29. 8. 2024 v 23:54 odesílatel Jim Jones
> napsal:
>
>
> > +SELECT xmlserialize(CONTENT doc AS text CANONICAL) =
> > xmlserialize(CONTENT doc AS text CANONICAL WITH COMMENTS) FROM
> >
On 28.08.24 10:19, Jim Jones wrote:
> Hi,
>
> While testing a feature reported by Pavel in this thread[1] I realized
> that elements containing whitespaces between them won't be indented with
> XMLSERIALIZE( ... INDENT)
>
> SELECT xmlserialize(DOCUMENT '42'
On 29.08.24 20:50, Pavel Stehule wrote:
>
> I know, but theoretically, there can be some benefit for CANONICAL if
> pg supports bytea there. Lot of databases still use non utf8 encoding.
>
> It is a more theoretical question - if pg supports different types
> there in future (because SQL/XML or
Hi,
While testing a feature reported by Pavel in this thread[1] I realized
that elements containing whitespaces between them won't be indented with
XMLSERIALIZE( ... INDENT)
SELECT xmlserialize(DOCUMENT '42' AS text INDENT);
xmlserialize
-
+
42+
+
(
On 26.08.24 16:59, Pavel Stehule wrote:
>
> 1. what about behaviour of NO INDENT - the implementation is not too
> old, so it can be changed if we want (I think), and it is better to do
> early than too late
While checking the feasibility of removing indentation with NO INDENT I
may have found
On 26.08.24 14:15, Pavel Stehule wrote:
> I am not strongly against enhancing XMLSERIALIZE, but it can be nice
> to see some wider concept first. Currently the state looks just random
> - and I didn't see any serious discussion about implementation fo
> SQL/XML. We don't need to be necessarily c
On 26.08.24 12:30, Pavel Stehule wrote:
> I think so there should be specified the target of CANONICAL - it is a
> partial replacement of NO INDENT or it produces format just for
> comparing? The CANONICAL format is not probably extra standardized,
> because libxml2 removes indenting, but examp
Hi Pavel
On 25.08.24 20:57, Pavel Stehule wrote:
>
> There is unwanted white space in the patch
>
> -<-><--><-->xmlFreeDoc(doc);
> +<->else if (format == XMLSERIALIZE_CANONICAL || format ==
> XMLSERIALIZE_CANONICAL_WITH_NO_COMMENTS)
> + <>{
> +<-><-->xmlChar *xmlbuf = NULL;
> +<-><-->int
On 05.07.24 16:18, Jim Jones wrote:
> On 02.07.24 18:02, Jim Jones wrote:
>> It basically does the following:
>>
>> * When casting an XML value to a SQL data type, XML values containing
>> XSD literals will be converted to their equivalent SQL data type.
>> * Whe
On 19.06.24 10:59, Jim Jones wrote:
> On 09.02.24 14:19, Jim Jones wrote:
>> v9 attached with rebase due to changes done to primnodes.h in 615f5f6
>>
> v10 attached with rebase due to changes in primnodes, parsenodes.h, and
> gram.y
>
v11 attached with rebase due to change
On 02.07.24 18:02, Jim Jones wrote:
> It basically does the following:
>
> * When casting an XML value to a SQL data type, XML values containing
> XSD literals will be converted to their equivalent SQL data type.
> * When casting from a SQL data type to XML, the cast operand will
3'::xml AS numeric);
xmlcast
-
42.73
(1 row)
SELECT xmlcast(42730102030405 AS xml);
xmlcast
42730102030405
(1 row)
Is it starting in the right direction? Any feedback would be much
appreciated.
Best,
JimFrom 945a18ba2ee20b32e5694c4285f44a70c913151b Mon Sep 17
Hi Andy
On 08.06.24 08:05, Andy Fan wrote:
> Here is a new function which could produce an array of numbers with a
> controllable array length and duplicated elements in these arrays. I
> used it when working with gin index, and I think it would be helpful for
> others as well, so here it is.
>
>
On 09.02.24 14:19, Jim Jones wrote:
> v9 attached with rebase due to changes done to primnodes.h in 615f5f6
>
v10 attached with rebase due to changes in primnodes, parsenodes.h, and
gram.y
--
Jim
From fbd98149d50fe19b886b30ed49b9d553a18f30b4 Mon Sep 17 00:00:00 2001
From: Jim Jones
Dat
Hi Greg, hi David
On 01.02.24 23:39, David Christensen wrote:
> On Thu, Feb 1, 2024 at 4:34 PM Greg Sabino Mullane wrote:
>> The use of the --echo-hidden flag in psql is used to show people the way
>> psql performs its magic for its backslash commands. None of them has more
>> magic than "\d re
Hi Laurenz
On 05.03.24 13:55, Laurenz Albe wrote:
Inspired by feedback to [1], I thought about how to reduce log spam.
My experience from the field is that a lot of log spam looks like
database/table/... "xy" does not exist
duplicate key value violates unique constraint "xy"
So what abo
On 24.02.24 14:46, David E. Wheeler wrote:
> What’s the protocol for marking a patch ready for committer?
I guess after the review of the last assigned reviewer
v9 applies cleanly, all tests pass and documentation builds correctly.
Just a very small observation:
The fact that a completely in
On 16.02.24 21:31, David G. Johnston wrote:
> Yes. In particular not all columns in the table need be specified in
> the copy command so while the parsed input data is all nulls the
> record itself may not be.
Yeah, you have a point there.
I guess if users want to avoid it to happen they can r
Hi!
On 12.02.24 01:00, jian he wrote:
> attached v2.
> syntax: `on_error set_to_null`
> based on upthread discussion, now if you specified `on_error
> set_to_null` and your column has `not
> null` constraint, we convert the error field to null, so it may error
> while bulk inserting for violating
On 15.02.24 23:16, Maiquel Grassi wrote:
>
> Hi!
>
> (v16)
>
> In this version, I made a small adjustment to the indentation
> of the \conninfo code and described the columns as returned
> by \conninfo+ as suggested by Jim Jones.
>
>
I've performed the fol
On 12.02.24 15:16, Maiquel Grassi wrote:
>
> (v14)
>
>
v14 applies cleanly and the SSL info is now shown as previously
suggested. Here is a more comprehensive test:
$ /usr/local/postgres-dev/bin/psql -x "\
host=server.uni-muenster.de
hostaddr=172.19.42.1
user=jim dbname=postgres
On 05.10.23 09:38, Jim Jones wrote:
>
> v8 attached changes de default behaviour to WITH COMMENTS.
v9 attached with rebase due to changes done to primnodes.h in 615f5f6
--
Jim
From fe51a1826b75b778c21f559236b23d340a10d703 Mon Sep 17 00:00:00 2001
From: Jim Jones
Date: Fri, 9 Feb 2024 13
Hi Nathan
On 09.02.24 03:41, Nathan Bossart wrote:
> Separately, does
> the server version really belong here? I'm not sure I would consider that
> to be connection information.
>
I tend to agree with you. The info there wouldn't hurt, but perhaps the
client version would be a better fit.
--
J
Hi Erik
On 08.02.24 21:37, Erik Wienhold wrote:
> Modifiers such as + or S in \dS are not covered by autocompletion.
> src/bin/psql/tab-complete.c only specifies backslash commands in their
> basic form (without modifiers).
>
> (\dS actually autocompletes to \ds to my surprise)
>
Aha... I never no
On 08.02.24 16:50, Maiquel Grassi wrote:
> Hi Jim,
> Thank you for your support on this patch!
> As I believe in its usability, I have been dedicating efforts to make
> it really interesting.
> I hadn't thought about the permissioning issue for
> "unix_socket_directories". I appreciate that.
> I
Hi Maiquel
On 07.02.24 21:13, Maiquel Grassi wrote:
>
> I believe in v7 patch we have a quite substantial meta-command feature.
>
>
Thanks for implementing this. I find it very handy.
I was just wondering if a "permission denied" error for non-superusers
is the best choice for "\conninfo+":
post
1 - 100 of 197 matches
Mail list logo
