Re: regdatabase

2025-05-08 Thread Ian Lawrence Barwick
2025年5月8日(木) 12:41 Nathan Bossart : > > On Wed, May 07, 2025 at 10:29:43AM -0400, Greg Sabino Mullane wrote: > > On Wed, May 7, 2025 at 4:55 AM Ian Lawrence Barwick > > wrote: > >> Version which applies/builds against current HEAD attached. I haven't yet >

Re: regdatabase

2025-05-07 Thread Ian Lawrence Barwick
2025年5月7日(水) 10:47 Nathan Bossart : > > On Wed, May 07, 2025 at 09:18:28AM +0900, Ian Lawrence Barwick wrote: > > Hah, I put together a patch to implement just that a while back, but > > then concluded > > for some reason that it would likely be rejected so saved mysel

Re: regdatabase

2025-05-06 Thread Ian Lawrence Barwick
2025年5月7日(水) 4:29 Nathan Bossart : > > Every once in a while, I find myself wanting to use regdatabase for > something like current_database()::regdatabase, and I'm always surprised > when I inevitably rediscover that it doesn't exist. I only found one > reference to the idea in the archives [0].

Re: jsonb_strip_nulls with arrays?

2025-03-05 Thread Ian Lawrence Barwick
Hi 2025年3月1日(土) 2:58 Florents Tselai : > Please add this to the next Commitfest at > https://commitfest.postgresql.org/52/ > > > Added ; thanks > https://commitfest.postgresql.org/patch/5260/ I see this was committed, but there's a small formatting error in the docs (extra comma in the paramete

Re: Add CASEFOLD() function.

2024-12-12 Thread Ian Lawrence Barwick
Hi 2024年12月12日(木) 18:00 Jeff Davis : > > Unicode case folding is a way to convert a string to a canonical case > for the purpose of case-insensitive matching. > > Users have long used LOWER() for that purpose, but there are a few edge > case problems: > > * Some characters have more than two cased

docs: minor typo fix for "lower(anymultirange)"

2024-04-24 Thread Ian Lawrence Barwick
Hi Here: https://www.postgresql.org/docs/current/functions-range.html#MULTIRANGE-FUNCTIONS-TABLE the description for "lower(anymultirange)": > (NULL if the multirange is empty has no lower bound). is missing "or" and should be: > (NULL if the multirange is empty or has no lower bound).

Have pg_basebackup write "dbname" in "primary_conninfo"?

2024-02-19 Thread Ian Lawrence Barwick
Hi Hi With the addition of "pg_sync_replication_slots()", there is now a use-case for including "dbname" in "primary_conninfo" and the docs have changed from stating [1]: Do not specify a database name in the primary_conninfo string. to [2]: For replication slot synchronization (see Secti

Re: Allow passing extra options to initdb for tests

2024-02-13 Thread Ian Lawrence Barwick
2024年2月7日(水) 12:51 Ian Lawrence Barwick : > > 2024年2月6日(火) 19:54 Peter Eisentraut : > > > > I'm proposing here a way to pass extra options to initdb when run > > internally during test setup in pg_regress or > > PostgreSQL::Test::Cluster's init (which cov

Re: Allow passing extra options to initdb for tests

2024-02-06 Thread Ian Lawrence Barwick
2024年2月6日(火) 19:54 Peter Eisentraut : > > I'm proposing here a way to pass extra options to initdb when run > internally during test setup in pg_regress or > PostgreSQL::Test::Cluster's init (which covers just about all test > suites other than initdb's own tests). > > For example: > > make ch

Re: doc patch: note AttributeRelationId passed to FDW validator function

2023-12-28 Thread Ian Lawrence Barwick
2023年12月28日(木) 15:37 Michael Paquier : > > On Thu, Dec 28, 2023 at 01:55:27PM +0900, Ian Lawrence Barwick wrote: > > 2023年6月7日(水) 9:08 Ian Lawrence Barwick : > >> The alternative v2 patch adds this to this list of OIDs, and also > >> formats it as an > >>

Re: doc patch: note AttributeRelationId passed to FDW validator function

2023-12-27 Thread Ian Lawrence Barwick
2023年6月7日(水) 9:08 Ian Lawrence Barwick : > > Hi > > Here: > > https://www.postgresql.org/docs/current/fdw-functions.html > > the enumeration of OIDs which might be passed as the FDW validator function's > second argument omits "AttributeRelationId" (a

Re: patch: improve "user mapping not found" error message

2023-11-19 Thread Ian Lawrence Barwick
2023年7月3日(月) 18:22 Peter Eisentraut : > > On 23.06.23 09:45, Ian Lawrence Barwick wrote: > > if (!HeapTupleIsValid(tp)) > > + { > > + ForeignServer *server = GetForeignServer(serverid); > > + > > ereport(ERROR, > &

Re: pg_stat_get_backend_subxact() and backend IDs?

2023-09-17 Thread Ian Lawrence Barwick
2023年8月31日(木) 6:56 Nathan Bossart : > > On Wed, Aug 30, 2023 at 10:56:22AM -0400, Robert Haas wrote: > > On Wed, Aug 30, 2023 at 10:27 AM Nathan Bossart > > wrote: > >> I'm about to spend way too much time writing the commit message for 0002, > >> but I plan to commit both patches sometime today.

Re: pg_stat_get_backend_subxact() and backend IDs?

2023-08-24 Thread Ian Lawrence Barwick
2023年8月25日(金) 1:19 Nathan Bossart : > > On Wed, Aug 23, 2023 at 07:51:40PM -0700, Nathan Bossart wrote: > > On Wed, Aug 23, 2023 at 07:32:06PM -0700, Nathan Bossart wrote: > >> On Thu, Aug 24, 2023 at 10:22:49AM +0900, Ian Lawrence Barwick wrote: > >>> Looki

pg_stat_get_backend_subxact() and backend IDs?

2023-08-23 Thread Ian Lawrence Barwick
Hi I was playing around with "pg_stat_get_backend_subxact()" (commit 10ea0f924) and see it emits NULL values for some backends, e.g.: postgres=# \pset null NULL Null display is "NULL". postgres=# SELECT id, pg_stat_get_backend_pid(id), s.*, pg_stat_get_backend

patch: improve "user mapping not found" error message

2023-06-23 Thread Ian Lawrence Barwick
Hi Mild corner-case annoyance while doing Random Experimental Things: postgres=# SELECT * FROM parttest; ERROR: user mapping not found for "postgres" Oky, but which server? postgres=# \det List of foreign tables Schema | Table | Server +---

doc patch: note AttributeRelationId passed to FDW validator function

2023-06-06 Thread Ian Lawrence Barwick
Hi Here: https://www.postgresql.org/docs/current/fdw-functions.html the enumeration of OIDs which might be passed as the FDW validator function's second argument omits "AttributeRelationId" (as passed when altering a foreign table's column options). Attached v1 patch adds this to this list of

Re: PG 16 draft release notes ready

2023-05-21 Thread Ian Lawrence Barwick
2023年5月19日(金) 5:49 Bruce Momjian : > > I have completed the first draft of the PG 16 release notes. You can > see the output here: > > https://momjian.us/pgsql_docs/release-16.html > > I will adjust it to the feedback I receive; that URL will quickly show > all updates. Hi Below are a f

Re: "CREATE RULE ... ON SELECT": redundant?

2023-05-03 Thread Ian Lawrence Barwick
2023年5月4日(木) 12:51 Tom Lane : > > Ian Lawrence Barwick writes: > > While poking around at an update for that, unless I'm missing something it > > is > > now not possible to use "CREATE RULE ... ON SELECT" for any kind of > > relation, > > g

"CREATE RULE ... ON SELECT": redundant?

2023-05-03 Thread Ian Lawrence Barwick
Hi Commit b23cd185f [1] forbids manual creation of ON SELECT rule on a table, and updated the main rules documentation [2], but didn't update the corresponding CREATE RULE page [3]. [1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=b23cd185fd5410e5204683933f848d4583e34b35 [2] ht

Re: Getting rid of SQLValueFunction

2022-12-29 Thread Ian Lawrence Barwick
Hi 2022年11月21日(月) 18:39 Michael Paquier : > > On Sun, Nov 20, 2022 at 03:15:34PM -0800, Ted Yu wrote: > > + * timestamp. These require a specific handling with their typmod is given > > + * by the function caller through their SQL keyword. > > > > typo: typmod is given -> typmod given > > > > Oth

Re: [PATCH] Add function to_oct

2022-12-20 Thread Ian Lawrence Barwick
2022年12月21日(水) 10:42 Eric Radman : > > On Wed, Dec 21, 2022 at 08:36:40AM +0900, Ian Lawrence Barwick wrote: > > 2022年12月21日(水) 7:08 Eric Radman :> > > > Hello! > > > > > > This patch is a new function based on the implementation of to_hex(int). > >

Re: Add LSN along with offset to error messages reported for WAL file read/write/validate header failures

2022-12-20 Thread Ian Lawrence Barwick
2022年12月20日(火) 21:35 Bharath Rupireddy : > > On Tue, Dec 20, 2022 at 1:27 PM Magnus Hagander wrote: > > > > On Tue, Dec 20, 2022 at 5:40 AM Michael Paquier wrote: > >> > >> On Tue, Dec 20, 2022 at 09:01:02AM +0900, Michael Paquier wrote: > >> > Yeah, my mind was considering as well yesterday the

Re: [PATCH] Add function to_oct

2022-12-20 Thread Ian Lawrence Barwick
2022年12月21日(水) 7:08 Eric Radman :> > Hello! > > This patch is a new function based on the implementation of to_hex(int). > > Since support for octal integer literals was added, to_oct(int) allows > octal values to be easily stored and returned in query results. > > to_oct(0o755) = '755' > > This

Re: Proposal for internal Numeric to Uint64 conversion function.

2022-12-13 Thread Ian Lawrence Barwick
2022年10月3日(月) 1:55 Andres Freund : > > Hi, > > The patch for this CF entry doesn't apply currently, and it looks like that's > been the case for quite a while... As that's remained the case and the last update from the author was in May, we'll close this as "returned with feedback". A new entry ca

Re: [PROPOSAL] new diagnostic items for the dynamic sql

2022-12-10 Thread Ian Lawrence Barwick
2022年8月3日(水) 7:56 Tom Lane : > > Jacob Champion writes: > > ...and Dinesh's email has just bounced back undelivered. :( > > > Anybody interested in running with this? If no one speaks up, I think we > > should return this as "needs more interest" before the next CF starts. > > Meh ... the last ver

Re: Allow parallel plan for referential integrity checks?

2022-12-10 Thread Ian Lawrence Barwick
2022年7月26日(火) 20:58 Frédéric Yhuel : > > > > On 4/14/22 14:25, Frédéric Yhuel wrote: > > > > > > On 3/19/22 01:57, Imseih (AWS), Sami wrote: > >> I looked at your patch and it's a good idea to make foreign key > >> validation > >> use parallel query on large relations. > >> > >> It would be valuabl

Re: [RFC] Add jit deform_counter

2022-12-10 Thread Ian Lawrence Barwick
2022年6月12日(日) 18:14 Dmitry Dolgov <9erthali...@gmail.com>: > > Hi, > > I've noticed that JIT performance counter generation_counter seems to include > actions, relevant for both jit_expressions and jit_tuple_deforming options. It > means one can't directly see what is the influence of jit_tuple_def

Re: pg_rewind race condition just after promotion

2022-12-10 Thread Ian Lawrence Barwick
2021年11月9日(火) 20:31 Daniel Gustafsson : > > > On 14 Jul 2021, at 14:03, Aleksander Alekseev > > wrote: > > > > The following review has been posted through the commitfest application: > > make installcheck-world: tested, passed > > Implements feature: tested, passed > > Spec compliant:

Re: docs: add missing id elements for developer GUCs

2022-12-05 Thread Ian Lawrence Barwick
2022年12月5日(月) 11:25 Michael Paquier : > > On Sat, Dec 03, 2022 at 03:58:19PM +0900, Ian Lawrence Barwick wrote: > > A few of the developer option GUCs were missing the "id" attribute > > in their markup, making it impossible to link to them directly. > > True en

Re: doc: add missing "id" attributes to extension packaging page

2022-12-05 Thread Ian Lawrence Barwick
2022年12月5日(月) 18:56 Alvaro Herrera : > > On 2022-Dec-05, Ian Lawrence Barwick wrote: > > > On this page: > > > > https://www.postgresql.org/docs/current/extend-extensions.html > > > > three of the sections are missing an "id" attribute; patc

Re: pg_basebackup: add test about zstd compress option

2022-12-05 Thread Ian Lawrence Barwick
2022年12月5日(月) 23:59 Robert Haas : > > On Fri, Dec 2, 2022 at 11:29 PM Ian Lawrence Barwick > wrote: > > Though on reflection maybe it's overkill and the existing tests > > suffice. Anyway leaving the patch here in the interests of pushing > > this forward in some

doc: add missing "id" attributes to extension packaging page

2022-12-04 Thread Ian Lawrence Barwick
Hi On this page: https://www.postgresql.org/docs/current/extend-extensions.html three of the sections are missing an "id" attribute; patch adds these. Noticed when trying to create a stable link to one of the affected sections. Regards Ian Barwick From c0dec489ec5b088d7e16b814aef9750ff271c6

docs: add missing id elements for developer GUCs

2022-12-02 Thread Ian Lawrence Barwick
Hi A few of the developer option GUCs were missing the "id" attribute in their markup, making it impossible to link to them directly. Specifically the entries from "trace_locks" to "log_btree_build_stats" here: https://www.postgresql.org/docs/current/runtime-config-developer.html Patch appl

Re: Think-o in foreign key comments

2022-12-02 Thread Ian Lawrence Barwick
2022年12月3日(土) 7:19 Paul Jungwirth : > > Hello, > > I noticed a few places in the new foreign key code where a comment says > "the ON DELETE SET NULL/DELETE clause". I believe it should say "ON > DELETE SET NULL/DEFAULT". > > These comments were added in d6f96ed94e7, "Allow specifying column list >

Re: pg_basebackup: add test about zstd compress option

2022-12-02 Thread Ian Lawrence Barwick
Hi I was looking at the commitfest entry for this patch [1] as it's been dormant for quite a while, with the intent of returning it with feedback. [1] https://commitfest.postgresql.org/40/3835/ 2022年8月25日(木) 16:52 Dong Wook Lee : > > On Tue, Aug 23, 2022 at 11:37 AM Michael Paquier wrote: > > >

Re: daitch_mokotoff module

2022-11-30 Thread Ian Lawrence Barwick
Hi Dag 2022年2月3日(木) 23:27 Dag Lem : > > Hi, > > Just some minor adjustments to the patch: > > * Removed call to locale-dependent toupper() > * Cleaned up input normalization This patch was marked as "Waiting on Author" in the CommitFest entry [1] but I see you provided an updated version which ha

Re: Atomic rename feature for Windows.

2022-11-30 Thread Ian Lawrence Barwick
2022年10月19日(水) 6:06 Thomas Munro : > > On Wed, Apr 6, 2022 at 10:40 AM Victor Spirin wrote: > > Updated patch: we use the posix semantic features in Windows build 17763 > > and up. > > We found an issue with this feature on Windows Server 2016 without > > updates (Windows 1607 Build 14393) > > Hi

Re: Understanding, testing and improving our Windows filesystem code

2022-11-27 Thread Ian Lawrence Barwick
2022年10月25日(火) 13:12 Thomas Munro : > > I pushed the bug fixes from this series, without their accompanying > tests. Here's a rebase of the test suite, with all those tests now > squashed into the main test patch, and also the > tell-Windows-to-be-more-like-Unix patch. Registered in the > commitf

Re: Understanding, testing and improving our Windows filesystem code

2022-11-27 Thread Ian Lawrence Barwick
2022年10月25日(火) 13:12 Thomas Munro : > > I pushed the bug fixes from this series, without their accompanying > tests. Here's a rebase of the test suite, with all those tests now > squashed into the main test patch, and also the > tell-Windows-to-be-more-like-Unix patch. Registered in the > commitf

Re: Allow file inclusion in pg_hba and pg_ident files

2022-11-27 Thread Ian Lawrence Barwick
2022年11月27日(日) 20:04 Julien Rouhaud : > > On Sun, Nov 27, 2022 at 03:39:44PM +0800, Julien Rouhaud wrote: > > Le dim. 27 nov. 2022 à 15:31, Ian Lawrence Barwick > > > > > > > > I'm trying to reconcile open CommitFest entries with their actual > > &g

Re: Allow file inclusion in pg_hba and pg_ident files

2022-11-26 Thread Ian Lawrence Barwick
2022年11月25日(金) 11:25 Julien Rouhaud : > > On Fri, Nov 25, 2022 at 07:41:59AM +0900, Michael Paquier wrote: > > On Thu, Nov 24, 2022 at 05:07:24PM +0800, Julien Rouhaud wrote: > > > So I went with CONF_FILE_START_DEPTH and CONF_FILE_MAX_DEPTH. Attached > > > v22 > > > that fixes it in all the plac

Re: Reducing power consumption on idle servers

2022-11-26 Thread Ian Lawrence Barwick
2022年11月22日(火) 5:50 Laurenz Albe : > > On Mon, 2022-11-21 at 12:11 -0500, Tom Lane wrote: > > Robert Haas writes: > > > The reason that I pushed back -- not as successfully as I would have > > > liked -- on the changes to pg_stop_backup / pg_start_backup is that I > > > know there are people using

CF 2022-11: entries "Ready for Committer" with recent activity

2022-11-26 Thread Ian Lawrence Barwick
Hi This is an overview of the current patches marked "Ready for Committer" which have been actively worked on during the current CF. They largely fall into two categories: - active participation from likely committers - have been reviewed and marked as "RfC", but need committer interest Dates in

CF 2022-11: entries "Waiting for Committer" but no recent activity

2022-11-26 Thread Ian Lawrence Barwick
Hi Apologies for the intermission in activity, among other "fun" things had a family visitation of the influenza virus, which is becoming fashionable in these parts again. In an attempt to salvage something from the situation I am having a crack at the older entries marked "Ready for Committer",

Re: [PATCH] Allow specification of custom slot for custom nodes

2022-11-26 Thread Ian Lawrence Barwick
2022年11月22日(火) 5:50 Alexander Korotkov : > > On Mon, Nov 21, 2022 at 4:34 PM Pavel Borisov wrote: > > The following review has been posted through the commitfest application: > > make installcheck-world: tested, passed > > Implements feature: tested, passed > > Spec compliant: not

Re: ps command does not show walsender's connected db

2022-11-16 Thread Ian Lawrence Barwick
2022年10月11日(火) 20:06 Bharath Rupireddy : > > On Tue, Oct 11, 2022 at 2:11 PM bt22nakamorit > wrote: > > > > 2022-10-10 16:12 Bharath Rupireddy wrote: > > > Thanks. LGTM. > > Thank you for your review! > > I have this issue posted on Commitfest 2022-11 with title "show > > walsender's connected db

Re: Parallel Full Hash Join

2022-11-16 Thread Ian Lawrence Barwick
2022年4月8日(金) 20:30 Thomas Munro : > > On Wed, Jan 12, 2022 at 10:30 AM Melanie Plageman > wrote: > > On Fri, Nov 26, 2021 at 3:11 PM Thomas Munro wrote: > > > #3 0x009cf57e in ExceptionalCondition (conditionName=0x29cae8 > > > "BarrierParticipants(&accessor->shared->batch_barrier) == 1",

Re: pglz compression performance, take two

2022-11-16 Thread Ian Lawrence Barwick
2021年11月5日(金) 14:51 Andrey Borodin : > > Thanks for the review Mark! Sorry it took too long to reply on my side. > > > 28 июня 2021 г., в 21:05, Mark Dilger > > написал(а): > > > >> #define PGLZ_HISTORY_SIZE 0x0fff - 1 /* to avoid compare in > >> iteration */ > > ... > >> static PGLZ_Hist

Re: Commit fest 2022-11

2022-11-16 Thread Ian Lawrence Barwick
2022年11月14日(月) 22:38 Ian Lawrence Barwick : > > 2022年11月14日(月) 22:23 James Coleman : > > > > On Mon, Nov 14, 2022 at 7:08 AM Ian Lawrence Barwick > > wrote: > > > > > > 2022年11月9日(水) 8:12 Justin Pryzby : > > > > > > If my script

Re: Allow file inclusion in pg_hba and pg_ident files

2022-11-15 Thread Ian Lawrence Barwick
2022年11月14日(月) 14:41 Michael Paquier : > > On Sat, Nov 12, 2022 at 04:13:53PM +0800, Julien Rouhaud wrote: > > It's looks good to me. I agree that file name and line number should be > > enough > > to diagnose any unexpected error. > > Thanks for checking. I have looked at 0001 and 0002 again wi

Re: vacuumlo: add test to vacuumlo for test coverage

2022-11-15 Thread Ian Lawrence Barwick
2022年9月3日(土) 17:28 Dong Wook Lee : > > Hi hackers, > I write a tiny patch about vacuumlo to improve test coverage. > I hope my work is meaningful. Hi While reviewing the patch backlog, we have determined that this patch adds one or more TAP tests but has not added the test to the "meson.build" fi

Re: logical decoding and replication of sequences, take 2

2022-11-15 Thread Ian Lawrence Barwick
2022年11月12日(土) 7:49 Tomas Vondra : > > Hi, > > I noticed on cfbot the patch no longer applies, so here's a rebased > version. Most of the breakage was due to the column filtering reworks, > grammar changes etc. A lot of bitrot, but mostly mechanical stuff. (...) Hi Thanks for the update patch.

Re: Testing autovacuum wraparound (including failsafe)

2022-11-15 Thread Ian Lawrence Barwick
2022年6月30日(木) 10:40 Masahiko Sawada : > > Hi, > > On Tue, Feb 1, 2022 at 11:58 AM Masahiko Sawada wrote: > > > > On Fri, Jun 11, 2021 at 10:19 AM Andres Freund wrote: > > > > > > Hi, > > > > > > On 2021-06-10 16:42:01 +0300, Anastasia Lubennikova wrote: > > > > Cool. Thank you for working on that

Re: Switching XLog source from archive to streaming when primary available

2022-11-15 Thread Ian Lawrence Barwick
2022年10月18日(火) 11:02 Bharath Rupireddy : > > On Tue, Oct 11, 2022 at 8:40 AM Nathan Bossart > wrote: > > > > On Mon, Oct 10, 2022 at 11:33:57AM +0530, Bharath Rupireddy wrote: > > > On Mon, Oct 10, 2022 at 3:17 AM Nathan Bossart > > > wrote: > > >> I wonder if it would be better to simply remov

Re: Skipping schema changes in publication

2022-11-15 Thread Ian Lawrence Barwick
2022年11月7日(月) 22:39 vignesh C : > > On Fri, 4 Nov 2022 at 08:19, Ian Lawrence Barwick wrote: > > > > Hi > > > > cfbot reports the patch no longer applies [1]. As CommitFest 2022-11 is > > currently underway, this would be an excellent time to update the patch.

Re: logical replication restrictions

2022-11-15 Thread Ian Lawrence Barwick
2022年11月14日(月) 10:09 Takamichi Osumi (Fujitsu) : > > On Tuesday, November 8, 2022 2:27 PM Kuroda, Hayato/黒田 隼人 > wrote: > > If you could not allocate a time to discuss this problem because of other > > important tasks or events, we would like to take over the thread and modify > > your patch. > >

Re: Documentation for building with meson

2022-11-15 Thread Ian Lawrence Barwick
2022年10月20日(木) 11:43 Justin Pryzby : > > On Wed, Oct 19, 2022 at 11:35:10AM -0700, samay sharma wrote: > > Creating a new thread focussed on adding docs for building Postgres with > > meson. This is a spinoff from the original thread [1] and I've attempted to > > address all the feedback provided t

Re: Commit fest 2022-11

2022-11-14 Thread Ian Lawrence Barwick
2022年11月14日(月) 22:23 James Coleman : > > On Mon, Nov 14, 2022 at 7:08 AM Ian Lawrence Barwick > wrote: > > > > 2022年11月9日(水) 8:12 Justin Pryzby : > > > > If my script is not wrong, these patches add TAP tests, but don't update > > > the requi

Re: Commit fest 2022-11

2022-11-14 Thread Ian Lawrence Barwick
2022年11月9日(水) 8:12 Justin Pryzby : > > On Thu, Nov 03, 2022 at 07:43:03PM -0500, Justin Pryzby wrote: > > On Thu, Nov 03, 2022 at 11:33:57AM +0900, Ian Lawrence Barwick wrote: > > > 2022年11月2日(水) 19:10 Greg Stark : > > > > On Tue, 1 Nov 2022 at 06:56

Re: [patch] Have psql's \d+ indicate foreign partitions

2022-11-07 Thread Ian Lawrence Barwick
2022年11月8日(火) 14:49 Michael Paquier : > > On Mon, Nov 07, 2022 at 01:43:22AM -0500, Tom Lane wrote: > > WFM. > > Okay, applied as bd95816, then. Thanks! CF entry updated accordingly. Regards Ian Barwick

Re: [patch] Have psql's \d+ indicate foreign partitions

2022-11-06 Thread Ian Lawrence Barwick
2022年11月6日(日) 1:39 Tom Lane : > > Michael Paquier writes: > > On Mon, Oct 24, 2022 at 09:44:18PM +0900, Ian Lawrence Barwick wrote: > >> Recently I have been working a lot with partitioned tables which contain a > >> mix > >> of local and foreign partitio

Re: Commit fest 2022-11

2022-11-03 Thread Ian Lawrence Barwick
2022年11月4日(金) 10:23 Ian Lawrence Barwick : > > 2022年11月4日(金) 9:43 Justin Pryzby : > > > > On Thu, Nov 03, 2022 at 11:33:57AM +0900, Ian Lawrence Barwick wrote: > > > 2022年11月2日(水) 19:10 Greg Stark : > > > > > > > > On Tue, 1 Nov 2022 at 06:56, M

Re: [PATCH] pgbench: add multiconnect option

2022-11-03 Thread Ian Lawrence Barwick
2022年4月2日(土) 22:35 Fabien COELHO : > > > > According to the cfbot this patch needs a rebase > > Indeed. v4 attached. Hi cfbot reports the patch no longer applies. As CommitFest 2022-11 is currently underway, this would be an excellent time to update the patch. Thanks Ian Barwick

Re: archive modules

2022-11-03 Thread Ian Lawrence Barwick
2022年10月16日(日) 16:36 Bharath Rupireddy : > > On Sat, Oct 15, 2022 at 3:13 AM Nathan Bossart > wrote: > > > > On Fri, Oct 14, 2022 at 11:51:30AM -0700, Nathan Bossart wrote: > > > On Fri, Oct 14, 2022 at 12:10:18PM +0530, Bharath Rupireddy wrote: > > >> 2) I think we have a problem - set archive_m

Re: Condition pushdown: why (=) is pushed down into join, but BETWEEN or >= is not?

2022-11-03 Thread Ian Lawrence Barwick
2022年7月7日(木) 20:11 Andrey Lepikhov : > > On 17/5/2022 05:00, Andy Fan wrote: > > Thanks. But I will wait to see if anyone will show interest with this. > > Or else > > Moving alone is not a great experience. > To move forward I've rebased your patchset onto new master, removed > annoying tailing b

Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL

2022-11-03 Thread Ian Lawrence Barwick
2022年5月3日(火) 8:45 David Christensen : > > ...and pushing a couple fixups pointed out by cfbot, so here's v4. Hi cfbot reports the patch no longer applies [1]. As CommitFest 2022-11 is currently underway, this would be an excellent time to update the patch. [1] http://cfbot.cputube.org/patch_40_3

Re: Skipping schema changes in publication

2022-11-03 Thread Ian Lawrence Barwick
2022年8月19日(金) 2:41 vignesh C : > > On Mon, Aug 8, 2022 at 2:53 PM vignesh C wrote: > > > > On Mon, Aug 8, 2022 at 12:46 PM vignesh C wrote: > > > > > > On Fri, Jun 3, 2022 at 3:36 PM vignesh C wrote: > > > > > > > > On Thu, May 26, 2022 at 7:04 PM osumi.takami...@fujitsu.com > > > > wrote: > >

Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication

2022-11-03 Thread Ian Lawrence Barwick
2022年8月5日(金) 22:55 Melih Mutlu : > > Hi Amit, > >> >> Why after step 4, do you need to drop the replication slot? Won't just >> >> clearing the required info from the catalog be sufficient? >> > >> > >> > The replication slots that we read from the catalog will not be used for >> > anything else a

Re: Reducing power consumption on idle servers

2022-11-03 Thread Ian Lawrence Barwick
2022年3月25日(金) 1:03 Simon Riggs : > > On Thu, 24 Mar 2022 at 15:39, Robert Haas wrote: > > > > On Thu, Mar 24, 2022 at 6:59 AM Simon Riggs > > wrote: > > > The proposals of this patch are the following, each of which can be > > > independently accepted/rejected: > > > 1. fix the sleep pattern of b

Re: Proposal to provide the facility to set binary format output for specific OID's per session

2022-11-03 Thread Ian Lawrence Barwick
2022年9月6日(火) 21:32 Dave Cramer : > > > > > On Tue, 6 Sept 2022 at 02:30, Ibrar Ahmed wrote: >> >> >> >> On Fri, Aug 12, 2022 at 5:48 PM Dave Cramer wrote: >>> >>> >>> >>> On Fri, 5 Aug 2022 at 17:51, Justin Pryzby wrote: On Tue, Jul 26, 2022 at 08:11:04AM -0400, Dave Cramer wrote:

Re: [Proposal] Page Compression for OLTP

2022-11-03 Thread Ian Lawrence Barwick
2022年7月27日(水) 2:47 chenhj : > > Hi hackers, > > I have rebase this patch and made some improvements. > > > 1. A header is added to each chunk in the pcd file, which records the chunk > of which block the chunk belongs to, and the checksum of the chunk. > > Accordingly, all pages in a compressed

Re: Commit fest 2022-11

2022-11-03 Thread Ian Lawrence Barwick
2022年11月4日(金) 9:43 Justin Pryzby : > > On Thu, Nov 03, 2022 at 11:33:57AM +0900, Ian Lawrence Barwick wrote: > > 2022年11月2日(水) 19:10 Greg Stark : > > > > > > On Tue, 1 Nov 2022 at 06:56, Michael Paquier wrote: > > > > > > > Two people showing

Re: On login trigger: take three

2022-11-03 Thread Ian Lawrence Barwick
2022年11月4日(金) 5:23 Daniel Gustafsson : > > > On 20 Sep 2022, at 16:10, Daniel Gustafsson wrote: > > > Since the original authors seems to have retired from the patch > > (I've only rebased it to try and help) I am inclined to mark it as returned > > with feedback. > > Doing so now since no updates

Re: Non-replayable WAL records through overflows and >MaxAllocSize lengths

2022-11-03 Thread Ian Lawrence Barwick
2022年10月5日(水) 16:46 Michael Paquier : > > Hi Matthias, > > On Wed, Jul 27, 2022 at 02:07:05PM +0200, Matthias van de Meent wrote: > > My apologies for the time it took me to come back to this thread. > > > + * To accommodate some overhead, hhis MaxXLogRecordSize value allows for > > > s/hhis/this/.

Re: [PATCH] New [relation] option engine

2022-11-03 Thread Ian Lawrence Barwick
2022年7月12日(火) 13:47 Nikolay Shaplov : > > В письме от вторник, 12 июля 2022 г. 07:30:40 MSK пользователь Nikolay Shaplov > написал: > > > What about table access methods? There have been a couple attempts to > > > allow custom reloptions for table AMs. Does this patch help that use > > > case? > >

Re: SLRUs in the main buffer pool - Page Header definitions

2022-11-03 Thread Ian Lawrence Barwick
2022年9月28日(水) 10:57 Bagga, Rishu : > > Hi, > > We have been working on adding page headers to the SLRU pages, as part of the > migration for SLRU to buffer cache. We’ve incorporated Thomas Munro’s patch > and Heikki’s Storage manager changes[1] and have a patch for early feedback. > > As part of

Re: In-placre persistance change of a relation

2022-11-03 Thread Ian Lawrence Barwick
2022年9月28日(水) 17:21 Kyotaro Horiguchi : > > Just rebased. Hi cfbot reports the patch no longer applies. As CommitFest 2022-11 is currently underway, this would be an excellent time to update the patch. Thanks Ian Barwick

Re: ExecRTCheckPerms() and many prunable partitions

2022-11-03 Thread Ian Lawrence Barwick
2022年10月15日(土) 15:01 Amit Langote : > > On Fri, Oct 7, 2022 at 4:31 PM Amit Langote wrote: > > On Fri, Oct 7, 2022 at 3:49 PM Amit Langote wrote: > > > On Fri, Oct 7, 2022 at 1:25 PM Amit Langote > > > wrote: > > > > On Fri, Oct 7, 2022 at 10:04 AM Amit Langote > > > > wrote: > > > > > On Thu

Re: [PATCH] Expand character set for ltree labels

2022-11-03 Thread Ian Lawrence Barwick
2022年10月6日(木) 7:05 Garen Torikian : > > After digging into it, you are completely correct. I had to do a bit more > reading to understand the relationships between UTF-8 and wchar, but > ultimately the existing locale support works for my use case. > > Therefore I have updated the patch with thre

Re: Data is copied twice when specifying both child and parent table in publication

2022-11-03 Thread Ian Lawrence Barwick
2022年10月17日(月) 14:49 wangw.f...@fujitsu.com : > > On Wed, Oct 5, 2022 at 11:08 AM Peter Smith wrote: > > Hi Wang-san. Here are my review comments for HEAD_v12-0001 patch. > > Thanks for your comments. > > > == > > > > 1. Missing documentation. > > > > In [1] you wrote: > > > I think the behavi

Re: [PATCH] Completed unaccent dictionary with many missing characters

2022-11-03 Thread Ian Lawrence Barwick
2022年7月13日(水) 19:13 Przemysław Sztoch : > > Dear Michael P., > > 3. The matter is not that simple. When I change priorities (ie > Latin-ASCII.xml is less important than Unicode decomposition), > then "U + 33D7" changes not to pH but to PH. > In the end, I left it like it was before ... > > If you

Re: Add semi-join pushdown to postgres_fdw

2022-11-03 Thread Ian Lawrence Barwick
2022年8月30日(火) 15:58 Alexander Pyhalov : > > Ashutosh Bapat писал 2022-08-29 17:12: > > Hi Alexander, > > Thanks for working on this. It's great to see FDW join pushdown scope > > being expanded to more complex cases. > > > > I am still figuring out the implementation. It's been a while I have > > l

Re: Commit fest 2022-11

2022-11-03 Thread Ian Lawrence Barwick
2022年11月3日(木) 11:33 Ian Lawrence Barwick : > > 2022年11月2日(水) 19:10 Greg Stark : > > > > On Tue, 1 Nov 2022 at 06:56, Michael Paquier wrote: > > > > > Two people showing up to help is really great, thanks! I'll be around > > > as well this

Re: Adding CommandID to heap xlog records

2022-11-03 Thread Ian Lawrence Barwick
2022年9月30日(金) 1:04 Matthias van de Meent : > > On Wed, 28 Sept 2022 at 19:40, Bruce Momjian wrote: > > > > On Thu, Sep 22, 2022 at 11:12:32PM +0200, Matthias van de Meent wrote: > > > On Thu, 8 Sept 2022 at 23:24, Tom Lane wrote: > > > > > > > > Matthias van de Meent writes: > > > > > Please fin

Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)

2022-11-03 Thread Ian Lawrence Barwick
2022年11月3日(木) 17:15 Maxim Orlov : > > Hi! > >> >> This entry was marked "Ready for committer" in the CommitFest app but cfbot >> reports the patch no longer applies. > > Thanks for the reminder. I think, this should work. Thanks for the quick update, cfbot reports no issues. I've set the CF entry

Re: [PATCH] Add native windows on arm64 support

2022-11-03 Thread Ian Lawrence Barwick
2022年9月1日(木) 13:42 Michael Paquier : > > On Wed, Aug 31, 2022 at 10:22:06PM -0400, Tom Lane wrote: > > Michael Paquier writes: > > > The input object could also be reworked so as we would not have any > > > ordering issues, say "pre&deeppost". > > > Changing only the path, you could use "/e/n2" in

Re: Add index scan progress to pg_stat_progress_vacuum

2022-11-03 Thread Ian Lawrence Barwick
2022年11月3日(木) 1:52 Imseih (AWS), Sami : > > Attached is v13-0001--Show-progress-for-index-vacuums.patch which addresses > the latest comments. The main changes are: > > 1/ Call the parallel_vacuum_progress_report inside the AMs rather than > vacuum_delay_point. > > 2/ A Boolean when set to True in

Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)

2022-11-03 Thread Ian Lawrence Barwick
2022年10月10日(月) 18:16 Aleksander Alekseev : > > Hi hackers, > > > Sorry about that. > > No problem. > > > Thanks, Simon. Not 100% sure who exactly is invited to vote, but just > > in case here is +1 from me. These patches were "Ready for Committer" > > for several months now and are unlikely to get

Re: Improve description of XLOG_RUNNING_XACTS

2022-11-03 Thread Ian Lawrence Barwick
2022年11月2日(水) 15:24 Amit Kapila : > > On Tue, Nov 1, 2022 at 4:33 PM Amit Kapila wrote: > > > > On Tue, Nov 1, 2022 at 12:53 PM Michael Paquier wrote: > > > > > > On Mon, Oct 17, 2022 at 02:53:57PM +0900, Michael Paquier wrote: > > > > No objections from here if you want to go ahead with v3 and p

Re: Commit fest 2022-11

2022-11-02 Thread Ian Lawrence Barwick
2022年11月2日(水) 19:10 Greg Stark : > > On Tue, 1 Nov 2022 at 06:56, Michael Paquier wrote: > > > Two people showing up to help is really great, thanks! I'll be around > > as well this month, so I'll do my share of patches, as usual. > > Fwiw I can help as well -- starting next week. I can't do much

Re: Commit fest 2022-11

2022-11-01 Thread Ian Lawrence Barwick
2022年11月2日(水) 1:36 Magnus Hagander :> > On Tue, Nov 1, 2022 at 11:59 AM Michael Paquier wrote: >> >> On Tue, Nov 01, 2022 at 07:10:15PM +0900, Ian Lawrence Barwick wrote: >> > Yup, Monday by the looks of it. >> > >> > My community login is "barwi

Re: Commit fest 2022-11

2022-11-01 Thread Ian Lawrence Barwick
2022年11月1日(火) 17:59 Simon Riggs : > > On Mon, 31 Oct 2022 at 05:42, Michael Paquier wrote: > > > As per the world clock, the next commit fest will begin in 30 hours > > (11/1 0:00 AoE time). I may have missed something, but it looks like > > we have no CFM for this one yet. > > > > Opinions, thou

Re: Commit fest 2022-11

2022-11-01 Thread Ian Lawrence Barwick
2022年11月1日(火) 13:40 Michael Paquier : > > On Tue, Nov 01, 2022 at 10:01:05AM +0900, Ian Lawrence Barwick wrote: > > This is on my bucket list of things to do some day, so I guess now is as > > bad a > > time as any :). Caveat is that this will have to be a personal >

Re: Commit fest 2022-11

2022-10-31 Thread Ian Lawrence Barwick
2022年10月31日(月) 14:42 Michael Paquier : > > Hi all, > > As per the world clock, the next commit fest will begin in 30 hours > (11/1 0:00 AoE time). I may have missed something, but it looks like > we have no CFM for this one yet. ** tumbleweed ** > Opinions, thoughts or volunteers? This is on my

Re: [patch] Have psql's \d+ indicate foreign partitions

2022-10-31 Thread Ian Lawrence Barwick
2022年10月27日(木) 16:12 Alvaro Herrera : > > On 2022-Oct-24, Justin Pryzby wrote: > > > On Mon, Oct 24, 2022 at 09:44:18PM +0900, Ian Lawrence Barwick wrote: > > > > + else if (child_relkind == > > > REL

[patch] Have psql's \d+ indicate foreign partitions

2022-10-24 Thread Ian Lawrence Barwick
Hi Recently I have been working a lot with partitioned tables which contain a mix of local and foreign partitions, and find it would be very useful to be able to easily obtain an overview of which partitions are foreign and where they are located. Currently, executing "\d+" on a partitioned table

Re: doc: add entry for pg_get_partkeydef()

2022-10-12 Thread Ian Lawrence Barwick
2022年10月12日(水) 3:29 Tom Lane : > Ian Lawrence Barwick writes: > > Small patch for $subject, as the other pg_get_XXXdef() functions are > > documented > > and I was looking for this one but couldn't remember what it was called. > > Seems reasonable. Pushed with m

doc: add entry for pg_get_partkeydef()

2022-10-10 Thread Ian Lawrence Barwick
Hi Small patch for $subject, as the other pg_get_XXXdef() functions are documented and I was looking for this one but couldn't remember what it was called. Regards Ian Barwick commit 1ab855e72e077abad247cc40619b6fc7f7758983 Author: Ian Barwick Date: Mon Oct 10 22:32:31 2022 +0900 doc: ad

Re: Support TRUNCATE triggers on foreign tables

2022-07-08 Thread Ian Lawrence Barwick
2022年7月8日(金) 17:10 Yugo NAGATA : > > On Fri, 8 Jul 2022 16:50:10 +0900 > Ian Lawrence Barwick wrote: > > > 2022年7月8日(金) 14:06 Fujii Masao : > > > On 2022/07/08 11:19, Yugo NAGATA wrote: > > > >> You added "foreign tables" for BEFORE statement

  1   2   >