Re[2]: Adding a note to protocol.sgml regarding CopyData

2018-09-24 Thread Bradley DeJong
Thanks for the feedback. On 2018-09-22, Amit Kapila wrote ... > ... Why can't we just extend the current Note where it is currently ... Because information about how the protocol works belongs in the protocol documentation not in the documentation for one implementation of the protocol. Th

Re[3]: doc - improve description of default privileges

2018-09-12 Thread Bradley DeJong
on 2018-08-30, Fabien Coelho wrote ... > ... Find v3 attached. ... Hi Fabien, As we're coming up on the end of this commitfest ... Is the reviewer supposed to move this to "ready for committer" or is the author supposed to do that? Is the reviewer supposed to explicitly state "I've looked at

Re[2]: doc - improve description of default privileges

2018-08-27 Thread Bradley DeJong
Hi Fabien, Thanks for writing this up - in particular the psql backslash commands. comments on the patch ... 1) I think that adding the "This privilege is abbreviated ... when displayed." lines to the privilege descriptions is redundant. The abbreviations are already listed after the "The ent

Re[3]: Adding a note to protocol.sgml regarding CopyData

2018-08-27 Thread Bradley DeJong
On 2018-08-27, Fabien COELHO wrote ... > ... references to the protocol version lacks homogeneity. > ... I'd suggest to keep "the vX.0 protocol" for a short version, > and "the version X.0 protocol" for long ... I agree. Change made. protocol.v3.patch Description: Binary data

Re[2]: Adding a note to protocol.sgml regarding CopyData

2018-08-26 Thread Bradley DeJong
an posted to pgsql-hackers. So I > decided to post to pgsql-hackers after posting to pgsql-docs. ... OK, I think this is what you wanted. Fabian's suggestion on making the removal more assertive is included in the v2 patch. On 2018-08- Bradley DeJong wrote ... >On 2018-07-27, Tatsuo