Hello,
We've noticed a behavior that seems surprising to us.
Since DROP DATABASE now waits for a ProcSignalBarrier, it can hang up
indefinitely if the archive_command hangs.
The reason for this is that the builtin archive module doesn't process any
interrupts while the archiving command is ru
On Thu, Jul 3, 2025 at 4:21 PM Amit Kapila wrote:
>
> On Thu, Jul 3, 2025 at 10:57 AM Dilip Kumar wrote:
> >
> > On Thu, Jul 3, 2025 at 10:43 AM Amit Kapila wrote:
> > >
> > > On Thu, Jul 3, 2025 at 10:26 AM Dilip Kumar wrote:
> > > >
> > > >
> > > > You changes related to write barrier LGTM, h
On Thu, Jul 03, 2025 at 12:14:55PM +0530, Rahila Syed wrote:
>> Now for the second part with the SRF making the injection point
>> information available at SQL level. The point about adding the new
>> function in the core engine has been sticky, and I'm coming down to
>> the conclusion that I'd st
On Fri, Jul 04, 2025 at 01:26:19AM +0900, Fujii Masao wrote:
> On 2025/07/03 22:31, Andy Fan wrote:
>> I checked the fix suggested by Hayato, I think his patch is better than
>> me because his patch checks at the startup time while my patch checks at
>> each time of RecordTransactionCommit. So v3 t
On Wed, 02 Jul 2025 at 16:34, Peter Smith wrote:
> On Wed, Jul 2, 2025 at 10:22 AM Aya Iwata (Fujitsu)
> wrote:
>>
> ...
>>
>> > reloptions.c
>> > --
>> > - Changes that should be moved to the contrib module Why should in-core
>> > reloptions know about this? See for example how "
On Fri, 4 Jul 2025 10:48:26 +0700
Daniil Davydov <3daniss...@gmail.com> wrote:
> Hi,
>
> On Thu, Jul 3, 2025 at 9:18 PM Yugo Nagata wrote:
> >
> > On Tue, 1 Jul 2025 18:56:11 +0700
> > Daniil Davydov <3daniss...@gmail.com> wrote:
> >
> > > CatalogIndexInsert is kinda "popular" function. It can b
Hi Rahila,
On Fri, 4 Jul 2025 07:42:58 +0530
Rahila Syed wrote:
> Thank you for sharing the patch.
> +1 to the idea of improving the error message.
Thank you for your review.
> Please take the following points mentioned into consideration.
>
> 1. I’m considering whether there might be a more
On Tue, Jul 1, 2025 at 6:29 PM Peter Eisentraut wrote:
>
> On 16.01.25 06:38, Peter Smith wrote:
> > On Thu, Jan 16, 2025 at 3:26 PM Tom Lane wrote:
> >>
> >> Peter Smith writes:
> >>> During some recent reviews, I came across some comments mentioning
> >>> "toast" ...
> >>> TOAST is a PostgreS
On Wed, Jun 18, 2025 at 8:33 PM Ranier Vilela wrote:
> Em qua., 18 de jun. de 2025 às 07:29, Etsuro Fujita
> escreveu:
>> On Tue, Jun 17, 2025 at 11:03 PM Fujii Masao
>> wrote:
>> > On 2025/06/17 20:37, Ranier Vilela wrote:
>> > > Em ter., 17 de jun. de 2025 às 06:09, Etsuro Fujita
>> > > mail
On Fri, Jul 4, 2025 at 1:22 AM Tom Lane wrote:
>
> Dilip Kumar writes:
> > On Tue, May 20, 2025 at 1:45 PM DIPESH DHAMELIYA
> > wrote:
> >> I understand but aren't we blocking parallelism for genuine cases with
> >> a very complex query where parallelism can help to some extent to
> >> improve e
On Tue, Mar 11, 2025 at 4:23 PM jian he wrote:
>
hi.
rebase and minor tweaks.
From 44c494fd8d7fdb9d8fd5d2d2a48f49b779d1bcb9 Mon Sep 17 00:00:00 2001
From: jian he
Date: Fri, 4 Jul 2025 13:25:00 +0800
Subject: [PATCH v17 2/2] Add option force_array for COPY JSON FORMAT
force_array option can onl
Hi
fresh rebase
Regards
Pavel
From f88defc5b54a0dd138acd28e6aa2ddc2828b1ad5 Mon Sep 17 00:00:00 2001
From: "ok...@github.com"
Date: Sun, 16 Jun 2024 15:52:38 +0200
Subject: [PATCH 3/3] set plpgsql.extra_errors to "none"
Purpose of previous commit was to run tests with active strict_expr_check.
On Tue, 1 Jul 2025 at 08:20, Ajin Cherian wrote:
>
> On Mon, Jun 9, 2025 at 3:58 PM Shlok Kyal wrote:
> >
> > On Wed, 4 Jun 2025 at 16:12, Ajin Cherian wrote:
> > >
> > > On Tue, May 20, 2025 at 2:33 AM Shlok Kyal
> > > wrote:
> > > >
> > > > This approach seems better to me. I have created a
Michael Paquier writes:
> The solution is simple: we need to replace buf->content by a call to
> xmlBufferContent(). This routine exists since be803967dbec (year
> 2000), so 25 years should make that safe enough to use.
> The last batch of libxml deprecation warning fixes we have done was
> last
On Fri, Jul 04, 2025 at 01:03:01PM +0900, Michael Paquier wrote:
> A colleague, Walid Abrahim, has reported that contrib/xml2/ gives a
Oops, Walid Ibrahim. Sorry for the mistake.
--
Michael
signature.asc
Description: PGP signature
Hi all,
A colleague, Walid Abrahim, has reported that contrib/xml2/ gives a
deprecation warning when attempting to compile xpath.c with upstream
libxml2 2.14 (just checkout the top of branch 2.14):
xpath.c: In function ‘pgxmlNodeSetToText’:
xpath.c:212:17: warning: ‘content’ is deprecated [-Wdepre
On Thu, Jul 3, 2025 at 7:07 PM Ashutosh Bapat
wrote:
>
> On Thu, Jul 3, 2025 at 9:32 AM Amit Kapila wrote:
> >
> > On Wed, Jul 2, 2025 at 5:50 PM Ashutosh Bapat
> > wrote:
> > >
> > > On Wed, Jul 2, 2025 at 12:36 PM shveta malik
> > > wrote:
> > > >
> > > > On Wed, Jul 2, 2025 at 10:50 AM Ashu
Hi,
On Thu, Jul 3, 2025 at 9:18 PM Yugo Nagata wrote:
>
> On Tue, 1 Jul 2025 18:56:11 +0700
> Daniil Davydov <3daniss...@gmail.com> wrote:
>
> > CatalogIndexInsert is kinda "popular" function. It can be called in
> > different situations, not in all of which a violation of unique
> > constraint m
Hi,
On Fri, Jul 4, 2025 at 7:10 AM Fujii Masao wrote:
>
> Patch pushed. Thanks, everyone!
>
Glad to hear this. Thanks!
--
Best regards,
Daniil Davydov
Postgres Professional
On Thu, 03 Jul 2025 at 12:59, John H wrote:
> Hi,
>
> On Wed, Jul 2, 2025 at 6:40 PM Japin Li wrote:
>>
>> >
>>
>> Splitting the logs from $PGDATA is definitely better. The question is whether
>> it's worth implementing this directly in core or if a prominent note in the
>> documentation would su
Hi Yugo,
> Currently, when creating an enum type, duplicate labels are caught by a
> unique
> index on pg_enum, resulting in a generic error message.
>
> postgres=# create type t as enum ('a','b','a');
> ERROR: duplicate key value violates unique constraint
> "pg_enum_typid_label_index"
> DE
On Thu, Jul 3, 2025 at 7:06 PM Richard Guo wrote:
> This patch does not apply again, so here is a new rebase.
>
> This version also fixes an issue related to parameterized paths: if
> the RHS has LATERAL references to the LHS, unique-ification becomes
> meaningless because the RHS depends on the L
Andy Fan writes:
Hi,
> Andy Fan writes:
>
> Hi,
>
> After some coding with this subject, I think it is better redefining
> the problem and solution.
..
> Hope I have made myself clear, any feedback is welcome!
While I was registering this patch to commitfest, I found thread [1]
which wanted to
On 2025/06/04 23:43, Maxim Orlov wrote:
On Wed, 4 Jun 2025 at 16:18, Fujii Masao mailto:masao.fu...@oss.nttdata.com>> wrote:
Regardless, I think we should go ahead and apply the current patch.
Yeah, it is definitely improving things. It turns out that I made almost the
same
patch for
Hi Ashutosh dn Dmitry,
I took a look at this patch, because it's somewhat related to the NUMA
patch series I posted a couple days ago, and I've been wondering if
it makes some of the NUMA stuff harder or simpler.
I don't think it makes a bit difference (for the NUMA stuff). My main
question was w
Maksim Milyutin writes:
> Updated patchset is attached
Pushed with minor adjustments. Mainly, I didn't entirely trust
your substitutions of, eg, "COALESCE(q1)" to "COALESCE(q1, 0)".
That would produce a different result if q1 were NULL. I'm not
sure that that actually occurs in these regression
Arseniy Mukhin writes:
> On Thu, Jul 3, 2025 at 10:21 PM Tom Lane wrote:
>> If you have no further comments, I agree it's ready. Please mark
>> as RfC, just for pro-forma process.
> Done.
And pushed. Thanks for reviewing!
regards, tom lane
Alvaro Herrera writes:
> On 2025-Jul-03, Justin Pryzby wrote:
>>> Actually I think we should consider backporting to all live versions
>> If you don't backpatch it, there's no point.
> Oh yeah, you're absolutely right.
No, it'd still be useful for handling upgrades from $busted_version
to curre
Hi,
On Wed, Jul 2, 2025 at 6:40 PM Japin Li wrote:
>
> >
>
> Splitting the logs from $PGDATA is definitely better. The question is whether
> it's worth implementing this directly in core or if a prominent note in the
> documentation would suffice.
>
I can work on the documentation update as a se
On 2025-Jul-03, Justin Pryzby wrote:
> > I think from 18 on, the problem can no longer be recreated,
>
> > Actually I think we should consider backporting to all live versions
>
> If you don't backpatch it, there's no point.
Oh yeah, you're absolutely right.
--
Álvaro Herrera PostgreS
Dilip Kumar writes:
> On Tue, May 20, 2025 at 1:45 PM DIPESH DHAMELIYA
> wrote:
>> I understand but aren't we blocking parallelism for genuine cases with
>> a very complex query where parallelism can help to some extent to
>> improve execution time? Users can always rewrite a query (for example
>
On Thu, Jul 3, 2025 at 10:21 PM Tom Lane wrote:
>
> Arseniy Mukhin writes:
> > Sql file is definitely more readable now. I think the patch is ready.
> > Should I move it to "Ready for Committer" status or do we need more
> > reviews or something?
>
> If you have no further comments, I agree it's
Arseniy Mukhin writes:
> Sql file is definitely more readable now. I think the patch is ready.
> Should I move it to "Ready for Committer" status or do we need more
> reviews or something?
If you have no further comments, I agree it's ready. Please mark
as RfC, just for pro-forma process.
On Wed, Jul 2, 2025 at 8:59 PM Tom Lane wrote:
>
> Arseniy Mukhin writes:
> > Sorry, I think I wasn't clear enough. I agree with this logic, but I
> > think it implies an impossible scenario for the "equals" case. The
> > scenario where during a scan we first have keys that are less than
> > orig
> I think from 18 on, the problem can no longer be recreated,
> Actually I think we should consider backporting to all live versions
If you don't backpatch it, there's no point.
Jacob Champion writes:
> A connection with only a hostaddr (no host) can't be cancelled via
> PQcreateCancel(), because we'll crash in emitHostIdentityInfo(). The
> problem is that the synthetic connhost entry we've created for
> cancellation has an incorrect type field, which causes the following
Hello,
We seem to have forgotten about this issue. I think this is even more
pressing with the changes to 18 for not-null constraints, though
strictly speaking it's always been a problem. Here's an updated patch.
I simplified the query (no need for a recursive CTE as far as I can
tell) and updat
On 2025-Jul-03, Japin Li wrote:
> Providing two LSN formats — %X%08X for translatable messages and
> LSN_FORMAT for non-translatable ones — seems to offer no clear advantage.
>
> I'd prefer to use %X/%08X directly and add the description to the
> LSN_FORMAT_ARGS macro.
WFM.
--
Álvaro Herrera
On 2025/07/03 22:31, Andy Fan wrote:
"Hayato Kuroda (Fujitsu)" writes:
Dear Michael, Fujii-san,
Ah, indeed, so it was reported a couple of months ago. I am not sure
that the argument about all the other GUCs potentially impacted holds
much value; we are talking about a specific code path
> On 2 Jul 2025, at 13:44, Peter Eisentraut wrote:
>
> On 27.06.25 19:24, Daniel Gustafsson wrote:
>> The OpenSSL code in libpq have two issues for multithreading: the verify_cb
>> callback use a global variable to pass back error detail state and there is
>> one
>> use of strerror().
>
> Sligh
Hello,
This is an interesting proposal, thanks for posting.
On Jul 3, 2025, at 11:00, Ross Heaney wrote:
> Proposed Improvements
> Instead we can relax the assumption that it must be an integer value for k.
> To do this we split the k value into an integer and a rational part. Call
> this k
On 2025-Jun-05, Fujii Masao wrote:
> Just one small style comment: in the documentation, table constraints are
> listed in the order CHECK, NOT NULL, UNIQUE, PRIMARY KEY, etc. So it might
> be better to follow that same order in the code for consistency in all
> three places mentioned above.
Done
Hi Andres,
On 7/1/2025 10:06 PM, Andres Freund wrote:
Hi,
On 2025-07-01 09:57:18 -0400, Andres Freund wrote:
On 2025-06-26 13:07:49 +0800, Zhou, Zhiguo wrote:
This patch addresses severe LWLock contention observed on high-core systems
where hundreds of processors concurrently access frequentl
On Thu, 3 Jul 2025 23:18:12 +0900
Yugo Nagata wrote:
> On Tue, 1 Jul 2025 18:56:11 +0700
> Daniil Davydov <3daniss...@gmail.com> wrote:
> > For example, with this patch such a query : "CREATE TYPE mood AS ENUM
> > ('happy', 'sad', 'happy');"
> > Will throw this error : "operation failed due to a
Hi,
Currently, when creating an enum type, duplicate labels are caught by a unique
index on pg_enum, resulting in a generic error message.
postgres=# create type t as enum ('a','b','a');
ERROR: duplicate key value violates unique constraint
"pg_enum_typid_label_index"
DETAIL: Key (enumtypi
Hi All,
I would like to propose some improvements to the bloom filter
implementation that exists in postgres at the moment. I will describe the
changes along with a patch with some tests. I wanted to get feedback before
I spend more time on this so the patch is not production ready(WIP) but is
su
On 2025-Jun-04, * Neustradamus * wrote:
> RECALL: A lot of e-mail on bad ML addresses yet.
>
> Dear all users of the pgsql-hackers @ lists.postgresql.org mailing list,
>
> A lot of people always send e-mails to the bad mailing list address.
I agree that it would be better that people stop using
On Wed, 2 Jul 2025 at 13:21, Zhijie Hou (Fujitsu)
wrote:
>
> On Wed, Jul 2, 2025 at 2:42 PM vignesh C wrote:
>
> >
> > Hi,
> >
> > I encountered an invalid pointer access issue. Below are the steps to
> > reproduce the issue:
> ...
> > The error occurs because entry->columns is allocated in the en
On 2025-May-11, Álvaro Herrera wrote:
> So we should also have tab-completion for ALTER TABLE ADD NOT NULL, as
> in the attached. Any opinions?
I have pushed this now, adding the parens after CHECK and reordering the
options per Fujii's suggestion in another thread. I opted to push only
to mast
> On Wed, Jul 02, 2025 at 05:07:28PM +0530, Ashutosh Bapat wrote:
> > There's also the question how this is related to other patches affecting
> > shared memory - I think the most relevant one is the "shared buffers
> > online resize" by Ashutosh, simply because it touches the shared memory.
>
> I
Yes, otherwise I had to grep the commits in `git log` and find what's the
correct way to use `pg_noreturn`.
It's not a simple keyword replacement since the order has to change now:
Old: void my_worker(Datum main_arg) pg_attribute_noreturn();
New: pg_noreturn void my_worker(Datum main_arg);
I've
On Wed, Jul 2, 2025 at 5:18 PM Fujii Masao wrote:
>
> > hi.
> >
> > I’ve tested the pg_restore options --no-policies, --no-publications, and
> > --no-subscriptions locally.
>
> Thanks for updating the patch! Could you add it to the next CommitFest
> so we don't forget about it?
>
sure.
>
> > Howe
On Tue, 1 Jul 2025 18:56:11 +0700
Daniil Davydov <3daniss...@gmail.com> wrote:
> Hi,
>
> On Tue, Jul 1, 2025 at 5:47 PM Yugo Nagata wrote:
> >
> > On Mon, 30 Jun 2025 18:32:47 +0700
> > Daniil Davydov <3daniss...@gmail.com> wrote:
> >
> > > On Mon, Jun 30, 2025 at 3:47 PM Yugo Nagata wrote:
> >
On Wed, Jul 2, 2025 at 6:06 PM Tomas Vondra wrote:
>
> I'm not sure how you're rebuilding the freelist. Presumably it can
> contain buffers that are no longer valid (after shrinking). How is that
> handled to not break anything? I think the NUMA variant would do exactly
> the same thing, except th
> On 3 Jul 2025, at 15:50, Nazir Bilal Yavuz wrote:
> On Thu, 3 Jul 2025 at 16:21, Daniel Gustafsson wrote:
>> + # Like 'MESON_COMMON_FEATURES' but not shared with 'Windows - VS' task too
>> + MESON_NON_VS_FEATURES: >-
>>
>> I'm not a fan of this name, it feel a bit unintuitive to describe wh
Hi James:
Very nice to find this topic, I am recently working on this topic [1] as
well without finding this topic has been discussed before. I just go
through this thread and find it goes with a different direction with mine.
would you mind to check my soluation to see is there any case I can'
Hi,
Thank you for looking into this!
On Thu, 3 Jul 2025 at 16:21, Daniel Gustafsson wrote:
>
> > On 3 Jul 2025, at 09:27, Nazir Bilal Yavuz wrote:
> > On Wed, 2 Jul 2025 at 14:33, Peter Eisentraut wrote:
>
> >> Here is a sketch of what I mean:
> >>
> >> env:
> >> ...
> >> PG_TEST_EXTRA: ..
On Thu, Jul 3, 2025 at 9:32 AM Amit Kapila wrote:
>
> On Wed, Jul 2, 2025 at 5:50 PM Ashutosh Bapat
> wrote:
> >
> > On Wed, Jul 2, 2025 at 12:36 PM shveta malik wrote:
> > >
> > > On Wed, Jul 2, 2025 at 10:50 AM Ashutosh Bapat
> > > wrote:
> > > >
> > > > Hi All,
> > > >
> > > > The failover s
"Hayato Kuroda (Fujitsu)" writes:
> Dear Michael, Fujii-san,
>
>> Ah, indeed, so it was reported a couple of months ago. I am not sure
>> that the argument about all the other GUCs potentially impacted holds
>> much value; we are talking about a specific code path.
>
> Yeah, I did report but sad
On 2025-07-03 11:37, Masahiko Sawada wrote:
On Wed, Jul 2, 2025 at 2:46 PM torikoshia
wrote:
On 2025-07-01 14:20, Masahiko Sawada wrote:
> On Thu, Jun 12, 2025 at 3:47 AM Masahiko Sawada
> wrote:
>>
>> On Tue, Jun 10, 2025 at 1:33 PM Nathan Bossart
>> wrote:
>> >
>> > On Tue, Jun 10, 2025 at
> On 3 Jul 2025, at 09:27, Nazir Bilal Yavuz wrote:
> On Wed, 2 Jul 2025 at 14:33, Peter Eisentraut wrote:
>> Here is a sketch of what I mean:
>>
>> env:
>> ...
>> PG_TEST_EXTRA: ...
>> MESON_COMMON_ARGS: -Dauto_features=disabled -Ddocs=enabled ...
>> CONFIGURE_COMMON_ARGS: --with-gssap
Thanks for the comments!
On Wed, Jul 2, 2025 at 7:12 PM Fujii Masao wrote:
> WAL files that have already been replayed can still be read again
> for WAL archiving (if archive_mode = always) or for replication
> (if the standby is acting as a streaming replication sender or
> a logical replication
On Thu, Jul 3, 2025 at 10:57 AM Dilip Kumar wrote:
>
> On Thu, Jul 3, 2025 at 10:43 AM Amit Kapila wrote:
> >
> > On Thu, Jul 3, 2025 at 10:26 AM Dilip Kumar wrote:
> > >
> > >
> > > You changes related to write barrier LGTM, however I have question
> > > regarding below change, IIUC, in logical
On Thu, 03 Jul 2025 at 10:19, Álvaro Herrera wrote:
> On 2025-Jul-03, Michael Paquier wrote:
>
>> Yep. If you do not want this new policy to be forgotten by new paths,
>> I'd suggested to standarize that with something like that, close to
>> the existing LSN_FORMAT_ARGS():
>> #define LSN_FORMAT "
On 2025-Jun-02, jian he wrote:
> On Mon, Jun 2, 2025 at 12:13 AM Álvaro Herrera wrote:
> >
> > Hmm, I think it would be more consistent to reject the case of duplicate
> > constraints, instead of silently ignoring it. So you'd do it in the
> > loop that checks for constraints before creating any
Andrei Lepikhov 于2025年7月3日周四 17:23写道：
> On 3/7/2025 04:02, Tender Wang wrote:
> >
> >
> > Andrei Lepikhov mailto:lepi...@gmail.com>> 于2025年7
> > 月2日周三 22:29写道：
> >
> > On 30/6/2025 04:38, Tender Wang wrote:
> > > Do you think it's worth doing this?
> > >
> > >
> > > Hi
Few more concerns:
4)
In UpdateSubscriptionRelState():
if (!HeapTupleIsValid(tup))
elog(ERROR, "subscription table %u in subscription %u
does not exist",
relid, subid);
table-->relation as now it can be hit for both sequence and table.
5)
In Logic
On 2025-Jul-03, Fujii Masao wrote:
> If we go with it, I’m slightly inclined to add [ ENFORCED ] to
> the CREATE TRIGGER syntax in the docs. Without that, users might be confused
> or raise concerns that CREATE CONSTRAINT TRIGGER accepts an option
> (i.e., ENFORCED) that isn't actually documented
On 3/7/2025 04:02, Tender Wang wrote:
Andrei Lepikhov mailto:lepi...@gmail.com>> 于2025年7
月2日周三 22:29写道：
On 30/6/2025 04:38, Tender Wang wrote:
> Do you think it's worth doing this?
>
>
> Hi all,
>
> I have added this patch to commitfest[1]. I'm hoping so
On 3/7/2025 02:30, Richard Guo wrote:
On Wed, Jul 2, 2025 at 6:44 PM Andrei Lepikhov wrote:
I apologise for the confusion in my previous message. I am not
suggesting that we postpone this. Instead, I would like an explanation
of why you believe that accessing the table statistics earlier could
This is not in reviewable state, but I wanted to get a sketch of a PoC
out there and highlight some issues that will need to be tackled. The
index scan successfully populates the radix tree and the contents are
verified to match the hash table for the queries present in the
regression tests. (Now t
On 2025-Jul-03, Michael Paquier wrote:
> Yep. If you do not want this new policy to be forgotten by new paths,
> I'd suggested to standarize that with something like that, close to
> the existing LSN_FORMAT_ARGS():
> #define LSN_FORMAT "%X/%08X"
Well, the reason we didn't use a macro in the form
Hi,
On Wed, Jul 2, 2025 at 6:24 PM Peter Eisentraut wrote:
>
> On 30.06.25 05:21, Daniil Davydov wrote:
> > Hi,
> > I noticed that some asserts and cycles use magic numbers 1 and 0
> > instead of BTLessStrategyNumber and InvalidStrategy.
> > At the same time, the BTMaxStrategyNumber macro is used
On Thu, May 29, 2025 at 06:09:00AM +0800, Quan Zongliang wrote:
> Updated
Applied, with a fixed indentation.
--
Michael
signature.asc
Description: PGP signature
Hi,
Thank you for looking into this!
On Wed, 2 Jul 2025 at 14:33, Peter Eisentraut wrote:
>
> On 02.07.25 09:22, Nazir Bilal Yavuz wrote:
> > One thing I’m unsure about the patch is that all these features are
> > stored in the MESON_FEATURES environment variable in each task. I
> > wonder if it
75 matches
Mail list logo
