> On 3 Jul 2025, at 09:27, Nazir Bilal Yavuz <byavu...@gmail.com> wrote: > On Wed, 2 Jul 2025 at 14:33, Peter Eisentraut <pe...@eisentraut.org> wrote:
>> Here is a sketch of what I mean: >> >> env: >> ... >> PG_TEST_EXTRA: ... >> MESON_COMMON_ARGS: -Dauto_features=disabled -Ddocs=enabled ... >> CONFIGURE_COMMON_ARGS: --with-gssapi --with-icu --with-ldap ... > > I agree that this repetition does not look good but my idea was to be > able to see which features are enabled at one glance. I tried to apply > grouping in v2: FWIW, I didn't mind the repetition in v1 but I won't argue against the current approach either. + # Like 'MESON_COMMON_FEATURES' but not shared with 'Windows - VS' task too + MESON_NON_VS_FEATURES: >- I'm not a fan of this name, it feel a bit unintuitive to describe what it isn't instead of what it is. How about MESON_LINUX_UNIX_FEATURES or something along those lines? # disable -Dnls as the number of files it creates cause a noticable slowdown configure_script: | - %BASH% -c "meson setup -Ddebug=true -Doptimization=g -Dcassert=true -Dinjection_points=true -Db_pch=true -Dnls=disabled -DTAR=%TAR % build" + %BASH% -c "meson setup %MESON_COMMON_PG_CONFIG_ARGS% -Ddebug=true -Doptimization=g -Db_pch=true %MESON_COMMON_NON_VS_FEATURES% -D TAR=%TAR% build" The MinGW build no longer disables nls, or am I missing something? -- Daniel Gustafsson
