Pushed the patch. Thanks!
Thank you. I'm very happy !!
Using the newly introduced mechanism, we can now easily extend
the log_lock_failure GUC to support additional NOWAIT lock failures,
such as LOCK TABLE ... NOWAIT, ALTER TABLE ... NOWAIT,
ALTER MATERIALIZED VIEW ... NOWAIT, and ALTER INDEX
On Tue, Mar 18, 2025 at 09:24:06PM +1300, David Rowley wrote:
> If it's for Assert enabled builds only, then to save from having to
> look at the buffer, you could have an extra field similar to
> jumble_len, but does not get reset when the jumble buffer fills. Just
> assert that the total_jumbled
On Thu, Mar 20, 2025 at 10:37 PM Masahiko Sawada wrote:
>
> On Wed, Mar 19, 2025 at 8:15 PM Amit Kapila wrote:
> >
> > On Wed, Mar 19, 2025 at 10:43 AM Masahiko Sawada
> > wrote:
> > >
> > > On Mon, Mar 17, 2025 at 6:05 PM Euler Taveira wrote:
> > > >
> > > > On Mon, Mar 17, 2025, at 8:44 PM,
On Thu, Mar 20, 2025 at 4:33 PM Tom Lane wrote:
> While I don't care much about the filename per se, I do note that
> we embed copyright notices into most generated files. Why
> not this one?
I don't care enough to argue about it. I suppose one can make an
argument for a variety of things.
--
Hi!
Please accept this patch (though it's not finished, just functional)!
It's \pset null for boolean values
Printing tables of 't' and 'f' makes for painful-to-read output.
This provides an easy win for psql users, giving them the option to do
better. I would like all of our documentation exam
Bruce Momjian writes:
> On Thu, Mar 20, 2025 at 01:33:26PM -0700, Jacob Champion wrote:
>> So one question for the collective is -- putting Curl itself aside --
>> is having a basic-but-usable OAuth flow, out of the box, worth the
>> costs of a generic HTTP client?
> One observation is that secur
On Fri, 21 Mar 2025 at 07:54, Andrei Lepikhov wrote:
> I have some doubts here.
> The number of distinct values says something only when it has taken
> together with the number of calls.
Couldn't the reader just look at the Nested Loop's outer side row
estimate for that?
> Frequently, one of the
> > This adds a planId to pg_stat_get_activity ( not pg_stat_activity ).
> > An extension
> > can offer its own view, similar to pg_stat_activity, which can include
> > planId.
> >
> > Note that there are no documentation updates required here as we don't
> > have per-field documentation for pg_st
On Wed, Mar 19, 2025 at 01:02:54PM +0100, Christoph Berg wrote:
> You are of course right, that one-line comment was just snakeoil :D.
> Now there are proper ones, thanks.
I have been thinking about this patch for a couple of days. What
makes me unhappy in this proposal is that RangeTblEntry is a
On Fri, 21 Mar 2025 at 10:12, David Rowley wrote:
> The patch looks good to me and seems worth applying to master.
Ok. Pushed.
David
> It sounds like we're sufficiently in agreement so I've committed the
> patch.
Thanks!
> I've rebased my pg_overexplain patch and attach that here.
I spent some time playing around with this extension, and I can
see the value.
1/ provides a good example for future extensions on how to
use the
On Thu, Mar 20, 2025 at 12:54 PM Matheus Alcantara
wrote:
> Since the security checks are defined I'm attaching 0003 which include
> the fix of security checks for postgres_fdw. It implements the
> validations very similar to what are being implemented on dblink.
Comments on 0003:
> +
On Thu, Mar 20, 2025 at 1:57 PM Joe Conway wrote:
> > I LOVE this idea!
> +many
Same here. But I also agree with Andrew that it would be fantastic if
TAP tests could be made to work, too. Yet, anything beats nothing!
--
Robert Haas
EDB: http://www.enterprisedb.com
On 20/3/2025 15:03, Ilia Evdokimov wrote:
On 20.03.2025 15:32, Andrei Lepikhov wrote:
I quite frequently need the number of distinct values (or groups)
predicted during the Memoize node creation to understand why caching
is sometimes employed or not.
But I had thought about an alternative way:
On 2025-03-20 Th 10:53 AM, Andrew Dunstan wrote:
On 2025-03-19 We 2:55 PM, Tom Lane wrote:
Peter Eisentraut writes:
Committed that, thanks.
Buildfarm member snakefly doesn't like this too much. Since no other
animals have failed, I guess it must be about local conditions on
that machine, b
Hi I am working with Aidar to give a review and I am also a beginner
reviewer.
> From 813e5ec0da4c65970b4b1ce2ec2918e4652da9ab Mon Sep 17 00:00:00 2001
> From: Nazir Bilal Yavuz
> Date: Fri, 20 Dec 2024 14:06:47 +0300
> Subject: [PATCH v1 1/2] Add pg_buffercache_evict_all() function for
testing
>
On 2025-03-20 Th 9:06 AM, Peter Eisentraut wrote:
This is a quick follow-up to the extension_control_path patch. With
this little additional patch, you can now run "make check" in
PGXS-using extensions (instead of having to do make install; make
installcheck with a running instance). I thin
Hi
út 18. 3. 2025 v 21:33 odesílatel Álvaro Herrera
napsal:
> On 2025-Mar-18, Pavel Stehule wrote:
>
> > Maybe I found a bug
> >
> > (2025-03-18 19:28:06) postgres=# create table foo(a int constraint gzero
> > check(a > 10) NOT ENFORCED);
> > CREATE TABLE
> > (2025-03-18 19:29:37) postgres=# ins
On Thu, Mar 20, 2025 at 11:13 AM Nathan Bossart
wrote:
> On Thu, Mar 20, 2025 at 09:59:45AM -0700, David G. Johnston wrote:
> > I get the need for this kind of logic, since we used a boolean for the
> > table option, but as a self-proclaimed hack it seems worth more comments
> > than provided her
On Thu, Mar 20, 2025 at 4:59 AM Peter Eisentraut
wrote:
> Here is a new version of the remaining main patch set. I've made a lot
> of changes to reduce the size and scope.
>
> - In version v21, you had included a bunch of expected files in the
> "treeb" module, which wasn't necessary, since the
Hi all,
With the understanding that the patchset is no longer just "my" baby...
= Dependencies =
I like seeing risk/reward discussions. I agonized over the choice of
HTTP dependency, and I transitioned from an "easier" OAuth library
over to Curl early on because of the same tradeoffs.
That said
On Thu, Mar 20, 2025 at 11:11:46AM -0500, Nathan Bossart wrote:
> As promised, I've committed just 0001 for now. I'll watch closely for any
> issues in the buildfarm.
Seeing none, here's is a rebased patch set without 0001. The only changes
are some fleshed-out comments and commit messages. I'm
Hi!
While trying to find postgres.bki in my build directory searching for the
file name didn't work because there is no comment in the file containing
the file name; like there is in every other file we write or generate,
including the related *_d.h files. Add it.
It probably belongs before the
On Thu, Mar 20, 2025 at 2:09 PM Antonin Houska wrote:
> Robert Haas wrote:
> > Is there a README or a long comment in here someplace that is a good
> > place to read to understand the overall design of this feature?
>
> I tried to explain how it works in the commit messages. The one in 0004 is
>
On Thu, Mar 20, 2025 at 01:05:05PM -0400, Andres Freund wrote:
> On 2025-03-19 18:17:37 -0400, Andres Freund wrote:
> > On 2025-03-19 14:25:30 -0700, Noah Misch wrote:
> > > > +* marked as failed. In case of a partial read, some
> > > > buffers may be
> > > > +* ok.
On 3/20/25 13:20, David E. Wheeler wrote:
On Mar 20, 2025, at 09:06, Peter Eisentraut wrote:
>> This is a quick follow-up to the extension_control_path patch.
With this little additional patch, you can now run "make check" in
PGXS-using extensions (instead of having to do make install; make
ins
Robert Haas wrote:
> Is there a README or a long comment in here someplace that is a good
> place to read to understand the overall design of this feature?
I tried to explain how it works in the commit messages. The one in 0004 is
probably the most important one.
--
Antonin Houska
Web: https:/
On Thu, Mar 20, 2025 at 1:32 PM Alvaro Herrera wrote:
> I rebased this patch series; here's v09. No substantive changes from v08.
> I made sure the tree still compiles after each commit.
>
> I did look at 0002 again (and renamed the members of the new struct by
> adding a p_ prefix, as well as fi
On Wed, Mar 19, 2025 at 8:15 PM Amit Kapila wrote:
>
> On Wed, Mar 19, 2025 at 10:43 AM Masahiko Sawada
> wrote:
> >
> > On Mon, Mar 17, 2025 at 6:05 PM Euler Taveira wrote:
> > >
> > > On Mon, Mar 17, 2025, at 8:44 PM, Masahiko Sawada wrote:
> > >
> > > I would suggest putting the new max_acti
On Tue, 11 Mar 2025 at 11:58, Dilip Kumar wrote:
>
> On Mon, Mar 10, 2025 at 2:24 PM Mahendra Singh Thalor
> wrote:
> >
> > Hi,
> > (refer file src/bin/pg_dump/pg_backup_utils.c)
> >
> > While doing some code changes with pg_dumpall and pg_rsetore[1], we noticed
> > that on_exit_nicely_list arra
On 2025-Mar-20, jian he wrote:
> > Is it expected that a child may have VALID constraint but parent has
> > not valid constraint?
>
> but the MergeConstraintsIntoExisting logic is when
> ALTER TABLE ATTACH PARTITION,
> it expects the child table to also have an equivalent constraint
> definition o
On Mar 20, 2025, at 09:06, Peter Eisentraut wrote:
>
> This is a quick follow-up to the extension_control_path patch. With this
> little additional patch, you can now run "make check" in PGXS-using
> extensions (instead of having to do make install; make installcheck with a
> running instance
On 2025/03/12 21:57, torikoshia wrote:
Hi,
After an off-list discussion with Fujii-san, I'm now trying to modify the
following message that is output when a client attempts to connect instead of
changing the log level as the original proposal:
$ psql: error: connection to server at "loc
Hi,
On 2025-03-19 18:17:37 -0400, Andres Freund wrote:
> On 2025-03-19 14:25:30 -0700, Noah Misch wrote:
> > > + * marked as failed. In case of a partial read, some buffers
> > > may be
> > > + * ok.
> > > + */
> > > + failed =
> > > + prior_resu
On Thu, Mar 20, 2025 at 6:11 AM Jelte Fennema-Nio wrote:
> I'm not saying there's no attack possible here (although I cannot
> think of one), but we allow configuring every other SSL option using
> an env var^1. So if there is an attack possible, why would that only
> apply to being able to contro
On Thu, Mar 20, 2025 at 3:58 AM Heikki Linnakangas wrote:
>
> I'm not sure if openssl has some locking on it,
OpenSSL leaves it up to the application (us). OpenSSL 3.5 will
apparently add a builtin implementation, which from a quick skim does
use locking. As another datapoint, libcurl's implement
On 2025-Mar-20, vignesh C wrote:
> Will it help the execution time if we use --jobs in case of pg_dump
> and pg_restore wherever supported:
As I said in another thread, I think we should enable this test to run
without requiring any PG_TEST_EXTRA, because otherwise the only way to
know about prob
On Wed, Mar 19, 2025 at 09:02:42PM -0500, Nathan Bossart wrote:
> On Wed, Mar 19, 2025 at 04:28:23PM -0500, Nathan Bossart wrote:
>> On Wed, Mar 19, 2025 at 02:32:01PM -0500, Nathan Bossart wrote:
>>> In addition to testing with in-place tablespaces, we might also want to
>>> teach the transfer mod
[ redirecting to -hackers ]
I wrote:
> David Fiedler writes:
>> I've stumbled across a code that used this condition, resulting in
>> unexpected behavior. I think it worths a note that catching 0 is not
>> possible and that it results in a catch all handler.
> Hmph. The code thinks
>
On 07.03.25 10:01, Peter Eisentraut wrote:
Since lapwing no longer runs with -Werror, and might be gone completely
soon, we no longer need the various workarounds gathered over time to
avoid compiler warnings there. The attached patch reverts various
patches and makes similar adjustments to so
Committed.
--
nathan
On Wed, 19 Mar 2025 at 17:13, Ashutosh Bapat
wrote:
>
> On Thu, Mar 13, 2025 at 6:10 PM Ashutosh Bapat
> wrote:
> > >
> > > I think the fix is to explicitly pass --lc-monetary to the old cluster
> > > and the restored cluster. 003 patch in the attached patch set does
> > > that. Please check if i
On 2025-03-19 We 2:55 PM, Tom Lane wrote:
Peter Eisentraut writes:
Committed that, thanks.
Buildfarm member snakefly doesn't like this too much. Since no other
animals have failed, I guess it must be about local conditions on
that machine, but the report is pretty opaque:
# +++ tap check in
On 20/3/2025 11:37, David Rowley wrote:
I'm also slightly concerned about making struct Memoize bigger. I had
issues with a performance regression [1] for 908a96861 when increasing
the WindowAgg struct size last year and the only way I found to make
it go away was to shuffle the fields around so
On Thu, Mar 20, 2025 at 8:20 PM Ashutosh Bapat
wrote:
>
> On Thu, Mar 20, 2025 at 3:25 PM Rushabh Lathia
> wrote:
> >
> > Hi Alvaro,
> >
> > Thank you for the offline discussion.
> >
> > As we all agree, changing the attnotnull datatype would not be a good idea
> > since it is
> > a commonly us
On 2025-Mar-20, jian he wrote:
> as you can see the output of `\d+ notnull_tbl1`
> That means the pg_attribute.attnotnull definition is changed.
That's correct, it changed in that way. I propose for the new docs:
>
>
>attnotnull bool
>
>
>This column h
Matheus Alcantara писал(а) 2025-03-18 21:56:
On Fri, Mar 7, 2025 at 7:43 AM Vladlen Popolitov
wrote:
>
>> Updated patch rebased to the current master. Also I resolved the
>> problems
>> with the lookup of the compiled expressions.
>> Cached jit compiles only expressions from cached plan - they
>
> On 19/3/2025 21:51, Sami Imseih wrote:
> >> Why do you think this hook is not redundant?
> > what is it redundant with?
> >
> >> It would be better to add the parameter "type: EXPLAIN_ONLY |
> >> ANALYZE_ONLY | BOTH" to the RegisterExtensionExplainOption() routine.
> >> This value will be saved
Peter Eisentraut writes:
> On 19.03.25 20:25, Matheus Alcantara wrote:
>> On Wed, Mar 19, 2025 at 3:56 PM Tom Lane wrote:
>>> Buildfarm member snakefly doesn't like this too much.
> I was able to reproduce the problem from scratch using:
> ./configure ...
> make # no contrib
> make -C src/test
This patch set has expanded significantly in scope recently, which is
probably the right thing, but that means there won't be enough time to
review and finish it for PG18. So I'm moving this to the next
commitfest now.
On 13.03.25 15:02, Alexandra Wang wrote:
Hi Mark,
Thank you so much for
On 20.03.2025 15:32, Andrei Lepikhov wrote:
I quite frequently need the number of distinct values (or groups)
predicted during the Memoize node creation to understand why caching
is sometimes employed or not.
But I had thought about an alternative way: having an extensible
EXPLAIN (thanks to R
On 20/03/2025 11:39, Álvaro Herrera wrote:
Hello,
It seems there's rough consensus on proceeding with a connection param
and no environment variable. TBH it's not very clear to me that an
envvar is a great way to drive this, even if there weren't security
considerations at play, just considerin
> On 3/17/25 00:24, Tom Lane wrote:
> > Note the lack of any upper case. Shortly later we reverse-engineered
> > an acronym for it [2], with the winner being Tom Lockhart's
> >
> > The Oversized-Attribute Storage Technique
I (very easily) found a reference to the GSM tool:
https://linux.die
On Thu, Mar 13, 2025 at 5:49 PM Ajin Cherian wrote:
>
> Moving this patch to the next CF as this patch needs more design level
> inputs which may not be feasible in this CF but do continue to review
> the patch.
>
> regards,
> Ajin Cherian
> Fujitsu Australia
Rebased the patch as it no longer app
On 20.03.2025 13:37, David Rowley wrote:
est_entries is a uint32, so %u is the correct format character for that type.
I don't think you need to prefix all these properties with "Cache"
just because the other two properties have that prefix. I also don't
think the names you've chosen really ref
On Thu, Mar 20, 2025 at 3:06 PM Nisha Moond wrote:
>
> Attached is v6 patch with above comments addressed.
Thanks updating the patch. I have some comments:
1.
The naming style of variables changed in this function seems a bit Inconsistent
with existing ones, I feel we'd better use similar style
On Thu, Mar 20, 2025 at 3:41 PM vignesh C wrote:
>
> On Thu, 20 Mar 2025 at 10:25, Shubham Khanna
> wrote:
> >
> >
> > I have created two patches, v16-0001 and v16-0002, to address the
> > performance issue. I conducted performance testing, and here are the
> > results:
> > - The difference in ex
On Thu, Mar 20, 2025 at 10:25 AM Shubham Khanna
wrote:
>
> The attached patches contain the suggested changes.
>
I have started reviewing the patches again. Here are some review comments
+
+ -a
+ --all
+
+
+ For all source server non-template databases create s
On Thu, 20 Mar 2025 at 21:48, Ilia Evdokimov
wrote:
> -> Memoize (cost=0.30..0.41 rows=1 width=4)
>Cache Key: t2.thousand
>Cache Mode: logical
>Cache Estimated Entries: 655
>Cache Estimated NDistinct: 721
>-
On Thu, Mar 20, 2025 at 5:54 PM Rushabh Lathia wrote:
>
hi. looking at the regress tests.
+-- verify NOT NULL VALID/NOT VALID
+CREATE TABLE notnull_tbl1 (a INTEGER, b INTEGER);
+INSERT INTO notnull_tbl1 VALUES (NULL, 1);
+INSERT INTO notnull_tbl1 VALUES (NULL, 2);
+INSERT INTO notnull_tbl1 VALUES
Hello
On 2025-Mar-20, Rushabh Lathia wrote:
> Attached is another version of the patch (WIP), where I have
> introduced a new catalog column, pg_attribute.attinvalidnotnull
> (boolean). This column will default to FALSE but will be set to TRUE
> when an INVALID NOT NULL constraint is created. Wi
On Thu, 20 Mar 2025 at 10:25, Shubham Khanna
wrote:
>
>
> I have created two patches, v16-0001 and v16-0002, to address the
> performance issue. I conducted performance testing, and here are the
> results:
> - The difference in execution time between HEAD and the v15 patch was 53.2%.
> - After rem
On 19.03.25 20:25, Matheus Alcantara wrote:
On Wed, Mar 19, 2025 at 3:56 PM Tom Lane wrote:
Peter Eisentraut writes:
Committed that, thanks.
Buildfarm member snakefly doesn't like this too much. Since no other
animals have failed, I guess it must be about local conditions on
that machine,
Hello,
It seems there's rough consensus on proceeding with a connection param
and no environment variable. TBH it's not very clear to me that an
envvar is a great way to drive this, even if there weren't security
considerations at play, just considering the case of a multithreaded
program that op
On Thu, Mar 20, 2025 at 5:39 PM Ryo Kanbayashi wrote:
>
> On Mon, Jan 27, 2025 at 2:01 PM Michael Paquier wrote:
> > On Thu, Mar 13, 2025 at 08:53:49AM +0900, Ryo Kanbayashi wrote:
> > > Putting a bit of context here. Most of the Postgres hackers based in
> > > Japan had a meeting last Friday, a
Hi,
I initially applied this patch on the master branch at commit f95da9f, but I
have noticed that the latest master branch already includes a fix for this
issue. A similar patch was recently committed in e983ee9 successfully resolving
this issue. Thanks for the update and assistance!
Thanks
Dmitry / Ashutosh,
Thanks for the patch set. I've been doing some testing with it and in
particular want to see if this solution would work with hugepage bufferpool.
I ran some simple tests (outside of PG) on linux kernel v6.1, which has
this commit that added some hugepage support to mremap (
htt
On 06.07.2023 11:27, Lukas Fittl wrote:
On Thu, Jul 6, 2023 at 12:56 AM Daniel Gustafsson wrote:
Lukas: do you have an updated patch for this commitfest to address
David's
comments?
I have a draft - I should be able to post an updated patch in the next
days. Thanks for checking!
On Mon, Jan 27, 2025 at 2:01 PM Michael Paquier wrote:
> On Thu, Mar 13, 2025 at 08:53:49AM +0900, Ryo Kanbayashi wrote:
> > Putting a bit of context here. Most of the Postgres hackers based in
> > Japan had a meeting last Friday, and Kanbayashi-san has asked me about
> > patches that introduce t
On Tue, Mar 18, 2025 at 9:12 PM Andres Freund wrote:
>
> Hi,
>
> Attached is v2.10, with the following changes:
>
> - committed core AIO infrastructure patch
Hi, yay, It's happening.jpg ;)
Some thoughts about 2.10-0004:
What do you think about putting there into (io_uring patch) info
about the
Hi,
>>
> >> + if (procNumber == MyProcNumber)
> >> + {
> >> + ereport(WARNING,
> >> + errmsg("cannot return statistics for local backend"),
> >> + errhint("Use pg_backend_memory_contexts view
> instead."));
> >> + PG_RETURN_NULL();
> >> + }
> >>
> >> I
On Wed, Mar 19, 2025 at 4:18 PM Amit Kapila wrote:
>
> On Wed, Mar 19, 2025 at 11:11 AM Nisha Moond wrote:
> >
> > Please find the attached v5-0001 patch without the stats part.
> >
>
> Review:
> ===
> 1.
> + foreach_ptr(TupleTableSlot, slot, conflictSlots)
> + {
> + indexoid = lfirst_oid(lis
On 19/3/2025 21:51, Sami Imseih wrote:
Why do you think this hook is not redundant?
what is it redundant with?
It would be better to add the parameter "type: EXPLAIN_ONLY |
ANALYZE_ONLY | BOTH" to the RegisterExtensionExplainOption() routine.
This value will be saved inside the ExplainExtensio
73 matches
Mail list logo
