On Thu, Mar 20, 2025 at 3:41 PM vignesh C <vignes...@gmail.com> wrote: > > On Thu, 20 Mar 2025 at 10:25, Shubham Khanna > <khannashubham1...@gmail.com> wrote: > > > > > > I have created two patches, v16-0001 and v16-0002, to address the > > performance issue. I conducted performance testing, and here are the > > results: > > - The difference in execution time between HEAD and the v15 patch was 53.2%. > > - After removing the suggested test cases, the difference reduced to > > 36.43%, showing a significant improvement. > > > > It is still taking quite a while, can we compare with the following > too see how much extra time it takes: > a) remove insert and select verification for the all database > successful tests as all of these are logical replication verification > which is extensively tested
If the intent is to remove those, I don't think it's a good idea. Other tests may be testing replication but they don't test the setup created by --all, which consists of objects generated with names crafted by utility. Said that we should also test the behaviour when such objects already exist. But I guess randomness in generated names is hard to control. -- Best Wishes, Ashutosh Bapat
