Re: Conflict detection for update_deleted in logical replication

On Wed, Dec 25, 2024 at 8:13 AM Zhijie Hou (Fujitsu) wrote: > > On Monday, December 23, 2024 2:15 PM Kuroda, Hayato/黒田 隼人 > wrote: > > > > Dear Hou, > > > > Thanks for updating the patch. Few comments: > > Thanks for the comments! > > > 02. ErrorOnReservedSlotName() > > > > Currently the functi

Re: Document How Commit Handles Aborted Transactions

On Tue, Dec 31, 2024 at 12:50 PM David G. Johnston wrote: > > Thoughts? > > On Fri, Dec 20, 2024 at 9:02 AM David G. Johnston > wrote: >> >> Hi, >> >> The commit reference page lacks an "Outputs" section even though it is >> capable of outputting both "COMMIT" and "ROLLBACK". >> >> The attached

Re: Windows UTF8 system locale

On Wed, Dec 25, 2024 at 06:55:51PM +0300, Vladlen Popolitov wrote: > This UTF-8 feature leads to annoying test failure > (010_dump_connstr). It's not merely an annoying test failure. On Windows configured with a multibyte system locale, anyone with CREATEDB privilege can name a database such that

Re: Introduce XID age and inactive timeout based replication slot invalidation

Hi Nisha, Here are some minor review comments for patch v58-0002. == src/backend/replication/slot.c check_replication_slot_inactive_timeout: 1. + +/* + * GUC check_hook for idle_replication_slot_timeout + * + * We don't allow the value of idle_replication_slot_timeout other + * than 0 durin

Re: System views for versions reporting

On 2025-01-02 10:36:48 +0800, jian he wrote: > https://cirrus-ci.com/github/postgresql-cfbot/postgresql/cf%2F5318 > shows lots of failures, but it doesn't seem to tell you about doc build > failure. It does: https://cirrus-ci.com/task/6472750665039872?logs=docs_build#L0 [15:26:26.443] time make -

Re: System views for versions reporting

hi. https://cirrus-ci.com/github/postgresql-cfbot/postgresql/cf%2F5318 shows lots of failures, but it doesn't seem to tell you about doc build failure. + + pg_system_versions + + + pg_system_versions + + should change to + otherwise cannot build doc. + + pg_system_versions Colum

Re: Backport of CVE-2024-10978 fix to older pgsql versions (11, 9.6, and 9.4)

On Wed, Jan 1, 2025 at 08:43:40PM -0500, Roberto C. Sánchez wrote: > On Wed, Jan 01, 2025 at 01:32:18PM -0500, Bruce Momjian wrote: > > > > Actually, there is another concern. Debian users who are using these 6+ > > year-old releases might think the release is supported by the community > > and

Re: Backport of CVE-2024-10978 fix to older pgsql versions (11, 9.6, and 9.4)

On Wed, Jan 01, 2025 at 01:32:18PM -0500, Bruce Momjian wrote: > > Actually, there is another concern. Debian users who are using these 6+ > year-old releases might think the release is supported by the community > and submit bug reports to us. I can't remember anyone complaining when > we said

Re: Incorrect CHUNKHDRSZ in nodeAgg.c

On Thu, 2 Jan 2025 at 13:33, Tom Lane wrote: > > David Rowley writes: > > I think what would be more interesting is seeing if we can store the > > TupleHashEntryData.firstTuple in a bump context. > > Are you saying the same as above, or something different? I thought you only meant store the has

Re: Incorrect CHUNKHDRSZ in nodeAgg.c

David Rowley writes: > On Thu, 2 Jan 2025 at 12:18, Tom Lane wrote: >> I thought for a bit about whether we shouldn't try to account for >> palloc power-of-2-block-size overhead here. That omission would >> typically be a far larger error than the one you are fixing. However, >> given that the

Re: Incorrect CHUNKHDRSZ in nodeAgg.c

On Thu, 2 Jan 2025 at 12:18, Tom Lane wrote: > I thought for a bit about whether we shouldn't try to account for > palloc power-of-2-block-size overhead here. That omission would > typically be a far larger error than the one you are fixing. However, > given that the inputs to hash_agg_entry_siz

Re: Introduce XID age and inactive timeout based replication slot invalidation

Hi Nisha. My review comments for patch v58-0001. == src/backend/replication/slot.c InvalidatePossiblyObsoleteSlot: 1. /* - * If the slot can be acquired, do so and mark it invalidated - * immediately. Otherwise we'll signal the owning process, below, and - * retry. + * If the slot can be

Re: Typos in the code and README

On Thu, 2 Jan 2025 at 05:00, Alexander Lakhin wrote: > Please look at another collection of typos and inconsistencies introduced > during 2024: The fixes all look good to me. I see some are mine, so I will take care of pushing. Thanks for the patch. David

Re: Incorrect CHUNKHDRSZ in nodeAgg.c

David Rowley writes: > While reading nodeAgg.c, I noticed code that uses CHUNKHDRSZ to help > figure out how much memory a tuple uses so the code knows when to > spill to disk. CHUNKHDRSZ is currently set to 16 bytes, which was > fine when that code was added, but it's a few years out-of-date sin

Incorrect CHUNKHDRSZ in nodeAgg.c

While reading nodeAgg.c, I noticed code that uses CHUNKHDRSZ to help figure out how much memory a tuple uses so the code knows when to spill to disk. CHUNKHDRSZ is currently set to 16 bytes, which was fine when that code was added, but it's a few years out-of-date since c6e0fe1f2 in 2022. The att

Re: Log a warning in pg_createsubscriber for max_slot_wal_keep_size

Hi Shubham. Here are some review comments for the patch v4-0001. == Commit message. 1. The 'pg_createsubscriber' utility is updated to fetch and validate the 'max_slot_wal_keep_size' setting from the publisher. A warning is raised during the '--dry-run' mode if the configuration is set to a

Re: POC: make mxidoff 64 bits

On 27/12/2024 19:09, Maxim Orlov wrote: On Wed, 18 Dec 2024 at 13:21, Heikki Linnakangas > wrote: Does the pg_upgrade code work though, if you have that buggy situation where oldestOffsetKnown == false ? ... > >               if (!TransactionIdIsVal

Re: Non-text mode for pg_dumpall

Here, I am attaching an updated patch. I fixed some bugs of v01 patch and did some code cleanup also. TODO WIP 1: after excluding databases, we have paths of all the databases that are needed to restore so we can launch parallel workers for each database. I am studying for this part. TODO WIP 2:

Re: Backport of CVE-2024-10978 fix to older pgsql versions (11, 9.6, and 9.4)

On Tue, Dec 31, 2024 at 03:52:07PM -0500, Bruce Momjian wrote: > On Tue, Dec 31, 2024 at 01:47:19PM -0700, David G. Johnston wrote: > > On Tue, Dec 31, 2024 at 1:30 PM Bruce Momjian wrote: > > > > On Tue, Dec 31, 2024 at 03:19:25PM -0500, Roberto C. Sánchez wrote: > > > > > My thinking w

Re: Improving tracking/processing of buildfarm test failures

Hello hackers, Please take a look at the December report on buildfarm failures: # SELECT br, count(*) FROM failures WHERE dt >= '2024-12-01' AND  dt < '2025-01-01' GROUP BY br; REL_13_STABLE: 6 REL_14_STABLE: 5 REL_15_STABLE: 4 REL_16_STABLE: 6 REL_17_STABLE: 13 master: 67 -- Total: 101 (Counting

Re: Revisiting {CREATE INDEX, REINDEX} CONCURRENTLY improvements

Hello everyone, My apologies, I probably forgot to attach the images with the benchmark results in my previous email. Please find them attached to this message. Best regards, Mikhail

Re: Typos in the code and README

Hello hackers, 03.09.2024 08:51, Michael Paquier wrote: And done that. Please look at another collection of typos and inconsistencies introduced during 2024: behvior -> behavior contraint -> constraint curent -> current disable_node -> disabled_nodes disabled_node > disabled_nodes disable

Re: Proposal to Enable/Disable Index using ALTER INDEX (with patch)

Hello! > Given this is working as expected, would we still need a migration step? No, it is clear now. Thanks for explaining. Best regards, Mikhail.

Re: Conflict detection for update_deleted in logical replication

On Wed, Dec 25, 2024 at 8:13 AM Zhijie Hou (Fujitsu) wrote: > > Attach the new version patch set which addressed all other comments. > Review comments on 0001 and 0002 = 1. /* + * Reset all data fields except those used to determine the timing for the + * next round of