On Sat, 5 Oct 2024 at 03:03, Robert Haas wrote:
> I tend to gravitate
> toward displaying things exactly as they exist internally because I've
> had so many bad experiences with having to try to reverse-engineer the
> value stored internally from whatever is printed.
Thanks for explaining your po
On Fri, Oct 4, 2024 at 7:25 PM Christoph Berg wrote:
>
> All,
>
> The PostgreSQL Contributor Page
> (https://www.postgresql.org/community/contributors/) includes people who have
> made substantial, long-term contributions of time and effort to the PostgreSQL
> project. The PostgreSQL Contributors
> Hi
>
> pá 4. 10. 2024 v 15:16 odesílatel Tatsuo Ishii
> napsal:
>
>> Sorry if this has been discussed before.
>>
>> I wonder why SET ROLE command does not produce a parameter status
>> message noticing the new current_user. Note that SET
>> SESSION_AUTHORIZATION command produces a parameter st
Amaan Haque writes:
> Im trying to create an AST representation of a query for the `INSERT`
> operation. ...
> I found through logs that the error originates from line 2053 in
> `NodeFuncs.c`. I cant correlate the unrecognized node to any enum value in
> `Nodes.h`. Any pointers on how to nav
The patch looks good to me.
The URI parsing process has become more stringent, allowing for accurate
handling of leading and trailing whitespace. Additionally, a feature has
been implemented to detect errors when extraneous data is present at the
end of the URI. The proper functioning of these cha
I'm running version 16. I'm working with a table structure as follows:
Table: MyTable
Columns:
- ColumnA (JSONB)
- ColumnB (TEXT)
- ColumnC (INT8)
- ColumnD (INT8)
The primary key is a composite of `ColumnB` + `ColumnC`.
I’m trying to create an AST representation of a query for the `INSERT`
o
On Fri, Oct 4, 2024 at 9:40 PM Robert Haas wrote:
> On Fri, Oct 4, 2024 at 2:20 PM Peter Geoghegan wrote:
> > On Fri, Oct 4, 2024 at 2:00 PM Alexander Korotkov
> > wrote:
> > > Yes, transformAExprIn() does the work to coerce all the expressions in
> > > the right part to the same type. Similar
On Fri, Oct 4, 2024 at 9:20 PM Peter Geoghegan wrote:
> On Fri, Oct 4, 2024 at 2:00 PM Alexander Korotkov
> wrote:
> > Yes, transformAExprIn() does the work to coerce all the expressions in
> > the right part to the same type. Similar logic could be implemented
> > in match_orclause_to_indexcol
On Sat, Oct 5, 2024 at 7:41 AM Heikki Linnakangas wrote:
> My test for dead-end backends opens 20 TCP (or unix domain) connections
> to the server, in quick succession. That works fine my system, and it
> passed cirrus CI on other platforms, but on FreeBSD it failed
> repeatedly. The behavior in t
On Fri, 27 Sept 2024 at 14:00, Tomas Vondra wrote:
> One thing that's not quite clear to me is what's the correct way for
> existing extensions to switch to an "owned schema". Let's say you have
> an extension. How do you transition to this? Can you just add it to the
> control file and then some
On Fri, Oct 04, 2024 at 02:00:00PM +0300, Alexander Lakhin wrote:
> sub _read {
> ...
> my $r = POSIX::read( $_[0], $s, 10_000 );
> croak "$!: read( $_[0] )" if not($r) and !$!{EINTR};
>
> That is, EINTR kind of recognized as an expected error, but there is no
> retry in this case. Thus, w
On 06/09/2024 12:52, Heikki Linnakangas wrote:
Unless you have comments on these first two patches which just add
tests, I'll commit them shortly. Still processing the rest of your
comments...
Didn't happen as "shortly" as I thought..
My test for dead-end backends opens 20 TCP (or unix domain
On Fri, Oct 4, 2024 at 2:20 PM Peter Geoghegan wrote:
> On Fri, Oct 4, 2024 at 2:00 PM Alexander Korotkov
> wrote:
> > Yes, transformAExprIn() does the work to coerce all the expressions in
> > the right part to the same type. Similar logic could be implemented
> > in match_orclause_to_indexcol
On Fri, Oct 4, 2024 at 2:00 PM Alexander Korotkov wrote:
> Yes, transformAExprIn() does the work to coerce all the expressions in
> the right part to the same type. Similar logic could be implemented
> in match_orclause_to_indexcol(). What worries me is whether it's
> quite late stage for this k
Hi, Peter!
Thank you very much for the feedback on this patch.
On Fri, Oct 4, 2024 at 8:44 PM Peter Geoghegan wrote:
> On Fri, Oct 4, 2024 at 7:45 AM Alexander Korotkov
> wrote:
> > Andrei, thank you for your opinion. Just for the record, I'm still
> > exploring this and will reply later toda
Hi,
On 2024-10-04 09:31:45 +0800, wenhui qiu wrote:
> > It's implied, but to make it more explicit: One big efficiency advantage
> of
> > writes by checkpointer is that they are sorted and can often be combined
> into
> > larger writes. That's often a lot more efficient: For network attached
> sto
On Fri, Oct 4, 2024 at 7:45 AM Alexander Korotkov wrote:
> Andrei, thank you for your opinion. Just for the record, I'm still
> exploring this and will reply later today or tomorrow.
The logic that allows this to work for the case of IN() lists appears
in transformAExprIn(), which is in parse_ex
On Fri, Oct 4, 2024 at 10:24 AM Robert Haas wrote:
> Interesting. I would not have guessed that. I wonder how it works.
ISTM that we've established a general expectation that you as a user
can be fairly imprecise about which specific types you use as
constants in your query, while still getting a
On Sun, Jul 2, 2023, at 07:45, Noah Misch wrote:
> On Sat, May 20, 2023 at 09:16:30AM +0200, Joel Jacobson wrote:
>> On Fri, May 19, 2023, at 18:06, Daniel Verite wrote:
>> > COPY FROM file CSV somewhat differs as your example shows,
>> > but it still mishandle \. when unquoted. For instance, consi
Congratulations to all! This seems the sort of thing we should crosspost to
-general and/or -announce, no?
Cheers,
Greg
Hi Nazir,
On Thu, Sep 26, 2024 at 4:14 PM Nazir Bilal Yavuz wrote:
> >
> > Let's split the patch into two 1. supporting TESTS in meson only for
> > regress/regress, 2. extending that support to other suites. The first
> > patch will bring meson inline with make as far as running a subset of
> > r
On Fri, Oct 4, 2024 at 6:43 PM jian he wrote:
>
> v3, 0001 documentation:
> We can at least write something on
> https://wiki.postgresql.org/wiki/Meson about this feature.
TESTS and make check-tests are both not documented under make. I don't
know the reason. IMO we don't have to document it in m
Hi Heikki and team,
A few updates…
> > Ok, if we don't need the assembler code at all, that's good. A patch to
> > introduce AIX support should not change it for non-AIX powerpc systems
> > though. That might be a good change, but would need to be justified
> > separately, e.g. by some p
On Fri, Oct 04, 2024 at 11:32:08AM +0900, btogiwarayuushi wrote:
> While WAL summaries feature and some support functions have been added in
> version 17, merely listing the contents of the pg_wal/summaries directory is
> missing.
Could you explain why you feel the existing support functions are
i
Congratulations to all!
On Fri, 4 Oct 2024 at 22:50, Nathan Bossart
wrote:
> On Fri, Oct 04, 2024 at 03:55:23PM +0200, Christoph Berg wrote:
> > New PostgreSQL Contributors:
> >
> > * Antonin Houska
> > * Ants Aasma
> > * Georgios Kokolatos
> > * Henrietta Dombrovskaya
> > * Ian Lawrence Barwic
On Thu, Oct 3, 2024 at 11:31 PM Andrei Lepikhov wrote:
> The origin reason was - to avoid multiple BitmapOr, which has some
> effects at the planning stage (memory consumption, planning time) and
> execution (execution time growth). IndexScan also works better with a
> single array (especially a h
On Fri, Oct 04, 2024 at 03:55:23PM +0200, Christoph Berg wrote:
> New PostgreSQL Contributors:
>
> * Antonin Houska
> * Ants Aasma
> * Georgios Kokolatos
> * Henrietta Dombrovskaya
> * Ian Lawrence Barwick
> * Jelte Fennema-Nio
> * Karen Jex
> * Pavlo Golub
> * Zhang Mingli
>
> New PostgreSQL Maj
On Thu, Oct 03, 2024 at 10:33:04PM -0400, Tom Lane wrote:
> "Jonathan S. Katz" writes:
>> I think Tom's initial suggestion (BLCKSZ/2) is better than 256, given we
>> really don't know what' out there in the wild, and this could end up
>> being a breaking change. Every other type in pg_authid is
On Fri, Oct 4, 2024 at 10:20 AM Peter Geoghegan wrote:
> The existing IN() syntax somehow manages to produce a useful bigint[]
> SAOP when I use the same mix of integer types/constants that were used
> for my original test case from yesterday:
Interesting. I would not have guessed that. I wonder
On Fri, Oct 4, 2024 at 8:31 AM Robert Haas wrote:
> Personally, I don't think this particular limitation is a problem. I
> don't think it will be terribly frequent in practice, and it doesn't
> seem any weirder than any of the other things that happen as a result
> of small and large integer const
On Thu, Oct 3, 2024 at 5:52 PM David Rowley wrote:
> It looks fine with the patch. The crux of the new logic is just
> summing up the disabled_nodes from the child nodes and checking if the
> disabled_nodes of the current node is higher than that sum. That's not
> exactly hard logic. The biggest r
All,
The PostgreSQL Contributor Page
(https://www.postgresql.org/community/contributors/) includes people who have
made substantial, long-term contributions of time and effort to the PostgreSQL
project. The PostgreSQL Contributors Team recognizes the following people for
their contributions.
New
On Mon, Sep 23, 2024 at 7:11 AM Alexander Korotkov wrote:
> Makes sense. Please, check the attached patch freeing the consts list
> while returning NULL from match_orclause_to_indexcol().
Some review comments:
I agree with the comments already given to the effect that the patch
looks much bette
Hi
pá 4. 10. 2024 v 15:16 odesílatel Tatsuo Ishii
napsal:
> Sorry if this has been discussed before.
>
> I wonder why SET ROLE command does not produce a parameter status
> message noticing the new current_user. Note that SET
> SESSION_AUTHORIZATION command produces a parameter status message fo
On 9/27/24 12:30 AM, Jeff Davis wrote:
The attached patch series refactors the collation and ctype behavior
into method tables, and provides a way to hook the creation of a
pg_locale_t so that an extension can create any kind of method table it
wants.
Great! I had been planning to do this mysel
Sorry if this has been discussed before.
I wonder why SET ROLE command does not produce a parameter status
message noticing the new current_user. Note that SET
SESSION_AUTHORIZATION command produces a parameter status message for
the new session_authorization value.
Best reagards,
--
Tatsuo Ishii
v3, 0001 documentation:
We can at least write something on
https://wiki.postgresql.org/wiki/Meson about this feature.
TESTS='check check_btree' meson test amcheck/regress --verbose
works, but I feel like there is a discoverability issue .
TESTS='check check_btree' meson test amcheck/regress --li
On 2024-Oct-03, jian he wrote:
> I thought SearchSysCacheCopyAttNum is expensive.
> Relation->rd_att is enough for checking attnotnull.
>
> What do you think of the following refactoring of set_attnotnull?
Eh, sure, why not. I mean, I expect that this is going to be barely
noticeable performanc
On Thu, Sep 26, 2024 at 11:45 PM Alexandra Wang
wrote:
>
> Hi,
>
> I didn’t run pgindent earlier, so here’s the updated version with the
> correct indentation. Hope this helps!
>
the attached patch solves the domain type issue, Andrew mentioned in the thread.
I also added a test case: composite
On Thu, Oct 3, 2024 at 4:15 PM Peter Geoghegan wrote:
> Now that you're explicitly creating RestrictInfos for a particular
> index, I suppose that it might be easier to do this kind of thing --
> you have more context. Perhaps the patch can be made to recognize
> a mix of constants like this as al
On Fri, Oct 4, 2024 at 5:05 PM Anthonin Bonnefoy
wrote:
>
> I agree that tracking 2 identical statements with different queryIds
> and nesting levels is very confusing. On the other hand, from an
> extension developer point of view (not necessarily limited to
> pg_stat_statements), I would like to
On Fri, Oct 4, 2024 at 6:31 AM Andrei Lepikhov wrote:
>
> On 10/4/24 03:15, Peter Geoghegan wrote:
> > On Tue, Oct 1, 2024 at 6:25 AM Alexander Korotkov
> > wrote:
> >> I think this patchset got much better, and it could possible be
> >> committed after another round of cleanup and comment/docs
On 04.10.24 05:55, Michael Paquier wrote:
On Thu, Oct 03, 2024 at 01:31:19PM +0200, Peter Eisentraut wrote:
Sounds good. Here is an updated version.
Good idea. What you have sent here looks good to me.
committed
Hello Noah,
16.06.2024 02:48, Noah Misch wrote:
I don't see in https://github.com/cpan-authors/IPC-Run/issues anything
affecting PostgreSQL. If you know of IPC::Run defects, please report them.
If I knew of an IPC::Run defect affecting PostgreSQL, I likely would work on
it before absurdity like
On Sun, Sep 29, 2024 at 12:34 PM vignesh C wrote:
>
> On Thu, 26 Sept 2024 at 11:07, shveta malik wrote:
> >
> > On Fri, Sep 20, 2024 at 9:36 AM vignesh C wrote:
> > >
> > > On Wed, 21 Aug 2024 at 11:54, vignesh C wrote:
> > > >
> > > > On Wed, 21 Aug 2024 at 08:33, Peter Smith wrote:
> > > >
Hi!
On 03.10.2024 23:15, Peter Geoghegan wrote:
I do think that this patch got a lot better, and simpler, but I'm a
little worried about it not covering cases that are only very slightly
different to the ones that you're targeting. It's easiest to see what
I mean using an example.
After the sta
On 04.10.2024 11:43, Ivan Kush wrote:
Do you mean, that I should try to execute such command?
In this patch it gives ANY
postgres=# EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
select * from table1
where fld2 in
(VALUES('\\230\\211\\030f\\332\\261R\\333\\021\\356\\337z5\\336\\032\\
On Sun, 25 Aug 2024 at 10:33, Joel Jacobson wrote:
>
> Nice. LGTM.
> I've successfully tested the new patch again on both Intel and AMD.
>
> I've marked it as Ready for Committer.
>
[Finally getting back to this]
Thanks for the review and testing.
Committed.
Regards,
Dean
On Wed, Oct 2, 2024 at 6:39 AM Michael Paquier wrote:
> FWIW, I've always found this case with EXPLAIN with two entries
> confusing, so what's the advantage in trying to apply this rule for
> the rest? We know that EXPLAIN, DECLARE and CTAS run a query attached
> to their DDL, hence isn't it suff
On 10/4/24 04:08, Tom Lane wrote:
Laurenz Albe writes:
I wonder if it is worth the extra planning time to detect and improve
such queries.
I'm skeptical too. I'm *very* skeptical of implementing it in the
grammar as shown here --- I'd go so far as to say that that approach
cannot be accepted
Some ORMs or proprietary software may write it mistakenly. In these
cases this idea may be helpful.
This patch contains GUC to enable/disable this optimization
On 10/3/24 23:19, Laurenz Albe wrote:
On Thu, 2024-10-03 at 23:10 +0300, Alena Rybakina wrote:
On 03.10.2024 22:52, Ivan Kush wrote:
Do you mean, that I should try to execute such command?
In this patch it gives ANY
postgres=# EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
select * from table1
where fld2 in
(VALUES('\\230\\211\\030f\\332\\261R\\333\\021\\356\\337z5\\336\\032\\372'::bytea),
('\\235\\204 \\004\\017\
Hi Kuroda-san,
Thanks for reviewing the patch.
>
> 1.
> I feel the name of SnapBuildDistributeNewCatalogSnapshot() should be updated
> because it
> distributes two objects: catalog snapshot and invalidation messages. Do you
> have good one
> in your mind? I considered
> "SnapBuildDistributeNewC
53 matches
Mail list logo
