On Mon, Sep 16, 2024 at 3:31 PM Bharath Rupireddy
wrote:
>
> Hi,
>
>
> Please find the attached v46 patch having changes for the above review
> comments and your test review comments and Shveta's review comments.
>
Thanks for addressing comments.
Is there a reason that we don't support this inva
Hi All,
I hope you're doing well.
I'm writing to kindly requesting if there is a bug tracker ID or any
reference number associated with this issue, I would appreciate it if you
could share it with me.
Thank you for your time and assistance. Please let me know if there's any
additional informatio
On Wed, Sep 18, 2024 at 04:16:12AM +, Bertrand Drouvot wrote:
> The macro is created in pgstat_internal.h as it looks like that "only" the
> statistics related code would benefit of it currently (could be moved to other
> header file later on if needed).
I'm OK to add a helper macro in pgstat
On Tue, Sep 17, 2024 at 4:15 PM Tom Lane wrote:
> Wolfgang Walther writes:
> > The core regression tests need to be run with a timezone that tests
> > special cases in the timezone handling code. But that might not be true
> > for extensions - all they want could be a stable output across major
On Tue, Sep 17, 2024 at 12:44 PM Bertrand Drouvot
wrote:
>
> Hi,
>
> On Tue, Sep 17, 2024 at 10:18:35AM +0530, shveta malik wrote:
> > Thanks for addressing the comments. I have not started reviewing v4
> > yet, but here are few more comments on v3:
> >
> > 1)
> > +#include "port/pg_crc32c.h"
> >
On Wed, Sep 18, 2024 at 09:38:32AM +0900, Michael Paquier wrote:
> FWIW, I was thinking about something like what has been done in
> indexcmds.c for 5bbdfa8a18dc as the query ID value is not predictible
> across releases, but we could see whether it is set or not.
By the way, with the main issue f
On Wed, Sep 18, 2024 at 07:50:27AM +0900, Michael Paquier wrote:
> On Tue, Sep 17, 2024 at 05:01:18PM -0500, Sami Imseih wrote:
> > > Then, please see attached two lightly-updated patches. 0001 is for a
> > > backpatch down to v14. This is yours to force things in the exec and
> > > bind messages f
On Thu, 12 Sept 2024 at 14:03, Ajin Cherian wrote:
>
> On Tue, Sep 3, 2024 at 7:42 PM vignesh C wrote:
>
> On Fri, 30 Aug 2024 at 11:01, Nisha Moond
> wrote:
> >
> > Here is the v11 patch-set. Changes are:
>
> 1) This command crashes:
> ALTER SUBSCRIPTION name RESET CONFLICT
On Mon, Sep 16, 2024 at 9:24 AM Noah Misch wrote:
>
> On Thu, Sep 12, 2024 at 03:42:48PM -0700, Masahiko Sawada wrote:
> > On Tue, Sep 10, 2024 at 3:05 PM Noah Misch wrote:
> > > On Tue, Sep 10, 2024 at 05:56:47PM -0400, Tom Lane wrote:
> > > > Got it. So now I'm wondering if we need all the com
=?UTF-8?B?0JXQs9C+0YAg0KfQuNC90LTRj9GB0LrQuNC9?= writes:
> This query does not expect that test database may already contain some
> information about custom user that ran test_pg_dump-running.
I'm perfectly content to reject this as being an abuse of the test
case. Our TAP tests are built on th
On Tue, Sep 17, 2024 at 11:24 PM Masahiko Sawada wrote:
>
> On Mon, Sep 16, 2024 at 11:53 PM Amit Kapila wrote:
> >
> > On Tue, Sep 17, 2024 at 6:08 AM Masahiko Sawada
> > wrote:
> >
> > I haven't thought about the implementation details yet but I think
> > during pruning (for example in heap_p
Hi hackers,
There is some places where we check that a struct is full of zeroes:
pgstat_report_bgwriter()
pgstat_report_checkpointer()
pgstat_relation_flush_cb()
Indeed that's the way we check if there is pending statistics to flush/report.
The current code is like (taking pgstat_relation_flush
>On Thu, Jun 20, 2024 at 3:43PM Hannu Krosing < han...@google.com > wrote:
>> Still it would be nice to have some public support for users of
>> non-managed PostgreSQL databases as well
>+1.
>
>--
>Robert Haas
>EDB: http://www.enterprisedb.com
Hello! I have recently been researching postgres bu
On Fri, Sep 13, 2024 at 04:03:13AM +, Bertrand Drouvot wrote:
> Overall, the patch LGTM.
Thanks for the review, I've applied that, then, detailing in the
commit log what this changes and the three format bumps required.
--
Michael
signature.asc
Description: PGP signature
Hi, here are my review comments for patch v31-0002.
==
1. General.
IMO patches 0001 and 0002 should be merged when next posted. IIUC the
reason for the split was only because there were 2 different authors
but that seems to be not relevant anymore.
==
Commit message
2.
When 'copy_data'
On Sun, Sep 15, 2024 at 12:14 AM Mats Kindahl wrote:
> I used the combination of your patch and making the computation of
> vacattrstats for a relation available through the API and managed to
> implement something that I think does the right thing. (I just sampled a few
> different statistics
Thank you very much for your response and suggestions.
As you mentioned, the patch here is actually designed for glibc's ptmalloc2
andis not applicable to other platforms. I will consider supporting it only
on the Linux platform in the future. In the memory management strategy of
ptmalloc2, there
On Mon, Sep 16, 2024 at 5:22 PM jian he wrote:
>
> in v7.
>
seems I am confused with the version number.
here, I attached another minor change in tests.
make
ERROR: invalid ON DELETE action for foreign key constraint containing
generated column
becomes
ERROR: foreign key constraints on virtual
On Tue, Sep 17, 2024 at 08:22:41PM -0400, Tom Lane wrote:
> Bruce Momjian writes:
> > On Tue, Sep 17, 2024 at 03:29:54PM -0300, Marcos Pegoraro wrote:
> >> Em ter., 17 de set. de 2024 às 05:12, Alvaro Herrera
> >>
> >>> Add backend support for injection points (Michael Paquier) [commit 1] [2]
>
On Tue, Sep 17, 2024 at 06:39:17PM -0500, Sami Imseih wrote:
> FWIW, I do like the INJECTION_POINT idea and actually mentioned something
> similar up the thread [1] for the revalidate cache case, but I can see it
> being applied
> to all the other places we expect the queryId to be set.
>
> [1]
Justin Pryzby writes:
> This commit seems to trigger elog(), not reproducible in the
> parent commit.
Yeah, I can reproduce that. Will take a look tomorrow.
regards, tom lane
Bruce Momjian writes:
> On Tue, Sep 17, 2024 at 03:29:54PM -0300, Marcos Pegoraro wrote:
>> Em ter., 17 de set. de 2024 às 05:12, Alvaro Herrera
>>
>>> Add backend support for injection points (Michael Paquier) [commit 1] [2]
> I think trying to add text to each item is both redundant and confu
On Tue, Sep 17, 2024 at 03:29:54PM -0300, Marcos Pegoraro wrote:
> Em ter., 17 de set. de 2024 às 05:12, Alvaro Herrera
> escreveu:
>
> Add backend support for injection points (Michael Paquier) [commit 1] [2]
> [3] [4]
>
> I think this way would be fine.
>
> And it would be good to hav
This commit seems to trigger elog(), not reproducible in the
parent commit.
6e086fa2e77 Allow parallel workers to cope with a newly-created session user ID.
postgres=# SET min_parallel_table_scan_size=0; CLUSTER pg_attribute USING
pg_attribute_relid_attnum_index;
ERROR: pg_attribute catalog is
> would help to grab a query ID. A second option I have in mind would
> be to set up an injection point that produces a NOTICE if a query ID
> is set when we end processing an execute message, then check the
> number of NOTICE messages produced as these can be predictible
> depending on the number
On Wed, Sep 18, 2024 at 01:08:26AM +0300, a.ima...@postgrespro.ru wrote:
> I've noticed that there is no way to specify a custom connection string when
> calling the PostgreSQL::Test::Cluster->background_psql() method compared to
> the
> PostgreSQL::Test:Cluster->psql(). It seems useful to have th
On Tue, Sep 17, 2024 at 05:01:18PM -0500, Sami Imseih wrote:
> > Then, please see attached two lightly-updated patches. 0001 is for a
> > backpatch down to v14. This is yours to force things in the exec and
> > bind messages for all portal types, with the test (placed elsewhere in
> > 14~15 branche
On Mon, Sep 16, 2024 at 6:05 PM Tomas Vondra wrote:
> I've been looking at this patch over the couple last days, mostly doing
> some stress testing / benchmarking (hence the earlier report) and basic
> review.
Thanks for taking a look! Very helpful.
> I do have some initial review comments, and
Hi, hackers!
I've noticed that there is no way to specify a custom connection string
when
calling the PostgreSQL::Test::Cluster->background_psql() method compared
to the
PostgreSQL::Test:Cluster->psql(). It seems useful to have this feature
while
testing with BackgroundPsql, for example, when
> Then, please see attached two lightly-updated patches. 0001 is for a
> backpatch down to v14. This is yours to force things in the exec and
> bind messages for all portal types, with the test (placed elsewhere in
> 14~15 branches). 0002 is for HEAD to add some sanity checks, blowing
> up the test
On Sun, Sep 08, 2024 at 05:32:16PM -0400, Tom Lane wrote:
> In looking at this, I found that there's also no test coverage
> for the , V, or PL format codes. Also, the possibility of
> overflow while converting an input value to int in order to
> pass it to int_to_roman was ignored. Attached
On Tue, Sep 17, 2024 at 5:11 PM Andrew Dunstan wrote:
>
> On 2024-09-17 Tu 5:26 AM, Florents Tselai wrote:
>
> Currently:
>
>
> jsonb_strip_nulls ( jsonb ) → jsonb
>
> Deletes all object fields that have null values from the given JSON value,
> recursively. Null values that are not object fields
Here are a few miscellaneous cleanup patches for pg_upgrade. I don't think
there's anything controversial here.
0001 removes some extra whitespace in the status message for failed data
type checks. I noticed that when the check fails, this status message is
indented beyond all the other output.
On Sep 17, 2024, at 15:03, Florents Tselai wrote:
> Fallback scenario: make this an extension, but in a first pass I didn’t find
> any convenient hooks.
> One has to create a whole new scanner, grammar etc.
Yeah, it got me thinking about the RFC-9535 JSONPath "Function Extension"
feature[1], w
> On 17 Sep 2024, at 9:40 PM, David E. Wheeler wrote:
>
> On Sep 16, 2024, at 18:39, Florents Tselai wrote:
>
>> Here’s an updated version of this patch.
>
> Oh, nice function.
>
> But a broader question for hackers: Is replace() specified in the SQL/JSON
> spec? If not, what’s the proces
On Sep 16, 2024, at 18:39, Florents Tselai wrote:
> Here’s an updated version of this patch.
Oh, nice function.
But a broader question for hackers: Is replace() specified in the SQL/JSON
spec? If not, what’s the process for evaluating whether or not to add features
not specified by the spec?
Em ter., 17 de set. de 2024 às 05:12, Alvaro Herrera <
alvhe...@alvh.no-ip.org> escreveu:
> Add backend support for injection points (Michael Paquier) [commit 1] [2]
> [3] [4]
>
I think this way would be fine.
And it would be good to have a
target="_blank"
on commit links so a new window or tab w
On Tue, Sep 17, 2024 at 2:06 AM Amit Kapila wrote:
>
> On Mon, Sep 16, 2024 at 10:43 PM Masahiko Sawada
> wrote:
> >
> > On Fri, Sep 13, 2024 at 3:58 AM Amit Kapila wrote:
> > >
> > > On Thu, Sep 12, 2024 at 4:03 AM Masahiko Sawada
> > > wrote:
> > > >
> > > > We have several reports that log
On Mon, Sep 16, 2024 at 01:51:42PM -0400, Andres Freund wrote:
> On 2024-09-16 07:43:49 -0700, Noah Misch wrote:
> > On Fri, Sep 06, 2024 at 03:38:16PM -0400, Andres Freund wrote:
> > Reattaching descriptors and memory in each child may work, or one could just
> > block io_method=io_uring under EX
On Mon, Sep 16, 2024 at 11:53 PM Amit Kapila wrote:
>
> On Tue, Sep 17, 2024 at 6:08 AM Masahiko Sawada wrote:
> >
> > On Fri, Sep 13, 2024 at 12:56 AM shveta malik
> > wrote:
> > >
> > > On Fri, Sep 13, 2024 at 11:38 AM Amit Kapila
> > > wrote:
> > > >
> > > > > >
> > > > > > So in brief, th
> Do you still need mkldexport.sh? Surely there's a better way to do that
> in year 2024. Some quick googling says there's a '-bexpall' option to
> 'ld', which kind of sounds like what we want. Will that work? How do
> other programs do this?
We have noticed couple of caveats with
On Mon, Sep 16, 2024 at 3:13 PM Peter Geoghegan wrote:
> I agree with your approach, but I'm concerned about it causing
> confusion inside _bt_parallel_done. And so I attach a v2 revision of
> your bug fix. v2 adds a check that nails that down, too.
Pushed this just now.
Thanks
--
Peter Geogheg
Hello Michael and Anthonin,
22.08.2024 10:33, Michael Paquier wrote:
Looks OK to me. I have spent more time double-checking the whole, and
it looks like we're there, so applied. Now let's play with it in more
regression tests. Note that the refactoring patch has been merged
with the original
On 2024-09-15 Su 6:17 PM, sia kc wrote:
About inlining not sure how it is done with gmail. Maybe should use
another email client.
Click the three dots with the tooltip "Show trimmed content". Then you
can scroll down and put your reply inline. (Personally I detest the
Gmail web interface
Wolfgang Walther writes:
> The core regression tests need to be run with a timezone that tests
> special cases in the timezone handling code. But that might not be true
> for extensions - all they want could be a stable output across major and
> minor versions of postgres and versions of tzdata
On 2024-09-17 Tu 5:26 AM, Florents Tselai wrote:
Currently:
|jsonb_strip_nulls| ( |jsonb| ) → |jsonb|
Deletes all object fields that have null values from the given JSON
value, recursively. Null values that are not object fields are untouched.
> Null values that are not object fields are
Hi,
On Tue, Sep 17, 2024 at 04:47:51PM +0300, Nazir Bilal Yavuz wrote:
> Hi,
>
> On Tue, 17 Sept 2024 at 16:07, Bertrand Drouvot
> wrote:
> > So I think it's better to keep both functions as they behave differently.
> >
> > Thoughts?
>
> Yes, that is correct. Sorry, you already had explained it
Hi,
On Tue, 17 Sept 2024 at 16:07, Bertrand Drouvot
wrote:
> On Tue, Sep 17, 2024 at 02:52:01PM +0300, Nazir Bilal Yavuz wrote:
> > Could we remove pg_stat_get_my_io() completely and use
> > pg_stat_get_backend_io() with the current backend's pid to get the
> > current backend's stats?
>
> The re
Hi,
On Tue, Sep 17, 2024 at 02:52:01PM +0300, Nazir Bilal Yavuz wrote:
> Hi,
>
> On Fri, 13 Sept 2024 at 19:09, Bertrand Drouvot
> wrote:
> > On Fri, Sep 13, 2024 at 04:45:08PM +0300, Nazir Bilal Yavuz wrote:
> > > - The pgstat_reset_io_counter_internal() is called in the
> > > pgstat_shutdown_h
Thanks for everyone's work on this, I am very interested in it getting into
a release. What is the status of this?
My use case is Patroni - when it needs to do a failover, it shuts down the
primary. However, large transactions can cause it to stay in the "shutting
down" state for a long time, whic
Here is an updated patch fixing the aforementionned problems
with tests and vacuum stats.
--
Benoit Lobréau
Consultant
http://dalibo.comFrom 1b52f5fb4e977599b8925c69193d31148042ca7d Mon Sep 17 00:00:00 2001
From: benoit
Date: Wed, 28 Aug 2024 02:27:13 +0200
Subject: [PATCH] Adds four parallel wo
Hi,
On Mon, Sep 16, 2024 at 8:31 PM Tom Lane wrote:
> Alvaro Herrera writes:
> > On 2024-Sep-16, Jim Jones wrote:
> >> * The value of "Current User" does not match the function current_user()
> >> --- as one might expcect. It is a little confusing, as there is no
> >> mention of "Current User"
Hi,
On Fri, 13 Sept 2024 at 19:09, Bertrand Drouvot
wrote:
> On Fri, Sep 13, 2024 at 04:45:08PM +0300, Nazir Bilal Yavuz wrote:
> > - The pgstat_reset_io_counter_internal() is called in the
> > pgstat_shutdown_hook(). This causes the stats_reset column showing the
> > termination time of the old
On Tue, Sep 17, 2024 at 10:46 AM David G. Johnston
wrote:
>
>
>
> On Monday, September 16, 2024, shveta malik wrote:
>>
>> On Tue, Sep 17, 2024 at 10:18 AM shveta malik wrote:
>> >
>> > Thanks for addressing the comments. I have not started reviewing v4
>> > yet, but here are few more comments o
On 05.09.24 14:09, Peter Eisentraut wrote:
On 07.08.24 22:54, Paul Jungwirth wrote:
Here are some fixes based on outstanding feedback (some old some new).
I have studied your patches v39-0001 through v39-0004, which correspond
to what had been reverted plus the new empty range check plus vari
Review comments for v31-0001.
(I tried to give only new comments, but there might be some overlap
with comments I previously made for v30-0001)
==
src/backend/catalog/pg_publication.c
1.
+
+ if (publish_generated_columns_given)
+ {
+ values[Anum_pg_publication_pubgencolumns - 1] =
BoolGetDat
> On 17 Sep 2024, at 11:24, Dagfinn Ilmari Mannsåker wrote:
> I just noticed that the docs for pg_service.conf
> (https://www.postgresql.org/docs/current/libpq-pgservice.html) don't
> mention the actual key word to use in the libpq connection string until
> the example in the last sentence, but i
Currently:
jsonb_strip_nulls ( jsonb ) → jsonb
Deletes all object fields that have null values from the given JSON value,
recursively. Null values that are not object fields are untouched.
> Null values that are not object fields are untouched.
Can we revisit this and make it work with arrays
Hi hackers,
I just noticed that the docs for pg_service.conf
(https://www.postgresql.org/docs/current/libpq-pgservice.html) don't
mention the actual key word to use in the libpq connection string until
the example in the last sentence, but it mentions the env var in the
first paragraph. Here's a
On Mon, Sep 16, 2024 at 10:43 PM Masahiko Sawada wrote:
>
> On Fri, Sep 13, 2024 at 3:58 AM Amit Kapila wrote:
> >
> > On Thu, Sep 12, 2024 at 4:03 AM Masahiko Sawada
> > wrote:
> > >
> > > We have several reports that logical decoding uses memory much more
> > > than logical_decoding_work_mem[
17.09.2024 10:47, Alexander Korotkov wrote:
Yes, now I did reproduce. I got that the problem could be that insert
LSN is not yet written at primary, thus wait_for_catchup doesn't wait
for it. I've workarounded that using pg_switch_wal(). The revised
patchset is attached.
Thank you for the re
Hi Richard Guo
I tried to changed the comment, can you help me to check if this is
correct?Many thanks.
- /*
- * get_cheapest_parallel_safe_total_inner
- * Find the unparameterized parallel-safe path with the least total cost.
- */
+ /* get_cheapest_parallel_safe_total_inner
+ * Skip pa
On Tue, 17 Sept 2024 at 10:12, Alvaro Herrera wrote:
> Maybe it would work to use numbers in square brackets instead:
>
> Add backend support for injection points (Michael Paquier) [1] [2] [3] [4]
Another option would be to add them in superscript using the
html tag (or even using some unico
On 2024-Sep-11, Bruce Momjian wrote:
> An interesting idea would be to report all function signature changes
> in each major release in some way.
Hmm, extension authors are going to realize this as soon as they try to
compile, so it doesn't seem necessary. Having useful APIs _added_ is a
differe
On 2024-Sep-16, Bruce Momjian wrote:
> We could try:
>
>Add backend support for injection points (Michael Paquier) §1 §2 §3 §4
>
> and maybe only add numbers if there is more than one commit.
Well, this reads like references to sections 1, 2, 3 and 4, but they
aren't that, and probably such
On Wed, 11 Sept 2024 at 16:10, Bruce Momjian wrote:
> You are right that I do mention changes specifically designed for the
> use of extensions, but there is no mention in the commit message of its
> use for extensions. In fact, I thought this was too low-level to be of
> use for extensions. How
On Tue, Sep 17, 2024 at 9:00 AM Alexander Lakhin wrote:
> 16.09.2024 21:55, Alexander Korotkov wrote:
> > Please find two patches attached. The first one does minor cleanup
> > including misuse of words you've pointed. The second one adds missing
> > wait_for_catchup(). That should fix the test
Here are some review comments for v31-0001 (for the docs only)
There may be some overlap here with some comments already made for
v30-0001 which are not yet addressed in v31-0001.
==
Commit message
1.
When introducing the 'publish_generated_columns' parameter, you must
also say this is a PUB
Hi,
On Tue, Sep 17, 2024 at 10:18:35AM +0530, shveta malik wrote:
> Thanks for addressing the comments. I have not started reviewing v4
> yet, but here are few more comments on v3:
>
> 1)
> +#include "port/pg_crc32c.h"
>
> It is not needed in pg_logicalinspect.c as it is already included in
> in
Hi,
On Mon, Sep 16, 2024 at 10:16:16PM -0700, David G. Johnston wrote:
> On Monday, September 16, 2024, shveta malik wrote:
>
> > On Tue, Sep 17, 2024 at 10:18 AM shveta malik
> > wrote:
> > >
> > > Thanks for addressing the comments. I have not started reviewing v4
> > > yet, but here are few
70 matches
Mail list logo
