Re: Conflict detection for update_deleted in logical replication

2024-09-16 Thread Amit Kapila
On Tue, Sep 17, 2024 at 6:08 AM Masahiko Sawada wrote: > > On Fri, Sep 13, 2024 at 12:56 AM shveta malik wrote: > > > > On Fri, Sep 13, 2024 at 11:38 AM Amit Kapila > > wrote: > > > > > > > > > > > > > So in brief, this solution is only for bidrectional setup? For > > > > > non-bidirectional,

Re: Regression tests fail with tzdata 2024b

2024-09-16 Thread Wolfgang Walther
Tom Lane: I was wondering whether the timezone used by pg_regress could be made configurable. Yes, I understood that you were suggesting that. My point is that it wouldn't do you any good: you will still have to change any regression test cases that depend on behavior PST8PDT has/had that is d

Re: Pgoutput not capturing the generated columns

2024-09-16 Thread Peter Smith
On Tue, Sep 17, 2024 at 4:15 PM Masahiko Sawada wrote: > > On Mon, Sep 16, 2024 at 8:09 PM Peter Smith wrote: > > > > I thought that the option "publish_generated_columns" is more related > > to "column lists" than "row filters". > > > > Let's say table 't1' has columns 'a', 'b', 'c', 'gen1', 'ge

Re: Pgoutput not capturing the generated columns

2024-09-16 Thread Masahiko Sawada
On Mon, Sep 16, 2024 at 8:09 PM Peter Smith wrote: > > I thought that the option "publish_generated_columns" is more related > to "column lists" than "row filters". > > Let's say table 't1' has columns 'a', 'b', 'c', 'gen1', 'gen2'. > > And > PUBLICATION pub2 FOR TABLE t1 WITH (publish_generated_

RE: [Proposal] Add foreign-server health checks infrastructure

2024-09-16 Thread Hayato Kuroda (Fujitsu)
Dear Fujii-san, Thanks for reviewing! > I made a couple of small adjustments and attached the updated version. > If that's ok, I'll go ahead and commit it. > > + Name of the local user mapped to the foreign server of this > + connection, or "public" if a public mapping is used. I

Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN

2024-09-16 Thread Tatsuo Ishii
> On Tue, 17 Sept 2024 at 14:40, Tatsuo Ishii wrote: >> Attached is the v5 patch. The difference from v4 is addtion of two >> more tests to explain.sql: >> >> 1) spils to disk case >> 2) splis to disk then switch back to memory case > > Looks ok to me, aside from the missing "reset work_mem;" aft

Wrong results with equality search using trigram index and non-deterministic collation

2024-09-16 Thread Laurenz Albe
Using a trigram index with an non-deterministic collation can lead to wrong query results: CREATE COLLATION faux_cn (PROVIDER = icu, LOCALE = 'und', DETERMINISTIC = FALSE, RULES = '&l = r'); CREATE TABLE boom (id integer PRIMARY KEY, t text COLLATE faux_cn); INSERT INTO boom VALUES (1, 'r

Re: [HACKERS] make async slave to wait for lsn to be replayed

2024-09-16 Thread Alexander Lakhin
Hi Alexander, 16.09.2024 21:55, Alexander Korotkov wrote: Please find two patches attached. The first one does minor cleanup including misuse of words you've pointed. The second one adds missing wait_for_catchup(). That should fix the test failure you've spotted. Please, check if it fixes an

RE: Using per-transaction memory contexts for storing decoded tuples

2024-09-16 Thread Hayato Kuroda (Fujitsu)
Hi, > We have several reports that logical decoding uses memory much more > than logical_decoding_work_mem[1][2][3]. For instance in one of the > reports[1], even though users set logical_decoding_work_mem to > '256MB', a walsender process was killed by OOM because of using more > than 4GB memory.

Re: Regression tests fail with tzdata 2024b

2024-09-16 Thread Tom Lane
Sven Klemm writes: > On Mon, Sep 16, 2024 at 5:19 PM Tom Lane wrote: >> Configurable to what? If your test cases are dependent on the >> historical behavior of PST8PDT, you're out of luck, because that >> simply isn't available anymore (or won't be once 2024b reaches >> your platform, anyway).

Re: [Proposal] Add foreign-server health checks infrastructure

2024-09-16 Thread Fujii Masao
On 2024/08/08 11:38, Hayato Kuroda (Fujitsu) wrote: Dear Fujii-san, Thanks for reviewing! PSA new version. Thanks for updating the patch! LGTM. I made a couple of small adjustments and attached the updated version. If that's ok, I'll go ahead and commit it. + Name of the local user

Re: Regression tests fail with tzdata 2024b

2024-09-16 Thread Sven Klemm
On Mon, Sep 16, 2024 at 5:19 PM Tom Lane wrote: > Configurable to what? If your test cases are dependent on the > historical behavior of PST8PDT, you're out of luck, because that > simply isn't available anymore (or won't be once 2024b reaches > your platform, anyway). > I was wondering whether

Re: Add contrib/pg_logicalsnapinspect

2024-09-16 Thread David G. Johnston
On Monday, September 16, 2024, shveta malik wrote: > On Tue, Sep 17, 2024 at 10:18 AM shveta malik > wrote: > > > > Thanks for addressing the comments. I have not started reviewing v4 > > yet, but here are few more comments on v3: > > > > I just noticed that when we pass NULL input, both the new

Re: Robocopy might be not robust enough for never-ending testing on Windows

2024-09-16 Thread Alexander Lakhin
Hello Thomas, 17.09.2024 04:01, Thomas Munro wrote: On Mon, Sep 16, 2024 at 6:00 PM Alexander Lakhin wrote: So this leak looks like a recent and still existing defect. From my cartoon-like understanding of Windows, I would guess that if event handles created by a program are leaked after it

Re: Add contrib/pg_logicalsnapinspect

2024-09-16 Thread shveta malik
On Tue, Sep 17, 2024 at 10:18 AM shveta malik wrote: > > Thanks for addressing the comments. I have not started reviewing v4 > yet, but here are few more comments on v3: > I just noticed that when we pass NULL input, both the new functions give 1 row as output, all cols as NULL: newdb1=# SELECT

Re: Add contrib/pg_logicalsnapinspect

2024-09-16 Thread shveta malik
On Mon, Sep 16, 2024 at 8:03 PM Bertrand Drouvot wrote: > > Hi, > > On Mon, Sep 16, 2024 at 04:02:51PM +0530, shveta malik wrote: > > On Wed, Sep 11, 2024 at 4:21 PM Bertrand Drouvot > > wrote: > > > > > > > > > Yeah, good idea. Done that way in v3 attached. > > > > > > > Thanks for the patch. +1

Re: Supporting = operator in gin/gist_trgm_ops

2024-09-16 Thread David Rowley
On Sat, 14 Nov 2020 at 18:31, Alexander Korotkov wrote: > I also have checked that btree_gist is preferred over pg_trgm gist > index for equality search. Despite our gist cost estimate is quite > dumb, it selects btree_gist index due to its lower size. So, this > part also looks good to me. > >

Re: Allow logical failover slots to wait on synchronous replication

2024-09-16 Thread shveta malik
On Mon, Sep 16, 2024 at 4:04 PM Amit Kapila wrote: > > On Mon, Sep 16, 2024 at 2:55 PM shveta malik wrote: > > > > On Mon, Sep 16, 2024 at 11:13 AM Amit Kapila > > wrote: > > > > > > > > Another question aside from the above point, what if someone has > > > specified logical subscribers in sync

Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN

2024-09-16 Thread David Rowley
On Tue, 17 Sept 2024 at 14:40, Tatsuo Ishii wrote: > Attached is the v5 patch. The difference from v4 is addtion of two > more tests to explain.sql: > > 1) spils to disk case > 2) splis to disk then switch back to memory case Looks ok to me, aside from the missing "reset work_mem;" after you're d

Re: Pgoutput not capturing the generated columns

2024-09-16 Thread Peter Smith
On Tue, Sep 17, 2024 at 7:02 AM Masahiko Sawada wrote: > > On Wed, Sep 11, 2024 at 10:30 PM Peter Smith wrote: > > > > Because this feature is now being implemented as a PUBLICATION option, > > there is another scenario that might need consideration; I am thinking > > about where the same table i

Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica.

2024-09-16 Thread Fujii Masao
On 2024/09/16 23:30, Anton A. Melnikov wrote: +1 This idea seems quite tenable to me. There is a small clarification. Now if there were no skipped restartpoints then restartpoints_done will be equal to restartpoints_timed + restartpoints_req. Similar for checkpoints. So i tried to introduce n

Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN

2024-09-16 Thread Tatsuo Ishii
> Not sure if there's any way to force it in the SQL standard. However > in term of implementation, PostgreSQL sorts the function > (generate_series) scan result using a sort key "a.n < 3", which > results in rows being >= 2 first (as false == 0), then rows being < 3 > (as true == 1). So unless Po

Re: Introduce XID age and inactive timeout based replication slot invalidation

2024-09-16 Thread Peter Smith
Here are a few comments for the patch v46-0001. == src/backend/replication/slot.c 1. ReportSlotInvalidation On Mon, Sep 16, 2024 at 8:01 PM Bharath Rupireddy wrote: > > On Mon, Sep 9, 2024 at 1:11 PM Peter Smith wrote: > > 3. ReportSlotInvalidation > > > > I didn't understand why there was

Re: Robocopy might be not robust enough for never-ending testing on Windows

2024-09-16 Thread Thomas Munro
On Mon, Sep 16, 2024 at 6:00 PM Alexander Lakhin wrote: > So this leak looks like a recent and still existing defect. >From my cartoon-like understanding of Windows, I would guess that if event handles created by a program are leaked after it has exited, it would normally imply that they've been

Re: Conflict detection for update_deleted in logical replication

2024-09-16 Thread Masahiko Sawada
On Fri, Sep 13, 2024 at 12:56 AM shveta malik wrote: > > On Fri, Sep 13, 2024 at 11:38 AM Amit Kapila wrote: > > > > > > > > > > So in brief, this solution is only for bidrectional setup? For > > > > non-bidirectional, > > > > feedback_slots is non-configurable and thus irrelevant. > > > > > > R

Re: [PATCH] WIP: replace method for jsonpath

2024-09-16 Thread Florents Tselai
Here’s an updated version of this patch.The previous version failed several CI steps; this passes them all.Unless someone disagrees,I’ll proceed with the documentation and add this for the next CF.As a future note:It’s worth noting that both this newly added jspItem and other ones like (jpiDecimal,

Re: optimizing pg_upgrade's once-in-each-database steps

2024-09-16 Thread Nathan Bossart
On Mon, Sep 09, 2024 at 11:20:28PM +0200, Daniel Gustafsson wrote: >> On 9 Sep 2024, at 21:17, Nathan Bossart wrote: >> >> On Thu, Sep 05, 2024 at 01:32:34PM +0200, Daniel Gustafsson wrote: >>> I've read and tested through the latest version of this patchset and I think >>> it's ready to go in. >

Re: Pgoutput not capturing the generated columns

2024-09-16 Thread Masahiko Sawada
On Wed, Sep 11, 2024 at 10:30 PM Peter Smith wrote: > > Because this feature is now being implemented as a PUBLICATION option, > there is another scenario that might need consideration; I am thinking > about where the same table is published by multiple PUBLICATIONS (with > different option settin

Re: SQL:2023 JSON simplified accessor support

2024-09-16 Thread Peter Eisentraut
On 29.08.24 18:33, Alexandra Wang wrote: I’ve implemented the member and array accessors and attached two alternative patches: 1. v1-0001-Add-JSON-JSONB-simplified-accessor.patch: This patch enables dot access to JSON object fields and subscript access to indexed JSON array elements by convertin

Re: [PoC] Federated Authn/z with OAUTHBEARER

2024-09-16 Thread Jacob Champion
On Wed, Sep 11, 2024 at 3:54 PM Jacob Champion wrote: > Yeah, and I still owe you all an updated roadmap. Okay, here goes. New reviewers: start here! == What is This? == OAuth 2.0 is a way for a trusted third party (a "provider") to tell a server whether a client on the other end of the line is

Re: Detailed release notes

2024-09-16 Thread Bruce Momjian
On Mon, Sep 16, 2024 at 03:42:22PM -0300, Marcos Pegoraro wrote: > Em seg., 16 de set. de 2024 às 15:15, Bruce Momjian > escreveu: > > > > I changed the patch to use the section symbol "§" instead of showing > > > the hashes.  The hashes seemed too detailed.  Does anyone see a better >

Re: Adding skip scan (including MDAM style range skip scan) to nbtree

2024-09-16 Thread Peter Geoghegan
On Thu, Sep 12, 2024 at 10:49 AM Matthias van de Meent wrote: > Thanks to Peter for the description, that helped me debug the issue. I > think I found a fix for the issue: regression tests for 811af978 > consistently got stuck on my macbook before the attached patch 0001, > after applying that thi

Re: [HACKERS] make async slave to wait for lsn to be replayed

2024-09-16 Thread Alexander Korotkov
Hi, Alexander! On Fri, Sep 13, 2024 at 3:00 PM Alexander Lakhin wrote: > > 10.08.2024 20:18, Alexander Korotkov wrote: > > On Sat, Aug 10, 2024 at 7:33 PM Alexander Korotkov > > wrote: > >> On Tue, Aug 6, 2024 at 5:17 AM Alexander Korotkov > >> wrote: > >> ... > >> Here is a revised version o

Re: Document DateStyle effect on jsonpath string()

2024-09-16 Thread David E. Wheeler
On Sep 16, 2024, at 13:29, Tom Lane wrote: > 17.0. If we were already past 17.0 I'd have a lot more angst > about changing this behavior. Great, very glad it made it in. D

Re: Detailed release notes

2024-09-16 Thread Marcos Pegoraro
Em seg., 16 de set. de 2024 às 15:15, Bruce Momjian escreveu: > > > I changed the patch to use the section symbol "§" instead of showing > > > the hashes. The hashes seemed too detailed. Does anyone see a better > > > symbol to use from here Well, I think section symbol is not a good choice f

Re: Detailed release notes

2024-09-16 Thread Bruce Momjian
On Sat, Sep 14, 2024 at 08:37:31PM -0400, Bruce Momjian wrote: > On Fri, Sep 13, 2024 at 12:39:28PM -0400, Bruce Momjian wrote: > > I applied this patch to PG 17. You can see the results at: > > > > https://momjian.us/pgsql_docs/release-17.html > > > > The community doc build only shows the

Re: AIO v2.0

2024-09-16 Thread Andres Freund
Hi, On 2024-09-12 14:55:49 -0700, Robert Pang wrote: > Hi Andres > > Thanks for the AIO patch update. I gave it a try and ran into a FATAL > in bgwriter when executing a benchmark. > > 2024-09-12 01:38:00.851 PDT [2780939] PANIC: no more bbs > 2024-09-12 01:38:00.854 PDT [2780473] LOG: backgro

Re: AIO v2.0

2024-09-16 Thread Andres Freund
Hi, Thanks for the review! On 2024-09-16 07:43:49 -0700, Noah Misch wrote: > On Fri, Sep 06, 2024 at 03:38:16PM -0400, Andres Freund wrote: > > There's plenty more to do, but I thought this would be a useful checkpoint. > > I find patches 1-5 are Ready for Committer. Cool! > > +typedef enum Pg

Re: Document DateStyle effect on jsonpath string()

2024-09-16 Thread Tom Lane
"David E. Wheeler" writes: > BTW, will the back-patch to 17 (cc4fdfa) be included in 17.0 or 17.1? 17.0. If we were already past 17.0 I'd have a lot more angst about changing this behavior. regards, tom lane

Re: Document DateStyle effect on jsonpath string()

2024-09-16 Thread David E. Wheeler
On Sep 11, 2024, at 15:52, David E. Wheeler wrote: > WFM, though now I’ll have to go change my port 😂. I saw this was committed in cb599b9. Thank you! BTW, will the back-patch to 17 (cc4fdfa) be included in 17.0 or 17.1? Best, David

Re: Using per-transaction memory contexts for storing decoded tuples

2024-09-16 Thread Masahiko Sawada
On Fri, Sep 13, 2024 at 3:58 AM Amit Kapila wrote: > > On Thu, Sep 12, 2024 at 4:03 AM Masahiko Sawada wrote: > > > > We have several reports that logical decoding uses memory much more > > than logical_decoding_work_mem[1][2][3]. For instance in one of the > > reports[1], even though users set l

Re: Introduce XID age and inactive timeout based replication slot invalidation

2024-09-16 Thread Bharath Rupireddy
Hi, Thanks for looking into this. On Mon, Sep 16, 2024 at 4:54 PM Amit Kapila wrote: > > Why raise the ERROR just for timeout invalidation here and why not if > the slot is invalidated for other reasons? This raises the question of > what happens before this patch if the invalid slot is used fro

Re: pg_trgm comparison bug on cross-architecture replication due to different char implementation

2024-09-16 Thread Noah Misch
On Thu, Sep 12, 2024 at 03:42:48PM -0700, Masahiko Sawada wrote: > On Tue, Sep 10, 2024 at 3:05 PM Noah Misch wrote: > > On Tue, Sep 10, 2024 at 05:56:47PM -0400, Tom Lane wrote: > > > Got it. So now I'm wondering if we need all the complexity of storing > > > stuff in the GIN metapages. Could w

Re: Psql meta-command conninfo+

2024-09-16 Thread Tom Lane
Alvaro Herrera writes: > On 2024-Sep-16, Jim Jones wrote: >> * The value of "Current User" does not match the function current_user() >> --- as one might expcect. It is a little confusing, as there is no >> mention of "Current User" in the docs. In case this is the intended >> behaviour, could you

Re: Regression tests fail with tzdata 2024b

2024-09-16 Thread Tom Lane
Sven Klemm writes: > This is an unfortunate change as this will break extensions tests using > pg_regress for testing. We run our tests against multiple minor versions > and this getting backported means our tests will fail with the next minor > pg release. Is there a workaround available to make

Re: AIO v2.0

2024-09-16 Thread Noah Misch
On Fri, Sep 06, 2024 at 03:38:16PM -0400, Andres Freund wrote: > There's plenty more to do, but I thought this would be a useful checkpoint. I find patches 1-5 are Ready for Committer. > +typedef enum PgAioHandleState This enum clarified a lot for me, so I wish I had read it before anything else

Re: Add contrib/pg_logicalsnapinspect

2024-09-16 Thread Bertrand Drouvot
Hi, On Mon, Sep 16, 2024 at 04:02:51PM +0530, shveta malik wrote: > On Wed, Sep 11, 2024 at 4:21 PM Bertrand Drouvot > wrote: > > > > > > Yeah, good idea. Done that way in v3 attached. > > > > Thanks for the patch. +1 on the patch's idea. I have started > reviewing/testing it. It is WIP but plea

Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica.

2024-09-16 Thread Anton A. Melnikov
Hi! On 13.09.2024 18:20, Fujii Masao wrote: If I understand correctly, restartpoints_timed and restartpoints_done were separated because a restartpoint can be skipped. restartpoints_timed counts when a restartpoint is triggered by a timeout, whether it runs or not, while restartpoints_done only

Re: Psql meta-command conninfo+

2024-09-16 Thread Alvaro Herrera
On 2024-Sep-16, Jim Jones wrote: > * The value of "Current User" does not match the function current_user() > --- as one might expcect. It is a little confusing, as there is no > mention of "Current User" in the docs. In case this is the intended > behaviour, could you please add it to the docs?

Re: scalability bottlenecks with (many) partitions (and more)

2024-09-16 Thread Tomas Vondra
On 9/16/24 15:11, Jakub Wartak wrote: > On Fri, Sep 13, 2024 at 1:45 AM Tomas Vondra wrote: > >> [..] > >> Anyway, at this point I'm quite happy with this improvement. I didn't >> have any clear plan when to commit this, but I'm considering doing so >> sometime next week, unless someone objec

Re: Psql meta-command conninfo+

2024-09-16 Thread Jim Jones
On 16.09.24 08:51, Hunaid Sohail wrote: > I have attached a new patch that now prints all info in tabular format > for \conninfo+. I have also made the table output dynamic, so if the > connection uses SSL, the columns in the table will expand accordingly. > It looks much cleaner now. > I have a

Re: Fix some ubsan/asan related issues

2024-09-16 Thread Junwang Zhao
Hi Tristan, On Tue, Feb 6, 2024 at 11:53 AM Tristan Partin wrote: > > On Tue Jan 30, 2024 at 3:58 PM CST, Andres Freund wrote: > > Hi, > > > > On 2024-01-30 09:59:25 -0600, Tristan Partin wrote: > > > From 331cec1c9db6ff60dcc6d9ba62a9c8be4e5e95ed Mon Sep 17 00:00:00 2001 > > > From: Tristan Parti

Re: scalability bottlenecks with (many) partitions (and more)

2024-09-16 Thread Jakub Wartak
On Fri, Sep 13, 2024 at 1:45 AM Tomas Vondra wrote: > [..] > Anyway, at this point I'm quite happy with this improvement. I didn't > have any clear plan when to commit this, but I'm considering doing so > sometime next week, unless someone objects or asks for some additional > benchmarks etc. T

Re: POC, WIP: OR-clause support for indexes

2024-09-16 Thread Andrei Lepikhov
On 9/9/2024 12:36, Alexander Korotkov wrote: Also, I agree it get it's wrong to directly copy RestrictInfo struct in group_similar_or_args(). Instead, I've renamed make_restrictinfo_internal() to make_plain_restrictinfo(), which is intended to handle non-recursive cases when you've children alre

Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN

2024-09-16 Thread Tatsuo Ishii
Hi Ashutosh, Thank you for the review. > Thanks. This will do. Is there a way to force the larger partition to > be computed first? That way we definitely know that the last > computation was done when all the tuples in the tuplestore were in > memory. Not sure if there's any way to force it in

Re: how to speed up 002_pg_upgrade.pl and 025_stream_regress.pl under valgrind

2024-09-16 Thread Tomas Vondra
On 9/15/24 21:47, Tomas Vondra wrote: > On 9/15/24 20:31, Tom Lane wrote: >> Tomas Vondra writes: >>> [ 002_pg_upgrade and 027_stream_regress are slow ] >> >>> I don't have a great idea how to speed up these tests, unfortunately. >>> But one of the problems is that all the TAP tests run serially

Re: Introduce XID age and inactive timeout based replication slot invalidation

2024-09-16 Thread Amit Kapila
On Mon, Sep 16, 2024 at 3:31 PM Bharath Rupireddy wrote: > > Please find the attached v46 patch having changes for the above review > comments and your test review comments and Shveta's review comments. > -ReplicationSlotAcquire(const char *name, bool nowait) +ReplicationSlotAcquire(const char *n

Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN

2024-09-16 Thread Ashutosh Bapat
On Sat, Sep 14, 2024 at 1:42 PM Tatsuo Ishii wrote: > > >> > or the case when the last usage fit in memory but an earlier > >> > usage spilled to disk. > >> > >> In my understanding once tuplestore changes the storage type to disk, > >> it never returns to the memory storage type in terms of > >>

Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row

2024-09-16 Thread Jim Jones
On 12.09.24 12:13, jian he wrote: > please check the attached file. v4 applies cleanly, it works as expected, and all tests pass. postgres=# \pset null '(NULL)' Null display is "(NULL)". postgres=# CREATE TEMPORARY TABLE t2 (a int, b int); CREATE TABLE postgres=# COPY t2 (a,b) FROM STDIN WIT

Re: Allow logical failover slots to wait on synchronous replication

2024-09-16 Thread Amit Kapila
On Mon, Sep 16, 2024 at 2:55 PM shveta malik wrote: > > On Mon, Sep 16, 2024 at 11:13 AM Amit Kapila wrote: > > > > > Another question aside from the above point, what if someone has > > specified logical subscribers in synchronous_standby_names? In the > > case of synchronized_standby_slots, we

Re: Add contrib/pg_logicalsnapinspect

2024-09-16 Thread shveta malik
On Wed, Sep 11, 2024 at 4:21 PM Bertrand Drouvot wrote: > > > Yeah, good idea. Done that way in v3 attached. > Thanks for the patch. +1 on the patch's idea. I have started reviewing/testing it. It is WIP but please find few initial comments: src/backend/replication/logical/snapbuild.c: 1) + fsy

Re: Introduce XID age and inactive timeout based replication slot invalidation

2024-09-16 Thread Bharath Rupireddy
Hi, Thanks for reviewing. On Mon, Sep 9, 2024 at 1:11 PM Peter Smith wrote: > > 1. > +Note that the inactive timeout invalidation mechanism is not > +applicable for slots on the standby server that are being synced > +from primary server (i.e., standby slots having > > ni

Re: Introduce XID age and inactive timeout based replication slot invalidation

2024-09-16 Thread Bharath Rupireddy
Hi, Thanks for reviewing. On Mon, Sep 9, 2024 at 10:54 AM shveta malik wrote: > > 2) > src/sgml/config.sgml: > > + disables the inactive timeout invalidation mechanism > > + Slot invalidation due to inactivity timeout occurs during checkpoint. > > Either have 'inactive' at both the places or 'in

Re: A starter task

2024-09-16 Thread Tomas Vondra
On 9/16/24 10:35, sia kc wrote: > > > On Mon, Sep 16, 2024 at 11:28 AM Tomas Vondra > wrote: > > On 9/16/24 00:17, sia kc wrote: > > I have a bad experience. I picked up a task from MariaDB backlog, > > explained in their chat rooms that I started doing that.

Re: Allow logical failover slots to wait on synchronous replication

2024-09-16 Thread shveta malik
On Mon, Sep 16, 2024 at 11:13 AM Amit Kapila wrote: > > On Fri, Sep 13, 2024 at 3:13 PM shveta malik wrote: > > > > On Thu, Sep 12, 2024 at 3:04 PM shveta malik wrote: > > > > > > On Wed, Sep 11, 2024 at 2:40 AM John H wrote: > > > > > > > > Hi Shveta, > > > > > > > > On Sun, Sep 8, 2024 at 11:

Re: Virtual generated columns

2024-09-16 Thread jian he
in v7. doc/src/sgml/ref/alter_table.sgml and column_constraint is: section need representation of: GENERATED ALWAYS AS ( generation_expr ) [VIRTUAL] in RelationBuildTupleDesc(Relation relation) we need to add "constr->has_generated_virtual" for the following code? if (constr->has_not_null

Re: Doc: Move standalone backup section, mention -X argument

2024-09-16 Thread Marlene Reiterer
I compiled the patch and it worked without any problems. I think the patch makes sense, because of the structure of the current docs. It seems more logical to have this section in this part of the documentation, where it is useful and not only described for another chapter, because it won't even w

Re: A starter task

2024-09-16 Thread sia kc
On Mon, Sep 16, 2024 at 11:28 AM Tomas Vondra wrote: > On 9/16/24 00:17, sia kc wrote: > > I have a bad experience. I picked up a task from MariaDB backlog, > > explained in their chat rooms that I started doing that. After it was > > done which was a SQL command which MySQL already supported to

Re: Regression tests fail with tzdata 2024b

2024-09-16 Thread Sven Klemm
On Mon, Sep 16, 2024 at 7:09 AM Tom Lane wrote: > Wolfgang Walther writes: > > Tom Lane: > >> Also, as a real place to a greater extent > >> than "PST8PDT" is, it's more subject to historical revisionism when > >> somebody turns up evidence of local law having been different than > >> TZDB curre

Re: A starter task

2024-09-16 Thread Tomas Vondra
On 9/16/24 00:17, sia kc wrote: > I have a bad experience. I picked up a task from MariaDB backlog, > explained in their chat rooms that I started doing that. After it was > done which was a SQL command which MySQL already supported to restart > server instance with SQL, they started rethinking the

Re: A starter task

2024-09-16 Thread Tomas Vondra
On 9/16/24 08:49, Tony Wayne wrote: > FWIW, maybe it'd be better to start by looking at existing patches and > do a bit of a review, learn how to apply/test those and learn from them. > > lets say i have experience in wal,physical replication,buffer management > where can i find patches to review

Re: Pgoutput not capturing the generated columns

2024-09-16 Thread Peter Smith
On Fri, Sep 13, 2024 at 9:34 PM Shubham Khanna wrote: > > On Tue, Sep 10, 2024 at 2:51 AM Masahiko Sawada wrote: > > > > On Mon, Sep 9, 2024 at 2:38 AM Shubham Khanna > > wrote: > > > > > > On Thu, Aug 29, 2024 at 11:46 AM Amit Kapila > > > wrote: > > > > > > > > On Thu, Aug 29, 2024 at 8:44 A

Re: Add system column support to the USING clause

2024-09-16 Thread Denis Garsh
On 13.09.2024 17:56, Tom Lane wrote: I think this is an actively bad idea, and it was likely intentional that it's not supported today. A few reasons why: Thank you, Tom and David, for your feedback. I admit my mistake. I should have asked if this problem was worth solving before diving in.