At Fri, 8 Sep 2023 08:02:57 +, "Hayato Kuroda (Fujitsu)"
wrote in
> > > Ditching cmd.exe seems like a big hassle. So, on the flip side, I
> > > tried to identify the postmaster PID using the shell's PID, and it
> > > seem to work. The APIs used are avaiable from XP/2003 onwards.
>
> Accordi
Hi hackers,
It's not necessary to fill the key field for most cases, since
hash_search has already done that for you. For developer that
using memset to zero the entry structure after enter it, fill the
key field is a must, but IMHO that is not good coding style, we
really should not touch the key
On Mon, Sep 11, 2023 at 05:19:27PM +0530, vignesh C wrote:
> Added a function binary_upgrade_sub_replication_origin_advance which
> will: a) check if the subscription exists, b) get the replication name
> for subscription and c) advance the replication origin.
>
> These are handled as part of v7 p
On Wed, Sep 13, 2023 at 10:57 AM Michael Paquier wrote:
>
> On Tue, Sep 12, 2023 at 03:15:44PM +0530, Amit Kapila wrote:
> >>
> >> - Not sure that there is any point to mention the other code paths in
> >> the tree where ReplicationSlotSave() can be called, and a slot can be
> >> saved in other pr
On Wed, Sep 13, 2023 at 11:40:25AM +0530, Bharath Rupireddy wrote:
> When a snapshot file reading fails in ImportSnapshot(), it errors out
> with "invalid snapshot identifier". This message better suits for
> snapshot identifier parsing errors which is being done just before the
> file reading. The
Hi,
When a snapshot file reading fails in ImportSnapshot(), it errors out
with "invalid snapshot identifier". This message better suits for
snapshot identifier parsing errors which is being done just before the
file reading. The attached patch adds a generic file reading error
message with path to
You are right, I came to this erroneous conclusion based on the following
mishandled experiment: My test program is shown below.
typedef struct ColumnIdentifier
{
Oidrelid;
AttrNumber resno;
} ColumnIdentifier;
typedef struct ColumnType
{
ColumnIdentifier colId;
12.09.2023 11:45, jian he wrote:
On Mon, Sep 11, 2023 at 8:00 PM Alexander Lakhin wrote:
I can confirm that all those anomalies are fixed now.
But new version brings a warning when compiled with gcc:
arrayfuncs.c:659:9: warning: variable 'prev_tok' is uninitialized when used
here [-Wuninitiali
On Tue, Sep 12, 2023 at 03:15:44PM +0530, Amit Kapila wrote:
> I don't think it will become more responsive in any way, not sure what
> made you think like that. The key idea is that after restart we want
> to ensure that all the WAL data up to the shutdown checkpoint record
> is sent to downstream
>
I was looking for this but I only found ISO/IEC 19075-5:2021.
https://www.iso.org/standard/78936.html
Maybe 19075-5:2021 is the latest one?
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
Hi,
Here is the patch rebased on the current master. Also, I fixed some
minor slips and one static analyzer warning.
This is just for adding to the next commitfest and enforcing work with
this patch.
One extra difference in newly added postgres_fdw tests is caused by this
patch - see changes
Op 9/13/23 om 03:00 schreef Erik Wienhold:
Hi David,
On 13/09/2023 02:16 CEST David E. Wheeler wrote:
CREATE TABLE MOVIES (id SERIAL PRIMARY KEY, movie JSONB NOT NULL);
\copy movies(movie) from PROGRAM 'curl -s
https://raw.githubusercontent.com/prust/wikipedia-movie-data/master/movies.json |
On Wed, Sep 13, 2023 at 8:43 AM Peter Smith wrote:
>
> Yesterday noticed a TAP test assignment to an unused $result.
>
> PSA patch to remove that.
>
Though it is harmless I think we can clean it up. Your patch looks good to me.
--
With Regards,
Amit Kapila.
On Wed, Sep 13, 2023 at 12:48:48AM +, Imseih (AWS), Sami wrote:
> The patch also modifies existing test cases for CALL handling in
> pg_stat_statements
> and adds additional tests which prove that a CALL to an overloaded procedure
> will generate a different query_id.
+CALL overload(1);
+CALL
Hi,
On 2023-08-28 17:29:56 +1200, Thomas Munro wrote:
> As an experiment, I hacked up a not-good-enough-to-share experiment
> where $node->safe_psql() would automatically cache a BackgroundPsql
> object and reuse it, and the times for that test dropped ~51 -> ~9s on
> Windows, and ~7 -> ~2s on the
On Wed, 13 Sep 2023 10:20:23 +0900
Michael Paquier wrote:
> On Tue, Sep 12, 2023 at 03:18:05PM +0900, Michael Paquier wrote:
> > On Wed, Sep 06, 2023 at 12:45:24AM +0900, Yugo NAGATA wrote:
> > > I attached the update patch. I removed the incorrect comments and
> > > unnecessary lines. Also, I r
On Tue, Sep 12, 2023 at 07:00:14PM +1000, Peter Smith wrote:
> Right. I found just a single test currently using pg_stat_subscription
> catalog. I added a worker_type check for that.
This looks enough to me, thanks!
--
Michael
signature.asc
Description: PGP signature
On Wed, Sep 13, 2023 at 09:59:22AM +0900, Kyotaro Horiguchi wrote:
> At Tue, 12 Sep 2023 09:03:27 +0900, Michael Paquier
> wrote in
> > On Mon, Sep 11, 2023 at 12:15:49PM -0700, Jeff Davis wrote:
> > > That's fine with me.
> >
> > Okay. Then, please find attached a v4 for HEAD and REL_16_STABL
On Tue, Sep 12, 2023 at 09:40:04PM -0300, Ranier Vilela wrote:
> I think that is not a good idea.
Hm? We already use __func__ across the tree even on Windows and
nobody has complained about that. Using a macro for the elog()
generated would be slightly more elegant, actually.
--
Michael
signat
Thanks for pointing that, I did miss some other "ncols * nrows" places.
Uploaded v3 patch to fix them.
As for the Windows, I didn't test it before but I think it should also have the
issue (and happens more possible since `cellsadded` is also a long type).
My fix idea is simple: define a common
Yesterday noticed a TAP test assignment to an unused $result.
PSA patch to remove that.
--
Kind Regards,
Peter Smith.
Fujitsu Australia
v1-0001-remove-redundant-result-assignment.patch
Description: Binary data
ywgrit writes:
> According to the description, the keycopy function only copies the key, but
> in reality it copies the entire entry, i.e., the key and the value,
On what grounds do you claim that? dynahash.c only ever passes "keysize"
as the size parameter.
regards, tom
On Tue, Sep 12, 2023 at 03:18:05PM +0900, Michael Paquier wrote:
> On Wed, Sep 06, 2023 at 12:45:24AM +0900, Yugo NAGATA wrote:
> > I attached the update patch. I removed the incorrect comments and
> > unnecessary lines. Also, I rewrote the test to use "skip_all" instead
> > of SKIP because we ski
Hi,
Currently, the psql's tab completion feature does not support properly
for ATTACH PARTITION. When key is typed after "ALTER TABLE
ATTACH PARTITION ", all possible table names should be
displayed, however, foreign table names are not displayed. So I created
a patch that addresses this is
The definition of hashctl is shown below
typedef struct HASHCTL
{
long num_partitions; /* # partitions (must be power of 2) */
long ssize; /* segment size */
long dsize; /* (initial) directory size */
long
Hi David,
On 13/09/2023 02:16 CEST David E. Wheeler wrote:
> CREATE TABLE MOVIES (id SERIAL PRIMARY KEY, movie JSONB NOT NULL);
> \copy movies(movie) from PROGRAM 'curl -s
> https://raw.githubusercontent.com/prust/wikipedia-movie-data/master/movies.json
> | jq -c ".[]" | sed "s|||g
At Tue, 12 Sep 2023 09:03:27 +0900, Michael Paquier wrote
in
> On Mon, Sep 11, 2023 at 12:15:49PM -0700, Jeff Davis wrote:
> > That's fine with me.
>
> Okay. Then, please find attached a v4 for HEAD and REL_16_STABLE.
For example, they result in the following message:
ERROR: unsupported col
Hi,
The proposal by Bertrand in CC to jumble CALL and SET in [1] was
rejected at the time for a more robust solution to jumble DDL.
Michael also in CC made this possible with commit 3db72ebcbe.
The attached patch takes advantage of the jumbling infrastructure
added in the above mentioned commit
Em ter., 12 de set. de 2023 às 17:51, Jeff Davis
escreveu:
> On Tue, 2023-09-12 at 09:03 +0900, Michael Paquier wrote:
> > On Mon, Sep 11, 2023 at 12:15:49PM -0700, Jeff Davis wrote:
> > > That's fine with me.
> >
> > Okay. Then, please find attached a v4 for HEAD and REL_16_STABLE.
>
> One ques
Hi Kuroda-san. Here are my review comments for patch v36-0002.
==
doc/src/sgml/ref/pgupgrade.sgml
1.
Configure the servers for log shipping. (You do not need to run
pg_backup_start() and
pg_backup_stop()
or take a file system backup as the standbys are still synchroni
On Fri, Sep 8, 2023 at 7:52 AM Bruce Momjian wrote:
>
> On Thu, Sep 7, 2023 at 09:21:07PM -0700, Nathan Bossart wrote:
> > On Thu, Sep 07, 2023 at 07:13:44PM -0400, Bruce Momjian wrote:
> > > On Thu, Sep 7, 2023 at 02:54:13PM -0700, Nathan Bossart wrote:
> > >> IMO the phrase "open a port" is ki
Greetings Hackers,
Been a while! I’m working on some experiments with JSONB columns and GIN
indexes, and have operated on the assumption that JSON Path operations would
take advantage of GIN indexes, with json_path_ops as a nice optimization. But
I’ve run into what appear to be some inconsisten
Hi,
On 2023-08-30 10:57:10 +0200, Daniel Gustafsson wrote:
> > On 28 Aug 2023, at 14:32, Daniel Gustafsson wrote:
>
> > Attached is a patch with a quick PoC for using PQPing instead of using psql
> > for
> > connection checks in pg_regress.
>
> The attached v2 fixes a silly mistake which led t
On Tue, 2023-09-05 at 12:08 -0700, Jeff Davis wrote:
> OK, so we could have a built-in FDW called pg_connection that would
> do
> the right kinds of validation; and then also allow other FDWs but the
> subscription would have to do its own validation.
While working on this, I found a minor bug and
One of the frustrations with using the "C" locale (or any deterministic
locale) is that the following returns false:
SELECT 'á' = 'á'; -- false
because those are the unicode sequences U&'\0061\0301' and U&'\00E1',
respectively, so memcmp() returns non-zero. But it's really the same
character
On Mon, Sep 11, 2023 at 11:18 PM Tatsuo Ishii wrote:
> What I am not sure about is, you and Vik mentioned that the
> traditional NFA is superior that POSIX NFA in terms of performance.
> But how "lexicographic ordering" is related to performance?
I think they're only tangentially related. POSIX N
On Mon, 2023-08-07 at 15:39 -0700, Nathan Bossart wrote:
> 0003 is looking pretty good, too, but I think we
> should get some more eyes on it, given the complexity.
Attached rebased version of 0003.
--
Jeff Davis
PostgreSQL Contributor Team - AWS
From f5b055aea1bf08928de1bffcfd7b202e28847595 M
On Tue, 2023-09-12 at 09:03 +0900, Michael Paquier wrote:
> On Mon, Sep 11, 2023 at 12:15:49PM -0700, Jeff Davis wrote:
> > That's fine with me.
>
> Okay. Then, please find attached a v4 for HEAD and REL_16_STABLE.
One question: would it make sense to use __func__?
Other than that, looks good.
Hello,
On 7/25/23 07:21, Daniel Gustafsson wrote:
> The attached version passes ssl tests for me on 1.0.2 through OpenSSL Git
> HEAD.
Tests pass for me too, including LibreSSL 3.8.
> + /* Calculate the diff from the epoch to the certificat timestamp */
"certificate"
> + ssl_client_get_n
On Fri, 1 Sept 2023 at 19:52, Tom Lane wrote:
>
> Alvaro Herrera writes:
> > On 2023-Sep-01, Matthias van de Meent wrote:
> >> A potential addition to the patch would to stop manually closing
> >> relations: initdb and check-world succeed without manual 'close'
> >> operations because the 'open'
Matthias van de Meent writes:
> Hmm, maybe we should measure the overhead of serializing the tuples instead.
> The difference between your patch and "serializing the tuples, but not
> sending them" is that serializing also does the detoasting, but also
> includes any time spent in the serializatio
Serpent writes:
> I'm talking about this part:
> PG_TRY();
> {
> ... code that might throw ereport(ERROR) ...
> }
Ah. Your phrasing needs work for clarity then. Also, "return"
is hardly the only way to break it; break, continue, or goto
leading out of the PG_TRY are other possibilities. May
Hi Matthias,
thanks for your feedback.
I wasn't sure on the memory-contexts. I was actually also unsure on
whether the array
TupleTableSlot.tts_isnull
is also set up correctly by the previous call to slot_getallattrs(slot).
This would allow to get rid of even more code from this patch, which
Tom Lane writes:
> Peter Eisentraut writes:
>> Would it work to just overload pg_get_serial_sequence with regclass
>> argument types?
>
> Probably not; the parser would have no principled way to resolve
> pg_get_serial_sequence('foo', 'bar') as one or the other. I'm
> not sure offhand if it wo
Peter Eisentraut writes:
> On 06.09.23 17:01, Alvaro Herrera wrote:
>> Assert()ing that a pointer is not null, and in the next line
>> dereferencing that pointer, is useless: the process would crash anyway
>> at the time of dereference, so the Assert() adds no value. Better to
>> leave the assert
Peter Eisentraut writes:
> Would it work to just overload pg_get_serial_sequence with regclass
> argument types?
Probably not; the parser would have no principled way to resolve
pg_get_serial_sequence('foo', 'bar') as one or the other. I'm
not sure offhand if it would throw error or just choose
Serpent writes:
> I created a tiny patch that documents that the code block following
> PG_TRY() cannot have any return statement.
AFAIK, this is wrong. The actual requirement is already stated
in the comment:
* ... The error recovery code
* can either do PG_RE_THROW to propagate the error ou
Dear Hou,
Thank you for reviewing!
> 1.
>
> #include "access/transam.h"
> #include "catalog/pg_language_d.h"
> +#include "fe_utils/string_utils.h"
> #include "pg_upgrade.h"
>
> It seems we don't need this head file anymore.
Removed.
> 2.
> + if (*invalidated && SlotIsLogical(s)
Hi,
Please find attached v5.
What changed:
1. Now we collect which files should be kept in a separate hash table.
2. Decision whether to keep the file is made only when the file is actually
missing on the source. That is, remaining WAL files will be copied over as
it currently is, although it cou
On Monday, September 11, 2023 6:32 PM vignesh C wrote:
>
>
> The attached v7 patch has the changes for the same.
Thanks for updating the patch, here are few comments:
1.
+/*
+ * binary_upgrade_sub_replication_origin_advance
+ *
+ * Update the remote_lsn for the subscriber's replication origi
When running the Postgres JDBC tests with this patchset I found dumb
mistake in my last patch where I didn't initialize the contents of
orig_params correctly. This new patchset fixes that.
v4-0001-Support-prepared-statement-invalidation-when-resu.patch
Description: Binary data
v4-0002-Complete
Hi,
I created a tiny patch that documents that the code block following
PG_TRY() cannot have any return statement.
Please CC me, as I'm not subscribed to this list.
commit 1968e53b9a649691fbedbdc059e2e933aa2b471b
Author: Serpent7776
Date: Tue Sep 12 14:38:09 2023 +0200
Document that PG_TR
Hi,
> Maybe in addition to making "ALTER SYSTEM" throw an error, the feature that
> disables it should also disable reading postgresql.auto.conf? Maybe even
> delete it and make it an error if it is present on startup (maybe even warn
> if it shows up while the DB is running?).
The outcome loo
On Tue, 12 Sept 2023 at 12:56, stepan rutz wrote:
>
> Hi,
>
> I have fallen into this trap and others have too. If you run
> EXPLAIN(ANALYZE) no de-toasting happens. This makes query-runtimes
> differ a lot. The bigger point is that the average user expects more
> from EXPLAIN(ANALYZE) than what i
On 5/7/2023 21:28, Andrey Lepikhov wrote:
Hi,
During the significant code revision in v.41 I lost some replacement
operations. Here is the fix and extra tests to check this in the future.
Also, Tom added the JoinDomain structure five months ago, and I added
code to replace relids for that plac
Dear Peter,
Thank you for reviewing! PSA new version.
> src/backend/replication/slot.c
>
> 3. InvalidatePossiblyObsoleteSlot
>
> + /*
> + * Raise an ERROR if the logical replication slot is invalidating. It
> + * would not happen because max_slot_wal_keep_size is set to -1 during
> + * the upgr
Dear Peter,
Thank you for reviewing!
=
> Commit message
>
> 1.
> Note that the pg_resetwal command would remove WAL files, which are required
> as
> restart_lsn. If WALs required by logical replication slots are removed, they
> are
> unusable. Therefore, during the upgrade, slot restoration
Hi,
Found server crash on RHEL 9/s390x platform with below test case -
*Machine details:*
*[edb@9428da9d2137 postgres]$ cat /etc/redhat-release AlmaLinux release 9.2
(Turquoise Kodkod)[edb@9428da9d2137 postgres]$ lscpuArchitecture:
s390x CPU op-mode(s): 32-bit, 64-bit Address sizes
On Wed, Aug 30, 2023 at 9:20 PM Robert Haas wrote:
>
> Meanwhile, here's a rebased set of patches. The somewhat-primitive
> attempts at writing tests are in 0009, but they don't work, for the
> reasons explained above. I think I'd probably like to go ahead and
> commit 0001 and 0002 soon if there
On Tue, Sep 12, 2023 at 10:55 AM Michael Paquier wrote:
>
> On Mon, Sep 11, 2023 at 02:49:49PM +0530, Amit Kapila wrote:
>
> Please see the v11 attached, that rewords all the places of the patch
> that need clarifications IMO. I've found that the comment additions
> in CheckPointReplicationSlots(
Hi,
I have fallen into this trap and others have too. If you run
EXPLAIN(ANALYZE) no de-toasting happens. This makes query-runtimes
differ a lot. The bigger point is that the average user expects more
from EXPLAIN(ANALYZE) than what it provides. This can be suprising. You
can force detoasting dur
On Thu, 7 Sept 2023 at 17:26, Himanshu Upadhyaya
wrote:
>
> Attached is v2 of the patch, rebased against the latest HEAD.
Thanks for working on this, few comments:
1) "CREATE TABLE check_constr_tbl (i int CHECK(i<>0) DEFERRABLE, t
text)" is crashing in windows, the same was noticed in CFBot too:
On Thu, 24 Aug 2023 at 14:51, Ashutosh Bapat
wrote:
>
> The patches still apply. But here's a rebased version with one white
> space error fixed. Also ran pgindent.
>
This needs another rebase, and it looks like the infinite interval
input code is broken.
I took a quick look, and had a couple of
hi. some trivial issue:
in src/backend/catalog/index.c
/* * System attributes are never null, so no need to check. */
if (attnum <= 0)
since you already checked attnum == 0
so here you can just attnum < 0?
-
ERROR: column "valid_at" named in WITHOU
On Tue, Sep 12, 2023 at 1:44 PM Michael Paquier wrote:
>
> On Tue, Sep 12, 2023 at 01:07:51PM +1000, Peter Smith wrote:
> > The type is only assigned during worker process launch, and during
> > process cleanup [1]. It's only possible to be UNKNOWN after
> > logicalrep_worker_cleanup().
> >
> > AF
Dear Vignesh,
Thank you for updating the patch! Here are some comments.
Sorry if there are duplicate comments - the thread revived recently so I might
lose my memory.
01. General
Is there a possibility that apply worker on old cluster connects to the
publisher during the upgrade? Regarding the
On Mon, Sep 11, 2023 at 8:00 PM Alexander Lakhin wrote:
>
> I can confirm that all those anomalies are fixed now.
> But new version brings a warning when compiled with gcc:
> arrayfuncs.c:659:9: warning: variable 'prev_tok' is uninitialized when used
> here [-Wuninitialized]
>
Regarding v6 patch:
> SELECT company, tdate, price,
> first_value(price) OVER w,
> last_value(price) OVER w,
> max(price) OVER w,
> min(price) OVER w,
> sum(price) OVER w,
> avg(price) OVER w,
> count(price) OVER w
> FROM stock
> WINDOW w AS (
> PARTITION BY company
> ROWS BETWEEN CURRENT R
Dear Michael,
> On Tue, Sep 12, 2023 at 02:33:25AM +, Zhijie Hou (Fujitsu) wrote:
> > 2.
> > + if (*invalidated && SlotIsLogical(s) && IsBinaryUpgrade)
> > + elog(ERROR, "Replication slots must not be invalidated
> during the upgrade.");
> >
> > I think normally the
On 04.09.23 22:30, Tom Lane wrote:
Noah Misch writes:
On Mon, Sep 04, 2023 at 08:16:44PM +0200, Daniel Gustafsson wrote:
On 4 Sep 2023, at 17:01, Tom Lane wrote:
I think this is a seriously bad idea. The entire point of not including
certain tests in check-world by default is that the omitt
On 06.09.23 05:07, Thomas Munro wrote:
This sounds better than the QUERY_SEPARATOR hack from commit
664d757531e, and similar kludges elsewhere. I think Pavel and David
are right about NUL being impossible in psql query output, no?
Note:
-z, --field-separator-zero
On 06.09.23 17:01, Alvaro Herrera wrote:
Assert()ing that a pointer is not null, and in the next line
dereferencing that pointer, is useless: the process would crash anyway
at the time of dereference, so the Assert() adds no value. Better to
leave the assert out.
I don't think this is quite co
On 11.09.23 13:59, Jelte Fennema wrote:
@Tom and @Robert, since you originally suggested extending the
protocol for this, I think some input from you on the protocol design
would be quite helpful. BTW, this protocol extension is the main
reason I personally care for this patch, because it would a
On 09.06.23 21:19, Dagfinn Ilmari Mannsåker wrote:
I've always been annoyed by the fact that pg_get_serial_sequence takes
the table and returns the sequence as strings rather than regclass. And
since identity columns were added, the name is misleading as well (which
is even acknowledged in the do
Thank you for letting me know more about the test method.
As you said, we applied the patch using git diff and created a test case on
the src/test/regress/sql.
Considering your question, we think it is enough to assume just one
subpartition level.
Because, Concidering the common partition configura
Dear Peter,
Thank you for reviewing! Before posting new patch set, I want to respond some
comments.
>
> ==
> 1. GENERAL -- Cluster Terminology
>
> This is not really a problem of your patch, but during message review,
> I noticed the terms old/new cluster VERSUS source/target cluster and
>
76 matches
Mail list logo
