Re: table_open/table_close with different lock mode

On Thu, Jul 20, 2023 at 11:38 PM Junwang Zhao wrote: > > On Fri, Jul 21, 2023 at 2:26 PM Michael Paquier wrote: > > > > On Fri, Jul 21, 2023 at 02:05:56PM +0800, Junwang Zhao wrote: > > > I noticed there are some places calling table_open with > > > RowExclusiveLock but table_close with NoLock, l

Re: Support worker_spi to execute the function dynamically.

On Fri, Jul 21, 2023 at 11:54 AM Michael Paquier wrote: > > On Fri, Jul 21, 2023 at 11:24:08AM +0530, Bharath Rupireddy wrote: > > Okay. Here's a quick patch for adding TAP tests to the worker_spi > > module. We can change it to taste. > > What do you think if we removed completely the sql/ test,

Re: table_open/table_close with different lock mode

On Fri, Jul 21, 2023 at 2:26 PM Michael Paquier wrote: > > On Fri, Jul 21, 2023 at 02:05:56PM +0800, Junwang Zhao wrote: > > I noticed there are some places calling table_open with > > RowExclusiveLock but table_close with NoLock, like in function > > toast_save_datum. > > > > Can anybody explain

Re: MERGE ... RETURNING

On Mon, Jul 17, 2023 at 12:43 PM Jeff Davis wrote: > > On Fri, 2023-07-14 at 09:55 +0100, Dean Rasheed wrote: > > I found a 10-year-old thread discussing adding support for OLD/NEW to > > RETURNING [1], but it doesn't look like anything close to a > > committable solution was developed, or even a

Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication

On Fri, Jul 21, 2023 at 3:39 PM Amit Kapila wrote: > > On Fri, Jul 21, 2023 at 7:30 AM Peter Smith wrote: > > > > ~~~ > > > > 2. StartLogRepWorker > > > > /* Common function to start the leader apply or tablesync worker. */ > > void > > StartLogRepWorker(int worker_slot) > > { > > /* Attach to sl

Re: table_open/table_close with different lock mode

On Fri, Jul 21, 2023 at 02:05:56PM +0800, Junwang Zhao wrote: > I noticed there are some places calling table_open with > RowExclusiveLock but table_close with NoLock, like in function > toast_save_datum. > > Can anybody explain the underlying logic, thanks in advance. This rings a bell. This is

Re: Support worker_spi to execute the function dynamically.

On Fri, Jul 21, 2023 at 11:24:08AM +0530, Bharath Rupireddy wrote: > Okay. Here's a quick patch for adding TAP tests to the worker_spi > module. We can change it to taste. What do you think if we removed completely the sql/ test, moving it to TAP so as we have only one cluster set up when running

Re: MERGE ... RETURNING

On Fri, Jul 14, 2023 at 1:55 AM Dean Rasheed wrote: > > On Thu, 13 Jul 2023 at 20:14, Jeff Davis wrote: > > > > On Thu, 2023-07-13 at 18:01 +0100, Dean Rasheed wrote: > > > For some use cases, I can imagine allowing OLD/NEW.colname would mean > > > you wouldn't need pg_merge_action() (if the colu

Re: Row pattern recognition

Hi, > Hi Ishii-san, > > On 7/19/23 22:15, Tatsuo Ishii wrote: >> Currently my patch has a limitation for the sake of simple >> implementation: a pattern like "A+" is parsed and analyzed in the raw >> parser. This makes subsequent process much easier because the pattern >> element variable (in thi

Re: Synchronizing slots from primary to standby

On Thu, Jul 20, 2023 at 5:05 PM shveta malik wrote: > > On Fri, Jun 16, 2023 at 3:26 PM Amit Kapila wrote: > > > > On Mon, Apr 17, 2023 at 7:37 PM Drouvot, Bertrand > > wrote: > > > > > > 3. As mentioned in the initial email, I think it would be better to > > replace LIST_SLOTS command with a SE

table_open/table_close with different lock mode

Hey hackers, I noticed there are some places calling table_open with RowExclusiveLock but table_close with NoLock, like in function toast_save_datum. Can anybody explain the underlying logic, thanks in advance. -- Regards Junwang Zhao

Re: WAL Insertion Lock Improvements

On Thu, Jul 20, 2023 at 02:38:29PM +0530, Bharath Rupireddy wrote: > On Fri, Jul 14, 2023 at 4:17 AM Andres Freund wrote: >> I think this commit does too many things at once. > > I've split the patch into three - 1) Make insertingAt 64-bit atomic. > 2) Have better commenting on why there's no mem

Re: Support worker_spi to execute the function dynamically.

On Fri, Jul 21, 2023 at 8:38 AM Michael Paquier wrote: > > On Thu, Jul 20, 2023 at 03:44:12PM +0530, Bharath Rupireddy wrote: > > I don't think that change is correct. The worker_spi essentially shows > > how to start bg workers with RegisterBackgroundWorker and dynamic bg > > workers with Registe

Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication

On Fri, Jul 21, 2023 at 7:30 AM Peter Smith wrote: > > ~~~ > > 2. StartLogRepWorker > > /* Common function to start the leader apply or tablesync worker. */ > void > StartLogRepWorker(int worker_slot) > { > /* Attach to slot */ > logicalrep_worker_attach(worker_slot); > > /* Setup signal handling

PATCH: Add REINDEX tag to event triggers

Added my v1 patch to add REINDEX to event triggers. I originally built this against pg15 but rebased to master for the patch to hopefully make it easier for maintainers to merge. The rebase was automatic so it should be easy to include into any recent version. I'd love for this to land in pg16 if

Re: POC: GROUP BY optimization

On 20/7/2023 18:46, Tomas Vondra wrote: On 7/20/23 08:37, Andrey Lepikhov wrote: On 3/10/2022 21:56, Tom Lane wrote: Revert "Optimize order of GROUP BY keys". This reverts commit db0d67db2401eb6238ccc04c6407a4fd4f985832 and several follow-on fixes. ... Since we're hard up against the release d

Re: Buildfarm failures on chipmunk

At Fri, 21 Jul 2023 09:10:54 +0530, vignesh C wrote in > postmaster.log shows the following error: > 2023-07-20 08:21:00.343 GMT [27063] LOG: unrecognized configuration > parameter "force_parallel_mode" in file > "/home/pgbfarm/buildroot/HEAD/pgsql.build/src/test/regress/tmp_check/data/postgresq

Re: Buildfarm failures on chipmunk

HI, > On Jul 21, 2023, at 11:40, vignesh C wrote: > > Hi, > > Recently chipmunk has failed with the following errors at [1]: > > make -C '../../..' > DESTDIR='/home/pgbfarm/buildroot/HEAD/pgsql.build'/tmp_install install >> '/home/pgbfarm/buildroot/HEAD/pgsql.build'/tmp_install/log/install.log

Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication

Some review comments for v21-0002. On Thu, Jul 20, 2023 at 11:41 PM Melih Mutlu wrote: > > Hi, > > Attached the updated patches with recent reviews addressed. > > See below for my comments: > > Peter Smith , 19 Tem 2023 Çar, 06:08 tarihinde şunu > yazdı: >> >> 5. >> + /* Found a table for next i

Buildfarm failures on chipmunk

Hi, Recently chipmunk has failed with the following errors at [1]: make -C '../../..' DESTDIR='/home/pgbfarm/buildroot/HEAD/pgsql.build'/tmp_install install >'/home/pgbfarm/buildroot/HEAD/pgsql.build'/tmp_install/log/install.log 2>&1 make -j1 checkprep >>'/home/pgbfarm/buildroot/HEAD/pgsql.build

Re: Use of additional index columns in rows filtering

On Thu, Jul 20, 2023 at 4:35 AM Tomas Vondra wrote: > I think the SAOP patch may need to be much more careful about this, but > for this patch it's simpler because it doesn't really change any of the > index internals, or the indexscan in general. It's true that the SAOP patch needs relatively co

Re: Support worker_spi to execute the function dynamically.

On Thu, Jul 20, 2023 at 03:44:12PM +0530, Bharath Rupireddy wrote: > I don't think that change is correct. The worker_spi essentially shows > how to start bg workers with RegisterBackgroundWorker and dynamic bg > workers with RegisterDynamicBackgroundWorker. If > shared_preload_libraries = worker_s

Re: Use COPY for populating all pgbench tables

On Thu, Jul 20, 2023 at 02:22:51PM -0500, Tristan Partin wrote: > Thanks for your testing Michael. I went ahead and added a test to make sure > that this behavior doesn't regress accidentally, but I am struggling to get > the test to fail using the previous version of this patch. Do you have any >

Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication

Some review comments for v21-0001 == src/backend/replication/logical/worker.c 1. InitializeLogRepWorker if (am_tablesync_worker()) ereport(LOG, - (errmsg("logical replication table synchronization worker for subscription \"%s\", table \"%s\" has started", + (errmsg("logical replication w

Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication

On Thu, Jul 20, 2023 at 11:41 PM Melih Mutlu wrote: > > Hi, > > Attached the updated patches with recent reviews addressed. > > See below for my comments: > > Peter Smith , 19 Tem 2023 Çar, 06:08 tarihinde şunu > yazdı: >> >> Some review comments for v19-0001 >> >> 2. LogicalRepSyncTableStart >>

Re: doc: improve the restriction description of using indexes on REPLICA IDENTITY FULL table.

On Wed, Jul 19, 2023 at 5:09 PM Önder Kalacı wrote: > > Hi Masahiko, Amit, all > >> I've updated the patch. > > > I think the flow is much nicer now compared to the HEAD. I really don't have > any > comments regarding the accuracy of the code changes, all looks good to me. > Overall, I cannot see

Re: logicalrep_message_type throws an error

On Fri, Jul 21, 2023 at 1:39 AM Ashutosh Bapat wrote: > > On Thu, Jul 20, 2023 at 9:11 AM Amit Kapila wrote: > > > > > > Okay, changed it accordingly. > > > > > > > oops, forgot to attach the patch. > > > > WFM > > @@ -3367,7 +3367,7 @@ apply_dispatch(StringInfo s) > default: >

Re: Row pattern recognition

On 7/21/23 01:36, Jacob Champion wrote: There's also the issue of backtracking in the face of reclassification, as I think Vik was alluding to upthread. We definitely need some kind of backtracking or other reclassification method. (I've attached two failing tests against v2, to hopefully b

Re: Row pattern recognition

Hi Ishii-san, On 7/19/23 22:15, Tatsuo Ishii wrote: > Currently my patch has a limitation for the sake of simple > implementation: a pattern like "A+" is parsed and analyzed in the raw > parser. This makes subsequent process much easier because the pattern > element variable (in this case "A") and

Re: Atomic ops for unlogged LSN

Based on your feedback, I’ve updated the patch with additional comments. 1. Explain the two cases when writing to the control file, and 2. a bit more emphasis on unloggedLSNs not being valid after a crash. Thanks to y’all. * John v2-0001-Use-atomic-ops-for-unloggedLSNs.patch Descript

Re: Performance degradation on concurrent COPY into a single relation in PG16.

On Thu, 20 Jul 2023 at 20:37, Dean Rasheed wrote: > > On Thu, 20 Jul 2023 at 00:56, David Rowley wrote: > I agree with the principal though. In the attached updated patch, I > replaced that test with a simpler one: > > +/* > + * Process the number's digits. We optimize for decimal input (

Re: Bytea PL/Perl transform

>Friday, 14 July 2023, 23:27 +03:00 от Tom Lane : >  >=?UTF-8?B?SXZhbiBQYW5jaGVua28=?= < w...@mail.ru > writes: >> Четверг, 6 июля 2023, 14:48 +03:00 от Peter Eisentraut < >> pe...@eisentraut.org >: >>> If the transform deals with a built-in type, then they should just be >>> added to the respect

Re: In Postgres 16 BETA, should the ParseNamespaceItem have the same index as it's RangeTableEntry?

Hello, Thank you for the help guys and I'm so sorry for my late response. Indeed, the error relies on the ResultRelInfo. In GetResultRTEPermissionInfo() function, it does a checking on the relinfo->ri_RootResultRelInfo variable. I believe that it should go inside this scope: if (relinfo-

Re: Use COPY for populating all pgbench tables

On Wed Jul 19, 2023 at 10:07 PM CDT, Michael Paquier wrote: So this patch causes pgbench to not stick with its historical behavior, and the change is incompatible with the comments because the tellers and branches tables don't use NULL for their filler attribute anymore. Great find. This was a

Re: Inefficiency in parallel pg_restore with many tables

Here is a work-in-progress patch set for converting ready_list to a priority queue. On my machine, Tom's 100k-table example [0] takes 11.5 minutes without these patches and 1.5 minutes with them. One item that requires more thought is binaryheap's use of Datum. AFAICT the Datum definitions live

Re: There should be a way to use the force flag when restoring databases

On Thu, Jul 20, 2023 at 2:10 AM Daniel Gustafsson wrote: > > > On 19 Jul 2023, at 19:28, Gurjeet Singh wrote: > > > > The docs for 'pg_restore --create` say "Create the database before > > restoring into it. If --clean is also specified, drop and recreate the > > target database before connecting

Re: logical decoding and replication of sequences, take 2

FWIW there's two questions related to the switch to XLOG_SMGR_CREATE. 1) Does smgr_decode() need to do the same block as sequence_decode()? /* Skip the change if already processed (per the snapshot). */ if (transactional && !SnapBuildProcessChange(builder, xid, buf->origptr))

Re: logicalrep_message_type throws an error

On Thu, Jul 20, 2023 at 9:11 AM Amit Kapila wrote: > > > > Okay, changed it accordingly. > > > > oops, forgot to attach the patch. > WFM @@ -3367,7 +3367,7 @@ apply_dispatch(StringInfo s) default: ereport(ERROR, (errcode(ERRCODE_PROTOCOL_VIOLATION), -

Re: Atomic ops for unlogged LSN

> what happens if … reader here stores the old unloggedLSN value > to control file and the server restarts (clean exit). So, the old >value is loaded back to unloggedLSN upon restart and the callers of > GetFakeLSNForUnloggedRel() will see an old/repeated value too. Is it a > problem? First, a c

Re: remaining sql/json patches

On 2023-Jul-21, Amit Langote wrote: > I’m thinking of pushing 0001 and 0002 tomorrow barring objections. 0001 looks reasonable to me. I think you asked whether to squash that one with the other bugfix commit for the same code that you already pushed to master; I think there's no point in committ

Re: pg15.3: dereference null *plan in CachedPlanIsSimplyValid/plpgsql

Justin Pryzby writes: > A production instance crashed like so. Oh, interesting. Apparently we got past the "Has cache invalidation fired on this plan?" check: if (!plansource->is_valid || plan != plansource->gplan || !plan->is_valid) return false; because "plan" and "plansource->gp

Re: remaining sql/json patches

On Thu, Jul 20, 2023 at 17:19 Amit Langote wrote: > On Wed, Jul 19, 2023 at 5:17 PM Amit Langote > wrote: > > On Wed, Jul 19, 2023 at 12:53 AM Alvaro Herrera > wrote: > > > On 2023-Jul-18, Amit Langote wrote: > > > > > > > Attached updated patches. In 0002, I removed the mention of the > > > >

pg15.3: dereference null *plan in CachedPlanIsSimplyValid/plpgsql

A production instance crashed like so. < 2023-07-20 05:41:36.557 MDT >LOG: server process (PID 106001) was terminated by signal 11: Segmentation fault [168417.649549] postmaster[106001]: segfault at 12 ip 008f1d40 sp 7ffe885502e0 error 4 in postgres[40+7dc000] Core was genera

Re: sslinfo extension - add notbefore and notafter timestamps

> On 17 Jul 2023, at 20:26, Cary Huang wrote: >>> Perhaps calling "tm2timestamp(&pgtm_time, 0, NULL, &ts)" without checking >>> the return code would be just fine. I see some other usages of >>> tm2timstamp() in other code areas also skip checking the return code. >> >> I think we want to know

Re: Printing backtrace of postgres processes

> On 11 Jan 2023, at 15:44, Bharath Rupireddy > wrote: > > On Wed, Nov 30, 2022 at 11:43 AM Bharath Rupireddy > wrote: >> >> I'm attaching the v22 patch set for further review. > > Needed a rebase due to 216a784829c2c5f03ab0c43e009126cbb819e9b2. > Attaching v23 patch set for further review.

Re: odd buildfarm failure - "pg_ctl: control file appears to be corrupt"

This patch no longer applies and needs a rebase. Given where we are in the commitfest, do you think this patch has the potential to go in or should it be moved? -- Daniel Gustafsson

Re: psql: Add role's membership options to the \du+ command

On 7/19/23 1:44 PM, Pavel Luzanov wrote: On 19.07.2023 19:47, Tom Lane wrote: And done, with some minor editorialization. Thanks to everyone who participated in the work. Special thanks to David for moving forward this patch for a long time, and to Tom for taking commit responsibilities. [R

Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication

Hi, Attached the updated patches with recent reviews addressed. See below for my comments: Peter Smith , 19 Tem 2023 Çar, 06:08 tarihinde şunu yazdı: > Some review comments for v19-0001 > > 2. LogicalRepSyncTableStart > > /* > * Finally, wait until the leader apply worker tells us to catch up a

Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication

On Thu, Jul 20, 2023 at 5:12 PM Melih Mutlu wrote: > > Peter Smith , 20 Tem 2023 Per, 05:41 tarihinde şunu > yazdı: >> >> 7. InitializeLogRepWorker >> >> if (am_tablesync_worker()) >> ereport(LOG, >> - (errmsg("logical replication worker for subscription \"%s\", table >> \"%s\" has started",

Re: Extracting cross-version-upgrade knowledge from buildfarm client

On 2023-07-20 Th 05:52, Alvaro Herrera wrote: On 2023-Jul-19, Andrew Dunstan wrote: The result you report suggest to me that somehow the old version is no longer a PostgreSQL::Version object.  Here's the patch I suggest: Ahh, okay, that makes more sense; and yes, it does work. Your patch L

Re: Add SPLIT PARTITION/MERGE PARTITIONS commands

The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed It is just a rebase I check with make and meson run manual sp

Re: POC: GROUP BY optimization

On 7/20/23 08:37, Andrey Lepikhov wrote: > On 3/10/2022 21:56, Tom Lane wrote: >> Revert "Optimize order of GROUP BY keys". >> >> This reverts commit db0d67db2401eb6238ccc04c6407a4fd4f985832 and >> several follow-on fixes. >> ... >> Since we're hard up against the release deadline for v15, let's >>

Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication

Hi, Peter Smith , 20 Tem 2023 Per, 05:41 tarihinde şunu yazdı: > 7. InitializeLogRepWorker > > if (am_tablesync_worker()) > ereport(LOG, > - (errmsg("logical replication worker for subscription \"%s\", table > \"%s\" has started", > + (errmsg("logical replication worker for subscription \"%s\

Re: Use of additional index columns in rows filtering

On 7/19/23 23:38, Peter Geoghegan wrote: > On Wed, Jul 19, 2023 at 1:46 PM Jeff Davis wrote: >> On Wed, 2023-07-19 at 20:03 +0200, Tomas Vondra wrote: >>> Makes sense, I also need to think about maybe not having duplicate >>> clauses in the two lists. What annoys me on that it partially >>> pre

Re: Synchronizing slots from primary to standby

On Fri, Jun 16, 2023 at 3:26 PM Amit Kapila wrote: > > On Mon, Apr 17, 2023 at 7:37 PM Drouvot, Bertrand > wrote: > > > 3. As mentioned in the initial email, I think it would be better to > replace LIST_SLOTS command with a SELECT query. > I had a look at this thread. I am interested to work on

Re: Partial aggregates pushdown

fujii.y...@df.mitsubishielectric.co.jp писал 2023-07-19 03:43: Hi Mr.Pyhalov, hackers. 3) I modified the patch to safely do a partial aggregate pushdown for queries which contain having clauses. Hi. Sorry, but I don't see how it could work. For example, the attached test returns wrong resul

Re: inconsistency between the VM page visibility status and the visibility status of the page

On 7/20/23 08:44, yanhui.xiong wrote: > Hi, > > i had a issue here, When executing a SELECT statement using an > index-only scan, i got a wrong row number because there may be an > inconsistency between the VM page visibility status and the visibility > status of the page,the VM bit is set and pag

Re: Support worker_spi to execute the function dynamically.

On Thu, Jul 20, 2023 at 2:38 PM Masahiro Ikeda wrote: > > Thanks for discussing about the patch. I updated the patch from your > comments > * v2-0001-Support-worker_spi-to-execute-the-function-dynamical.patch > > I found another thing to be changed better. Though the tests was assumed > "shared_pr

Re: Extracting cross-version-upgrade knowledge from buildfarm client

On 2023-Jul-19, Andrew Dunstan wrote: > The result you report suggest to me that somehow the old version is no > longer a PostgreSQL::Version object.  Here's the patch I suggest: Ahh, okay, that makes more sense; and yes, it does work. -- Álvaro Herrera PostgreSQL Developer — https://

Re: Support worker_spi to execute the function dynamically.

On Thu, Jul 20, 2023 at 2:59 PM Michael Paquier wrote: > > On Thu, Jul 20, 2023 at 05:54:55PM +0900, Masahiro Ikeda wrote: > > Yes, you're right. When I tried using worker_spi to test wait event, > > I found the behavior. And thanks a lot for your patch. I wasn't aware > > of the way. I'll merge

Re: Support worker_spi to execute the function dynamically.

On Thu, Jul 20, 2023 at 05:54:55PM +0900, Masahiro Ikeda wrote: > Yes, you're right. When I tried using worker_spi to test wait event, > I found the behavior. And thanks a lot for your patch. I wasn't aware > of the way. I'll merge your patch to the tests for wait events. Be careful when using th

Re: There should be a way to use the force flag when restoring databases

> On 19 Jul 2023, at 19:28, Gurjeet Singh wrote: > > On Tue, Jul 18, 2023 at 12:53 AM Joan wrote: >> >> Since posgres 13 there's the option to do a FORCE when dropping a database >> (so it disconnects current users) Documentation here: >> https://www.postgresql.org/docs/current/sql-dropdataba

Re: WAL Insertion Lock Improvements

On Fri, Jul 14, 2023 at 4:17 AM Andres Freund wrote: > > Hi, > > On 2023-07-13 14:04:31 -0700, Andres Freund wrote: > > From b74b6e953cb5a7e7ea1a89719893f6ce9e231bba Mon Sep 17 00:00:00 2001 > > From: Bharath Rupireddy > > Date: Fri, 19 May 2023 15:00:21 + > > Subject: [PATCH v8] Optimize WAL

Re: Support worker_spi to execute the function dynamically.

Hi, On 2023-07-20 13:50, Bharath Rupireddy wrote: On Thu, Jul 20, 2023 at 10:09 AM Michael Paquier wrote: On Thu, Jul 20, 2023 at 09:43:37AM +0530, Bharath Rupireddy wrote: > +1. However, a comment above helps one to understand why some GUCs are > defined before if (!process_shared_preload_li

Re: Support worker_spi to execute the function dynamically.

On 2023-07-20 12:55, Michael Paquier wrote: On Thu, Jul 20, 2023 at 11:15:51AM +0900, Masahiro Ikeda wrote: While I'm working on the thread[1], I found that the function of worker_spi module fails if 'shared_preload_libraries' doesn't have worker_spi. I guess that you were patching worker_spi

Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication

Hi Peter, Peter Smith , 20 Tem 2023 Per, 07:10 tarihinde şunu yazdı: > Hi, I had a look at the latest 3 patch (v20-0003). > > Although this patch was recently modified, the updates are mostly only > to make it compatible with the updated v20-0002 patch. Specifically, > the v20-0003 updates di

Re: Performance degradation on concurrent COPY into a single relation in PG16.

On Thu, 20 Jul 2023 at 00:56, David Rowley wrote: > > I noticed that 6fcda9aba added quite a lot of conditions that need to > be checked before we process a normal decimal integer string. I think > we could likely do better and code it to assume that most strings will > be decimal and put that cas

Re: Assertion failure in SnapBuildInitialSnapshot()

> On 9 Feb 2023, at 07:32, Masahiko Sawada wrote: > I've attached the patch of this idea for discussion. Amit, Andres: have you had a chance to look at the updated version of this patch? -- Daniel Gustafsson

Re: Atomic ops for unlogged LSN

On Thu, Jul 20, 2023 at 12:25 AM John Morris wrote: > > >> Why don't we just use a barrier when around reading the value? It's not > >> like > >> CreateCheckPoint() is frequent? > > One reason is that a barrier isn’t needed, and adding unnecessary barriers > can also be confusing. > > With respe

Re: logical decoding and replication of sequences, take 2

Thanks Tomas for the updated patches. Here are my comments on 0006 patch as well as 0002 patch. On Wed, Jul 19, 2023 at 4:23 PM Tomas Vondra wrote: > > I think this is an accurate description of what the current patch does. > And I think it's a reasonable behavior. > > My point is that if this g

Re: [feature]COPY FROM enable FORCE_NULL/FORCE_NOT_NULL on all columns

Hi, On Jul 7, 2023 at 18:00 +0800, Damir Belyalov , wrote: > > V2 patch still have some errors when apply file doc/src/sgml/ref/copy.sgml, > rebased and fixed it in V3 path. > Thanks a lot for review. I have updated https://commitfest.postgresql.org/43/3896/ to staus Ready for Committer, thanks

Re: remaining sql/json patches

Hello, On Thu, Jul 20, 2023 at 10:35 AM jian he wrote: > On Tue, Jul 18, 2023 at 5:11 PM Amit Langote wrote: > > > Op 7/17/23 om 07:00 schreef jian he: > > > > hi. > > > > seems there is no explanation about, json_api_common_syntax in > > > > functions-json.html > > > > > > > > I can get json_qu