On 2023-Jul-21, Amit Langote wrote: > I’m thinking of pushing 0001 and 0002 tomorrow barring objections.
0001 looks reasonable to me. I think you asked whether to squash that one with the other bugfix commit for the same code that you already pushed to master; I think there's no point in committing as separate patches, because the first one won't show up in the git_changelog output as a single entity with the one in 16, so it'll just be additional noise. I've looked at 0002 at various points in time and I think it looks generally reasonable. I think your removal of a couple of newlines (where originally two appear in sequence) is unwarranted; that the name to_json[b]_worker is ugly for exported functions (maybe "datum_to_json" would be better, or you may have better ideas); and that the omission of the stock comment in the new stanzas in FigureColnameInternal() is strange. But I don't have anything serious. Do add some ecpg tests ... Also, remember to pgindent and bump catversion, if you haven't already. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "No hay hombre que no aspire a la plenitud, es decir, la suma de experiencias de que un hombre es capaz"
