Hi
I try run make check-world. Now I have problems with tests of psql
I had to cancel tests
log:
[08:46:49.828](0.038s) ok 63 - no ON_ERROR_STOP, --single-transaction and
multiple -c switches
[08:46:49.860](0.033s) ok 64 - client-side error commits transaction, no
ON_ERROR_STOP and multiple -c
On Mon, May 8, 2023 at 1:51 PM Masahiko Sawada wrote:
>
> Apart from the documentation change, given that setting slot_name =
> NONE always requires for the subscription to be disabled beforehand,
> does it make sense to change ALTER SUBSCRIPTION SET so that we disable
> the subscription when sett
On Tue, May 09, 2023 at 02:10:20PM +0900, Michael Paquier wrote:
> Should we split this patch into two parts, as they aim at tackling two
> different cases then? One for LWLockConflictsWithVar() and
> LWLockReleaseClearVar() which are the straight-forward pieces
> (using one pg_atomic_write_u64()
On Mon, May 8, 2023 at 1:45 PM Drouvot, Bertrand
wrote:
>
> On 5/8/23 4:42 AM, Amit Kapila wrote:
> > On Sat, May 6, 2023 at 9:33 PM Drouvot, Bertrand
> > wrote:
> >>
> >> On 5/6/23 3:28 PM, Amit Kapila wrote:
> >>> On Sat, May 6, 2023 at 1:52 PM Drouvot, Bertrand
> >>> wrote:
> >>
> >>> Next st
On Mon, May 08, 2023 at 08:18:04PM +0530, Bharath Rupireddy wrote:
> On Mon, May 8, 2023 at 5:57 PM Bharath Rupireddy
> wrote:
>> On Mon, Apr 10, 2023 at 9:38 AM Michael Paquier wrote:
>>> The sensitive change is in LWLockUpdateVar(). I am not completely
>>> sure to understand this removal, thou
Dear Sawada-san,
Thank you for giving the patch! I confirmed that the problem you raised could be
occurred on the HEAD, and the test you added could reproduce that. When the
stats
entry has been removed but pg_stat_get_subscription_stats() is called, the
returned
values are set as 0x0.
Additiona
On Tue, May 09, 2023 at 09:34:56AM +0530, Bharath Rupireddy wrote:
> Below is the configuration I've been using. I have been keeping the
> checkpoints away so far to get expected numbers. Probably, something
> that I should modify for this long run? Change checkpoint_timeout to
> 15 min or so?
>
>
On Tue, May 9, 2023 at 9:27 AM Michael Paquier wrote:
>
> On Tue, May 09, 2023 at 09:24:14AM +0530, Bharath Rupireddy wrote:
> > I'll pick a test case that generates a reasonable amount of WAL 256
> > bytes. What do you think of the following?
> >
> > test-case 2: -T900, WAL ~256 bytes (for c in 1
Hi,
On 2023-05-09 15:41:36 +1200, Thomas Munro wrote:
> I tried out the patch you posted over at [1].
Thanks!
> $ psql db2
> psql: error: connection to server on socket "/tmp/.s.PGSQL.5432"
> failed: FATAL: database "db2" is invalid
> DETAIL: Use DROP DATABASE to drop invalid databases
>
> I
On Tue, May 09, 2023 at 09:24:14AM +0530, Bharath Rupireddy wrote:
> I'll pick a test case that generates a reasonable amount of WAL 256
> bytes. What do you think of the following?
>
> test-case 2: -T900, WAL ~256 bytes (for c in 1 2 4 8 16 32 64 128 256
> 512 768 1024 2048 4096 - takes 3.5hrs)
>
On Tue, May 9, 2023 at 9:02 AM Michael Paquier wrote:
>
> On Mon, May 08, 2023 at 04:04:10PM -0700, Nathan Bossart wrote:
> > On Mon, May 08, 2023 at 05:57:09PM +0530, Bharath Rupireddy wrote:
> >> test-case 1: -T5, WAL ~16 bytes
> >> test-case 1: -t1000, WAL ~16 bytes
> >
> > I wonder if it's wor
On Tue, May 9, 2023 at 3:41 PM Thomas Munro wrote:
> I tried out the patch you posted over at [1].
I forgot to add, +1, I think this is a good approach.
(I'm still a little embarrassed at how long we spent trying to debug
this in the other thread from the supplied clues, when you'd already
point
I tried out the patch you posted over at [1]. For those wanting an
easy way to test it, or test the buggy behaviour in master without
this patch, you can simply kill -STOP the checkpointer, so that DROP
DATABASE hangs in RequestCheckpoint() (or you could SIGSTOP any other
backend so it hangs in th
On Mon, May 08, 2023 at 04:04:10PM -0700, Nathan Bossart wrote:
> On Mon, May 08, 2023 at 05:57:09PM +0530, Bharath Rupireddy wrote:
>> test-case 1: -T5, WAL ~16 bytes
>> test-case 1: -t1000, WAL ~16 bytes
>
> I wonder if it's worth doing a couple of long-running tests, too.
Yes, 5s or 1000 trans
On Mon, May 08, 2023 at 05:36:27PM +0100, Dagfinn Ilmari Mannsåker wrote:
> Here's an updated v3 patch with that. While adding that, I noticed that
> CREATE UNLOGGED only tab-completes TABLE and MATERIALIZED VIEW, not
> SEQUENCE, so I added that (and removed MATERIALIZED VIEW when part of
> CREATE
On Tue, May 9, 2023 at 1:48 AM Ranier Vilela wrote:
> I think you missed list_nth_xid, It makes perfect sense to exist.
>
It seems that list_nth_xid is more about simplification. So maybe we
should put it in 0001?
Thanks
Richard
On Tue, May 9, 2023 at 1:26 AM Alvaro Herrera
wrote:
> The problem I see is that each of these new functions has a single
> caller, and the only one that looks like it could have a performance
> advantage is list_copy_move_nth_to_head() (which is the weirdest of the
> lot). I'm inclined not to h
Hi Kuroda-san. Here are some review comments for the v10-0001 patch.
==
General.
1. pg_dump option is documented to the user.
I'm not sure about exposing the new pg_dump
--logical-replication-slots-only option to the user.
I thought this pg_dump option was intended only to be called
*inter
On Mon, May 8, 2023 at 11:22 PM Peter Eisentraut <
peter.eisentr...@enterprisedb.com> wrote:
> On 23.04.23 08:42, Richard Guo wrote:
> > Thanks for the suggestion. I've split the patch into two as attached.
> > 0001 is just a minor simplification by replacing lfirst(list_head(list))
> > with lini
Alexander Lakhin writes:
> The only thing that confused me, is the error message (it's not new, too):
> select '{{1}}'::int[];
> or even:
> select '{{'::int[];
> ERROR: number of array dimensions (7) exceeds the maximum allowed (6)
Yeah, I didn't touch that, but it's pret
02.05.2023 18:41, Tom Lane wrote:
So, here's a rewrite.
Although I view this as a bug fix, AFAICT the only effects are to
accept input that should be rejected. So again I don't advocate
back-patching. But should we sneak it into v16, or wait for v17?
I've tested the patch from a user perspec
On Mon, May 8, 2023 at 8:09 PM Amit Kapila wrote:
>
> On Fri, May 5, 2023 at 9:14 AM Zhijie Hou (Fujitsu)
> wrote:
> >
> > On Wednesday, May 3, 2023 3:17 PM Amit Kapila
> > wrote:
> > >
> >
> > Attach another patch to fix the problem that pa_shutdown will access invalid
> > MyLogicalRepWorker.
On Mon, May 8, 2023 at 3:34 PM Amit Kapila wrote:
>
> On Mon, May 8, 2023 at 11:08 AM Masahiko Sawada wrote:
> >
> > On Mon, May 8, 2023 at 12:52 PM Zhijie Hou (Fujitsu)
> > wrote:
> > >
> > > On Monday, May 8, 2023 11:08 AM Masahiko Sawada
> > >
> > > Hi,
> > >
> > > >
> > > > On Tue, May 2, 2
On Mon, May 08, 2023 at 04:23:15PM +0900, Masahiko Sawada wrote:
> We call pgstat_drop_subscription() at the end of DropSubscription()
> but we could leave from this function earlier e.g. when no slot is
> associated with the subscription. In this case, the statistics entry
> for the subscription r
On Tue, May 02, 2023 at 11:41:27AM -0400, Tom Lane wrote:
> It looks like back in the dim mists of the
> Berkeley era, there was an intentional attempt to allow
> non-rectangular array input, with the missing elements automatically
> filled out as NULLs. Since that was undocumented, we concluded i
On Mon, May 08, 2023 at 10:39:42AM +0200, Daniel Gustafsson wrote:
> On 4 May 2023, at 14:18, Daniel Gustafsson wrote:
>> On 4 May 2023, at 14:09, Tom Lane wrote:
>>> Hmm, I'm kinda -1 on them having the same name visible in the
>>> contexts dump --- that seems very confusing. How about naming
>
On Mon, May 08, 2023 at 05:57:09PM +0530, Bharath Rupireddy wrote:
> I ran performance tests on the patch with different use-cases. Clearly
> the patch reduces burden on LWLock's waitlist lock (evident from perf
> reports [1]). However, to see visible impact in the output, the txns
> must be genera
On Mon, May 8, 2023 at 2:05 PM Michael Paquier wrote:
>
> On Mon, May 08, 2023 at 01:57:33PM +1000, Peter Smith wrote:
> > I agree. Do you want me to make a new v4 patch to also do that, or
> > will you handle them in passing?
>
> I'll just go handle them on the way, no need to send an updated
> p
On Mon, May 08, 2023 at 08:00:39PM +0200, Tomas Vondra wrote:
> The LZ4Stream_write() forgot to move the pointer to the next chunk, so
> it was happily decompressing the initial chunk over and over. A bit
> embarrassing oversight :-(
>
> The custom format calls WriteDataToArchiveLZ4(), which was c
On Mon, 2023-05-08 at 17:47 -0400, Tom Lane wrote:
> -ERROR: could not convert locale name "C" to language tag:
> U_ILLEGAL_ARGUMENT_ERROR
> +NOTICE: using standard form "en-US-u-va-posix" for locale "C"
...
> I suppose this is environment-dependent. Sadly, the buildfarm
> client does not show
Jeff Davis writes:
> === 0001: do not convert C to en-US-u-va-posix
> I plan to commit this soon.
Several buildfarm animals have failed since this went in. The
only one showing enough info to diagnose is siskin [1]:
@@ -1043,16 +1043,15 @@
ERROR: ICU locale "nonsense-nowhere" has unknown lan
Hi,
On 2023-04-26 18:47:14 +0900, Kyotaro Horiguchi wrote:
> I see four issues here.
>
> 1. The current database stats omits buffer fetches that don't
> originate from a relation.
>
> In this case pgstat_relation can't work since recovery isn't conscious
> of relids. We might be able to resol
On Wed, May 03, 2023 at 04:11:33PM +0300, Melih Mutlu wrote:
> Andres Freund , 27 Nis 2023 Per, 19:27 tarihinde şunu
> yazdı:
> > #ifdef WAL_DEBUG
> > > if (XLOG_DEBUG ||
> > > (record->xl_rmid == RM_XACT_ID &&
> > trace_recovery_messages <= DEB
Hi,
On 2023-04-25 10:28:58 -0700, Andres Freund wrote:
> On 2023-04-25 11:42:43 -0400, Robert Haas wrote:
> > On Mon, Apr 24, 2023 at 8:03 PM Andres Freund wrote:
> > > What we've discussed somewhere in the past is to always truncate N+1 when
> > > creating the first page in N. I.e. if we extend
Hi,
On 2023-05-08 08:57:08 -0400, Robert Haas wrote:
> On Mon, May 1, 2023 at 12:54 PM Aleksander Alekseev
> wrote:
> > So I'm still unable to reproduce the described scenario, at least on PG16.
>
> Well, that proves that either (1) the scenario that I described is
> impossible for some unknown
Andres Freund writes:
> I don't really have feelings either way - but haven't we gone further and even
> backpatched things like spinlock support for new arches in the past?
Mmmm ... don't really think those cases were comparable. We weren't
adding support for a whole new OS. Now, you might arg
Hi,
On 2023-05-05 07:08:39 -0400, Andrew Dunstan wrote:
> On 2023-05-04 Th 19:54, Andres Freund wrote:
> > Hm. I can't reproduce this in my test win10 VM, unfortunately. What OS / OS
> > version is the host? Any chance to get systeminfo.exe output or something
> > like
> > that?
>
>
> Its a Win
I've reviewed both your patch versions and responded to the ideas in
both of them and the associated emails below.
On Wed, Apr 26, 2023 at 5:47 AM Kyotaro Horiguchi
wrote:
>
> At Tue, 25 Apr 2023 16:04:23 -0700, Andres Freund wrote
> in
> > key those stats by oid. However, it *does* report the
--- Original Message ---
On Monday, May 8th, 2023 at 8:20 PM, Tomas Vondra
wrote:
>
>
>
>
> On 5/8/23 18:19, gkokola...@pm.me wrote:
>
> > --- Original Message ---
> > On Monday, May 8th, 2023 at 3:16 AM, Tom Lane t...@sss.pgh.pa.us wrote:
> >
> > > I wrote:
> > >
>
Hi,
On 2023-05-06 00:35:40 -0400, Tom Lane wrote:
> Michael Paquier writes:
> > Seeing how simple this has become, I would be really tempted to get
> > that applied, especially if there's a buildfarm machine able to follow
> > up.. On the one hand, we are in a stability period for v16, so it may
Hi,
On 2023-05-08 16:00:01 +0300, Alexander Lakhin wrote:
> This difference is confirmed by multiple test runs. `git bisect` for this
> regression pointed at f193883fc.
I can reproduce a significant regression due to f193883fc of a workload just
running
SELECT CURRENT_TIMESTAMP;
A single session
On 5/8/23 18:19, gkokola...@pm.me wrote:
>
>
>
>
>
> --- Original Message ---
> On Monday, May 8th, 2023 at 3:16 AM, Tom Lane wrote:
>
>
>>
>>
>> I wrote:
>>
>>> Michael Paquier mich...@paquier.xyz writes:
>>>
While testing this patch, I have triggered an error pointing out
On 5/8/23 03:16, Tom Lane wrote:
> I wrote:
>> Michael Paquier writes:
>>> While testing this patch, I have triggered an error pointing out that
>>> the decompression path of LZ4 is broken for table data. I can
>>> reproduce that with a dump of the regression database, as of:
>>> make installchec
Em seg., 8 de mai. de 2023 às 14:26, Alvaro Herrera
escreveu:
> On 2023-May-08, Peter Eisentraut wrote:
>
> > On 23.04.23 08:42, Richard Guo wrote:
> > > Thanks for the suggestion. I've split the patch into two as attached.
> > > 0001 is just a minor simplification by replacing
> lfirst(list_hea
On 2023-May-08, Peter Eisentraut wrote:
> On 23.04.23 08:42, Richard Guo wrote:
> > Thanks for the suggestion. I've split the patch into two as attached.
> > 0001 is just a minor simplification by replacing lfirst(list_head(list))
> > with linitial(list). 0002 introduces new functions to reduce
Michael Paquier writes:
> On Tue, May 02, 2023 at 01:19:49PM +0100, Dagfinn Ilmari Mannsåker wrote:
>> Dagfinn Ilmari Mannsåker writes:
>>> This is for completing the word CREATE itself after CREATE SCHEMA
>>> [[] AUTHORIZATION] . The things that can come after that
>>> are already handled gene
On 08.05.23 04:38, 盏一 wrote:
> It seems extremely specific to one particular C++ implementation
To perform a force unwind during longjmp, the _Unwind_ForcedUnwind
function is used. This function is defined in the [Itanium C++ ABI
Standard](https://itanium-cxx-abi.github.io/cxx-abi/abi-eh.html
--- Original Message ---
On Monday, May 8th, 2023 at 3:16 AM, Tom Lane wrote:
>
>
> I wrote:
>
> > Michael Paquier mich...@paquier.xyz writes:
> >
> > > While testing this patch, I have triggered an error pointing out that
> > > the decompression path of LZ4 is broken for table
Thanks for continuing to work on this!
On Thu, May 04, 2023 at 07:30:06PM +0200, Jehan-Guillaume de Rorthais wrote:
> On Fri, 21 Apr 2023 16:44:48 -0400 Melanie Plageman
> wrote:
...
> > I think the biggest change that is needed is to implement this memory
> > context usage for parallel hash joi
On 27.04.23 13:44, Daniel Verite wrote:
This collation has an empty pg_collation.collversion column, instead
of being set to the same value as "und-x-icu" to track its version.
The original patch implements this as an INSERT in which it would be easy to
fix I guess, but in current HEAD it come
On 23.04.23 08:42, Richard Guo wrote:
Thanks for the suggestion. I've split the patch into two as attached.
0001 is just a minor simplification by replacing lfirst(list_head(list))
with linitial(list). 0002 introduces new functions to reduce the
movement of list elements in several places so as
Alvaro Herrera writes:
> This made me wonder if storing the unadorned port number is really the
> best way. Suppose we did extend things so that we listen on different
> ports on different interfaces; how would this scheme work at all?
Yeah, the probability that that will happen someday is one o
On Mon, May 8, 2023 at 5:57 PM Bharath Rupireddy
wrote:
>
> On Mon, Apr 10, 2023 at 9:38 AM Michael Paquier wrote:
>
> > -LWLockUpdateVar(LWLock *lock, uint64 *valptr, uint64 val)
> > +LWLockUpdateVar(LWLock *lock, pg_atomic_uint64 *valptr, uint64 val)
> > [...]
> > Assert(pg_atomic_read_u32(
On 2023-Apr-19, Yurii Rashkovskii wrote:
> If we consider this path, then (if we assume the format of the file is
> still to be private), we can make the port line accept multiple ports using
> a delimiter like `:` so that the next line still remains the same.
This made me wonder if storing the u
Hello Mark,
05.05.2023 20:45, MARK CALLAGHAN wrote:
This is mostly a hobby project for me - my other hobby is removing invasive weeds. I am happy to answer questions and
run more tests, but turnaround for answers won't be instant. Getting results from Linux perf for these tests is on my
TODO li
On Mon, May 1, 2023 at 12:54 PM Aleksander Alekseev
wrote:
> So I'm still unable to reproduce the described scenario, at least on PG16.
Well, that proves that either (1) the scenario that I described is
impossible for some unknown reason or (2) something is wrong with your
test scenario. I bet it
On Mon, Apr 24, 2023 at 10:16 AM Peter Eisentraut
wrote:
> Right. I'm perfectly content with just allowing port number 0 and
> leaving it at that.
That seems fine to me, too. If somebody wants to add a pg_ctl feature
to extract this or any other information from the postmaster.pid file,
that can
I'm very much in favor of adding a way to support reporting other GUC
variables than the current hardcoded list. This can be quite useful to
support some amount of session state in connection poolers.
Some general feedback on the patch:
1. I don't think the synchronization mechanism that you added
On Fri, May 5, 2023 at 9:14 AM Zhijie Hou (Fujitsu)
wrote:
>
> On Wednesday, May 3, 2023 3:17 PM Amit Kapila wrote:
> >
>
> Attach another patch to fix the problem that pa_shutdown will access invalid
> MyLogicalRepWorker. I personally want to avoid introducing new static
> variable,
> so I only
On Mon, May 8, 2023 at 3:58 PM shveta malik wrote:
>
> On Tue, May 2, 2023 at 8:30 AM shveta malik wrote:
> >
> > On Fri, Apr 28, 2023 at 5:11 PM Amit Kapila wrote:
> > >
> > > Now, I think we can try to eliminate this entire ObjTree machinery and
> > > directly from the JSON blob during deparsi
On Fri, Apr 7, 2023 at 4:55 PM John Naylor
wrote:
> - Fixed-size PagetableEntry's are pretty large, but the tid compression
scheme used in this thread (in addition to being complex) is not a great
fit for tidbitmap because it makes it more difficult to track per-block
metadata (see also next poin
> On 4 May 2023, at 14:18, Daniel Gustafsson wrote:
>
>> On 4 May 2023, at 14:09, Tom Lane wrote:
>>
>> Daniel Gustafsson writes:
>>> When reading a memory contexts log I realized that we have this:
>>> LOG: level: 2; EventTriggerCache: 8192 total in 1 blocks; 7928 free (4
>>> chunks); 264 u
On Mon, May 8, 2023 at 12:07 PM Amit Kapila wrote:
>
> On Fri, May 5, 2023 at 6:47 PM Robert Sjöblom
> wrote:
> >
> > We have recently used the PostgreSQL documentation when setting up our
> > logical replication. We noticed there was a step missing in the
> > documentation on how to drop a logi
Hi,
On 5/8/23 4:42 AM, Amit Kapila wrote:
On Sat, May 6, 2023 at 9:33 PM Drouvot, Bertrand
wrote:
On 5/6/23 3:28 PM, Amit Kapila wrote:
On Sat, May 6, 2023 at 1:52 PM Drouvot, Bertrand
wrote:
Next steps:
=
1. The first thing is we should verify this theory by adding some LOG
in K
Hi,
We call pgstat_drop_subscription() at the end of DropSubscription()
but we could leave from this function earlier e.g. when no slot is
associated with the subscription. In this case, the statistics entry
for the subscription remains. To fix it, I think we need to call it
earlier, just after re
On 03.05.23 23:02, Paul Jungwirth wrote:
Thank you again for the review. Here is a patch with most of your
feedback addressed. Sorry it has taken so long! These patches are
rebased up to 1ab763fc22adc88e5d779817e7b42b25a9dd7c9e
(May 3).
Here are a few small fixup patches to get your patch set
66 matches
Mail list logo
