On Wed, 29 Mar 2023 21:32:05 -0700
Noah Misch wrote:
> On Sun, Jan 22, 2023 at 02:42:46PM -0600, Karl O. Pinc wrote:
> > v10-0001-List-trusted-and-obsolete-extensions.patch
>
> > +
> > + These modules and extensions are obsolete:
> > +
> > +
> > +
> > +
> > +
> > +
>
> C
The pg_basebackup code has WalSegSz as uint32, whereas the rest of the
code has it as int. This seems confusing, and using the extra range
wouldn't actually work. This was in the original commit (fc49e24fa6),
but I suppose it was an oversight.From 43c6b03b0d2cc044989de7722b8fd7b136fded7b Mon S
On Thu, Mar 30, 2023 at 11:12 AM Peter Smith wrote:
>
> > >
> > > 5.
> > > AFAIK, the "if (change->data.tp.oldtuple)" can only be true for UPDATE
> > > or DELETE, so the code would be better to include a sanity Assert.
> > >
> > > SUGGESTION
> > > if (change->data.tp.oldtuple)
> > > {
> > > As
On Thu, 2023-03-02 at 23:58 -0800, Jeff Davis wrote:
> On Thu, 2023-03-02 at 11:45 -0800, Jeff Davis wrote:
> > In this case it looks easier to add the right API than to be sure
> > about
> > whether it's needed or not.
>
> I attached a sketch of one approach. I'm not very confident that it's
> th
Hi Hou-san,
I looked again at v4-0001.
On Thu, Mar 30, 2023 at 2:01 PM houzj.f...@fujitsu.com
wrote:
>
> On Thursday, March 30, 2023 9:15 AM Peter Smith wrote:
> >
...
> >
> > 2.
> > /* Convert tuple if needed. */
> > if (relentry-> attrmap)
> > {
> > ...
> > }
> >
> > The "Convert tuple if
On Thu, Mar 30, 2023 at 10:02 AM Andres Freund wrote:
> Attached is v6. Changes:
0006:
+ereport(ERROR,
+errcode_for_file_access(),
+errmsg("could not extend file \"%s\" with posix_fallocate():
%m",
+ FilePathName(v->mdfd_vfd)),
+errhint
On Wed, 2023-03-29 at 16:00 -0400, Robert Haas wrote:
> Here's a new patch set to show how this would work. 0001 is as
> before.
The following special case ("unless they can SET ROLE..."):
/*
* Try to prevent the user to which we're switching from assuming the
* privileges of the current use
On Mon, Mar 27, 2023 at 11:34:36PM -0500, Justin Pryzby wrote:
> On Tue, Mar 28, 2023 at 09:13:10AM +0900, Michael Paquier wrote:
> > On Mon, Mar 20, 2023 at 09:30:50AM +0900, Michael Paquier wrote:
> > > Did you check dump and restore flows with partition
> > > trees and --no-table-access-method?
On Sun, Jan 22, 2023 at 02:42:46PM -0600, Karl O. Pinc wrote:
> v10-0001-List-trusted-and-obsolete-extensions.patch
> +
> + These modules and extensions are obsolete:
> +
> +
> +
> +
> +
> +
Commit a013738 incorporated this change. Since xml2 is the only in-tree way
to use XS
On Wed, Jul 13, 2022 at 04:49:00PM -0700, Andres Freund wrote:
> On 2022-07-14 08:46:02 +0900, Michael Paquier wrote:
> > On Wed, Jul 13, 2022 at 12:30:00PM -0500, Justin Pryzby wrote:
> > > How did you make this list ? Was it by excluding things that failed for
> > > you ?
> > >
> > > cfbot is
Hi Kuroda-san.
This patch had already gone through several review cycles when it was
known as v5-0002, in the previous thread [1], so it is already LGTM.
Just to be sure, I applied it again, rebuilt the HTML docs, and
re-checked all the rendering.
I have marked the CF entry for this patch as "re
On Thu, Mar 30, 2023 at 5:15 AM Peter Geoghegan wrote:
>
> On Wed, Mar 29, 2023 at 12:47 PM Peter Geoghegan wrote:
> > A couple of small tweaks to this appear in the attached revision, v8.
>
> I spent some time on the documentation today, too. Attached is v9,
> which seems pretty close to being c
On Thu, Mar 30, 2023 at 12:01 PM Amit Kapila wrote:
>
> On Wed, Mar 29, 2023 at 7:58 PM Tomas Vondra
> wrote:
> >
> > On 3/29/23 11:51, Amit Kapila wrote:
> > >>
> > >> It's not clear to me what should be the exact behavior?
> > >>
> > >> I mean, imagine we're opening a connection for logical rep
On Wed, Mar 29, 2023 at 7:58 PM Tomas Vondra
wrote:
>
> On 3/29/23 11:51, Amit Kapila wrote:
> >>
> >> It's not clear to me what should be the exact behavior?
> >>
> >> I mean, imagine we're opening a connection for logical replication, and
> >> the subscriber does not handle sequences. What shoul
On Thursday, March 30, 2023 9:15 AM Peter Smith wrote:
>
> Hi Hou-san,
>
> I tried to compare the logic of patch v3-0001 versus the original HEAD code.
>
> IMO this patch logic is not exactly the same as before -- there are
> some subtle differences. I am not sure if these differences represent
Dear Peter,
> > This thread is motivated from [1]. This patch adds some links that refer
> publication options.
> >
>
> Is this the correct attachment?
Opps, I attached wrong one. Here is currect.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
0001-Add-XML-ID-attributes-to-create_publication.sg
Hi,
Thank you for updating the patches.
On Thu, Mar 30, 2023 at 5:01 AM Melanie Plageman
wrote:
>
> Thanks for the detailed review!
>
> On Tue, Mar 28, 2023 at 11:09 PM Kyotaro Horiguchi
> wrote:
> >
> > At Tue, 28 Mar 2023 20:35:28 -0400, Melanie Plageman
> > wrote in
> > > On Tue, Mar 28, 2
On Thu, Mar 30, 2023 at 12:57 PM Hayato Kuroda (Fujitsu)
wrote:
>
> Dear hackers,
>
> This thread is motivated from [1]. This patch adds some links that refer
> publication options.
>
Is this the correct attachment?
--
Kind Regards,
Peter Smith,
Fujitsu Australia
On Tue, 2023-03-28 at 08:41 +0200, Peter Eisentraut wrote:
> [PATCH v9 1/5] Fix error inconsistency in older ICU versions.
>
> ok
Committed 0001.
> [PATCH v9 2/5] initdb: replace check_icu_locale() with
> default_icu_locale().
>
> I would keep the #ifdef USE_ICU inside the lower-level functio
Dear hackers,
This thread is motivated from [1]. This patch adds some links that refer
publication options.
While adding missing ID attributes to create_subscription.sgml, we found that
this could extend to create_publication.sgml. In the file no entries have an XML
ID attribute, but I think tha
Dear Daniel, Jelte
Thank you for creating a good feature!
While checking the buildfarm, I found a failure on NetBSD caused by the added
code[1]:
```
fe-connect.c: In function 'libpq_prng_init':
fe-connect.c:1048:11: error: cast from pointer to integer of different size
[-Werror=pointer-to-int-c
> From: Masahiko Sawada
> >
> > One related idea is that currently, we fetch the table list
> > corresponding to publications in subscription and create the entries
> > for those in pg_subscription_rel during Create Subscription, can we
> > think of postponing that work till after the initial sch
Hi,
On 2023-03-29 19:08:25 +0200, Peter Eisentraut wrote:
> On 29.03.23 18:24, Andres Freund wrote:
> > On 2023-03-29 18:08:29 +0200, Peter Eisentraut wrote:
> > > On 24.03.23 19:12, Andres Freund wrote:
> > > > > I thought about this some more. I think we could get rid of
> > > > > attusertypmo
Hi Hou-san,
I tried to compare the logic of patch v3-0001 versus the original HEAD code.
IMO this patch logic is not exactly the same as before -- there are
some subtle differences. I am not sure if these differences represent
real problems or not.
Below are all my review comments:
==
1.
/
Hi,
On 2023-03-29 20:51:04 -0400, Melanie Plageman wrote:
> > > +if (returnCode == 0)
> > > +return 0;
> > > +
> > > +/* for compatibility with %m printing etc */
> > > +errno = returnCode;
> > > +
> > > +/*
> > > +* Return in cases of a "real" failure, if fallocate is
On Tue, Mar 28, 2023 at 11:47 PM Andres Freund wrote:
>
> On 2023-03-26 17:42:45 -0400, Melanie Plageman wrote:
> > +{
> > +/* if errno is unset, assume problem is no disk space */
> > +if (errno == 0)
> > +errno = ENOSPC;
> > +return -1;
> > +}
> >
> >
On Wed, Mar 29, 2023 at 12:47 PM Peter Geoghegan wrote:
> A couple of small tweaks to this appear in the attached revision, v8.
I spent some time on the documentation today, too. Attached is v9,
which seems pretty close to being committable. I hope to commit what I
have here (or something very cl
Hi Tom,
Thank you for your feedback. Below are my comments.
On Wed, Mar 29, 2023 at 6:55 PM Tom Lane wrote:
> Yurii Rashkovskii writes:
> > I would like to suggest a patch against master (although it may be worth
> > backporting it) that makes it possible to listen on any unused port.
>
> I th
> +Enables the building of documentation in HTML and
> +man format. It defaults to auto.
> +
> +Enables the building of documentation in PDF
> +format. It defaults to auto.
These sound awkward. Recommend:
Enables building the documentation in PDF
format. It defaul
Hi,
On 2023-03-29 18:39:27 +0200, Peter Eisentraut wrote:
> On 29.03.23 18:25, Andres Freund wrote:
> > On 2023-03-29 18:15:02 +0200, Peter Eisentraut wrote:
> > > On 25.03.23 21:14, Andres Freund wrote:
> > > > I wonder if, for meson, the best behaviour would be to make 'docs' a
> > > > feature
On Thu, Feb 2, 2023, 15:47 Alvaro Herrera wrote:
> Are you still at this? CFbot says the meson tests failed last time for
> some reason:
> http://commitfest.cputube.org/greg-stark.html
On Sat, Feb 04, 2023 at 05:12:36PM +0100, Greg Stark wrote:
> I think that was spurious. It looked good when we
On Thu, Mar 2, 2023 at 12:00:43PM -0500, Joseph Koshakow wrote:
>
>
> On Thu, Mar 2, 2023 at 11:53 AM Fujii Masao
> wrote:
> >
> > On 2022/09/14 14:27, bt22kawamotok wrote:
> > > I update patch to reflect master update.
> >
> > Thanks for updating the patch!
> >
> > +
> >
I took another couple of looks at this and pushed it after a few small tweaks
to the docs.
--
Daniel Gustafsson
> On 29 Mar 2023, at 21:14, Daniel Gustafsson wrote:
> Ugh, I clearly should've stayed on the couch yesterday.
Maybe today as well, just as I had sent this I realized there is mention of the
output format in the docs that I had missed. The attached changes that as well
to match the new format.
Thanks for the detailed review!
On Tue, Mar 28, 2023 at 11:09 PM Kyotaro Horiguchi
wrote:
>
> At Tue, 28 Mar 2023 20:35:28 -0400, Melanie Plageman
> wrote in
> > On Tue, Mar 28, 2023 at 4:21 AM Kyotaro Horiguchi
> > wrote:
> > >
> > > At Mon, 27 Mar 2023 14:12:03 -0400, Melanie Plageman
> >
On Tue, Mar 28, 2023 at 6:48 PM Jeff Davis wrote:
> That's not strictly true. See the example at the bottom of this email.
Yeah, we're very casual about repeated user switching in all kinds of
contexts, and that's really pretty scary. I don't know how to fix that
without removing capabilities tha
On Mon, Mar 27, 2023 at 7:40 PM Peter Geoghegan wrote:
> Attached revision v7 adjusts the column order. This is still WIP, but
> gives a good idea of the direction I'm going in.
A couple of small tweaks to this appear in the attached revision, v8.
Now it looks like this:
pg@regression:5432 [1294
> On 29 Mar 2023, at 09:08, Peter Eisentraut
> wrote:
>
> On 28.03.23 15:56, Daniel Gustafsson wrote:
>>> On 28 Mar 2023, at 15:26, Daniel Gustafsson wrote:
>>> I think the attached is a good candidate for going in, but I would like to
>>> see it
>>> for another spin in the CF bot first.
>> An
Peter Eisentraut wrote:
> So for your patch, I would just do the path adjustment ad hoc in-line.
> It's just one additional line.
Here's the patch updated that way.
Best regards,
--
Daniel Vérité
https://postgresql.verite.pro/
Twitter: @DanielVerite
diff --git a/src/bin/psql/t/001_bas
On Tue, Mar 28, 2023 at 3:34 PM Michael Paquier wrote:
> I disagree with this argument. Personally, I have a *much* better
> experience with textual representation because there is no need to
> cross-check the internals of the code in case you don't remember what
> a given number means in an enum
> On 29 Mar 2023, at 19:18, Bruce Momjian wrote:
> On Thu, Feb 23, 2023 at 09:36:00AM +0100, Daniel Gustafsson wrote:
>>> On 23 Feb 2023, at 05:48, Tom Lane wrote:
>>> Mass conversion of /* to // style would answer that,
>>> but would also create an impossible back-patching problem.
>>
>> Yeah,
Hi,
29.03.2023 13:27, Alvaro Herrera wrote:
... and pushed it now, after some more meddling.
I'll rebase the rest of the series now.
Please look at the several minor issues/inconsistencies,
I've spotted in the commit:
1) s/JSON_ARRRAYAGG/JSON_ARRAYAGG/
2)
check_key_uniqueness vs check_uniqu
Andres,
On Mon, Mar 27, 2023 at 1:49 PM Alexander Korotkov wrote:
> On Fri, Mar 24, 2023 at 3:39 AM Andres Freund wrote:
> > On 2023-03-23 23:24:19 +0300, Alexander Korotkov wrote:
> > > On Thu, Mar 23, 2023 at 8:06 PM Andres Freund wrote:
> > > > I seriously doubt that solving this at the tupl
On Thu, Feb 23, 2023 at 09:36:00AM +0100, Daniel Gustafsson wrote:
> > On 23 Feb 2023, at 05:48, Tom Lane wrote:
>
> > For my own taste, I really don't have any objection to // in isolation --
> > the problem with it is just that we've got megabytes of code in the other
> > style. I fear it'd lo
On 29.03.23 18:24, Andres Freund wrote:
Hi,
On 2023-03-29 18:08:29 +0200, Peter Eisentraut wrote:
On 24.03.23 19:12, Andres Freund wrote:
I thought about this some more. I think we could get rid of attusertypmod
and just hardcode it as -1. The idea would be that if you ask for an
encrypted c
On Wed, Mar 29, 2023 at 5:13 AM Amit Kapila wrote:
>
> On Wed, Mar 29, 2023 at 2:49 AM Zheng Li wrote:
> >
> >
> > I agree that a full fledged DDL deparser and DDL replication is too
> > big of a task for one patch. I think we may consider approaching this
> > feature in the following ways:
> > 1
On 29.03.23 18:25, Andres Freund wrote:
On 2023-03-29 18:15:02 +0200, Peter Eisentraut wrote:
On 25.03.23 21:14, Andres Freund wrote:
I wonder if, for meson, the best behaviour would be to make 'docs' a feature
set to auto. If docs set to enabled, and the necessary tools are not
available, fail
Hi,
On 2023-03-29 18:15:02 +0200, Peter Eisentraut wrote:
> On 25.03.23 21:14, Andres Freund wrote:
> > I wonder if, for meson, the best behaviour would be to make 'docs' a feature
> > set to auto. If docs set to enabled, and the necessary tools are not
> > available, fail at that time, instead of
Hi,
On 2023-03-29 18:08:29 +0200, Peter Eisentraut wrote:
> On 24.03.23 19:12, Andres Freund wrote:
> > > I thought about this some more. I think we could get rid of attusertypmod
> > > and just hardcode it as -1. The idea would be that if you ask for an
> > > encrypted column of type, say, varc
On 25.03.23 21:14, Andres Freund wrote:
I wonder if, for meson, the best behaviour would be to make 'docs' a feature
set to auto. If docs set to enabled, and the necessary tools are not
available, fail at that time, instead of doing so while building.
Makes sense to me.
If that's what we deci
On 24.03.23 19:12, Andres Freund wrote:
I thought about this some more. I think we could get rid of attusertypmod
and just hardcode it as -1. The idea would be that if you ask for an
encrypted column of type, say, varchar(500), the server isn't able to
enforce that anyway, so we could just proh
On Wed, 2023-03-29 at 08:17 -0400, Dave Cramer wrote:
> I'm starting to wonder about the utility of the protocol extension
> mechanism?
I'm starting to agree that the awkwardness around connection poolers is
a problem. If that's the case, I'm wondering if the protocol extensions
will ever be usef
On 29.03.2023 at 06:52, Hayato Kuroda (Fujitsu) wrote:
FYI - my patch is pushed
Thanks!
Could you please rebase your patch?
Done and tested. Patch is attached.
Regards,
Brar
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index fcb53c6997..5c50347c58 100644
--- a/doc/src
On Wed, 29 Mar 2023 at 10:43, Denis Laxalde wrote:
> More importantly, not having PQcancelSend() creating the PGcancelConn
> makes reuse of that value, passing through PQcancelReset(), more
> intuitive. E.g., in the tests:
You convinced me. Attached is an updated patch where PQcancelSend
takes th
On Wed, Mar 29, 2023 at 7:57 PM Kumar, Sachin wrote:
>
> > > > > From: Amit Kapila
> > > > > > I think we won't be able to use same snapshot because the
> > > > > > transaction will be committed.
> > > > > > In CreateSubscription() we can use the transaction snapshot from
> > > > > > walrcv_creat
On Wed, Mar 29, 2023 at 6:35 AM Justin Pryzby wrote:
> If you have a zstd library with thread support, you could test with
> -Z zstd:workers=3. But I think threads aren't enabled in the common
> libzstd packages. Jacob figured out how to compile libzstd easily using
> "meson wraps" - but I don't
On 29.03.23 16:28, Tomas Vondra wrote:
Perhaps it'd be reasonable to tie the "protocol version" to subscriber
capabilities, so that a protocol version guarantees what message types
the subscriber understands. So we could increment the protocol version,
check it in pgoutput_startup and then error-
On 27.03.23 15:55, Peter Eisentraut wrote:
The information schema should be updated. I think the following views:
- CHECK_CONSTRAINTS
- CONSTRAINT_COLUMN_USAGE
- DOMAIN_CONSTRAINTS
- TABLE_CONSTRAINTS
It looks like these have no test coverage; maybe that could be addressed
at the same time.
On 3/29/23 11:51, Amit Kapila wrote:
> On Wed, Mar 29, 2023 at 12:04 AM Tomas Vondra
> wrote:
>>
>> On 3/28/23 18:34, Masahiko Sawada wrote:
>>> On Mon, Mar 27, 2023 at 11:46 PM Tomas Vondra
>>> wrote:
>
> Apart from that, how does the publication having sequences work with
> subsc
On Tue, Mar 28, 2023 at 02:03:49PM -0400, Kirk Wolak wrote:
> On Tue, Mar 28, 2023 at 12:23 PM Tomas Vondra
> wrote:
> > On 3/27/23 19:28, Justin Pryzby wrote:
> > > On Fri, Mar 17, 2023 at 03:43:31AM +0100, Tomas Vondra wrote:
> > >> On 3/16/23 05:50, Justin Pryzby wrote:
> > >>> On Fri, Mar 10,
Matthias van de Meent writes:
> Then, the attached trivial patch removes the function and all
> references I could find.
Pushed after a bit of fooling with adjacent comments.
regards, tom lane
Hi,
On 3/29/23 11:44 AM, Drouvot, Bertrand wrote:
Looking forward to your feedback,
Just realized that more polishing was needed.
Done in V2 attached.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.comFrom 5ce9b8
Op 3/29/23 om 12:27 schreef Alvaro Herrera:
On 2023-Mar-28, Erik Rijkers wrote:
In the json_arrayagg() description, it says:
'If ABSENT ON NULL is specified, any NULL values are omitted.'
That's true, but as omitting NULL values is the default (i.e., also without
that clause) maybe it's better
On Wed, 29 Mar 2023 at 14:12, Tom Lane wrote:
>
> Matthias van de Meent writes:
> > BufmgrCommit does exactly nothing; it is an empty function and has
> > been since commit 33960006 in late 2008 when it stopped calling
> > smgrcommit().
> > All two usages of the function (in our code base) seem t
st 29. 3. 2023 v 12:28 odesílatel Dagfinn Ilmari Mannsåker <
ilm...@ilmari.org> napsal:
> Hi hackers,
>
> A while back we added support for completing time zone names after SET
> TIMEZONE, but we failed to do the same for the AT TIME ZONE operator.
> Here's a trivial patch for that.
>
+1
Pavel
On Tue, 28 Mar 2023 at 19:01, Jeff Davis wrote:
> On Tue, 2023-03-28 at 10:22 -0400, Dave Cramer wrote:
> > OK, IIUC what you are proposing here is that there would be a
> > separate pool for
> > database, user, and OIDs. This doesn't seem too flexible. For
> > instance if I create a UDT and then
Matthias van de Meent writes:
> BufmgrCommit does exactly nothing; it is an empty function and has
> been since commit 33960006 in late 2008 when it stopped calling
> smgrcommit().
> All two usages of the function (in our code base) seem to be in
> xact.c. Are we maintaining it for potential futur
Yurii Rashkovskii writes:
> I would like to suggest a patch against master (although it may be worth
> backporting it) that makes it possible to listen on any unused port.
I think this is a bad idea, mainly because this:
> Instead, with this patch, one can specify `port` as `0` (the "wildcard"
>
Hi,
Whilst reading up on the transaction commit code, I noticed the following lines:
/* Tell bufmgr and smgr to prepare for commit */
BufmgrCommit();
BufmgrCommit does exactly nothing; it is an empty function and has
been since commit 33960006 in late 2008 when it stopped calling
smgrcommit(
On Tue, Mar 28, 2023 at 8:30 PM Masahiko Sawada wrote:
>
> On Tue, Mar 28, 2023 at 6:47 PM Amit Kapila wrote:
> >
> > > >
> > > > > > I think we can have same issues as you mentioned New table t1 is
> > > > > > added
> > > > > > to the publication , User does a refresh publication.
> > > > > > p
> > > > From: Amit Kapila
> > > > > I think we won't be able to use same snapshot because the
> > > > > transaction will be committed.
> > > > > In CreateSubscription() we can use the transaction snapshot from
> > > > > walrcv_create_slot() till walrcv_disconnect() is called.(I am
> > > > > not su
Hi hackers,
A while back we added support for completing time zone names after SET
TIMEZONE, but we failed to do the same for the AT TIME ZONE operator.
Here's a trivial patch for that.
- ilmari
>From 57138e851552a99174d00a0e48ce55ca3170df75 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dagfinn=20Ilm
On 2023-Mar-28, Erik Rijkers wrote:
> In the json_arrayagg() description, it says:
> 'If ABSENT ON NULL is specified, any NULL values are omitted.'
> That's true, but as omitting NULL values is the default (i.e., also without
> that clause) maybe it's better to say:
> 'Any NULL values are omitted
On 24.03.23 08:04, Pavel Stehule wrote:
Maybe I can divide the patch 0002-session-variables to three sections -
related to memory management, planning and execution?
Personally, I find the existing split not helpful. There is no value
(to me) in putting code, documentation, and tests in thre
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, failed
Hi,
Just a minor warning with documentation patch
git apply
On Wed, Mar 29, 2023 at 12:04 AM Tomas Vondra
wrote:
>
> On 3/28/23 18:34, Masahiko Sawada wrote:
> > On Mon, Mar 27, 2023 at 11:46 PM Tomas Vondra
> > wrote:
> >>>
> >>> Apart from that, how does the publication having sequences work with
> >>> subscribers who are not able to handle sequence cha
Hi hackers,
In another thread [1], Thomas had the idea to $SUBJECT in a similar way
to what is currently done with src/backend/storage/lmgr/lwlocknames.txt.
Doing so, like in the attached patch proposal, would help to avoid:
- wait event without documentation like observed in [2]
- orphaned wai
Hi,
> As suggested before by Heikki Linnakangas, I've added a patch for making 2PC
> transaction state 64-bit.
> At first, my intention was to rebuild all twophase interface to use
> FullTransactionId. But doing this in a proper
> manner would lead to switching from TransactionId to FullTransact
On Wed, Mar 29, 2023 at 2:49 AM Zheng Li wrote:
>
>
> I agree that a full fledged DDL deparser and DDL replication is too
> big of a task for one patch. I think we may consider approaching this
> feature in the following ways:
> 1. Phased development and testing as discussed in other emails.
> Pro
Hi,
> * Pluggable toaster
> - This seems to have digressed from the original patch. There were
> patches early on and a lot of feedback. Is the result that the
> original patches are Rejected or are they still live?
We agreed to work on a completely new RFC which is currently discussed
within
On Tue, Mar 28, 2023 at 11:14 PM Jacob Champion wrote:
>
> On Tue, Mar 28, 2023 at 2:59 AM wangw.f...@fujitsu.com
>
> > > Would it
> > > be enough to just replace that whole thing with gpt.attrs?
> >
> > Make sense.
> > Changed as suggested.
>
> LGTM, by inspection. Thanks!
>
Pushed.
--
With Re
Jelte Fennema a écrit :
> > Namely, I wonder why it returns a PGcancelConn and what's the
> > point of requiring the user to call PQcancelStatus() to see if something
> > got wrong. Maybe it could be defined as:
> >
> > int PQcancelSend(PGcancelConn *cancelConn);
> >
> > where the return value wo
At Wed, 29 Mar 2023 13:21:55 +0900 (JST), Kyotaro Horiguchi
wrote in
> So, sorry for the noise. I'll review it while this into cnosideration.
0003:
It's not this patche's fault, but I don't like the fact that the
variables used for GUC, VacuumCostDelay and VacuumCostLimit, are
updated outside
On Wed, Mar 29, 2023 at 3:39 AM Tom Lane wrote:
> Alvaro Herrera writes:
> > So I'm back home and found a couple more weird errors in the log:
>
> > ERROR: mismatching PartitionPruneInfo found at part_prune_index 0
> > DETALLE: plan node relids (b 1), pruneinfo relids (b 36)
>
> This one reprod
On 22.03.23 10:45, Peter Eisentraut wrote:
On 18.03.23 00:54, Andres Freund wrote:
I think a good compromise would be buildtype=debugoptimized, which is
-O2
with debug symbols, which also sort of matches the default in the
autoconf
world.
Looks like that'd result in a slightly worse build wi
On 28.03.23 15:56, Daniel Gustafsson wrote:
On 28 Mar 2023, at 15:26, Daniel Gustafsson wrote:
I think the attached is a good candidate for going in, but I would like to see
it
for another spin in the CF bot first.
Another candidate due to a thinko which raised a compiler warning.
This i
Hi,
Previously, we read int this mailing list some controversial opinions on
queryid generation and Jumbling technique. Here we don't intend to solve
these problems but help an extension at least don't conflict with others
on the queryId value.
Extensions could need to pass some query-relate
87 matches
Mail list logo
