Matthias van de Meent <boekewurm+postg...@gmail.com> writes: > BufmgrCommit does exactly nothing; it is an empty function and has > been since commit 33960006 in late 2008 when it stopped calling > smgrcommit(). > All two usages of the function (in our code base) seem to be in > xact.c. Are we maintaining it for potential future use, or can the > function be removed?
Seems reasonable. Even if bufmgr grew a new need to be called during commit, it would quite possibly need to be called from a different spot; so I doubt that the function is useful even as a placeholder. regards, tom lane