On Thu, 2023-03-23 at 13:16 -0700, Jeff Davis wrote:
> Another thought: for ICU, do we want the default collation to be
> UNICODE (root collation)? What we have now gets the default from the
> environment, which is consistent with the libc provider.
>
> But now that we have the UNICODE collation,
Hi,
On Tue, Aug 9, 2022 at 5:01 AM Zheng Li wrote:
>
> Hello,
>
> Logical replication of DDL commands support is being worked on in [1].
> However, global object commands are quite different from other
> non-global object DDL commands and need to be handled differently. For
> example, global obje
[PATCH v9 1/5] Fix error inconsistency in older ICU versions.
ok
[PATCH v9 2/5] initdb: replace check_icu_locale() with
default_icu_locale().
I would keep the #ifdef USE_ICU inside the lower-level function
default_icu_locale(), like it was before, so that the higher-level
setlocales() doesn
On Fri, 2023-03-24 at 16:41 -0400, Tom Lane wrote:
> Christoph Berg writes:
> > Re: Tom Lane
> > > I don't actually see why a postgres_fdw test case is needed at all?
> > > The tests in explain.sql seem sufficient.
>
> > When I asked Laurenz about that he told me that local tables wouldn't
> > ex
On Tue, Mar 28, 2023 at 9:49 AM Hayato Kuroda (Fujitsu)
wrote:
>
> Thank you for prompt reply!
>
> > Hmm, my above-suggested wording was “publish_via_partition_root
> > parameter “ but it seems you (accidentally?) omitted the word
> > “parameter”.
>
> It is my carelessness, sorry for inconvenience
On Tuesday, March 28, 2023 1:41 PM Amit Kapila wrote:
>
> On Mon, Mar 27, 2023 at 5:37 PM Amit Kapila
> wrote:
> >
> > On Mon, Mar 27, 2023 at 12:07 PM Amit Kapila
> wrote:
> > >
> > > On Mon, Mar 27, 2023 at 2:52 AM Tom Lane wrote:
> > > >
> > >
> > > > I suggest taking a couple of steps back
On Tue, Mar 28, 2023 at 07:49:45AM +0200, Drouvot, Bertrand wrote:
> What about something like?
>
> for pg_stat_get_xact_blocks_fetched(): "block read requests for table or
> index, in the current
> transaction. This number minus pg_stat_get_xact_blocks_hit() gives the number
> of kernel
> read(
On 27.03.23 20:54, Alvaro Herrera wrote:
Even so, I was unable to get bison
to accept the 'KEY name VALUES blah' syntax; it might be a
fun/challenging project to change the productions that we use for JSON
names and values:
+json_name_and_value:
+/* Supporting this syntax seems to require major
On Mon, Mar 27, 2023 at 11:34:35PM -0500, Justin Pryzby wrote:
> I realized that one difference with tablespaces is that, as written,
> partitioned tables will *always* have an AM specified, and partitions
> will never use default_table_access_method. Is that what's intended ?
>
> Or do we need l
Hi,
On 3/28/23 7:23 AM, Michael Paquier wrote:
On Tue, Mar 28, 2023 at 12:36:15PM +0900, Kyotaro Horiguchi wrote:
I found that commit ddfc2d9a37 removed the descriptions for
pg_stat_get_blocks_fetched and pg_stat_get_blocks_hit. Right before
that commit, monitoring.sgml had these lines:
-
On Mon, Mar 27, 2023 at 5:37 PM Amit Kapila wrote:
>
> On Mon, Mar 27, 2023 at 12:07 PM Amit Kapila wrote:
> >
> > On Mon, Mar 27, 2023 at 2:52 AM Tom Lane wrote:
> > >
> >
> > > I suggest taking a couple of steps back from the minutiae of the
> > > patch, and spending some hard effort thinking
On Mon, 2023-03-27 at 16:47 -0400, Robert Haas wrote:
> No, not really. It's pretty common for a lot of things to be in the
> public schema, and the public schema is likely to be in the search
> path of every user involved.
Consider this trigger function which uses an unqualified reference to
pfun
On Tue, Mar 28, 2023 at 12:36:15PM +0900, Kyotaro Horiguchi wrote:
> I found that commit ddfc2d9a37 removed the descriptions for
> pg_stat_get_blocks_fetched and pg_stat_get_blocks_hit. Right before
> that commit, monitoring.sgml had these lines:
>
> - pg_stat_get_blocks_fetched minus
> -
On 3/28/23 12:41 AM, Michael Paquier wrote:
On Mon, Mar 27, 2023 at 07:08:51PM +0900, Michael Paquier wrote:
The patch has one mistake: PG_STAT_GET_XACT_FUNCENTRY_FLOAT8_MS does
not need a slash on its last line or it would include the next, empty
line. This could lead to mistakes (no need t
Thanks for this patch.
v5-0001 looks good to me.
v5-0002 looks good to me.
I've marked the CF entry [1] as "ready for committer".
--
[1] https://commitfest.postgresql.org/43/4256/
Kind Regards,
Peter Smith.
Fujitsu Australia
On Mon, Mar 27, 2023 at 9:32 PM Andres Freund wrote:
> On 2023-03-27 20:12:11 -0700, Peter Geoghegan wrote:
> > On Mon, Mar 27, 2023 at 6:48 PM Andres Freund wrote:
> > > It seems odd that we enter the page into the VM at this point. That means
> > > that
> > > use of that page will now require
On Tue, Mar 28, 2023 at 09:13:10AM +0900, Michael Paquier wrote:
> On Mon, Mar 20, 2023 at 09:30:50AM +0900, Michael Paquier wrote:
> > Did you check dump and restore flows with partition
> > trees and --no-table-access-method? Perhaps there should be
> > some regression tests with partitioned tab
Hi,
On 2023-03-27 20:12:11 -0700, Peter Geoghegan wrote:
> On Mon, Mar 27, 2023 at 6:48 PM Andres Freund wrote:
> > It seems odd that we enter the page into the VM at this point. That means
> > that
> > use of that page will now require a bit more work (including
> > RelationGetBufferForTuple()
Dear Peter,
Thank you for prompt reply!
> Hmm, my above-suggested wording was “publish_via_partition_root
> parameter “ but it seems you (accidentally?) omitted the word
> “parameter”.
It is my carelessness, sorry for inconvenience. PSA new ones.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
v
The commit message explains prettty well, and it seems to work in
simple testing, and yeah commit c6f2f016 was not a work of art.
pg_basebackeup --format=plain "worked", but your way is better. I
guess we should add a test of -Fp too, to keep it working? Here's one
of those.
I know it's not your
On Monday, March 27, 2023 8:08 PM Amit Kapila wrote:
> On Mon, Mar 27, 2023 at 12:07 PM Amit Kapila
> wrote:
> >
> > On Mon, Mar 27, 2023 at 2:52 AM Tom Lane wrote:
> > >
> >
> > > I suggest taking a couple of steps back from the minutiae of the
> > > patch, and spending some hard effort thinkin
On Tue, Mar 28, 2023 at 2:04 PM Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Peter,
>
> Thank you for reviewing. PSA new version.
>
v4-0001 LGTM
>
> >
> > v3-0002
> >
> >
>
> > 2.2 doc/src/sgml/logical-replication.sgml (31.6. Restrictions)
> >
> > Publications can also specify that
On Mon, Mar 27, 2023 at 06:07:09PM -0700, Peter Geoghegan wrote:
> I see a bug on HEAD, following yesterday's commit 0276ae42dd.
>
> GetWALRecordInfo() will now output the value of the fpi_len variable
> before it has actually been set by our call to . So it'll always
> be 0.
Indeed, good cat
At Tue, 28 Mar 2023 07:38:25 +0900, Michael Paquier wrote
in
> On Mon, Mar 27, 2023 at 10:24:46AM -0400, Melanie Plageman wrote:
> > I do like/prefer "block read requests" and
> > "blocks requested found in cache"
> > Though, now I fear my initial complaint may have been a bit pedantic.
>
> Tha
On Tue, Mar 28, 2023 at 6:18 AM Justin Pryzby wrote:
> I ran sqlsmith on this patch for a short while, and reduced one of its
> appalling queries to this:
>
> postgres=# SELECT jsonb_object_agg_unique_strict('', null::xid8);
> ERROR: unexpected jsonb type as object key
I think this may have to d
On Mon, Mar 27, 2023 at 6:48 PM Andres Freund wrote:
> It seems odd that we enter the page into the VM at this point. That means that
> use of that page will now require a bit more work (including
> RelationGetBufferForTuple() pinning it).
I think that it's fairly obvious that it's *not* odd at a
Dear Peter,
Thank you for reviewing. PSA new version.
>
> v3-0001
>
>
> This patch looks good, but I think there are a couple of other places
> where you could add links:
>
> ~~~
>
> 1.1 doc/src/sgml/logical-replication.sgml (31.5 Conflicts)
>
> "When the streaming mode is p
Greetings,
On Mon, Mar 27, 2023 at 21:35 Bruce Momjian wrote:
> On Tue, Mar 28, 2023 at 02:03:50AM +0200, Stephen Frost wrote:
> > The remote storage is certainly an independent system. Multi-mount LUNs
> are
> > entirely possible in a SAN (and absolutely with NFS, or just the NFS
> server
> > i
On Tue, Mar 28, 2023 at 5:29 AM Peter Geoghegan wrote:
>
> On Mon, Mar 27, 2023 at 12:42 AM Bharath Rupireddy
> wrote:
> > Thanks. Here's the v6 patch (last patch that I have with me for
> > pg_walinspect) for adding per-record info to pg_get_wal_block_info.
> > Note that I addressed all review c
On Mon, Mar 27, 2023 at 4:59 PM Peter Geoghegan wrote:
> Looking at this now, with the intention of committing it for 16.
Attached revision v7 adjusts the column order. This is still WIP, but
gives a good idea of the direction I'm going in.
v7 makes the column output look like this:
pg@regressi
Hi,
visibilitymap.c currently marks empty pages as all visible, including WAL
logging them:
if (PageIsEmpty(page))
...
/*
* Empty pages are always all-visible and all-frozen (note that
* the same is currently not true for new pages, see above).
At Mon, 27 Mar 2023 11:46:08 +0530, Bharath Rupireddy
wrote in
> I recently observed an assertion failure [1] a few times on my dev
> setup during initdb. The code was built with --enable-debug
> --enable-cassert CFLAGS="-ggdb3 -O0". The assertion was gone after I
> did make distclean and built
On Tue, Mar 28, 2023 at 02:03:50AM +0200, Stephen Frost wrote:
> The remote storage is certainly an independent system. Multi-mount LUNs are
> entirely possible in a SAN (and absolutely with NFS, or just the NFS server
> itself is compromised..), so while the attacker may not have any access to the
Hi Kuroda-san. Here are my review comments for both patches v3-0001 and v3-0002.
v3-0001
This patch looks good, but I think there are a couple of other places
where you could add links:
~~~
1.1 doc/src/sgml/logical-replication.sgml (31.5 Conflicts)
"When the streaming mode i
On Mon, Mar 27, 2023 at 4:59 PM Peter Geoghegan wrote:
> Looking at this now, with the intention of committing it for 16.
I see a bug on HEAD, following yesterday's commit 0276ae42dd.
GetWALRecordInfo() will now output the value of the fpi_len variable
before it has actually been set by our call
On Thu, Mar 23, 2023 at 08:50:50PM -0500, Justin Pryzby wrote:
> I'm sure it's possible, but it's also not worth writing a special
> implementation just to handle huge_pages_active, which is better written
> in 30 lines than in 300 lines.
>
> If we needed to avoid using a GUC, maybe it'd work to a
Greetings,
On Mon, Mar 27, 2023 at 19:19 Bruce Momjian wrote:
> On Tue, Mar 28, 2023 at 12:57:42AM +0200, Stephen Frost wrote:
> > I consider the operating system and its processes as much more of a
> > single entity than TLS over a network.
> >
> > This may be the case sometimes but the
On Mon, Mar 20, 2023 at 09:30:50AM +0900, Michael Paquier wrote:
> Did you check dump and restore flows with partition
> trees and --no-table-access-method? Perhaps there should be
> some regression tests with partitioned tables?
I was looking at the patch, and as I suspected the dumps generated
On Mon, Mar 27, 2023 at 12:42 AM Bharath Rupireddy
wrote:
> Thanks. Here's the v6 patch (last patch that I have with me for
> pg_walinspect) for adding per-record info to pg_get_wal_block_info.
> Note that I addressed all review comments received so far. Any
> thoughts?
Looking at this now, with
On Tue, Mar 28, 2023 at 12:57:42AM +0200, Stephen Frost wrote:
> I consider the operating system and its processes as much more of a
> single entity than TLS over a network.
>
> This may be the case sometimes but there’s absolutely no shortage of other
> cases and it’s almost more the rule
On Sun, Mar 26, 2023 at 9:52 AM Melanie Plageman
wrote:
> I have some very minor pieces of feedback, mainly about extraneous
> commas that made me uncomfortable ;)
Offensive punctuation removed.
> > discussion). Therefore FULL JOIN inhibited page-based parallelism,
> > as the other join strateg
On Mon, Mar 20, 2023 at 11:22 PM Amit Kapila
wrote:
> If the tests you have in mind are only related to this patch set then
> feel free to propose them here if you feel the current ones are not
> sufficient.
I think the new tests added by Wang cover my concerns (thanks!). I share
Peter's comment
Greetings,
On Mon, Mar 27, 2023 at 18:17 Bruce Momjian wrote:
> On Tue, Mar 28, 2023 at 12:01:56AM +0200, Stephen Frost wrote:
> > Greetings,
> >
> > On Mon, Mar 27, 2023 at 12:38 Bruce Momjian wrote:
> >
> > On Wed, Mar 8, 2023 at 04:25:04PM -0500, Stephen Frost wrote:
> > > Agreed, t
On Mon, Mar 13, 2023 at 02:48:56PM -0400, Regina Obe wrote:
>
> I still see the main use-case as for those that micro version and for this
> use case, they would need a way, not necessarily to have a single upgrade
> script, but a script for each minor.
>
> So something like
>
> 3.2.%--3.4.0 =
On 3/27/23 23:13, Jehan-Guillaume de Rorthais wrote:
> Hi,
>
> On Mon, 20 Mar 2023 15:12:34 +0100
> Jehan-Guillaume de Rorthais wrote:
>
>> On Mon, 20 Mar 2023 09:32:17 +0100
>> Tomas Vondra wrote:
>>
> * Patch 1 could be rebased/applied/backpatched
Would it help if I rebase P
On Mon, Mar 27, 2023 at 07:08:51PM +0900, Michael Paquier wrote:
> The patch has one mistake: PG_STAT_GET_XACT_FUNCENTRY_FLOAT8_MS does
> not need a slash on its last line or it would include the next, empty
> line. This could lead to mistakes (no need to send a new patch just
> for that).
Adjust
On Sun, Mar 26, 2023 at 8:41 PM Kyotaro Horiguchi
wrote:
> > I'd still put the LSN data before the three OIDs for consistency with
> > the structures, though my opinion does not seem to count much..
>
> I agree with Michael on this point. Also, although it may not be
> significant for SQL, the row
On Mon, Mar 27, 2023 at 10:24:46AM -0400, Melanie Plageman wrote:
> I do like/prefer "block read requests" and
> "blocks requested found in cache"
> Though, now I fear my initial complaint may have been a bit pedantic.
That's fine. Let's ask for extra opinions, then.
So, have others an opinion t
--- Original Message ---
On Thursday, March 16th, 2023 at 11:30 PM, Tomas Vondra
wrote:
>
>
>
>
> On 3/16/23 01:20, Justin Pryzby wrote:
>
> > On Mon, Mar 13, 2023 at 10:47:12PM +0100, Tomas Vondra wrote:
> >
> > >
> > > Thanks. I don't want to annoy you too much, but could
On Mon, Mar 27, 2023 at 2:29 PM Melanie Plageman
wrote:
> I went to add dedup records and noticed that since the actual
> BTDedupInterval struct is what is put in the xlog, I would need access
> to that type from nbtdesc.c, however, including nbtree.h doesn't seem to
> work because it includes fil
On Mon, 2023-03-27 at 14:06 -0400, Robert Haas wrote:
> I thought you were asking for those changes to be made before this
> patch got committed, so that's what I was responding to. If you're
> asking for it not to be committed at all, that's a different
> discussion.
I separately had a complaint
On Tue, Mar 28, 2023 at 12:01:56AM +0200, Stephen Frost wrote:
> Greetings,
>
> On Mon, Mar 27, 2023 at 12:38 Bruce Momjian wrote:
>
> On Wed, Mar 8, 2023 at 04:25:04PM -0500, Stephen Frost wrote:
> > Agreed, though the latest efforts include an option for *authenticated*
> > encryp
On Tue, Mar 28, 2023 at 4:06 AM Brar Piening wrote:
>
> On 23.03.2023 at 20:08, Brar Piening wrote:
> > Since the need for ids is starting to grow again (ecb696527c added an
> > id to a varlistentry in doc/src/sgml/ref/create_subscription.sgml)
> > I've also amended the add-needed-ids patch once a
> I don't get it. If we just return, that would result in skipping
> changes rather than erroring out on changes, but it wouldn't preserve
> the current behavior, because we'd still care about the table owner's
> permissions rather than, as now, the subscription owner's permissions.
Attached is an
Greetings,
On Mon, Mar 27, 2023 at 12:38 Bruce Momjian wrote:
> On Wed, Mar 8, 2023 at 04:25:04PM -0500, Stephen Frost wrote:
> > Agreed, though the latest efforts include an option for *authenticated*
> > encryption as well as unauthenticated. That makes it much more
> > difficult to make und
On Mon, Mar 13, 2023 at 9:41 PM Peter Geoghegan wrote:
> On Mon, Mar 13, 2023 at 4:01 PM Melanie Plageman
> wrote:
>
> > I have added detail to xl_btree_delete and xl_btree_vacuum. I have added
> > the updated/deleted target offset numbers and the updated tuples
> > metadata.
> >
> > I wondered
I ran sqlsmith on this patch for a short while, and reduced one of its
appalling queries to this:
postgres=# SELECT jsonb_object_agg_unique_strict('', null::xid8);
ERROR: unexpected jsonb type as object key
postgres=# \errverbose
ERROR: XX000: unexpected jsonb type as object key
UBICACIÓN: Js
Hi,
On Mon, 20 Mar 2023 15:12:34 +0100
Jehan-Guillaume de Rorthais wrote:
> On Mon, 20 Mar 2023 09:32:17 +0100
> Tomas Vondra wrote:
>
> > >> * Patch 1 could be rebased/applied/backpatched
> > >
> > > Would it help if I rebase Patch 1 ("move BufFile stuff into separate
> > > context")?
On Mon, Mar 27, 2023 at 1:17 PM Robert Haas wrote:
> Patch attached.
This is fine, as far as it goes. Obviously it fixes the immediate problem.
> > I don't think that it's particularly likely that having refined
> > aborted speculative insertion amcheck coverage will make a critical
> > differen
On Mon, Mar 27, 2023 at 3:04 PM Jeff Davis wrote:
> On Mon, 2023-03-27 at 12:53 -0400, Robert Haas wrote:
> > We do know that an empty search_path is secure,
> > but it's probably also going to cause any code we run to fail, unless
> > that code schema-qualifies all references outside of pg_catalo
On Mon, Mar 27, 2023 at 2:34 PM Peter Geoghegan wrote:
> > Since this was back-patched, I think it's probably better to just
> > remove the error. We can introduce new validation if we want, but that
> > should probably be master-only.
>
> That makes sense.
Patch attached.
> I don't think that i
On Mon, 2023-03-27 at 10:46 -0700, Andres Freund wrote:
> > There are some big issues, like the security model for replaying
> > changes.
>
> That seems largely unrelated.
They are self-evidently related in a fundamental way. The behavior of
the non-superuser-subscription patch depends on the pre
On Mon, 2023-03-27 at 12:53 -0400, Robert Haas wrote:
> We do know that an empty search_path is secure,
> but it's probably also going to cause any code we run to fail, unless
> that code schema-qualifies all references outside of pg_catalog, or
> unless it sets search_path itself.
I am confused.
On Mon, Mar 27, 2023 at 10:17 AM Robert Haas wrote:
> > What about aborted speculative insertions? See
> > heap_abort_speculative(), which directly sets the speculatively
> > inserted heap tuple's xmin to InvalidTransactionId/zero.
>
> Oh, dear. I didn't know about that case.
A big benefit of hav
On Sat, Mar 25, 2023 at 3:03 PM Melanie Plageman
wrote:
>
> On Thu, Mar 23, 2023 at 8:27 PM Melanie Plageman
> wrote:
> > On Thu, Mar 23, 2023 at 2:09 AM Masahiko Sawada
> > wrote:
> > > > And, I was wondering if it was worth trying to split up the part that
> > > > reloads the config file and
On Sat, Mar 25, 2023 at 3:16 PM Jeff Davis wrote:
> On Fri, 2023-03-24 at 09:24 -0400, Robert Haas wrote:
> > I certainly agree that the security model isn't in a reasonable place
> > right now. However, I feel that:
> >
> > (1) adding an extra predefined role
>
> > (2) even adding the connection
Hi,
On 2023-03-25 12:16:35 -0700, Jeff Davis wrote:
> On Fri, 2023-03-24 at 09:24 -0400, Robert Haas wrote:
> > I certainly agree that the security model isn't in a reasonable place
> > right now. However, I feel that:
> >
> > (1) adding an extra predefined role
>
> > (2) even adding the connect
On Thu, Mar 23, 2023 at 3:06 PM Robert Haas wrote:
> On Thu, Mar 23, 2023 at 1:34 PM Robert Haas wrote:
> > OK, let me spend some more time on this and I'll post a patch (or
> > patches) in a bit.
>
> All right, here are some more fixups.
It looks like e88754a1965c0f40a723e6e46d670cacda9e19bd ma
On Fri, Mar 17, 2023 at 03:43:31AM +0100, Tomas Vondra wrote:
> On 3/16/23 05:50, Justin Pryzby wrote:
> > On Fri, Mar 10, 2023 at 12:48:13PM -0800, Jacob Champion wrote:
> >> On Wed, Mar 8, 2023 at 10:59 AM Jacob Champion
> >> wrote:
> >>> I did some smoke testing against zstd's GitHub release o
Hi,
On 2023-03-26 21:13:41 -0400, Andrew Dunstan wrote:
> > On Mar 26, 2023, at 5:28 PM, Andres Freund wrote:
> >> On 2023-03-26 12:39:08 -0700, Andres Freund wrote:
> >> First: I am *not* arguing we shouldn't repair building against strawberry
> >> perl
> >> with mingw.
> >
> > Hm - can you de
On Sat, Mar 25, 2023 at 6:25 PM Peter Geoghegan wrote:
> On Fri, Mar 24, 2023 at 8:13 AM Robert Haas wrote:
> > If we're checking xmin and find that it is invalid (i.e. 0) just
> > report that as corruption, similar to what's already done in the
> > three cases that seem correct. If we're checkin
On Sat, Mar 25, 2023 at 5:24 AM Jelte Fennema wrote:
> For my purposes I always trust the publisher, what I don't trust is
> the table owners. But I can indeed imagine scenarios where that's the
> other way around, and indeed you can protect against that currently,
> but not with your new patch. T
On 23.03.2023 at 20:08, Brar Piening wrote:
Since the need for ids is starting to grow again (ecb696527c added an
id to a varlistentry in doc/src/sgml/ref/create_subscription.sgml)
I've also amended the add-needed-ids patch once again so that the
build does not fail after applying the make_html_i
On Sat, Mar 25, 2023 at 12:01 PM Noah Misch wrote:
> (One might allow temp
> tables by introducing NewTempSchemaNestLevel(), called whenever we call
> NewGUCNestLevel(). The transaction would then proceed as though it has no
> temp schema, allocating an additional schema if creating a temp object
On Fri, Mar 24, 2023 at 8:02 PM Jeff Davis wrote:
> Without a reasonable example, we should probably be on some kind of
> path to disallowing crazy stuff in triggers that poses only risks and
> no benefits. Not the job of this patch, but perhaps it can be seen as a
> step in that direction?
Possi
On Wed, Mar 8, 2023 at 04:25:04PM -0500, Stephen Frost wrote:
> Agreed, though the latest efforts include an option for *authenticated*
> encryption as well as unauthenticated. That makes it much more
> difficult to make undetected changes to the data that's protected by
> the authenticated encry
Hi,
On 3/17/23 03:43, Tomas Vondra wrote:
>
> ...
>
>>> I'm a little suspicious of the replacement of supports_compression()
>>> with parse_compress_specification(). For example:
>>>
- errmsg = supports_compression(AH->compression_spec);
- if (errmsg)
+ parse_compress_specifi
Hi,
> I guess you didn't set up the hostnames in /etc/hosts as described in
> 004_load_balance_dns.pl. Then it's expected that the loop body isn't
> covered. As discussed upthread, running this test manually is much
> more cumbersome than is desirable, but it's still better than not
> having the t
On Fri, Mar 24, 2023 at 4:11 PM Mark Dilger
wrote:
> > > Imagine for example that the table
> > > owner has a trigger which doesn't sanitize search_path. The
> > > subscription owner can potentially leverage that to get the table
> > > owner's privileges.
>
> I don't find that terribly convincing.
> On 27 Mar 2023, at 16:33, Tom Lane wrote:
>
> Julien Rouhaud writes:
>> On Mon, Mar 27, 2023 at 02:06:34PM +0200, Daniel Gustafsson wrote:
>> On 27 Mar 2023, at 14:04, Dagfinn Ilmari Mannsåker wrote:
Doesn't this apply to Apple Silicon generally, not just M1? M2 already
exists,
> > ```
> > if (conn->addr == NULL && conn->naddr != 0)
> > ```
Afaict this is not necessary, since getaddrinfo already returns an
error if the host could not be resolved to any addresses. A quick test
gives me this error:
error: could not translate host name "doesnotexist" to address: Name
or ser
On 3/27/23 03:32, Masahiko Sawada wrote:
> Hi,
>
> On Fri, Mar 24, 2023 at 7:26 AM Tomas Vondra
> wrote:
>>
>> I merged the earlier "fixup" patches into the relevant parts, and left
>> two patches with new tweaks (deducing the corrent "WAL" state from the
>> current state read by copy_sequence
Julien Rouhaud writes:
> On Mon, Mar 27, 2023 at 02:06:34PM +0200, Daniel Gustafsson wrote:
> On 27 Mar 2023, at 14:04, Dagfinn Ilmari Mannsåker wrote:
>>> Doesn't this apply to Apple Silicon generally, not just M1? M2 already
>>> exists, and M3 etc. will presumably also appear at some point. The
Hi!
I made the specified changes and my patch turned out the same as yours. The
performance measurements were the same too.
The only thing left to do is how not to add IGNORE_DATATYPE_ERRORS as a
keyword. See how this is done for parameters such as FORCE_NOT_NULL,
FORCE_NULL, FORCE_QUOTE. They ar
On Wed, Mar 22, 2023 at 6:42 PM Michael Paquier wrote:
>
> On Wed, Mar 22, 2023 at 02:21:12PM -0400, Melanie Plageman wrote:
> > Apologies as I know this docs update has already been committed, but
> > buffers fetched and blocks fetched both feel weird to me. If you have a
> > cache hit, you don't
Thank you, I will do that.
On Mon, Mar 27, 2023 at 7:34 PM Bharath Rupireddy <
bharath.rupireddyforpostg...@gmail.com> wrote:
> On Mon, Mar 27, 2023 at 7:13 PM parth ratra
> wrote:
> >
> > Hey Everyone,
> >
> > I am Parth Ratra from India majoring in CSE. I have hands-on experience
> with HTML/V
On Mon, Mar 27, 2023 at 7:13 PM parth ratra wrote:
>
> Hey Everyone,
>
> I am Parth Ratra from India majoring in CSE. I have hands-on experience with
> HTML/Vanilla CSS/ JS, Reactjs and CI/CD pipelines through various projects. I
> am proficient in C/C++, Python, and Django as well.
>
> I am sup
On Thu, Mar 23, 2023 at 2:49 PM Tomas Vondra
wrote:
> > On Mon, Mar 20, 2023 at 10:12 AM Jehan-Guillaume de Rorthais
> > wrote:
> >> BNJL and/or other considerations are for 17 or even after. In the meantime,
> >> Melanie, who authored BNLJ, +1 the balancing patch as it can coexists with
> >> ot
On 15.03.23 23:44, Alvaro Herrera wrote:
Here's v5. I removed the business of renaming constraints in child
relations: recursing now just relies on matching column names. Each
column has only one NOT NULL constraint; if you try to add another,
nothing happens. All in all, this code is pretty s
On 2023-03-23 02:50, Andres Freund wrote:
Thanks again for your review.
Attached v5 patch.
Have you measured whether this has negative performance effects when
*NOT*
using the new option?
I loaded 1000 rows of pgbench_accounts on my laptop and compared the
elapsed time.
GUCs changed from
Hey Everyone,
I am Parth Ratra from India majoring in CSE. I have *hands-on experience
with HTML/Vanilla CSS/ JS, Reactjs and CI/CD pipelines through various
projects. I am proficient in C/C++, Python, and Django* as well.
*I am super excited to work with PostgreSQL and would like to contribute
On Sat, Mar 25, 2023 at 9:13 PM Joseph Koshakow wrote:
>
> On Fri, Mar 24, 2023 at 9:43 AM Ashutosh Bapat
> wrote:
> >
> >You don't need to do this, but looks like we can add DAYS_PER_WEEK macro
> > and
> >use it here.
>
> I've attached a patch with this new macro. There's probably tons
Hi,
> ```
> +ret = store_conn_addrinfo(conn, addrlist);
> +pg_freeaddrinfo_all(hint.ai_family, addrlist);
> +if (ret)
> +goto error_return;/* message already logged */
> ```
> The goto path is not test-covered.
D'oh, this one is fine since store_conn_addrin
Hi,
> So I think it should be:
>
> ```
> if (conn->addr == NULL && conn->naddr != 0)
> ```
>
> [...]
>
> I will take a look at v16 now.
The code coverage could be slightly better.
In v16-0001:
```
+ret = store_conn_addrinfo(conn, addrlist);
+pg_freeaddrinfo_all(hint.ai_family, a
On Mon, Mar 27, 2023 at 02:06:34PM +0200, Daniel Gustafsson wrote:
> > On 27 Mar 2023, at 14:04, Dagfinn Ilmari Mannsåker
> > wrote:
> > Daniel Gustafsson writes:
>
> >> Applied with a tiny but of changes to make it look like the rest of the
> >> paragraph more. Thanks!
> >
> > Doesn't this appl
On Mon, Mar 27, 2023 at 12:07 PM Amit Kapila wrote:
>
> On Mon, Mar 27, 2023 at 2:52 AM Tom Lane wrote:
> >
>
> > I suggest taking a couple of steps back from the minutiae of the
> > patch, and spending some hard effort thinking about how the thing
> > would be controlled in a useful fashion (tha
> On 27 Mar 2023, at 14:04, Dagfinn Ilmari Mannsåker wrote:
> Daniel Gustafsson writes:
>> Applied with a tiny but of changes to make it look like the rest of the
>> paragraph more. Thanks!
>
> Doesn't this apply to Apple Silicon generally, not just M1? M2 already
> exists, and M3 etc. will pre
Daniel Gustafsson writes:
>> On 27 Mar 2023, at 10:41, Julien Rouhaud wrote:
>> On Mon, Mar 27, 2023 at 10:32:52AM +0200, Daniel Gustafsson wrote:
On 27 Mar 2023, at 10:24, Julien Rouhaud wrote:
>
FTR the documented XML_CATALOG_FILES environment variable is only valid for
Intel b
Hi,
> > ▶ 6/6 - received at least one connection on node1 OK
> > ▶ 6/6 - received at least one connection on node2 OK
> > ▶ 6/6 - received at least one connection on node3 OK
> > ▶ 6/6 - received 50 connections across all nodesOK
>
> Good point.
>
> > Finally, I changed a
> On 27 Mar 2023, at 13:50, Jelte Fennema wrote:
>
> Looks good overall. I attached a new version with a few small changes:
>
>> * Changed store_conn_addrinfo to return int like how all the functions
>>dealing with addrinfo does. Also moved the error reporting to inside
>> there
>>whe
1 - 100 of 119 matches
Mail list logo
